* [iproute PATCH] ipaddress: Allow listing addresses by type
@ 2016-06-01 19:57 Phil Sutter
2016-06-01 21:50 ` Vadim Kochan
0 siblings, 1 reply; 3+ messages in thread
From: Phil Sutter @ 2016-06-01 19:57 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Vadim Kochan
Not sure why this was limited to ip-link before. It is semantically
equal to the 'master' keyword, which is not restricted at all.
Cc: Vadim Kochan <vadim4j@gmail.com>
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
ip/ipaddress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index df363b070d5de..1b5ee838ef3fe 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -1613,7 +1613,7 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
if (!ifindex)
invarg("Device does not exist\n", *argv);
filter.master = ifindex;
- } else if (do_link && strcmp(*argv, "type") == 0) {
+ } else if (strcmp(*argv, "type") == 0) {
NEXT_ARG();
filter.kind = *argv;
} else {
--
2.8.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [iproute PATCH] ipaddress: Allow listing addresses by type
2016-06-01 19:57 [iproute PATCH] ipaddress: Allow listing addresses by type Phil Sutter
@ 2016-06-01 21:50 ` Vadim Kochan
0 siblings, 0 replies; 3+ messages in thread
From: Vadim Kochan @ 2016-06-01 21:50 UTC (permalink / raw)
To: Phil Sutter; +Cc: Stephen Hemminger, netdev, Vadim Kochan
On Wed, Jun 01, 2016 at 09:57:27PM +0200, Phil Sutter wrote:
> Not sure why this was limited to ip-link before. It is semantically
> equal to the 'master' keyword, which is not restricted at all.
>
Hi Phil,
I don't remember why I did so, but you are right, it might be
used for 'ip addr' too.
> Cc: Vadim Kochan <vadim4j@gmail.com>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> ip/ipaddress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index df363b070d5de..1b5ee838ef3fe 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -1613,7 +1613,7 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
> if (!ifindex)
> invarg("Device does not exist\n", *argv);
> filter.master = ifindex;
> - } else if (do_link && strcmp(*argv, "type") == 0) {
> + } else if (strcmp(*argv, "type") == 0) {
> NEXT_ARG();
> filter.kind = *argv;
> } else {
> --
> 2.8.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [iproute PATCH] ipaddress: Allow listing addresses by type
[not found] <ba62a9b5ffab44adaf0532dc4ca6725d@HQ1WP-EXMB11.corp.brocade.com>
@ 2016-06-08 15:35 ` Stephen Hemminger
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2016-06-08 15:35 UTC (permalink / raw)
To: Phil Sutter; +Cc: netdev, Vadim Kochan
On Wed, 1 Jun 2016 19:57:27 +0000
Phil Sutter <phil@nwl.cc> wrote:
> Not sure why this was limited to ip-link before. It is semantically
> equal to the 'master' keyword, which is not restricted at all.
>
> Cc: Vadim Kochan <vadim4j@gmail.com>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Please resubmit and update usage and man page.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-08 15:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-01 19:57 [iproute PATCH] ipaddress: Allow listing addresses by type Phil Sutter
2016-06-01 21:50 ` Vadim Kochan
[not found] <ba62a9b5ffab44adaf0532dc4ca6725d@HQ1WP-EXMB11.corp.brocade.com>
2016-06-08 15:35 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.