All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] IB/usnic: Remove unused DMA attributes
@ 2016-06-02  9:45 Krzysztof Kozlowski
       [not found] ` <1464860701-11376-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2016-06-02  9:45 UTC (permalink / raw)
  To: Christian Benvenuti, Dave Goodell, Doug Ledford, Sean Hefty,
	Hal Rosenstock, linux-rdma, linux-kernel
  Cc: Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz

The DMA attributes are set but never used.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 drivers/infiniband/hw/usnic/usnic_uiom.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c b/drivers/infiniband/hw/usnic/usnic_uiom.c
index 7209fbc03ccb..a0b6ebee4d8a 100644
--- a/drivers/infiniband/hw/usnic/usnic_uiom.c
+++ b/drivers/infiniband/hw/usnic/usnic_uiom.c
@@ -36,7 +36,6 @@
 #include <linux/dma-mapping.h>
 #include <linux/sched.h>
 #include <linux/hugetlb.h>
-#include <linux/dma-attrs.h>
 #include <linux/iommu.h>
 #include <linux/workqueue.h>
 #include <linux/list.h>
@@ -112,10 +111,6 @@ static int usnic_uiom_get_pages(unsigned long addr, size_t size, int writable,
 	int i;
 	int flags;
 	dma_addr_t pa;
-	DEFINE_DMA_ATTRS(attrs);
-
-	if (dmasync)
-		dma_set_attr(DMA_ATTR_WRITE_BARRIER, &attrs);
 
 	if (!can_do_mlock())
 		return -EPERM;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] IB/usnic: Remove unused DMA attributes
  2016-06-02  9:45 [PATCH] IB/usnic: Remove unused DMA attributes Krzysztof Kozlowski
@ 2016-06-06 23:28     ` Doug Ledford
  0 siblings, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2016-06-06 23:28 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Christian Benvenuti, Dave Goodell,
	Sean Hefty, Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: Bartlomiej Zolnierkiewicz


[-- Attachment #1.1: Type: text/plain, Size: 1108 bytes --]

On 6/2/2016 5:45 AM, Krzysztof Kozlowski wrote:
> The DMA attributes are set but never used.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/infiniband/hw/usnic/usnic_uiom.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c b/drivers/infiniband/hw/usnic/usnic_uiom.c
> index 7209fbc03ccb..a0b6ebee4d8a 100644
> --- a/drivers/infiniband/hw/usnic/usnic_uiom.c
> +++ b/drivers/infiniband/hw/usnic/usnic_uiom.c
> @@ -36,7 +36,6 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/sched.h>
>  #include <linux/hugetlb.h>
> -#include <linux/dma-attrs.h>
>  #include <linux/iommu.h>
>  #include <linux/workqueue.h>
>  #include <linux/list.h>
> @@ -112,10 +111,6 @@ static int usnic_uiom_get_pages(unsigned long addr, size_t size, int writable,
>  	int i;
>  	int flags;
>  	dma_addr_t pa;
> -	DEFINE_DMA_ATTRS(attrs);
> -
> -	if (dmasync)
> -		dma_set_attr(DMA_ATTR_WRITE_BARRIER, &attrs);
>  
>  	if (!can_do_mlock())
>  		return -EPERM;
> 

Thanks, applied.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] IB/usnic: Remove unused DMA attributes
@ 2016-06-06 23:28     ` Doug Ledford
  0 siblings, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2016-06-06 23:28 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Christian Benvenuti, Dave Goodell,
	Sean Hefty, Hal Rosenstock, linux-rdma, linux-kernel
  Cc: Bartlomiej Zolnierkiewicz


[-- Attachment #1.1: Type: text/plain, Size: 1080 bytes --]

On 6/2/2016 5:45 AM, Krzysztof Kozlowski wrote:
> The DMA attributes are set but never used.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/infiniband/hw/usnic/usnic_uiom.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c b/drivers/infiniband/hw/usnic/usnic_uiom.c
> index 7209fbc03ccb..a0b6ebee4d8a 100644
> --- a/drivers/infiniband/hw/usnic/usnic_uiom.c
> +++ b/drivers/infiniband/hw/usnic/usnic_uiom.c
> @@ -36,7 +36,6 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/sched.h>
>  #include <linux/hugetlb.h>
> -#include <linux/dma-attrs.h>
>  #include <linux/iommu.h>
>  #include <linux/workqueue.h>
>  #include <linux/list.h>
> @@ -112,10 +111,6 @@ static int usnic_uiom_get_pages(unsigned long addr, size_t size, int writable,
>  	int i;
>  	int flags;
>  	dma_addr_t pa;
> -	DEFINE_DMA_ATTRS(attrs);
> -
> -	if (dmasync)
> -		dma_set_attr(DMA_ATTR_WRITE_BARRIER, &attrs);
>  
>  	if (!can_do_mlock())
>  		return -EPERM;
> 

Thanks, applied.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-06 23:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02  9:45 [PATCH] IB/usnic: Remove unused DMA attributes Krzysztof Kozlowski
     [not found] ` <1464860701-11376-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-06 23:28   ` Doug Ledford
2016-06-06 23:28     ` Doug Ledford

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.