* [PATCH] net: ethernet: ti: cpsw: remove unused priv lock
@ 2016-06-02 22:37 Ivan Khoronzhuk
2016-06-03 16:47 ` Grygorii Strashko
2016-06-03 23:43 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Ivan Khoronzhuk @ 2016-06-02 22:37 UTC (permalink / raw)
To: mugunthanvnm, linux-kernel
Cc: grygorii.strashko, linux-omap, netdev, Ivan Khoronzhuk
There is no reason in this lock. At least for now.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on master
drivers/net/ethernet/ti/cpsw.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 9919cb3..8d1d373 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -365,7 +365,6 @@ static inline void slave_write(struct cpsw_slave *slave, u32 val, u32 offset)
}
struct cpsw_priv {
- spinlock_t lock;
struct platform_device *pdev;
struct net_device *ndev;
struct napi_struct napi_rx;
@@ -2413,7 +2412,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev,
}
priv_sl2 = netdev_priv(ndev);
- spin_lock_init(&priv_sl2->lock);
priv_sl2->data = *data;
priv_sl2->pdev = pdev;
priv_sl2->ndev = ndev;
@@ -2533,7 +2531,6 @@ static int cpsw_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, ndev);
priv = netdev_priv(ndev);
- spin_lock_init(&priv->lock);
priv->pdev = pdev;
priv->ndev = ndev;
priv->dev = &ndev->dev;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock
2016-06-02 22:37 [PATCH] net: ethernet: ti: cpsw: remove unused priv lock Ivan Khoronzhuk
@ 2016-06-03 16:47 ` Grygorii Strashko
2016-06-03 23:43 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Grygorii Strashko @ 2016-06-03 16:47 UTC (permalink / raw)
To: Ivan Khoronzhuk, mugunthanvnm, linux-kernel; +Cc: linux-omap, netdev
On 06/03/2016 01:37 AM, Ivan Khoronzhuk wrote:
> There is no reason in this lock. At least for now.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>
> Based on master
>
> drivers/net/ethernet/ti/cpsw.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 9919cb3..8d1d373 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -365,7 +365,6 @@ static inline void slave_write(struct cpsw_slave *slave, u32 val, u32 offset)
> }
>
> struct cpsw_priv {
> - spinlock_t lock;
> struct platform_device *pdev;
> struct net_device *ndev;
> struct napi_struct napi_rx;
> @@ -2413,7 +2412,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev,
> }
>
> priv_sl2 = netdev_priv(ndev);
> - spin_lock_init(&priv_sl2->lock);
> priv_sl2->data = *data;
> priv_sl2->pdev = pdev;
> priv_sl2->ndev = ndev;
> @@ -2533,7 +2531,6 @@ static int cpsw_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, ndev);
> priv = netdev_priv(ndev);
> - spin_lock_init(&priv->lock);
> priv->pdev = pdev;
> priv->ndev = ndev;
> priv->dev = &ndev->dev;
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock
@ 2016-06-03 16:47 ` Grygorii Strashko
0 siblings, 0 replies; 4+ messages in thread
From: Grygorii Strashko @ 2016-06-03 16:47 UTC (permalink / raw)
To: Ivan Khoronzhuk, mugunthanvnm, linux-kernel; +Cc: linux-omap, netdev
On 06/03/2016 01:37 AM, Ivan Khoronzhuk wrote:
> There is no reason in this lock. At least for now.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>
> Based on master
>
> drivers/net/ethernet/ti/cpsw.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 9919cb3..8d1d373 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -365,7 +365,6 @@ static inline void slave_write(struct cpsw_slave *slave, u32 val, u32 offset)
> }
>
> struct cpsw_priv {
> - spinlock_t lock;
> struct platform_device *pdev;
> struct net_device *ndev;
> struct napi_struct napi_rx;
> @@ -2413,7 +2412,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev,
> }
>
> priv_sl2 = netdev_priv(ndev);
> - spin_lock_init(&priv_sl2->lock);
> priv_sl2->data = *data;
> priv_sl2->pdev = pdev;
> priv_sl2->ndev = ndev;
> @@ -2533,7 +2531,6 @@ static int cpsw_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, ndev);
> priv = netdev_priv(ndev);
> - spin_lock_init(&priv->lock);
> priv->pdev = pdev;
> priv->ndev = ndev;
> priv->dev = &ndev->dev;
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ethernet: ti: cpsw: remove unused priv lock
2016-06-02 22:37 [PATCH] net: ethernet: ti: cpsw: remove unused priv lock Ivan Khoronzhuk
2016-06-03 16:47 ` Grygorii Strashko
@ 2016-06-03 23:43 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2016-06-03 23:43 UTC (permalink / raw)
To: ivan.khoronzhuk
Cc: mugunthanvnm, linux-kernel, grygorii.strashko, linux-omap, netdev
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Date: Fri, 3 Jun 2016 01:37:08 +0300
> There is no reason in this lock. At least for now.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Applied to net-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-03 23:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02 22:37 [PATCH] net: ethernet: ti: cpsw: remove unused priv lock Ivan Khoronzhuk
2016-06-03 16:47 ` Grygorii Strashko
2016-06-03 16:47 ` Grygorii Strashko
2016-06-03 23:43 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.