* [PATCH] x86: include linux/ratelimit.h in nmi.c
@ 2016-06-06 14:09 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-06-06 14:09 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-kernel, rtc-linux, Arnd Bergmann, Thomas Gleixner,
Ingo Molnar, H. Peter Anvin, x86
When building random configurations, we now occasionally get a new
build error:
In file included from include/linux/kernel.h:13:0,
from include/linux/list.h:8,
from include/linux/preempt.h:10,
from include/linux/spinlock.h:50,
from arch/x86/kernel/nmi.c:13:
arch/x86/kernel/nmi.c: In function 'nmi_max_handler':
include/linux/printk.h:375:9: error: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE' [-Werror=implicit-int]
static DEFINE_RATELIMIT_STATE(_rs, \
^
arch/x86/kernel/nmi.c:110:2: note: in expansion of macro 'printk_ratelimited'
printk_ratelimited(KERN_INFO
^~~~~~~~~~~~~~~~~~
This was working before the rtc rework series because linux/ratelimit.h
was included implictly through asm/mach_traps.h -> asm/mc146818rtc.h
-> linux/mc146818rtc.h -> linux/rtc.h -> linux/device.h.
We clearly shouldn't rely on this indirect inclusion, so this adds
an explicit #include in the file that needs it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 5ab788d73832 ("rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h")
---
It's only broken in the linux-rtc git at the moment, so it makes sense
to fix it there.
arch/x86/kernel/nmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
index 04b132a767f1..bfe4d6c96fbd 100644
--- a/arch/x86/kernel/nmi.c
+++ b/arch/x86/kernel/nmi.c
@@ -17,6 +17,7 @@
#include <linux/debugfs.h>
#include <linux/delay.h>
#include <linux/hardirq.h>
+#include <linux/ratelimit.h>
#include <linux/slab.h>
#include <linux/export.h>
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [rtc-linux] [PATCH] x86: include linux/ratelimit.h in nmi.c
@ 2016-06-06 14:09 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-06-06 14:09 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-kernel, rtc-linux, Arnd Bergmann, Thomas Gleixner,
Ingo Molnar, H. Peter Anvin, x86
When building random configurations, we now occasionally get a new
build error:
In file included from include/linux/kernel.h:13:0,
from include/linux/list.h:8,
from include/linux/preempt.h:10,
from include/linux/spinlock.h:50,
from arch/x86/kernel/nmi.c:13:
arch/x86/kernel/nmi.c: In function 'nmi_max_handler':
include/linux/printk.h:375:9: error: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE' [-Werror=implicit-int]
static DEFINE_RATELIMIT_STATE(_rs, \
^
arch/x86/kernel/nmi.c:110:2: note: in expansion of macro 'printk_ratelimited'
printk_ratelimited(KERN_INFO
^~~~~~~~~~~~~~~~~~
This was working before the rtc rework series because linux/ratelimit.h
was included implictly through asm/mach_traps.h -> asm/mc146818rtc.h
-> linux/mc146818rtc.h -> linux/rtc.h -> linux/device.h.
We clearly shouldn't rely on this indirect inclusion, so this adds
an explicit #include in the file that needs it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 5ab788d73832 ("rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h")
---
It's only broken in the linux-rtc git at the moment, so it makes sense
to fix it there.
arch/x86/kernel/nmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
index 04b132a767f1..bfe4d6c96fbd 100644
--- a/arch/x86/kernel/nmi.c
+++ b/arch/x86/kernel/nmi.c
@@ -17,6 +17,7 @@
#include <linux/debugfs.h>
#include <linux/delay.h>
#include <linux/hardirq.h>
+#include <linux/ratelimit.h>
#include <linux/slab.h>
#include <linux/export.h>
--
2.7.0
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: include linux/ratelimit.h in nmi.c
2016-06-06 14:09 ` [rtc-linux] " Arnd Bergmann
@ 2016-06-06 14:12 ` Thomas Gleixner
-1 siblings, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2016-06-06 14:12 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alexandre Belloni, linux-kernel, rtc-linux, Ingo Molnar,
H. Peter Anvin, x86
On Mon, 6 Jun 2016, Arnd Bergmann wrote:
> When building random configurations, we now occasionally get a new
> build error:
>
> In file included from include/linux/kernel.h:13:0,
> from include/linux/list.h:8,
> from include/linux/preempt.h:10,
> from include/linux/spinlock.h:50,
> from arch/x86/kernel/nmi.c:13:
> arch/x86/kernel/nmi.c: In function 'nmi_max_handler':
> include/linux/printk.h:375:9: error: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE' [-Werror=implicit-int]
> static DEFINE_RATELIMIT_STATE(_rs, \
> ^
> arch/x86/kernel/nmi.c:110:2: note: in expansion of macro 'printk_ratelimited'
> printk_ratelimited(KERN_INFO
> ^~~~~~~~~~~~~~~~~~
>
> This was working before the rtc rework series because linux/ratelimit.h
> was included implictly through asm/mach_traps.h -> asm/mc146818rtc.h
> -> linux/mc146818rtc.h -> linux/rtc.h -> linux/device.h.
>
> We clearly shouldn't rely on this indirect inclusion, so this adds
> an explicit #include in the file that needs it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 5ab788d73832 ("rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h")
> ---
> It's only broken in the linux-rtc git at the moment, so it makes sense
> to fix it there.
Acked-by: Thomas Gleixner <tglx@linutronix.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [rtc-linux] Re: [PATCH] x86: include linux/ratelimit.h in nmi.c
@ 2016-06-06 14:12 ` Thomas Gleixner
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2016-06-06 14:12 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alexandre Belloni, linux-kernel, rtc-linux, Ingo Molnar,
H. Peter Anvin, x86
On Mon, 6 Jun 2016, Arnd Bergmann wrote:
> When building random configurations, we now occasionally get a new
> build error:
>
> In file included from include/linux/kernel.h:13:0,
> from include/linux/list.h:8,
> from include/linux/preempt.h:10,
> from include/linux/spinlock.h:50,
> from arch/x86/kernel/nmi.c:13:
> arch/x86/kernel/nmi.c: In function 'nmi_max_handler':
> include/linux/printk.h:375:9: error: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE' [-Werror=implicit-int]
> static DEFINE_RATELIMIT_STATE(_rs, \
> ^
> arch/x86/kernel/nmi.c:110:2: note: in expansion of macro 'printk_ratelimited'
> printk_ratelimited(KERN_INFO
> ^~~~~~~~~~~~~~~~~~
>
> This was working before the rtc rework series because linux/ratelimit.h
> was included implictly through asm/mach_traps.h -> asm/mc146818rtc.h
> -> linux/mc146818rtc.h -> linux/rtc.h -> linux/device.h.
>
> We clearly shouldn't rely on this indirect inclusion, so this adds
> an explicit #include in the file that needs it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 5ab788d73832 ("rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h")
> ---
> It's only broken in the linux-rtc git at the moment, so it makes sense
> to fix it there.
Acked-by: Thomas Gleixner <tglx@linutronix.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86: include linux/ratelimit.h in nmi.c
2016-06-06 14:09 ` [rtc-linux] " Arnd Bergmann
@ 2016-06-06 15:08 ` Alexandre Belloni
-1 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2016-06-06 15:08 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-kernel, rtc-linux, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86
On 06/06/2016 at 16:09:52 +0200, Arnd Bergmann wrote :
> When building random configurations, we now occasionally get a new
> build error:
>
> In file included from include/linux/kernel.h:13:0,
> from include/linux/list.h:8,
> from include/linux/preempt.h:10,
> from include/linux/spinlock.h:50,
> from arch/x86/kernel/nmi.c:13:
> arch/x86/kernel/nmi.c: In function 'nmi_max_handler':
> include/linux/printk.h:375:9: error: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE' [-Werror=implicit-int]
> static DEFINE_RATELIMIT_STATE(_rs, \
> ^
> arch/x86/kernel/nmi.c:110:2: note: in expansion of macro 'printk_ratelimited'
> printk_ratelimited(KERN_INFO
> ^~~~~~~~~~~~~~~~~~
>
> This was working before the rtc rework series because linux/ratelimit.h
> was included implictly through asm/mach_traps.h -> asm/mc146818rtc.h
> -> linux/mc146818rtc.h -> linux/rtc.h -> linux/device.h.
>
> We clearly shouldn't rely on this indirect inclusion, so this adds
> an explicit #include in the file that needs it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 5ab788d73832 ("rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h")
> ---
> It's only broken in the linux-rtc git at the moment, so it makes sense
> to fix it there.
>
> arch/x86/kernel/nmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [rtc-linux] Re: [PATCH] x86: include linux/ratelimit.h in nmi.c
@ 2016-06-06 15:08 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2016-06-06 15:08 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-kernel, rtc-linux, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86
On 06/06/2016 at 16:09:52 +0200, Arnd Bergmann wrote :
> When building random configurations, we now occasionally get a new
> build error:
>
> In file included from include/linux/kernel.h:13:0,
> from include/linux/list.h:8,
> from include/linux/preempt.h:10,
> from include/linux/spinlock.h:50,
> from arch/x86/kernel/nmi.c:13:
> arch/x86/kernel/nmi.c: In function 'nmi_max_handler':
> include/linux/printk.h:375:9: error: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE' [-Werror=implicit-int]
> static DEFINE_RATELIMIT_STATE(_rs, \
> ^
> arch/x86/kernel/nmi.c:110:2: note: in expansion of macro 'printk_ratelimited'
> printk_ratelimited(KERN_INFO
> ^~~~~~~~~~~~~~~~~~
>
> This was working before the rtc rework series because linux/ratelimit.h
> was included implictly through asm/mach_traps.h -> asm/mc146818rtc.h
> -> linux/mc146818rtc.h -> linux/rtc.h -> linux/device.h.
>
> We clearly shouldn't rely on this indirect inclusion, so this adds
> an explicit #include in the file that needs it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 5ab788d73832 ("rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h")
> ---
> It's only broken in the linux-rtc git at the moment, so it makes sense
> to fix it there.
>
> arch/x86/kernel/nmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-06 15:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-06 14:09 [PATCH] x86: include linux/ratelimit.h in nmi.c Arnd Bergmann
2016-06-06 14:09 ` [rtc-linux] " Arnd Bergmann
2016-06-06 14:12 ` Thomas Gleixner
2016-06-06 14:12 ` [rtc-linux] " Thomas Gleixner
2016-06-06 15:08 ` Alexandre Belloni
2016-06-06 15:08 ` [rtc-linux] " Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.