* [PATCH net-next] sit: remove unnecessary protocol check in ipip6_tunnel_xmit()
@ 2016-06-09 9:03 Simon Horman
2016-06-09 18:23 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Simon Horman @ 2016-06-09 9:03 UTC (permalink / raw)
To: netdev; +Cc: Simon Horman
ipip6_tunnel_xmit() is called immediately after checking that
skb->protocol is htons(ETH_P_IPV6) so there is no need
to check it a second time.
Found by inspection.
Signed-off-by: Simon Horman <simon.horman@netronome.com>
Reviewed-by: Dinan Gunawardena <dinan.gunawardena@netronome.com>
---
This patch is targeted at upstream kernel "net-next" as a trivial fix.
Please review.
net/ipv6/sit.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index 0a5a255277e5..d9f2bd6ef72d 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -825,9 +825,6 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *skb,
u8 protocol = IPPROTO_IPV6;
int t_hlen = tunnel->hlen + sizeof(struct iphdr);
- if (skb->protocol != htons(ETH_P_IPV6))
- goto tx_error;
-
if (tos == 1)
tos = ipv6_get_dsfield(iph6);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] sit: remove unnecessary protocol check in ipip6_tunnel_xmit()
2016-06-09 9:03 [PATCH net-next] sit: remove unnecessary protocol check in ipip6_tunnel_xmit() Simon Horman
@ 2016-06-09 18:23 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-06-09 18:23 UTC (permalink / raw)
To: simon.horman; +Cc: netdev
From: Simon Horman <simon.horman@netronome.com>
Date: Thu, 9 Jun 2016 18:03:34 +0900
> ipip6_tunnel_xmit() is called immediately after checking that
> skb->protocol is htons(ETH_P_IPV6) so there is no need
> to check it a second time.
>
> Found by inspection.
>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
> Reviewed-by: Dinan Gunawardena <dinan.gunawardena@netronome.com>
Looks good, applied, thanks Simon.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-09 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 9:03 [PATCH net-next] sit: remove unnecessary protocol check in ipip6_tunnel_xmit() Simon Horman
2016-06-09 18:23 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.