[PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Kieran Bingham]

The FCP driver, can also support the FCPF variant for FDP1 compatible
processing.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
index 6a12960609d8..271dcfdb5a76 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
@@ -7,12 +7,14 @@ conversion of AXI transactions in order to reduce the memory bandwidth.
 
 There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
 for FDP (FCPF). Their configuration and behaviour depend on the module they
-are paired with. These DT bindings currently support the FCPV only.
+are paired with. These DT bindings currently support the FCPV and FCPF.
 
  - compatible: Must be one or more of the following
 
    - "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP'
+   - "renesas,r8a7795-fcpf" for R8A7795 (R-Car H3) compatible 'FCP for FDP'
    - "renesas,fcpv" for generic compatible 'FCP for VSP'
+   - "renesas,fcpf" for generic compatible 'FCP for FDP'
 
    When compatible with the generic version, nodes must list the
    SoC-specific version corresponding to the platform first, followed by the
-- 
2.7.4

[PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Kieran Bingham]

The FCP driver, can also support the FCPF variant for FDP1 compatible
processing.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
index 6a12960609d8..271dcfdb5a76 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
@@ -7,12 +7,14 @@ conversion of AXI transactions in order to reduce the memory bandwidth.
 
 There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
 for FDP (FCPF). Their configuration and behaviour depend on the module they
-are paired with. These DT bindings currently support the FCPV only.
+are paired with. These DT bindings currently support the FCPV and FCPF.
 
  - compatible: Must be one or more of the following
 
    - "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP'
+   - "renesas,r8a7795-fcpf" for R8A7795 (R-Car H3) compatible 'FCP for FDP'
    - "renesas,fcpv" for generic compatible 'FCP for VSP'
+   - "renesas,fcpf" for generic compatible 'FCP for FDP'
 
    When compatible with the generic version, nodes must list the
    SoC-specific version corresponding to the platform first, followed by the
-- 
2.7.4

[PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Kieran Bingham]

The FCP driver, can also support the FCPF variant for FDP1 compatible
processing.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
index 6a12960609d8..271dcfdb5a76 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
@@ -7,12 +7,14 @@ conversion of AXI transactions in order to reduce the memory bandwidth.
 
 There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
 for FDP (FCPF). Their configuration and behaviour depend on the module they
-are paired with. These DT bindings currently support the FCPV only.
+are paired with. These DT bindings currently support the FCPV and FCPF.
 
  - compatible: Must be one or more of the following
 
    - "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP'
+   - "renesas,r8a7795-fcpf" for R8A7795 (R-Car H3) compatible 'FCP for FDP'
    - "renesas,fcpv" for generic compatible 'FCP for VSP'
+   - "renesas,fcpf" for generic compatible 'FCP for FDP'
 
    When compatible with the generic version, nodes must list the
    SoC-specific version corresponding to the platform first, followed by the
-- 
2.7.4

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Rob Herring]

On Thu, Jun 09, 2016 at 02:41:32PM +0100, Kieran Bingham wrote:
> The FCP driver, can also support the FCPF variant for FDP1 compatible

Drop the comma.

> processing.
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

With that,

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Rob Herring]

On Thu, Jun 09, 2016 at 02:41:32PM +0100, Kieran Bingham wrote:
> The FCP driver, can also support the FCPF variant for FDP1 compatible

Drop the comma.

> processing.
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

With that,

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Rob Herring]

On Thu, Jun 09, 2016 at 02:41:32PM +0100, Kieran Bingham wrote:
> The FCP driver, can also support the FCPF variant for FDP1 compatible

Drop the comma.

> processing.
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

With that,

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Kieran Bingham]

On 10/06/16 18:37, Rob Herring wrote:
> On Thu, Jun 09, 2016 at 02:41:32PM +0100, Kieran Bingham wrote:
>> The FCP driver, can also support the FCPF variant for FDP1 compatible
> 
> Drop the comma.

Ok

>> processing.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> With that,
> 
> Acked-by: Rob Herring <robh@kernel.org>

Thanks

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Kieran Bingham]

On 10/06/16 18:37, Rob Herring wrote:
> On Thu, Jun 09, 2016 at 02:41:32PM +0100, Kieran Bingham wrote:
>> The FCP driver, can also support the FCPF variant for FDP1 compatible
> 
> Drop the comma.

Ok

>> processing.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> With that,
> 
> Acked-by: Rob Herring <robh@kernel.org>

Thanks

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Kieran Bingham]

On 10/06/16 18:37, Rob Herring wrote:
> On Thu, Jun 09, 2016 at 02:41:32PM +0100, Kieran Bingham wrote:
>> The FCP driver, can also support the FCPF variant for FDP1 compatible
> 
> Drop the comma.

Ok

>> processing.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> With that,
> 
> Acked-by: Rob Herring <robh@kernel.org>

Thanks

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Thursday 09 Jun 2016 14:41:32 Kieran Bingham wrote:
> The FCP driver, can also support the FCPF variant for FDP1 compatible
> processing.

With the comma dropped,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> b/Documentation/devicetree/bindings/media/renesas,fcp.txt index
> 6a12960609d8..271dcfdb5a76 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -7,12 +7,14 @@ conversion of AXI transactions in order to reduce the
> memory bandwidth.
> 
>  There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> FCP for FDP (FCPF). Their configuration and behaviour depend on the module
> they -are paired with. These DT bindings currently support the FCPV only.
> +are paired with. These DT bindings currently support the FCPV and FCPF.
> 
>   - compatible: Must be one or more of the following
> 
>     - "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP'
> +   - "renesas,r8a7795-fcpf" for R8A7795 (R-Car H3) compatible 'FCP for
> FDP' - "renesas,fcpv" for generic compatible 'FCP for VSP'
> +   - "renesas,fcpf" for generic compatible 'FCP for FDP'
> 
>     When compatible with the generic version, nodes must list the
>     SoC-specific version corresponding to the platform first, followed by
> the

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Thursday 09 Jun 2016 14:41:32 Kieran Bingham wrote:
> The FCP driver, can also support the FCPF variant for FDP1 compatible
> processing.

With the comma dropped,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> b/Documentation/devicetree/bindings/media/renesas,fcp.txt index
> 6a12960609d8..271dcfdb5a76 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -7,12 +7,14 @@ conversion of AXI transactions in order to reduce the
> memory bandwidth.
> 
>  There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> FCP for FDP (FCPF). Their configuration and behaviour depend on the module
> they -are paired with. These DT bindings currently support the FCPV only.
> +are paired with. These DT bindings currently support the FCPV and FCPF.
> 
>   - compatible: Must be one or more of the following
> 
>     - "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP'
> +   - "renesas,r8a7795-fcpf" for R8A7795 (R-Car H3) compatible 'FCP for
> FDP' - "renesas,fcpv" for generic compatible 'FCP for VSP'
> +   - "renesas,fcpf" for generic compatible 'FCP for FDP'
> 
>     When compatible with the generic version, nodes must list the
>     SoC-specific version corresponding to the platform first, followed by
> the

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Thursday 09 Jun 2016 14:41:32 Kieran Bingham wrote:
> The FCP driver, can also support the FCPF variant for FDP1 compatible
> processing.

With the comma dropped,

Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>

> Signed-off-by: Kieran Bingham <kieran-SI8QzZ7I9JUn3X9lZQuFcg@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> b/Documentation/devicetree/bindings/media/renesas,fcp.txt index
> 6a12960609d8..271dcfdb5a76 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -7,12 +7,14 @@ conversion of AXI transactions in order to reduce the
> memory bandwidth.
> 
>  There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> FCP for FDP (FCPF). Their configuration and behaviour depend on the module
> they -are paired with. These DT bindings currently support the FCPV only.
> +are paired with. These DT bindings currently support the FCPV and FCPF.
> 
>   - compatible: Must be one or more of the following
> 
>     - "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP'
> +   - "renesas,r8a7795-fcpf" for R8A7795 (R-Car H3) compatible 'FCP for
> FDP' - "renesas,fcpv" for generic compatible 'FCP for VSP'
> +   - "renesas,fcpf" for generic compatible 'FCP for FDP'
> 
>     When compatible with the generic version, nodes must list the
>     SoC-specific version corresponding to the platform first, followed by
> the

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Kieran Bingham]

The power domain must be specified to bring the device out of module
standby. Document this in the example provided, so that new additions
are not missed.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
index 271dcfdb5a76..6a55f5215221 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
@@ -31,4 +31,5 @@ Device node example
 		compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
 		reg = <0 0xfea2f000 0 0x200>;
 		clocks = <&cpg CPG_MOD 602>;
+		power-domains = <&sysc R8A7795_PD_A3VP>;
 	};
-- 
2.7.4

[PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Kieran Bingham]

The power domain must be specified to bring the device out of module
standby. Document this in the example provided, so that new additions
are not missed.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
index 271dcfdb5a76..6a55f5215221 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
@@ -31,4 +31,5 @@ Device node example
 		compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
 		reg = <0 0xfea2f000 0 0x200>;
 		clocks = <&cpg CPG_MOD 602>;
+		power-domains = <&sysc R8A7795_PD_A3VP>;
 	};
-- 
2.7.4

[PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Kieran Bingham]

The power domain must be specified to bring the device out of module
standby. Document this in the example provided, so that new additions
are not missed.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
index 271dcfdb5a76..6a55f5215221 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
@@ -31,4 +31,5 @@ Device node example
 		compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
 		reg = <0 0xfea2f000 0 0x200>;
 		clocks = <&cpg CPG_MOD 602>;
+		power-domains = <&sysc R8A7795_PD_A3VP>;
 	};
-- 
2.7.4

Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Rob Herring]

On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
> The power domain must be specified to bring the device out of module
> standby. Document this in the example provided, so that new additions
> are not missed.
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> index 271dcfdb5a76..6a55f5215221 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -31,4 +31,5 @@ Device node example
>  		compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>  		reg = <0 0xfea2f000 0 0x200>;
>  		clocks = <&cpg CPG_MOD 602>;
> +		power-domains = <&sysc R8A7795_PD_A3VP>;

This needs to be documented above too, not just the example.

>  	};
> -- 
> 2.7.4
> 

Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Rob Herring]

On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
> The power domain must be specified to bring the device out of module
> standby. Document this in the example provided, so that new additions
> are not missed.
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> index 271dcfdb5a76..6a55f5215221 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -31,4 +31,5 @@ Device node example
>  		compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>  		reg = <0 0xfea2f000 0 0x200>;
>  		clocks = <&cpg CPG_MOD 602>;
> +		power-domains = <&sysc R8A7795_PD_A3VP>;

This needs to be documented above too, not just the example.

>  	};
> -- 
> 2.7.4
> 

Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Rob Herring]

On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
> The power domain must be specified to bring the device out of module
> standby. Document this in the example provided, so that new additions
> are not missed.
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> index 271dcfdb5a76..6a55f5215221 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -31,4 +31,5 @@ Device node example
>  		compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>  		reg = <0 0xfea2f000 0 0x200>;
>  		clocks = <&cpg CPG_MOD 602>;
> +		power-domains = <&sysc R8A7795_PD_A3VP>;

This needs to be documented above too, not just the example.

>  	};
> -- 
> 2.7.4
> 

Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Rob Herring]

On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
> The power domain must be specified to bring the device out of module
> standby. Document this in the example provided, so that new additions
> are not missed.
> 
> Signed-off-by: Kieran Bingham <kieran-SI8QzZ7I9JUn3X9lZQuFcg@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> index 271dcfdb5a76..6a55f5215221 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -31,4 +31,5 @@ Device node example
>  		compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>  		reg = <0 0xfea2f000 0 0x200>;
>  		clocks = <&cpg CPG_MOD 602>;
> +		power-domains = <&sysc R8A7795_PD_A3VP>;

This needs to be documented above too, not just the example.

>  	};
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Geert Uytterhoeven]

Hi Rob,

On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote:
> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
>> The power domain must be specified to bring the device out of module
>> standby. Document this in the example provided, so that new additions
>> are not missed.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> index 271dcfdb5a76..6a55f5215221 100644
>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> @@ -31,4 +31,5 @@ Device node example
>>               compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>>               reg = <0 0xfea2f000 0 0x200>;
>>               clocks = <&cpg CPG_MOD 602>;
>> +             power-domains = <&sysc R8A7795_PD_A3VP>;
>
> This needs to be documented above too, not just the example.

Why? Power domains are an optional feature, whose presence depends
on the platform, not on the device.

Hence "power-domains" properties may appear in any device node.
Having to document them in every single binding document is overkill.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Geert Uytterhoeven]

Hi Rob,

On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote:
> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
>> The power domain must be specified to bring the device out of module
>> standby. Document this in the example provided, so that new additions
>> are not missed.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> index 271dcfdb5a76..6a55f5215221 100644
>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> @@ -31,4 +31,5 @@ Device node example
>>               compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>>               reg = <0 0xfea2f000 0 0x200>;
>>               clocks = <&cpg CPG_MOD 602>;
>> +             power-domains = <&sysc R8A7795_PD_A3VP>;
>
> This needs to be documented above too, not just the example.

Why? Power domains are an optional feature, whose presence depends
on the platform, not on the device.

Hence "power-domains" properties may appear in any device node.
Having to document them in every single binding document is overkill.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Rob Herring]

On Fri, Jun 10, 2016 at 2:11 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Rob,
>
> On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote:
>> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
>>> The power domain must be specified to bring the device out of module
>>> standby. Document this in the example provided, so that new additions
>>> are not missed.
>>>
>>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>>> ---
>>>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>> index 271dcfdb5a76..6a55f5215221 100644
>>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>> @@ -31,4 +31,5 @@ Device node example
>>>               compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>>>               reg = <0 0xfea2f000 0 0x200>;
>>>               clocks = <&cpg CPG_MOD 602>;
>>> +             power-domains = <&sysc R8A7795_PD_A3VP>;
>>
>> This needs to be documented above too, not just the example.
>
> Why? Power domains are an optional feature, whose presence depends
> on the platform, not on the device.

Examples are not documentation. The binding should stand on its own
without the example.

How did I know this is optional unless you document it as optional?
How many power domains does the device have?

> Hence "power-domains" properties may appear in any device node.
> Having to document them in every single binding document is overkill.

We do it for everything else pretty much. There's some exceptions like "status".

I agree that we get a bunch of redundancy with random text describing
the properties. I'm all for a structured syntax that can distill the
device bindings down to the pertainent information. If only someone
proposed using yaml or something...

Rob

Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Rob Herring]

On Fri, Jun 10, 2016 at 2:11 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Rob,
>
> On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote:
>> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
>>> The power domain must be specified to bring the device out of module
>>> standby. Document this in the example provided, so that new additions
>>> are not missed.
>>>
>>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>>> ---
>>>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>> index 271dcfdb5a76..6a55f5215221 100644
>>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>> @@ -31,4 +31,5 @@ Device node example
>>>               compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>>>               reg = <0 0xfea2f000 0 0x200>;
>>>               clocks = <&cpg CPG_MOD 602>;
>>> +             power-domains = <&sysc R8A7795_PD_A3VP>;
>>
>> This needs to be documented above too, not just the example.
>
> Why? Power domains are an optional feature, whose presence depends
> on the platform, not on the device.

Examples are not documentation. The binding should stand on its own
without the example.

How did I know this is optional unless you document it as optional?
How many power domains does the device have?

> Hence "power-domains" properties may appear in any device node.
> Having to document them in every single binding document is overkill.

We do it for everything else pretty much. There's some exceptions like "status".

I agree that we get a bunch of redundancy with random text describing
the properties. I'm all for a structured syntax that can distill the
device bindings down to the pertainent information. If only someone
proposed using yaml or something...

Rob

Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Geert Uytterhoeven]

Hi Rob,

CC linux-pm

On Fri, Jun 10, 2016 at 11:33 PM, Rob Herring <robh@kernel.org> wrote:
> On Fri, Jun 10, 2016 at 2:11 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote:
>>> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
>>>> The power domain must be specified to bring the device out of module
>>>> standby. Document this in the example provided, so that new additions
>>>> are not missed.
>>>>
>>>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>>>> ---
>>>>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>>> index 271dcfdb5a76..6a55f5215221 100644
>>>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>>> @@ -31,4 +31,5 @@ Device node example
>>>>               compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>>>>               reg = <0 0xfea2f000 0 0x200>;
>>>>               clocks = <&cpg CPG_MOD 602>;
>>>> +             power-domains = <&sysc R8A7795_PD_A3VP>;
>>>
>>> This needs to be documented above too, not just the example.
>>
>> Why? Power domains are an optional feature, whose presence depends
>> on the platform, not on the device.
>
> Examples are not documentation. The binding should stand on its own
> without the example.
>
> How did I know this is optional unless you document it as optional?
> How many power domains does the device have?

The device does not have power domains, and is not aware of the existence
of power domains. Each SoC has one or more power domains.

"power-domains" properties are used to describe the hierarchical relationship
between power domains and the devices that resides in these power domains.
Just like nodes and subnodes describe the hierarchical relationship between
buses and the devices directly connected to these buses.

On the (Linux) software side, the device driver does have to use Runtime PM
if an SoC has more power domains than just the single "always-on" power domain.

>> Hence "power-domains" properties may appear in any device node.
>> Having to document them in every single binding document is overkill.
>
> We do it for everything else pretty much. There's some exceptions like "status".

IMHO having to document "power-domains" in every single DT binding is
as silly as having to document that the device node must be a child of the bus
device node in every single DT binding. This belongs in the DT binding of the
power controller, which is the device controlling the power domain.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

[Geert Uytterhoeven]

Hi Rob,

CC linux-pm

On Fri, Jun 10, 2016 at 11:33 PM, Rob Herring <robh@kernel.org> wrote:
> On Fri, Jun 10, 2016 at 2:11 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote:
>>> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote:
>>>> The power domain must be specified to bring the device out of module
>>>> standby. Document this in the example provided, so that new additions
>>>> are not missed.
>>>>
>>>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>>>> ---
>>>>  Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>>> index 271dcfdb5a76..6a55f5215221 100644
>>>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>>>> @@ -31,4 +31,5 @@ Device node example
>>>>               compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
>>>>               reg = <0 0xfea2f000 0 0x200>;
>>>>               clocks = <&cpg CPG_MOD 602>;
>>>> +             power-domains = <&sysc R8A7795_PD_A3VP>;
>>>
>>> This needs to be documented above too, not just the example.
>>
>> Why? Power domains are an optional feature, whose presence depends
>> on the platform, not on the device.
>
> Examples are not documentation. The binding should stand on its own
> without the example.
>
> How did I know this is optional unless you document it as optional?
> How many power domains does the device have?

The device does not have power domains, and is not aware of the existence
of power domains. Each SoC has one or more power domains.

"power-domains" properties are used to describe the hierarchical relationship
between power domains and the devices that resides in these power domains.
Just like nodes and subnodes describe the hierarchical relationship between
buses and the devices directly connected to these buses.

On the (Linux) software side, the device driver does have to use Runtime PM
if an SoC has more power domains than just the single "always-on" power domain.

>> Hence "power-domains" properties may appear in any device node.
>> Having to document them in every single binding document is overkill.
>
> We do it for everything else pretty much. There's some exceptions like "status".

IMHO having to document "power-domains" in every single DT binding is
as silly as having to document that the device node must be a child of the bus
device node in every single DT binding. This belongs in the DT binding of the
power controller, which is the device controlling the power domain.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

[Kieran Bingham]

The FDP1 is a de-interlacing module which converts interlaced video to
progressive video. It is also capable of performing pixel format conversion
between YCbCr/YUV formats and RGB formats.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt

diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
new file mode 100644
index 000000000000..e2da2aec5e9f
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
@@ -0,0 +1,34 @@
+Renesas R-Car Fine Display Processor (FDP1)
+-----------------------------------------------
+
+The FDP1 is a de-interlacing module which converts interlaced video to
+progressive video. It is capable of performing pixel format conversion between
+YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
+an input to the module.
+
+ - compatible: Must be one or more of the following
+
+   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
+   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
+   - "renesas,fdp1" for generic compatible
+
+   When compatible with the generic version, nodes must list the
+   SoC-specific version corresponding to the platform first, followed by the
+   family-specific and/or generic versions.
+
+ - reg: the register base and size for the device registers
+ - clocks: Reference to the functional clock
+ - renesas,fcp: Reference to the FCPF connected to the FDP1
+
+
+Device node example
+-------------------
+
+	fdp1ch1: fdp1@fe940000 {
+		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
+		reg = <0 0xfe940000 0 0x2400>;
+		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cpg CPG_MOD 119>;
+		power-domains = <&sysc R8A7795_PD_A3VP>;
+		renesas,fcp = <&fcpf0>;
+	};
\ No newline at end of file
-- 
2.7.4

[PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

[Kieran Bingham]

The FDP1 is a de-interlacing module which converts interlaced video to
progressive video. It is also capable of performing pixel format conversion
between YCbCr/YUV formats and RGB formats.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt

diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
new file mode 100644
index 000000000000..e2da2aec5e9f
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
@@ -0,0 +1,34 @@
+Renesas R-Car Fine Display Processor (FDP1)
+-----------------------------------------------
+
+The FDP1 is a de-interlacing module which converts interlaced video to
+progressive video. It is capable of performing pixel format conversion between
+YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
+an input to the module.
+
+ - compatible: Must be one or more of the following
+
+   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
+   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
+   - "renesas,fdp1" for generic compatible
+
+   When compatible with the generic version, nodes must list the
+   SoC-specific version corresponding to the platform first, followed by the
+   family-specific and/or generic versions.
+
+ - reg: the register base and size for the device registers
+ - clocks: Reference to the functional clock
+ - renesas,fcp: Reference to the FCPF connected to the FDP1
+
+
+Device node example
+-------------------
+
+	fdp1ch1: fdp1@fe940000 {
+		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
+		reg = <0 0xfe940000 0 0x2400>;
+		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cpg CPG_MOD 119>;
+		power-domains = <&sysc R8A7795_PD_A3VP>;
+		renesas,fcp = <&fcpf0>;
+	};
\ No newline at end of file
-- 
2.7.4

[PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

[Kieran Bingham]

The FDP1 is a de-interlacing module which converts interlaced video to
progressive video. It is also capable of performing pixel format conversion
between YCbCr/YUV formats and RGB formats.

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
 .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt

diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
new file mode 100644
index 000000000000..e2da2aec5e9f
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
@@ -0,0 +1,34 @@
+Renesas R-Car Fine Display Processor (FDP1)
+-----------------------------------------------
+
+The FDP1 is a de-interlacing module which converts interlaced video to
+progressive video. It is capable of performing pixel format conversion between
+YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
+an input to the module.
+
+ - compatible: Must be one or more of the following
+
+   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
+   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
+   - "renesas,fdp1" for generic compatible
+
+   When compatible with the generic version, nodes must list the
+   SoC-specific version corresponding to the platform first, followed by the
+   family-specific and/or generic versions.
+
+ - reg: the register base and size for the device registers
+ - clocks: Reference to the functional clock
+ - renesas,fcp: Reference to the FCPF connected to the FDP1
+
+
+Device node example
+-------------------
+
+	fdp1ch1: fdp1@fe940000 {
+		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
+		reg = <0 0xfe940000 0 0x2400>;
+		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cpg CPG_MOD 119>;
+		power-domains = <&sysc R8A7795_PD_A3VP>;
+		renesas,fcp = <&fcpf0>;
+	};
\ No newline at end of file
-- 
2.7.4

Re: [PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

[Rob Herring]

On Thu, Jun 09, 2016 at 02:41:34PM +0100, Kieran Bingham wrote:
> The FDP1 is a de-interlacing module which converts interlaced video to
> progressive video. It is also capable of performing pixel format conversion
> between YCbCr/YUV formats and RGB formats.
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> new file mode 100644
> index 000000000000..e2da2aec5e9f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> @@ -0,0 +1,34 @@
> +Renesas R-Car Fine Display Processor (FDP1)
> +-----------------------------------------------
> +
> +The FDP1 is a de-interlacing module which converts interlaced video to
> +progressive video. It is capable of performing pixel format conversion between
> +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
> +an input to the module.
> +
> + - compatible: Must be one or more of the following
> +
> +   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
> +   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
> +   - "renesas,fdp1" for generic compatible
> +
> +   When compatible with the generic version, nodes must list the
> +   SoC-specific version corresponding to the platform first, followed by the
> +   family-specific and/or generic versions.
> +
> + - reg: the register base and size for the device registers
> + - clocks: Reference to the functional clock
> + - renesas,fcp: Reference to the FCPF connected to the FDP1
> +
> +
> +Device node example
> +-------------------
> +
> +	fdp1ch1: fdp1@fe940000 {
> +		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
> +		reg = <0 0xfe940000 0 0x2400>;
> +		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cpg CPG_MOD 119>;
> +		power-domains = <&sysc R8A7795_PD_A3VP>;

Not documented.

> +		renesas,fcp = <&fcpf0>;
> +	};
> \ No newline at end of file

Fix this.

> -- 
> 2.7.4
> 

Re: [PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

[Rob Herring]

On Thu, Jun 09, 2016 at 02:41:34PM +0100, Kieran Bingham wrote:
> The FDP1 is a de-interlacing module which converts interlaced video to
> progressive video. It is also capable of performing pixel format conversion
> between YCbCr/YUV formats and RGB formats.
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> new file mode 100644
> index 000000000000..e2da2aec5e9f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> @@ -0,0 +1,34 @@
> +Renesas R-Car Fine Display Processor (FDP1)
> +-----------------------------------------------
> +
> +The FDP1 is a de-interlacing module which converts interlaced video to
> +progressive video. It is capable of performing pixel format conversion between
> +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
> +an input to the module.
> +
> + - compatible: Must be one or more of the following
> +
> +   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
> +   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
> +   - "renesas,fdp1" for generic compatible
> +
> +   When compatible with the generic version, nodes must list the
> +   SoC-specific version corresponding to the platform first, followed by the
> +   family-specific and/or generic versions.
> +
> + - reg: the register base and size for the device registers
> + - clocks: Reference to the functional clock
> + - renesas,fcp: Reference to the FCPF connected to the FDP1
> +
> +
> +Device node example
> +-------------------
> +
> +	fdp1ch1: fdp1@fe940000 {
> +		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
> +		reg = <0 0xfe940000 0 0x2400>;
> +		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cpg CPG_MOD 119>;
> +		power-domains = <&sysc R8A7795_PD_A3VP>;

Not documented.

> +		renesas,fcp = <&fcpf0>;
> +	};
> \ No newline at end of file

Fix this.

> -- 
> 2.7.4
> 

Re: [PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

[Rob Herring]

On Thu, Jun 09, 2016 at 02:41:34PM +0100, Kieran Bingham wrote:
> The FDP1 is a de-interlacing module which converts interlaced video to
> progressive video. It is also capable of performing pixel format conversion
> between YCbCr/YUV formats and RGB formats.
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> ---
>  .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> new file mode 100644
> index 000000000000..e2da2aec5e9f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> @@ -0,0 +1,34 @@
> +Renesas R-Car Fine Display Processor (FDP1)
> +-----------------------------------------------
> +
> +The FDP1 is a de-interlacing module which converts interlaced video to
> +progressive video. It is capable of performing pixel format conversion between
> +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
> +an input to the module.
> +
> + - compatible: Must be one or more of the following
> +
> +   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
> +   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
> +   - "renesas,fdp1" for generic compatible
> +
> +   When compatible with the generic version, nodes must list the
> +   SoC-specific version corresponding to the platform first, followed by the
> +   family-specific and/or generic versions.
> +
> + - reg: the register base and size for the device registers
> + - clocks: Reference to the functional clock
> + - renesas,fcp: Reference to the FCPF connected to the FDP1
> +
> +
> +Device node example
> +-------------------
> +
> +	fdp1ch1: fdp1@fe940000 {
> +		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
> +		reg = <0 0xfe940000 0 0x2400>;
> +		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cpg CPG_MOD 119>;
> +		power-domains = <&sysc R8A7795_PD_A3VP>;

Not documented.

> +		renesas,fcp = <&fcpf0>;
> +	};
> \ No newline at end of file

Fix this.

> -- 
> 2.7.4
> 

Re: [PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

[Kieran Bingham]

On 10/06/16 18:40, Rob Herring wrote:
> On Thu, Jun 09, 2016 at 02:41:34PM +0100, Kieran Bingham wrote:
>> The FDP1 is a de-interlacing module which converts interlaced video to
>> progressive video. It is also capable of performing pixel format conversion
>> between YCbCr/YUV formats and RGB formats.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>>  .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
>> new file mode 100644
>> index 000000000000..e2da2aec5e9f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
>> @@ -0,0 +1,34 @@
>> +Renesas R-Car Fine Display Processor (FDP1)
>> +-----------------------------------------------
>> +
>> +The FDP1 is a de-interlacing module which converts interlaced video to
>> +progressive video. It is capable of performing pixel format conversion between
>> +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
>> +an input to the module.
>> +
>> + - compatible: Must be one or more of the following
>> +
>> +   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
>> +   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
>> +   - "renesas,fdp1" for generic compatible
>> +
>> +   When compatible with the generic version, nodes must list the
>> +   SoC-specific version corresponding to the platform first, followed by the
>> +   family-specific and/or generic versions.
>> +
>> + - reg: the register base and size for the device registers
>> + - clocks: Reference to the functional clock
>> + - renesas,fcp: Reference to the FCPF connected to the FDP1
>> +
>> +
>> +Device node example
>> +-------------------
>> +
>> +	fdp1ch1: fdp1@fe940000 {
>> +		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
>> +		reg = <0 0xfe940000 0 0x2400>;
>> +		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cpg CPG_MOD 119>;
>> +		power-domains = <&sysc R8A7795_PD_A3VP>;
> 
> Not documented.

I'll mirror whatever the consensus is on this topic from the other patch
here.

> 
>> +		renesas,fcp = <&fcpf0>;
>> +	};
>> \ No newline at end of file
> 
> Fix this.

Ok

>> -- 
>> 2.7.4
>>

-- 
Regards

Kieran Bingham

Re: [PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

[Kieran Bingham]

On 10/06/16 18:40, Rob Herring wrote:
> On Thu, Jun 09, 2016 at 02:41:34PM +0100, Kieran Bingham wrote:
>> The FDP1 is a de-interlacing module which converts interlaced video to
>> progressive video. It is also capable of performing pixel format conversion
>> between YCbCr/YUV formats and RGB formats.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>>  .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
>> new file mode 100644
>> index 000000000000..e2da2aec5e9f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
>> @@ -0,0 +1,34 @@
>> +Renesas R-Car Fine Display Processor (FDP1)
>> +-----------------------------------------------
>> +
>> +The FDP1 is a de-interlacing module which converts interlaced video to
>> +progressive video. It is capable of performing pixel format conversion between
>> +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
>> +an input to the module.
>> +
>> + - compatible: Must be one or more of the following
>> +
>> +   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
>> +   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
>> +   - "renesas,fdp1" for generic compatible
>> +
>> +   When compatible with the generic version, nodes must list the
>> +   SoC-specific version corresponding to the platform first, followed by the
>> +   family-specific and/or generic versions.
>> +
>> + - reg: the register base and size for the device registers
>> + - clocks: Reference to the functional clock
>> + - renesas,fcp: Reference to the FCPF connected to the FDP1
>> +
>> +
>> +Device node example
>> +-------------------
>> +
>> +	fdp1ch1: fdp1@fe940000 {
>> +		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
>> +		reg = <0 0xfe940000 0 0x2400>;
>> +		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cpg CPG_MOD 119>;
>> +		power-domains = <&sysc R8A7795_PD_A3VP>;
> 
> Not documented.

I'll mirror whatever the consensus is on this topic from the other patch
here.

> 
>> +		renesas,fcp = <&fcpf0>;
>> +	};
>> \ No newline at end of file
> 
> Fix this.

Ok

>> -- 
>> 2.7.4
>>

-- 
Regards

Kieran Bingham

Re: [PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

[Kieran Bingham]

On 10/06/16 18:40, Rob Herring wrote:
> On Thu, Jun 09, 2016 at 02:41:34PM +0100, Kieran Bingham wrote:
>> The FDP1 is a de-interlacing module which converts interlaced video to
>> progressive video. It is also capable of performing pixel format conversion
>> between YCbCr/YUV formats and RGB formats.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>> ---
>>  .../devicetree/bindings/media/renesas,fdp1.txt     | 34 ++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
>> new file mode 100644
>> index 000000000000..e2da2aec5e9f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
>> @@ -0,0 +1,34 @@
>> +Renesas R-Car Fine Display Processor (FDP1)
>> +-----------------------------------------------
>> +
>> +The FDP1 is a de-interlacing module which converts interlaced video to
>> +progressive video. It is capable of performing pixel format conversion between
>> +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
>> +an input to the module.
>> +
>> + - compatible: Must be one or more of the following
>> +
>> +   - "renesas,r8a7795-fdp1" for R8A7795 (R-Car H3)
>> +   - "renesas,r8a7796-fdp1" for R8A7796 (R-Car M3-W)
>> +   - "renesas,fdp1" for generic compatible
>> +
>> +   When compatible with the generic version, nodes must list the
>> +   SoC-specific version corresponding to the platform first, followed by the
>> +   family-specific and/or generic versions.
>> +
>> + - reg: the register base and size for the device registers
>> + - clocks: Reference to the functional clock
>> + - renesas,fcp: Reference to the FCPF connected to the FDP1
>> +
>> +
>> +Device node example
>> +-------------------
>> +
>> +	fdp1ch1: fdp1@fe940000 {
>> +		compatible = "renesas,r8a7795-fdp1", "renesas,fdp1";
>> +		reg = <0 0xfe940000 0 0x2400>;
>> +		interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cpg CPG_MOD 119>;
>> +		power-domains = <&sysc R8A7795_PD_A3VP>;
> 
> Not documented.

I'll mirror whatever the consensus is on this topic from the other patch
here.

> 
>> +		renesas,fcp = <&fcpf0>;
>> +	};
>> \ No newline at end of file
> 
> Fix this.

Ok

>> -- 
>> 2.7.4
>>

-- 
Regards

Kieran Bingham