All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] build: cleanup remaining references to BR2_STRIP_sstrip
@ 2016-06-10 11:28 Julien Floret
  2016-06-10 18:16 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Julien Floret @ 2016-06-10 11:28 UTC (permalink / raw)
  To: buildroot

sstrip option has been removed in commit
106f5b8c5093 ("build: remove deprecated sstrip option").

Signed-off-by: Julien Floret <julien.floret@6wind.com>
---
 package/Makefile.in                  | 8 --------
 support/dependencies/dependencies.mk | 4 ----
 2 files changed, 12 deletions(-)

diff --git a/package/Makefile.in b/package/Makefile.in
index 2d454a63820b..f6d1e6787cb9 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -201,14 +201,6 @@ TARGET_STRIP = $(TARGET_CROSS)strip
 STRIPCMD = $(TARGET_CROSS)strip --remove-section=.comment --remove-section=.note
 KSTRIPCMD = $(STRIPCMD) $(STRIP_STRIP_UNNEEDED)
 endif
-ifeq ($(BR2_STRIP_sstrip),y)
-STRIP_STRIP_DEBUG :=
-STRIP_STRIP_UNNEEDED :=
-STRIP_STRIP_ALL :=
-TARGET_STRIP = $(HOST_DIR)/usr/bin/$(GNU_TARGET_NAME)-sstrip
-STRIPCMD = $(TARGET_STRIP)
-KSTRIPCMD = $(TARGET_CROSS)strip --remove-section=.comment --remove-section=.note --strip-unneeded
-endif
 ifeq ($(BR2_STRIP_none),y)
 TARGET_STRIP = true
 STRIPCMD = $(TARGET_STRIP)
diff --git a/support/dependencies/dependencies.mk b/support/dependencies/dependencies.mk
index 82327216cd61..4334dac4e811 100644
--- a/support/dependencies/dependencies.mk
+++ b/support/dependencies/dependencies.mk
@@ -16,10 +16,6 @@ $(shell support/dependencies/check-host-$(1).sh $(2))
 endef
 -include $(sort $(wildcard support/dependencies/check-host-*.mk))
 
-ifeq ($(BR2_STRIP_sstrip),y)
-DEPENDENCIES_HOST_PREREQ += host-sstrip
-endif
-
 ifeq ($(BR2_CCACHE),y)
 DEPENDENCIES_HOST_PREREQ += host-ccache
 endif
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] build: cleanup remaining references to BR2_STRIP_sstrip
  2016-06-10 11:28 [Buildroot] [PATCH] build: cleanup remaining references to BR2_STRIP_sstrip Julien Floret
@ 2016-06-10 18:16 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-06-10 18:16 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 10 Jun 2016 13:28:02 +0200, Julien Floret wrote:
> sstrip option has been removed in commit
> 106f5b8c5093 ("build: remove deprecated sstrip option").
> 
> Signed-off-by: Julien Floret <julien.floret@6wind.com>
> ---
>  package/Makefile.in                  | 8 --------
>  support/dependencies/dependencies.mk | 4 ----
>  2 files changed, 12 deletions(-)

Applied to master, thanks. I think package/sstrip/sstrip.mk could also
be simplified to get rid of the host variant, since it's not used
anywhere anymore.

It would be me, I would also remove the target variant, or at least
mark it as deprecated.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-10 18:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-10 11:28 [Buildroot] [PATCH] build: cleanup remaining references to BR2_STRIP_sstrip Julien Floret
2016-06-10 18:16 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.