All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Sorokin <afarallax@yandex.ru>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	Richard Henderson <rth@twiddle.net>,
	Peter Maydell <peter.maydell@linaro.org>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Michael Walle <michael@walle.cc>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Leon Alrae <leon.alrae@imgtec.com>,
	Anthony Green <green@moxielogic.com>, Jia Liu <proljc@gmail.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Max Filippov <jcmvbkbc@gmail.com>,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	Sergey Sorokin <afarallax@yandex.ru>
Subject: [Qemu-devel] [PATCH 0/2] Fix confusing argument names in some common functions
Date: Fri, 10 Jun 2016 19:26:37 +0300	[thread overview]
Message-ID: <1465575999-3594234-1-git-send-email-afarallax@yandex.ru> (raw)

There are functions tlb_fill(), cpu_unaligned_access() and
do_unaligned_access() that are called with access type and mmu index
arguments. But these arguments are named 'is_write' and 'is_user' in their
declarations. The patches fix the names to avoid a confusion.

Sergey Sorokin (2):
  Fix confusing argument names of do_unaligned_access() functions
  Fix a confusing argument name in tlb_fill() function

 include/exec/exec-all.h       |  2 +-
 include/qom/cpu.h             |  8 ++++----
 target-alpha/cpu.h            |  4 ++--
 target-alpha/mem_helper.c     |  8 ++++----
 target-arm/internals.h        |  4 ++--
 target-arm/op_helper.c        | 27 +++++++++++++++------------
 target-cris/op_helper.c       |  4 ++--
 target-i386/mem_helper.c      |  4 ++--
 target-lm32/op_helper.c       |  4 ++--
 target-m68k/op_helper.c       |  4 ++--
 target-microblaze/op_helper.c |  4 ++--
 target-mips/cpu.h             |  4 ++--
 target-mips/op_helper.c       |  6 +++---
 target-moxie/helper.c         |  4 ++--
 target-openrisc/mmu_helper.c  |  4 ++--
 target-ppc/mmu_helper.c       |  6 +++---
 target-s390x/mem_helper.c     |  4 ++--
 target-sh4/op_helper.c        |  4 ++--
 target-sparc/cpu.h            |  5 +++--
 target-sparc/ldst_helper.c    |  9 +++++----
 target-tricore/op_helper.c    |  4 ++--
 target-unicore32/op_helper.c  |  4 ++--
 target-xtensa/cpu.h           |  4 ++--
 target-xtensa/op_helper.c     | 10 ++++++----
 24 files changed, 74 insertions(+), 67 deletions(-)

-- 
1.9.3

             reply	other threads:[~2016-06-10 16:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 16:26 Sergey Sorokin [this message]
2016-06-10 16:26 ` [Qemu-devel] [PATCH 1/2] Fix confusing argument names of do_unaligned_access() functions Sergey Sorokin
2016-06-10 16:33   ` Peter Maydell
2016-06-10 16:36     ` Sergey Sorokin
2016-06-10 16:42     ` Sergey Sorokin
2016-06-10 16:43       ` Peter Maydell
2016-06-10 17:26         ` Sergey Sorokin
2016-06-13  8:23           ` Paolo Bonzini
2016-06-13  7:03   ` Aurelien Jarno
2016-06-14 12:01     ` Sergey Sorokin
2016-06-10 16:26 ` [Qemu-devel] [PATCH 2/2] Fix a confusing argument name in tlb_fill() function Sergey Sorokin
2016-06-11 10:28   ` David Gibson
2016-06-14 18:40   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465575999-3594234-1-git-send-email-afarallax@yandex.ru \
    --to=afarallax@yandex.ru \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=edgar.iglesias@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=green@moxielogic.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=jcmvbkbc@gmail.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=leon.alrae@imgtec.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=michael@walle.cc \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=proljc@gmail.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.