All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS
@ 2016-06-12 11:18 Petr Kulhavy
  2016-06-18  8:43 ` Stefano Babic
  0 siblings, 1 reply; 2+ messages in thread
From: Petr Kulhavy @ 2016-06-12 11:18 UTC (permalink / raw)
  To: u-boot

spl_boot_mode() returned MMCSD_MODE_RAW on MMC if CONFIG_SPL_EXT_SUPPORT
was configured. EXTFS is the default filesystem selected in imx6_spl.h
and the function should return MMCSD_MODE_FS instead.

Fix this and return MMCSD_MODE_FS instead in such cases.

Signed-off-by: Petr Kulhavy <brain@jikos.cz>
CC: Stefano Babic <sbabic@denx.de>
CC: Tim Harvey <tharvey@gateworks.com>
CC: Fabio Estevam <Fabio.Estevam@freescale.com>
---
 arch/arm/imx-common/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/imx-common/spl.c b/arch/arm/imx-common/spl.c
index caa45cf..42cefdd 100644
--- a/arch/arm/imx-common/spl.c
+++ b/arch/arm/imx-common/spl.c
@@ -76,7 +76,7 @@ u32 spl_boot_mode(void)
 	/* for MMC return either RAW or FAT mode */
 	case BOOT_DEVICE_MMC1:
 	case BOOT_DEVICE_MMC2:
-#if defined(CONFIG_SPL_FAT_SUPPORT)
+#if defined(CONFIG_SPL_FAT_SUPPORT) || defined(CONFIG_SPL_EXT_SUPPORT)
 		return MMCSD_MODE_FS;
 #elif defined(CONFIG_SUPPORT_EMMC_BOOT)
 		return MMCSD_MODE_EMMCBOOT;
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS
  2016-06-12 11:18 [U-Boot] [PATCH] imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS Petr Kulhavy
@ 2016-06-18  8:43 ` Stefano Babic
  0 siblings, 0 replies; 2+ messages in thread
From: Stefano Babic @ 2016-06-18  8:43 UTC (permalink / raw)
  To: u-boot

On 12/06/2016 13:18, Petr Kulhavy wrote:
> spl_boot_mode() returned MMCSD_MODE_RAW on MMC if CONFIG_SPL_EXT_SUPPORT
> was configured. EXTFS is the default filesystem selected in imx6_spl.h
> and the function should return MMCSD_MODE_FS instead.
> 
> Fix this and return MMCSD_MODE_FS instead in such cases.
> 
> Signed-off-by: Petr Kulhavy <brain@jikos.cz>
> CC: Stefano Babic <sbabic@denx.de>
> CC: Tim Harvey <tharvey@gateworks.com>
> CC: Fabio Estevam <Fabio.Estevam@freescale.com>
> ---
>  arch/arm/imx-common/spl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/imx-common/spl.c b/arch/arm/imx-common/spl.c
> index caa45cf..42cefdd 100644
> --- a/arch/arm/imx-common/spl.c
> +++ b/arch/arm/imx-common/spl.c
> @@ -76,7 +76,7 @@ u32 spl_boot_mode(void)
>  	/* for MMC return either RAW or FAT mode */
>  	case BOOT_DEVICE_MMC1:
>  	case BOOT_DEVICE_MMC2:
> -#if defined(CONFIG_SPL_FAT_SUPPORT)
> +#if defined(CONFIG_SPL_FAT_SUPPORT) || defined(CONFIG_SPL_EXT_SUPPORT)
>  		return MMCSD_MODE_FS;
>  #elif defined(CONFIG_SUPPORT_EMMC_BOOT)
>  		return MMCSD_MODE_EMMCBOOT;
> 

Applied to master (bug fix), thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-18  8:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-12 11:18 [U-Boot] [PATCH] imx_common: Return MMCSD_MODE_FS in spl_boot_mode() also for EXTFS Petr Kulhavy
2016-06-18  8:43 ` Stefano Babic

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.