From: Petr Mladek <pmladek@suse.com> To: Andrew Morton <akpm@linux-foundation.org>, Oleg Nesterov <oleg@redhat.com>, Tejun Heo <tj@kernel.org>, Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Josh Triplett <josh@joshtriplett.org>, Thomas Gleixner <tglx@linutronix.de>, Linus Torvalds <torvalds@linux-foundation.org>, Jiri Kosina <jkosina@suse.cz>, Borislav Petkov <bp@suse.de>, Michal Hocko <mhocko@suse.cz>, linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com> Subject: [PATCH v9 07/12] kthread: Add kthread_destroy_worker() Date: Thu, 16 Jun 2016 13:17:26 +0200 [thread overview] Message-ID: <1466075851-24013-8-git-send-email-pmladek@suse.com> (raw) In-Reply-To: <1466075851-24013-1-git-send-email-pmladek@suse.com> The current kthread worker users call flush() and stop() explicitly. This function drains the worker, stops it, and frees the kthread_worker struct in one call. It is supposed to be used together with kthread_create_worker*() that allocates struct kthread_worker. Also note that drain() correctly handles self-queuing works in compare with flush(). Signed-off-by: Petr Mladek <pmladek@suse.com> --- include/linux/kthread.h | 2 ++ kernel/kthread.c | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/include/linux/kthread.h b/include/linux/kthread.h index c889b653f8cb..b2c4dcea8f51 100644 --- a/include/linux/kthread.h +++ b/include/linux/kthread.h @@ -137,4 +137,6 @@ void kthread_flush_work(struct kthread_work *work); void kthread_flush_worker(struct kthread_worker *worker); void kthread_drain_worker(struct kthread_worker *worker); +void kthread_destroy_worker(struct kthread_worker *worker); + #endif /* _LINUX_KTHREAD_H */ diff --git a/kernel/kthread.c b/kernel/kthread.c index 4454b1267718..567ec49b4872 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -853,3 +853,24 @@ void kthread_drain_worker(struct kthread_worker *worker) spin_unlock_irq(&worker->lock); } EXPORT_SYMBOL(kthread_drain_worker); + +/** + * kthread_destroy_worker - destroy a kthread worker + * @worker: worker to be destroyed + * + * Drain and destroy @worker. It has the same conditions + * for use as kthread_drain_worker(), see above. + */ +void kthread_destroy_worker(struct kthread_worker *worker) +{ + struct task_struct *task; + + task = worker->task; + if (WARN_ON(!task)) + return; + + kthread_drain_worker(worker); + kthread_stop(task); + kfree(worker); +} +EXPORT_SYMBOL(kthread_destroy_worker); -- 1.8.5.6
WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com> To: Andrew Morton <akpm@linux-foundation.org>, Oleg Nesterov <oleg@redhat.com>, Tejun Heo <tj@kernel.org>, Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Josh Triplett <josh@joshtriplett.org>, Thomas Gleixner <tglx@linutronix.de>, Linus Torvalds <torvalds@linux-foundation.org>, Jiri Kosina <jkosina@suse.cz>, Borislav Petkov <bp@suse.de>, Michal Hocko <mhocko@suse.cz>, linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com> Subject: [PATCH v9 07/12] kthread: Add kthread_destroy_worker() Date: Thu, 16 Jun 2016 13:17:26 +0200 [thread overview] Message-ID: <1466075851-24013-8-git-send-email-pmladek@suse.com> (raw) In-Reply-To: <1466075851-24013-1-git-send-email-pmladek@suse.com> The current kthread worker users call flush() and stop() explicitly. This function drains the worker, stops it, and frees the kthread_worker struct in one call. It is supposed to be used together with kthread_create_worker*() that allocates struct kthread_worker. Also note that drain() correctly handles self-queuing works in compare with flush(). Signed-off-by: Petr Mladek <pmladek@suse.com> --- include/linux/kthread.h | 2 ++ kernel/kthread.c | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/include/linux/kthread.h b/include/linux/kthread.h index c889b653f8cb..b2c4dcea8f51 100644 --- a/include/linux/kthread.h +++ b/include/linux/kthread.h @@ -137,4 +137,6 @@ void kthread_flush_work(struct kthread_work *work); void kthread_flush_worker(struct kthread_worker *worker); void kthread_drain_worker(struct kthread_worker *worker); +void kthread_destroy_worker(struct kthread_worker *worker); + #endif /* _LINUX_KTHREAD_H */ diff --git a/kernel/kthread.c b/kernel/kthread.c index 4454b1267718..567ec49b4872 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -853,3 +853,24 @@ void kthread_drain_worker(struct kthread_worker *worker) spin_unlock_irq(&worker->lock); } EXPORT_SYMBOL(kthread_drain_worker); + +/** + * kthread_destroy_worker - destroy a kthread worker + * @worker: worker to be destroyed + * + * Drain and destroy @worker. It has the same conditions + * for use as kthread_drain_worker(), see above. + */ +void kthread_destroy_worker(struct kthread_worker *worker) +{ + struct task_struct *task; + + task = worker->task; + if (WARN_ON(!task)) + return; + + kthread_drain_worker(worker); + kthread_stop(task); + kfree(worker); +} +EXPORT_SYMBOL(kthread_destroy_worker); -- 1.8.5.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-16 11:19 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-16 11:17 [PATCH v9 00/12] kthread: Kthread worker API improvements Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-16 11:17 ` [PATCH v9 01/12] kthread: Rename probe_kthread_data() to kthread_probe_data() Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-20 19:16 ` Tejun Heo 2016-06-20 19:16 ` Tejun Heo 2016-06-16 11:17 ` [PATCH v9 02/12] kthread: Kthread worker API cleanup Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-20 19:27 ` Tejun Heo 2016-06-20 19:27 ` Tejun Heo 2016-06-16 11:17 ` [PATCH v9 03/12] kthread/smpboot: Do not park in kthread_create_on_cpu() Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-16 11:17 ` [PATCH v9 04/12] kthread: Allow to call __kthread_create_on_node() with va_list args Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-20 19:51 ` Tejun Heo 2016-06-20 19:51 ` Tejun Heo 2016-06-16 11:17 ` [PATCH v9 05/12] kthread: Add kthread_create_worker*() Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-20 19:55 ` Tejun Heo 2016-06-20 19:55 ` Tejun Heo 2016-06-16 11:17 ` [PATCH v9 06/12] kthread: Add kthread_drain_worker() Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-20 19:56 ` Tejun Heo 2016-06-20 19:56 ` Tejun Heo 2016-06-22 20:54 ` Peter Zijlstra 2016-06-22 20:54 ` Peter Zijlstra 2016-06-23 21:32 ` Tejun Heo 2016-06-23 21:32 ` Tejun Heo 2016-06-23 21:32 ` Tejun Heo 2016-06-24 7:05 ` Peter Zijlstra 2016-06-24 7:05 ` Peter Zijlstra 2016-06-24 9:08 ` Petr Mladek 2016-06-24 9:08 ` Petr Mladek 2016-06-24 15:54 ` Tejun Heo 2016-06-24 15:54 ` Tejun Heo 2016-06-27 14:33 ` Petr Mladek 2016-06-27 14:33 ` Petr Mladek 2016-06-27 14:33 ` Petr Mladek 2016-06-28 17:04 ` Tejun Heo 2016-06-28 17:04 ` Tejun Heo 2016-06-29 8:17 ` Petr Mladek 2016-06-29 8:17 ` Petr Mladek 2016-06-29 13:15 ` Tejun Heo 2016-06-29 13:15 ` Tejun Heo 2016-06-29 13:15 ` Tejun Heo 2016-06-16 11:17 ` Petr Mladek [this message] 2016-06-16 11:17 ` [PATCH v9 07/12] kthread: Add kthread_destroy_worker() Petr Mladek 2016-06-20 19:57 ` Tejun Heo 2016-06-20 19:57 ` Tejun Heo 2016-06-16 11:17 ` [PATCH v9 08/12] kthread: Detect when a kthread work is used by more workers Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-20 20:10 ` Tejun Heo 2016-06-20 20:10 ` Tejun Heo 2016-06-16 11:17 ` [PATCH v9 09/12] kthread: Initial support for delayed kthread work Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-20 20:20 ` Tejun Heo 2016-06-20 20:20 ` Tejun Heo 2016-06-16 11:17 ` [PATCH v9 10/12] kthread: Allow to cancel " Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-20 20:27 ` Tejun Heo 2016-06-20 20:27 ` Tejun Heo 2016-06-16 11:17 ` [PATCH v9 11/12] kthread: Allow to modify delayed " Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-20 20:29 ` Tejun Heo 2016-06-20 20:29 ` Tejun Heo 2016-06-16 11:17 ` [PATCH v9 12/12] kthread: Better support freezable kthread workers Petr Mladek 2016-06-16 11:17 ` Petr Mladek 2016-06-20 20:30 ` Tejun Heo 2016-06-20 20:30 ` Tejun Heo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1466075851-24013-8-git-send-email-pmladek@suse.com \ --to=pmladek@suse.com \ --cc=akpm@linux-foundation.org \ --cc=bp@suse.de \ --cc=jkosina@suse.cz \ --cc=josh@joshtriplett.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.cz \ --cc=mingo@redhat.com \ --cc=oleg@redhat.com \ --cc=paulmck@linux.vnet.ibm.com \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ --cc=torvalds@linux-foundation.org \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.