All of lore.kernel.org
 help / color / mirror / Atom feed
From: js1304@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	mgorman@techsingularity.net, Minchan Kim <minchan@kernel.org>,
	Alexander Potapenko <glider@google.com>,
	Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Sasha Levin <sasha.levin@oracle.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: [PATCH v3 9/9] mm/page_isolation: clean up confused code
Date: Fri, 17 Jun 2016 16:57:39 +0900	[thread overview]
Message-ID: <1466150259-27727-10-git-send-email-iamjoonsoo.kim@lge.com> (raw)
In-Reply-To: <1466150259-27727-1-git-send-email-iamjoonsoo.kim@lge.com>

From: Joonsoo Kim <iamjoonsoo.kim@lge.com>

When there is an isolated_page, post_alloc_hook() is called with
page but __free_pages() is called with isolated_page. Since they are
the same so no problem but it's very confusing. To reduce it,
this patch changes isolated_page to boolean type and uses page variable
consistently.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 mm/page_isolation.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index 4639163..064b7fb 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -81,7 +81,7 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
 {
 	struct zone *zone;
 	unsigned long flags, nr_pages;
-	struct page *isolated_page = NULL;
+	bool isolated_page = false;
 	unsigned int order;
 	unsigned long page_idx, buddy_idx;
 	struct page *buddy;
@@ -109,7 +109,7 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
 			if (pfn_valid_within(page_to_pfn(buddy)) &&
 			    !is_migrate_isolate_page(buddy)) {
 				__isolate_free_page(page, order);
-				isolated_page = page;
+				isolated_page = true;
 			}
 		}
 	}
@@ -129,7 +129,7 @@ out:
 	spin_unlock_irqrestore(&zone->lock, flags);
 	if (isolated_page) {
 		post_alloc_hook(page, order, __GFP_MOVABLE);
-		__free_pages(isolated_page, order);
+		__free_pages(page, order);
 	}
 }
 
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: js1304@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	mgorman@techsingularity.net, Minchan Kim <minchan@kernel.org>,
	Alexander Potapenko <glider@google.com>,
	Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Sasha Levin <sasha.levin@oracle.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: [PATCH v3 9/9] mm/page_isolation: clean up confused code
Date: Fri, 17 Jun 2016 16:57:39 +0900	[thread overview]
Message-ID: <1466150259-27727-10-git-send-email-iamjoonsoo.kim@lge.com> (raw)
In-Reply-To: <1466150259-27727-1-git-send-email-iamjoonsoo.kim@lge.com>

From: Joonsoo Kim <iamjoonsoo.kim@lge.com>

When there is an isolated_page, post_alloc_hook() is called with
page but __free_pages() is called with isolated_page. Since they are
the same so no problem but it's very confusing. To reduce it,
this patch changes isolated_page to boolean type and uses page variable
consistently.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 mm/page_isolation.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index 4639163..064b7fb 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -81,7 +81,7 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
 {
 	struct zone *zone;
 	unsigned long flags, nr_pages;
-	struct page *isolated_page = NULL;
+	bool isolated_page = false;
 	unsigned int order;
 	unsigned long page_idx, buddy_idx;
 	struct page *buddy;
@@ -109,7 +109,7 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
 			if (pfn_valid_within(page_to_pfn(buddy)) &&
 			    !is_migrate_isolate_page(buddy)) {
 				__isolate_free_page(page, order);
-				isolated_page = page;
+				isolated_page = true;
 			}
 		}
 	}
@@ -129,7 +129,7 @@ out:
 	spin_unlock_irqrestore(&zone->lock, flags);
 	if (isolated_page) {
 		post_alloc_hook(page, order, __GFP_MOVABLE);
-		__free_pages(isolated_page, order);
+		__free_pages(page, order);
 	}
 }
 
-- 
1.9.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-06-17  7:58 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17  7:57 [PATCH v3 0/9] reduce memory usage by page_owner js1304
2016-06-17  7:57 ` js1304
2016-06-17  7:57 ` [PATCH v3 1/9] mm/compaction: split freepages without holding the zone lock js1304
2016-06-17  7:57   ` js1304
2016-06-17  7:57 ` [PATCH v3 2/9] mm/page_owner: initialize page owner " js1304
2016-06-17  7:57   ` js1304
2016-06-17  7:57 ` [PATCH v3 3/9] mm/page_owner: copy last_migrate_reason in copy_page_owner() js1304
2016-06-17  7:57   ` js1304
2016-06-17  7:57 ` [PATCH v3 4/9] mm/page_owner: introduce split_page_owner and replace manual handling js1304
2016-06-17  7:57   ` js1304
2016-06-17  7:57 ` [PATCH v3 5/9] tools/vm/page_owner: increase temporary buffer size js1304
2016-06-17  7:57   ` js1304
2016-06-17 12:56   ` Vlastimil Babka
2016-06-17 12:56     ` Vlastimil Babka
2016-06-17  7:57 ` [PATCH v3 6/9] mm/page_owner: use stackdepot to store stacktrace js1304
2016-06-17  7:57   ` js1304
2016-10-26 13:06   ` [v3,6/9] " Sascha Silbe
2016-10-27  0:17     ` Joonsoo Kim
2016-10-27  0:17       ` Joonsoo Kim
2016-12-22 23:37       ` Sascha Silbe
2016-06-17  7:57 ` [PATCH v3 7/9] mm/page_owner: avoid null pointer dereference js1304
2016-06-17  7:57   ` js1304
2016-06-17 13:32   ` Vlastimil Babka
2016-06-17 13:32     ` Vlastimil Babka
2016-06-24 20:19     ` Andrew Morton
2016-06-24 20:19       ` Andrew Morton
2016-06-17  7:57 ` [PATCH v3 8/9] mm/page_alloc: introduce post allocation processing on page allocator js1304
2016-06-17  7:57   ` js1304
2016-06-17  7:57 ` js1304 [this message]
2016-06-17  7:57   ` [PATCH v3 9/9] mm/page_isolation: clean up confused code js1304
2016-06-17 13:34   ` Vlastimil Babka
2016-06-17 13:34     ` Vlastimil Babka
2016-06-24 23:19 ` [PATCH v3 0/9] reduce memory usage by page_owner Andrew Morton
2016-06-24 23:19   ` Andrew Morton
2016-06-27  5:45   ` Joonsoo Kim
2016-06-27  5:45     ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466150259-27727-10-git-send-email-iamjoonsoo.kim@lge.com \
    --to=js1304@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=glider@google.com \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=minchan@kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.