All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Alias _obstack_free to fix binutils build
@ 2016-06-17  9:33 Dmitriy Falko
  2016-06-17 10:15 ` Burton, Ross
  0 siblings, 1 reply; 5+ messages in thread
From: Dmitriy Falko @ 2016-06-17  9:33 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Dmitriy Falko <d.falko@partner.samsung.com>
---
 libc/misc/gnu/obstack.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libc/misc/gnu/obstack.c b/libc/misc/gnu/obstack.c
index 38cfd83..2689263 100644
--- a/libc/misc/gnu/obstack.c
+++ b/libc/misc/gnu/obstack.c
@@ -385,11 +385,11 @@ obstack_free (struct obstack *h, void *obj)
     abort ();
 }
 
-# if 0
+
 /* Older versions of libc used a function _obstack_free intended to be
    called by non-GCC compilers.  */
 strong_alias (obstack_free, _obstack_free)
-# endif
+
 
 int
 _obstack_memory_used (struct obstack *h)
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] Alias _obstack_free to fix binutils build
  2016-06-17  9:33 [PATCH] Alias _obstack_free to fix binutils build Dmitriy Falko
@ 2016-06-17 10:15 ` Burton, Ross
  2016-06-17 10:22   ` Dmitrii Falko
  0 siblings, 1 reply; 5+ messages in thread
From: Burton, Ross @ 2016-06-17 10:15 UTC (permalink / raw)
  To: Dmitriy Falko; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

Hi Dmitry,

Can you re-send this as a patch against oe-core itself instead of
(presumably) binutils, explaining why it breaks for you and why this is the
correct fix?

Thanks,
Ross

On 17 June 2016 at 10:33, Dmitriy Falko <d.falko@partner.samsung.com> wrote:

> Signed-off-by: Dmitriy Falko <d.falko@partner.samsung.com>
> ---
>  libc/misc/gnu/obstack.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libc/misc/gnu/obstack.c b/libc/misc/gnu/obstack.c
> index 38cfd83..2689263 100644
> --- a/libc/misc/gnu/obstack.c
> +++ b/libc/misc/gnu/obstack.c
> @@ -385,11 +385,11 @@ obstack_free (struct obstack *h, void *obj)
>      abort ();
>  }
>
> -# if 0
> +
>  /* Older versions of libc used a function _obstack_free intended to be
>     called by non-GCC compilers.  */
>  strong_alias (obstack_free, _obstack_free)
> -# endif
> +
>
>  int
>  _obstack_memory_used (struct obstack *h)
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 1879 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Alias _obstack_free to fix binutils build
  2016-06-17 10:15 ` Burton, Ross
@ 2016-06-17 10:22   ` Dmitrii Falko
  0 siblings, 0 replies; 5+ messages in thread
From: Dmitrii Falko @ 2016-06-17 10:22 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]

Hi Ross,

I already re-send this patch(http://patches.openembedded.org/patch/125115/)

More info about this issue i wrote here: 
https://bugzilla.yoctoproject.org/show_bug.cgi?id=9781

17.06.2016 13:15, Burton, Ross пишет:
> Hi Dmitry,
>
> Can you re-send this as a patch against oe-core itself instead of 
> (presumably) binutils, explaining why it breaks for you and why this 
> is the correct fix?
>
> Thanks,
> Ross
>
> On 17 June 2016 at 10:33, Dmitriy Falko <d.falko@partner.samsung.com 
> <mailto:d.falko@partner.samsung.com>> wrote:
>
>     Signed-off-by: Dmitriy Falko <d.falko@partner.samsung.com
>     <mailto:d.falko@partner.samsung.com>>
>     ---
>      libc/misc/gnu/obstack.c | 4 ++--
>      1 file changed, 2 insertions(+), 2 deletions(-)
>
>     diff --git a/libc/misc/gnu/obstack.c b/libc/misc/gnu/obstack.c
>     index 38cfd83..2689263 100644
>     --- a/libc/misc/gnu/obstack.c
>     +++ b/libc/misc/gnu/obstack.c
>     @@ -385,11 +385,11 @@ obstack_free (struct obstack *h, void *obj)
>          abort ();
>      }
>
>     -# if 0
>     +
>      /* Older versions of libc used a function _obstack_free intended
>     to be
>         called by non-GCC compilers.  */
>      strong_alias (obstack_free, _obstack_free)
>     -# endif
>     +
>
>      int
>      _obstack_memory_used (struct obstack *h)
>     --
>     2.7.4
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

-- 
Best regards,

Falko Dmitrii

Leading Software Engineer

Samsung R&D Institute Rus

Tel. 8(495)797-2500 Ext. 3839; mob. +7(999)528-26-02


[-- Attachment #2: Type: text/html, Size: 3753 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Alias _obstack_free to fix binutils build
  2016-06-17 12:41 Dmitriy Falko
@ 2016-06-17 21:55 ` Khem Raj
  0 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2016-06-17 21:55 UTC (permalink / raw)
  To: Dmitriy Falko; +Cc: Patches and discussions about the oe-core layer

On Fri, Jun 17, 2016 at 5:41 AM, Dmitriy Falko
<d.falko@partner.samsung.com> wrote:
> Binutils as(sembler) trying to referency _obstack_free when building
> it for ARM uclibc(not cross compile version).
>
> Enables it(just alias to uclibc obstack_free) to fix build of binutils.

this is ok

>
> [YOCTO #9781]
>
> Signed-off-by: Dmitriy Falko <d.falko@partner.samsung.com>
> ---
>  meta/recipes-core/uclibc/uclibc-git.inc            |  1 +
>  ...Alias-_obstack_free-to-fix-binutils-build.patch | 31 ++++++++++++++++++++++
>  2 files changed, 32 insertions(+)
>  create mode 100644 meta/recipes-core/uclibc/uclibc-git/0001-Alias-_obstack_free-to-fix-binutils-build.patch
>
> diff --git a/meta/recipes-core/uclibc/uclibc-git.inc b/meta/recipes-core/uclibc/uclibc-git.inc
> index a56fa7c..ea1d37d 100644
> --- a/meta/recipes-core/uclibc/uclibc-git.inc
> +++ b/meta/recipes-core/uclibc/uclibc-git.inc
> @@ -6,6 +6,7 @@ FILESEXTRAPATHS =. "${FILE_DIRNAME}/uclibc-git:"
>
>  SRC_URI = "git://uclibc-ng.org/git/uclibc-ng \
>          file://0001-Disable-lrount_tes-function.patch \
> +        file://0001-Alias-_obstack_free-to-fix-binutils-build.patch \
>          file://uClibc.machine \
>          file://uClibc.distro \
>          file://obstack.cfg \
> diff --git a/meta/recipes-core/uclibc/uclibc-git/0001-Alias-_obstack_free-to-fix-binutils-build.patch b/meta/recipes-core/uclibc/uclibc-git/0001-Alias-_obstack_free-to-fix-binutils-build.patch
> new file mode 100644
> index 0000000..8f97ab8
> --- /dev/null
> +++ b/meta/recipes-core/uclibc/uclibc-git/0001-Alias-_obstack_free-to-fix-binutils-build.patch
> @@ -0,0 +1,31 @@
> +From f795fc77a2cf90ce77707faddc93a51f736a4553 Mon Sep 17 00:00:00 2001
> +From: Dmitriy Falko <d.falko@partner.samsung.com>
> +Date: Fri, 17 Jun 2016 11:31:02 +0300
> +Subject: [PATCH] Alias _obstack_free to fix binutils build
> +
> +Signed-off-by: Dmitriy Falko <d.falko@partner.samsung.com>
> +---
> + libc/misc/gnu/obstack.c | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/libc/misc/gnu/obstack.c b/libc/misc/gnu/obstack.c
> +index 38cfd83..2689263 100644
> +--- a/libc/misc/gnu/obstack.c
> ++++ b/libc/misc/gnu/obstack.c
> +@@ -385,11 +385,11 @@ obstack_free (struct obstack *h, void *obj)
> +     abort ();
> + }
> +
> +-# if 0
> ++
> + /* Older versions of libc used a function _obstack_free intended to be
> +    called by non-GCC compilers.  */
> + strong_alias (obstack_free, _obstack_free)
> +-# endif
> ++
> +
> + int
> + _obstack_memory_used (struct obstack *h)
> +--
> +2.7.4
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] Alias _obstack_free to fix binutils build
@ 2016-06-17 12:41 Dmitriy Falko
  2016-06-17 21:55 ` Khem Raj
  0 siblings, 1 reply; 5+ messages in thread
From: Dmitriy Falko @ 2016-06-17 12:41 UTC (permalink / raw)
  To: openembedded-core

Binutils as(sembler) trying to referency _obstack_free when building
it for ARM uclibc(not cross compile version).

Enables it(just alias to uclibc obstack_free) to fix build of binutils.

[YOCTO #9781]

Signed-off-by: Dmitriy Falko <d.falko@partner.samsung.com>
---
 meta/recipes-core/uclibc/uclibc-git.inc            |  1 +
 ...Alias-_obstack_free-to-fix-binutils-build.patch | 31 ++++++++++++++++++++++
 2 files changed, 32 insertions(+)
 create mode 100644 meta/recipes-core/uclibc/uclibc-git/0001-Alias-_obstack_free-to-fix-binutils-build.patch

diff --git a/meta/recipes-core/uclibc/uclibc-git.inc b/meta/recipes-core/uclibc/uclibc-git.inc
index a56fa7c..ea1d37d 100644
--- a/meta/recipes-core/uclibc/uclibc-git.inc
+++ b/meta/recipes-core/uclibc/uclibc-git.inc
@@ -6,6 +6,7 @@ FILESEXTRAPATHS =. "${FILE_DIRNAME}/uclibc-git:"
 
 SRC_URI = "git://uclibc-ng.org/git/uclibc-ng \
         file://0001-Disable-lrount_tes-function.patch \
+        file://0001-Alias-_obstack_free-to-fix-binutils-build.patch \
         file://uClibc.machine \
         file://uClibc.distro \
         file://obstack.cfg \
diff --git a/meta/recipes-core/uclibc/uclibc-git/0001-Alias-_obstack_free-to-fix-binutils-build.patch b/meta/recipes-core/uclibc/uclibc-git/0001-Alias-_obstack_free-to-fix-binutils-build.patch
new file mode 100644
index 0000000..8f97ab8
--- /dev/null
+++ b/meta/recipes-core/uclibc/uclibc-git/0001-Alias-_obstack_free-to-fix-binutils-build.patch
@@ -0,0 +1,31 @@
+From f795fc77a2cf90ce77707faddc93a51f736a4553 Mon Sep 17 00:00:00 2001
+From: Dmitriy Falko <d.falko@partner.samsung.com>
+Date: Fri, 17 Jun 2016 11:31:02 +0300
+Subject: [PATCH] Alias _obstack_free to fix binutils build
+
+Signed-off-by: Dmitriy Falko <d.falko@partner.samsung.com>
+---
+ libc/misc/gnu/obstack.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/libc/misc/gnu/obstack.c b/libc/misc/gnu/obstack.c
+index 38cfd83..2689263 100644
+--- a/libc/misc/gnu/obstack.c
++++ b/libc/misc/gnu/obstack.c
+@@ -385,11 +385,11 @@ obstack_free (struct obstack *h, void *obj)
+     abort ();
+ }
+
+-# if 0
++
+ /* Older versions of libc used a function _obstack_free intended to be
+    called by non-GCC compilers.  */
+ strong_alias (obstack_free, _obstack_free)
+-# endif
++
+
+ int
+ _obstack_memory_used (struct obstack *h)
+--
+2.7.4
+
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-17 21:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-17  9:33 [PATCH] Alias _obstack_free to fix binutils build Dmitriy Falko
2016-06-17 10:15 ` Burton, Ross
2016-06-17 10:22   ` Dmitrii Falko
2016-06-17 12:41 Dmitriy Falko
2016-06-17 21:55 ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.