All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table
@ 2016-06-17 14:52 Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH v2 02/10] multipath-tools: add INFINIDAT devices " Xose Vazquez Perez
                   ` (9 more replies)
  0 siblings, 10 replies; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 14:52 UTC (permalink / raw)
  Cc: device-mapper development, Xose Vazquez Perez

based on documentation provided by manufacturer:
https://drive.google.com/open?id=0B_B6YmEmO7cDQlMzc1BsaUxZRVU

- Red Hat Enterprise Linux 7.x for Violin 7300
vendor "VIOLIN"
product "CONCERTO ARRAY"
path_selector "round-robin 0"
path_grouping_policy multibus
prio alua
path_checker tur
rr_min_io 100
rr_weight priorities
failback immediate
features "1 queue_if_no_path"
no_path_retry 300

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 66b5123..726ee3b 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1176,6 +1176,22 @@ static struct hwentry default_hw[] = {
 		.checker_name  = TUR,
 	},
 	/*
+	 * Violin Memory, Inc.
+	 */
+	{
+		.vendor        = "VIOLIN",
+		.product       = "CONCERTO ARRAY",
+		.selector      = "round-robin 0",
+		.pgpolicy      = MULTIBUS,
+		.prio_name     = PRIO_ALUA,
+		.checker_name  = TUR,
+		.minio         = 100,
+		.rr_weight     = RR_WEIGHT_PRIO,
+		.pgfailback    = -FAILBACK_IMMEDIATE,
+		.features      = "1 queue_if_no_path",
+		.no_path_retry = 300,
+	},
+	/*
 	 * EOL
 	 */
 	{
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 02/10] multipath-tools: add INFINIDAT devices to hardware table
  2016-06-17 14:52 [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table Xose Vazquez Perez
@ 2016-06-17 14:52 ` Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH v2 03/10] multipath-tools: add TEGILE " Xose Vazquez Perez
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 14:52 UTC (permalink / raw)
  Cc: device-mapper development, Xose Vazquez Perez

based on documentation provided by the manufacturer:
https://support.infinidat.com/hc/en-us/articles/202319222

  vendor "NFINIDAT"             <----- This is not a bug, it's _NFINIDAT_
  product "InfiniBox.*"
  prio alua
  path_grouping_policy group_by_prio
  path_checker tur
  path_selector "round-robin 0"
  features "0"
  failback 30
  rr_weight priorities
  no_path_retry fail
  rr_min_io 1    # for kernels up to 2.6.31
  rr_min_io_rq 1 # for kernels 2.6.31 or newer
  flush_on_last_del yes
  fast_io_fail_tmo 5
  dev_loss_tmo 30

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 726ee3b..0ea7968 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1192,6 +1192,25 @@ static struct hwentry default_hw[] = {
 		.no_path_retry = 300,
 	},
 	/*
+	 * Infinidat, Inc.
+	 */
+	{
+		.vendor        = "NFINIDAT",
+		.product       = "InfiniBox.*",
+		.prio_name     = PRIO_ALUA,
+		.pgpolicy      = GROUP_BY_PRIO,
+		.checker_name  = TUR,
+		.selector      = "round-robin 0",
+		.features      = DEFAULT_FEATURES,
+		.pgfailback    = 30,
+		.rr_weight     = RR_WEIGHT_PRIO,
+		.no_path_retry = NO_PATH_RETRY_FAIL,
+		.minio_rq      = 1,
+		.flush_on_last_del = FLUSH_ENABLED,
+		.fast_io_fail  = 5,
+		.dev_loss      = 30,
+	},
+	/*
 	 * EOL
 	 */
 	{
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 03/10] multipath-tools: add TEGILE devices to hardware table
  2016-06-17 14:52 [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH v2 02/10] multipath-tools: add INFINIDAT devices " Xose Vazquez Perez
@ 2016-06-17 14:52 ` Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH 04/10] multipath-tools: remove current maintainer from orphan array families Xose Vazquez Perez
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 14:52 UTC (permalink / raw)
  Cc: device-mapper development, Xose Vazquez Perez

based on documentation provided by manufacturer:
http://pages.tegile.com/rs/568-BVY-995/images/Oracle%20BPG%201.0.pdf

vendor                  "TEGILE"
product                 "ZEBI-FC|INTELLIFLASH"
hardware_handler        "1 alua"
path_selector           "round- robin 0"
path_grouping_policy    "group_by_prio"
no_path_retry           10
dev_loss_tmo            50
path_checker            tur
prio                    alua
failback                30
rr_min_io               128

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 0ea7968..d882f31 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1211,6 +1211,22 @@ static struct hwentry default_hw[] = {
 		.dev_loss      = 30,
 	},
 	/*
+	 * Tegile Systems, Inc.
+	 */
+	{
+		.vendor        = "TEGILE",
+		.product       = "ZEBI-FC|INTELLIFLASH",
+		.hwhandler     = "1 alua",
+		.selector      = "round-robin 0",
+		.pgpolicy      = GROUP_BY_PRIO,
+		.no_path_retry = 10,
+		.dev_loss      = 50,
+		.checker_name  = TUR,
+		.prio_name     = PRIO_ALUA,
+		.pgfailback    = 30,
+		.minio         = 128,
+	},
+	/*
 	 * EOL
 	 */
 	{
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 04/10] multipath-tools: remove current maintainer from orphan array families.
  2016-06-17 14:52 [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH v2 02/10] multipath-tools: add INFINIDAT devices " Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH v2 03/10] multipath-tools: add TEGILE " Xose Vazquez Perez
@ 2016-06-17 14:52 ` Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH v2 05/10] multipath-tools: unreachable controllers maintainers Xose Vazquez Perez
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 14:52 UTC (permalink / raw)
  Cc: device-mapper development, Xose Vazquez Perez

Redundant.

Cc: Hannes Reinecke <hare@suse.de>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index d882f31..46aa9cd 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -57,9 +57,6 @@ static struct hwentry default_hw[] = {
 	},
 	/*
 	 * StorageWorks controller family
-	 *
-	 * Maintainer : Christophe Varoqui
-	 * Mail : christophe.varoqui@opensvc.com
 	 */
 	{
 		.vendor        = "3PARdata",
@@ -238,9 +235,6 @@ static struct hwentry default_hw[] = {
 	},
 	/*
 	 * DDN controller family
-	 *
-	 * Maintainer : Christophe Varoqui
-	 * Mail : christophe.varoqui@opensvc.com
 	 */
 	{
 		.vendor        = "DDN",
@@ -319,9 +313,6 @@ static struct hwentry default_hw[] = {
 	},
 	/*
 	 * Fujitsu controller family
-	 *
-	 * Maintainer : Christophe Varoqui
-	 * Mail : christophe.varoqui@opensvc.com
 	 */
 	{
 		.vendor        = "FSC",
@@ -874,9 +865,6 @@ static struct hwentry default_hw[] = {
 
 	/*
 	 * SGI arrays
-	 *
-	 * Maintainer : Christophe Varoqui
-	 * Mail : christophe.varoqui@opensvc.com
 	 */
 	{
 		.vendor        = "SGI",
@@ -935,9 +923,6 @@ static struct hwentry default_hw[] = {
 	},
 	/*
 	 * STK arrays
-	 *
-	 * Maintainer : Christophe Varoqui
-	 * Mail : christophe.varoqui@opensvc.com
 	 */
 	{
 		.vendor        = "STK",
@@ -955,9 +940,6 @@ static struct hwentry default_hw[] = {
 	},
 	/*
 	 * SUN arrays
-	 *
-	 * Maintainer : Christophe Varoqui
-	 * Mail : christophe.varoqui@opensvc.com
 	 */
 	{
 		.vendor        = "SUN",
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v2 05/10] multipath-tools: unreachable controllers maintainers
  2016-06-17 14:52 [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table Xose Vazquez Perez
                   ` (2 preceding siblings ...)
  2016-06-17 14:52 ` [PATCH 04/10] multipath-tools: remove current maintainer from orphan array families Xose Vazquez Perez
@ 2016-06-17 14:52 ` Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH 06/10] multipath-tools: new email address for Srinivas Ramani Xose Vazquez Perez
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 14:52 UTC (permalink / raw)
  Cc: device-mapper development, Xose Vazquez Perez

Delete 3 unreachable controllers maintainers, their emails are bounced.

Compellent Technologies, Inc.: Jim Lester <jim.lester@compellent.com>
NETAPP controller family: Dave Wysochanski <davidw@netapp.com>
IBM NSeries (NETAPP) controller family: Dave Wysochanski <davidw@netapp.com>

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 46aa9cd..54d5320 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -19,9 +19,6 @@
 static struct hwentry default_hw[] = {
 	/*
 	 * Compellent Technologies, Inc.
-	 *
-	 * Maintainer : Jim Lester, Compellent
-	 * Mail : jim.lester@compellent.com
 	 */
 	{
 		.vendor        = "COMPELNT",
@@ -780,9 +777,6 @@ static struct hwentry default_hw[] = {
 	},
 	/*
 	 * NETAPP controller family
-	 *
-	 * Maintainer : Dave Wysochanski
-	 * Mail : davidw@netapp.com
 	 */
 	{
 		.vendor        = "NETAPP",
@@ -825,9 +819,6 @@ static struct hwentry default_hw[] = {
 	},
 	/*
 	 * IBM NSeries (NETAPP) controller family
-	 *
-	 * Maintainer : Dave Wysochanski
-	 * Mail : davidw@netapp.com
 	 */
 	{
 		.vendor        = "IBM",
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 06/10] multipath-tools: new email address for Srinivas Ramani
  2016-06-17 14:52 [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table Xose Vazquez Perez
                   ` (3 preceding siblings ...)
  2016-06-17 14:52 ` [PATCH v2 05/10] multipath-tools: unreachable controllers maintainers Xose Vazquez Perez
@ 2016-06-17 14:52 ` Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH 08/10] multipath-tools: remove USER_FRIENDLY_NAMES_OFF Xose Vazquez Perez
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 14:52 UTC (permalink / raw)
  Cc: Srinivas Ramani, Xose Vazquez Perez, device-mapper development

*This one needs a mandatory ACK from Srinivas Ramani*
Otherwise it must be removed.

Cc: Srinivas Ramani <srinivas.ramani@oracle.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 54d5320..25c77e3 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -838,7 +838,7 @@ static struct hwentry default_hw[] = {
 	 * Pillar Data controller family
 	 *
 	 * Maintainer : Srinivasan Ramani
-	 * Mail : sramani@pillardata.com
+	 * Mail : srinivas.ramani@oracle.com
 	 */
 	{
 		.vendor        = "Pillar",
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 08/10] multipath-tools: remove USER_FRIENDLY_NAMES_OFF
  2016-06-17 14:52 [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table Xose Vazquez Perez
                   ` (4 preceding siblings ...)
  2016-06-17 14:52 ` [PATCH 06/10] multipath-tools: new email address for Srinivas Ramani Xose Vazquez Perez
@ 2016-06-17 14:52 ` Xose Vazquez Perez
  2016-06-20  6:58   ` Christophe Varoqui
  2016-06-17 14:52 ` [PATCH 09/10] multipath-tools: clean up comments at hwtable.c Xose Vazquez Perez
                   ` (3 subsequent siblings)
  9 siblings, 1 reply; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 14:52 UTC (permalink / raw)
  Cc: device-mapper development, Xose Vazquez Perez

This is up to sysadmins, and it is already off by default.

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 598b9b8..bef8d31 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -794,7 +794,6 @@ static struct hwentry default_hw[] = {
 		.prio_name     = PRIO_ONTAP,
 		.prio_args     = NULL,
 		.retain_hwhandler = RETAIN_HWHANDLER_ON,
-		.user_friendly_names = USER_FRIENDLY_NAMES_OFF,
 		.detect_prio   = DETECT_PRIO_ON,
 	},
 	/*
@@ -1133,7 +1132,6 @@ static struct hwentry default_hw[] = {
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.checker_name  = TUR,
 		.fast_io_fail  = 10,
-		.user_friendly_names = USER_FRIENDLY_NAMES_OFF,
 		.prio_name     = DEFAULT_PRIO,
 		.no_path_retry = 0,
 		.dev_loss      = 60,
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 09/10] multipath-tools: clean up comments at hwtable.c
  2016-06-17 14:52 [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table Xose Vazquez Perez
                   ` (5 preceding siblings ...)
  2016-06-17 14:52 ` [PATCH 08/10] multipath-tools: remove USER_FRIENDLY_NAMES_OFF Xose Vazquez Perez
@ 2016-06-17 14:52 ` Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH 10/10] multipath-tools: group ONTAP family Xose Vazquez Perez
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 14:52 UTC (permalink / raw)
  Cc: device-mapper development, Xose Vazquez Perez

Remove redundant info and update company names.

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 67 ++++++++++++++++++++++++++++----------------------
 1 file changed, 37 insertions(+), 30 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index bef8d31..fbfa917 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -18,7 +18,7 @@
  */
 static struct hwentry default_hw[] = {
 	/*
-	 * Compellent Technologies, Inc.
+	 * Compellent Technologies/DELL
 	 */
 	{
 		.vendor        = "COMPELNT",
@@ -34,7 +34,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * Apple controller family
+	 * Apple
 	 *
 	 * Maintainer : Shyam Sundar
 	 * Mail : g.shyamsundar@yahoo.co.in
@@ -53,7 +53,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * StorageWorks controller family
+	 * StorageWorks/HPE
 	 */
 	{
 		.vendor        = "3PARdata",
@@ -140,7 +140,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	{
-		/* HP MSA2000 product family with old firmware */
+		/* HP MSA2000 family with old firmware */
 		.vendor        = "HP",
 		.product       = "MSA2[02]12fc|MSA2012i",
 		.features      = DEFAULT_FEATURES,
@@ -155,7 +155,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	{
-		/* HP MSA2000 product family with new firmware */
+		/* HP MSA2000 family with new firmware */
 		.vendor        = "HP",
 		.product       = "MSA2012sa|MSA23(12|24)(fc|i|sa)|MSA2000s VOLUME",
 		.features      = DEFAULT_FEATURES,
@@ -170,7 +170,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	{
-		/* HP MSA 1040/2040 product family */
+		/* HP MSA 1040/2040 family */
 		.vendor        = "HP",
 		.product       = "MSA (1|2)040 SA(N|S)",
 		.features      = DEFAULT_FEATURES,
@@ -216,7 +216,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	{
-		/* HP P2000 family arrays */
+		/* HP P2000 family */
 		.vendor        = "HP",
 		.product       = "P2000 G3 FC|P2000G3 FC/iSCSI|P2000 G3 SAS|P2000 G3 iSCSI",
 		.features      = DEFAULT_FEATURES,
@@ -231,7 +231,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * DDN controller family
+	 * DDN
 	 */
 	{
 		.vendor        = "DDN",
@@ -247,7 +247,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * EMC / Clariion controller family
+	 * EMC/DELL
 	 *
 	 * Maintainer : Edward Goggin, EMC
 	 * Mail : egoggin@emc.com
@@ -266,6 +266,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	{
+		/* DGC CLARiiON CX/AX and EMC VNX */
 		.vendor        = "DGC",
 		.product       = ".*",
 		.bl_product    = "LUNZ",
@@ -309,7 +310,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * Fujitsu controller family
+	 * Fujitsu
 	 */
 	{
 		.vendor        = "FSC",
@@ -338,7 +339,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * Hitachi controller family
+	 * Hitachi
 	 *
 	 * Maintainer : Matthias Rudolph
 	 * Mail : matthias.rudolph@hds.com
@@ -370,7 +371,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * IBM controller family
+	 * IBM
 	 *
 	 * Maintainer : Hannes Reinecke, SuSE
 	 * Mail : hare@suse.de
@@ -463,7 +464,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	{
-	    /* IBM DS4700 */
+		/* IBM DS4700 */
 		.vendor        = "IBM",
 		.product       = "^1814",
 		.bl_product    = "Universal Xport",
@@ -478,7 +479,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	{
-	    /* IBM DS4800 */
+		/* IBM DS4800 */
 		.vendor        = "IBM",
 		.product       = "^1815",
 		.bl_product    = "Universal Xport",
@@ -493,7 +494,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	{
-	    /* IBM DS5000 */
+		/* IBM DS5000 */
 		.vendor        = "IBM",
 		.product       = "^1818",
 		.bl_product    = "Universal Xport",
@@ -668,7 +669,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	{
-	    /* IBM XIV Storage System */
+		/* IBM XIV Storage System */
 		.vendor        = "IBM",
 		.product       = "2810XIV",
 		.features      = "1 queue_if_no_path",
@@ -703,7 +704,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	{
-		/* IBM 3303      NVDISK */
+		/* IBM 3303 NVDISK */
 		.vendor        = "IBM",
 		.product       = "3303      NVDISK",
 		.features      = DEFAULT_FEATURES,
@@ -730,6 +731,9 @@ static struct hwentry default_hw[] = {
 		.prio_name     = PRIO_ALUA,
 		.prio_args     = NULL,
 	},
+	/*
+	 * DELL
+	 */
 	{
 		/* DELL MD3000/MD3000i */
 		.vendor        = "DELL",
@@ -776,7 +780,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * NETAPP controller family
+	 * NETAPP
 	 */
 	{
 		.vendor        = "NETAPP",
@@ -797,7 +801,7 @@ static struct hwentry default_hw[] = {
 		.detect_prio   = DETECT_PRIO_ON,
 	},
 	/*
-	 * NEXENTA/COMSTAR controller family
+	 * NEXENTA
 	 *
 	 * Maintainer : Yacine Kheddache
 	 * Mail : yacine@alyseo.com
@@ -817,7 +821,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * IBM NSeries (NETAPP) controller family
+	 * IBM NSeries (NETAPP)
 	 */
 	{
 		.vendor        = "IBM",
@@ -834,7 +838,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * Pillar Data controller family
+	 * Pillar Data/Oracle
 	 *
 	 * Maintainer : Srinivasan Ramani
 	 * Mail : srinivas.ramani@oracle.com
@@ -854,7 +858,7 @@ static struct hwentry default_hw[] = {
 	},
 
 	/*
-	 * SGI arrays
+	 * SGI
 	 */
 	{
 		.vendor        = "SGI",
@@ -897,8 +901,11 @@ static struct hwentry default_hw[] = {
 		.prio_name     = PRIO_RDAC,
 		.prio_args     = NULL,
 	},
-	/* NEC Storage M Series */
+	/*
+	 * NEC
+	 */
 	{
+		/* Storage M Series */
 		.vendor        = "NEC",
 		.product       = "DISK ARRAY",
 		.features      = DEFAULT_FEATURES,
@@ -912,7 +919,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * STK arrays
+	 * STK/Oracle
 	 */
 	{
 		.vendor        = "STK",
@@ -929,7 +936,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * SUN arrays
+	 * SUN/Oracle
 	 */
 	{
 		.vendor        = "SUN",
@@ -971,7 +978,7 @@ static struct hwentry default_hw[] = {
 		.prio_args     = NULL,
 	},
 	/*
-	 * Pivot3 RAIGE
+	 * Pivot3
 	 *
 	 * Maintainer : Bart Brooks, Pivot3
 	 * Mail : bartb@pivot3.com
@@ -1034,7 +1041,7 @@ static struct hwentry default_hw[] = {
 		.checker_name  = RDAC,
 		.prio_name     = PRIO_RDAC,
 	},
-	/* LSI/Engenio/NetApp E-Series RDAC storage
+	/* LSI/Engenio/NetApp RDAC
 	 *
 	 * Maintainer : Sean Stewart
 	 * Mail : sean.stewart@netapp.com
@@ -1147,7 +1154,7 @@ static struct hwentry default_hw[] = {
 		.checker_name  = TUR,
 	},
 	/*
-	 * Violin Memory, Inc.
+	 * Violin Memory
 	 */
 	{
 		.vendor        = "VIOLIN",
@@ -1163,7 +1170,7 @@ static struct hwentry default_hw[] = {
 		.no_path_retry = 300,
 	},
 	/*
-	 * Infinidat, Inc.
+	 * Infinidat
 	 */
 	{
 		.vendor        = "NFINIDAT",
@@ -1182,7 +1189,7 @@ static struct hwentry default_hw[] = {
 		.dev_loss      = 30,
 	},
 	/*
-	 * Tegile Systems, Inc.
+	 * Tegile Systems
 	 */
 	{
 		.vendor        = "TEGILE",
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 10/10] multipath-tools: group ONTAP family
  2016-06-17 14:52 [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table Xose Vazquez Perez
                   ` (6 preceding siblings ...)
  2016-06-17 14:52 ` [PATCH 09/10] multipath-tools: clean up comments at hwtable.c Xose Vazquez Perez
@ 2016-06-17 14:52 ` Xose Vazquez Perez
  2016-06-17 14:52 ` [PATCH] multipath-tools: RDAC border Xose Vazquez Perez
       [not found] ` <1466175169-16684-7-git-send-email-xose.vazquez@gmail.com>
  9 siblings, 0 replies; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 14:52 UTC (permalink / raw)
  Cc: device-mapper development, Xose Vazquez Perez

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 32 +++++++++++++++-----------------
 1 file changed, 15 insertions(+), 17 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index fbfa917..b67568f 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -800,41 +800,39 @@ static struct hwentry default_hw[] = {
 		.retain_hwhandler = RETAIN_HWHANDLER_ON,
 		.detect_prio   = DETECT_PRIO_ON,
 	},
-	/*
-	 * NEXENTA
-	 *
-	 * Maintainer : Yacine Kheddache
-	 * Mail : yacine@alyseo.com
-	 */
 	{
-		.vendor        = "NEXENTA",
-		.product       = "COMSTAR",
+		/* IBM NSeries(NETAPP) */
+		.vendor        = "IBM",
+		.product       = "Nseries.*",
 		.features      = "1 queue_if_no_path",
 		.hwhandler     = DEFAULT_HWHANDLER,
-		.pgpolicy      = GROUP_BY_SERIAL,
+		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.rr_weight     = RR_WEIGHT_NONE,
-		.no_path_retry = 30,
+		.no_path_retry = NO_PATH_RETRY_UNDEF,
 		.minio         = 128,
 		.checker_name  = DIRECTIO,
-		.prio_name     = DEFAULT_PRIO,
+		.prio_name     = PRIO_ONTAP,
 		.prio_args     = NULL,
 	},
 	/*
-	 * IBM NSeries (NETAPP)
+	 * NEXENTA
+	 *
+	 * Maintainer : Yacine Kheddache
+	 * Mail : yacine@alyseo.com
 	 */
 	{
-		.vendor        = "IBM",
-		.product       = "Nseries.*",
+		.vendor        = "NEXENTA",
+		.product       = "COMSTAR",
 		.features      = "1 queue_if_no_path",
 		.hwhandler     = DEFAULT_HWHANDLER,
-		.pgpolicy      = GROUP_BY_PRIO,
+		.pgpolicy      = GROUP_BY_SERIAL,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.rr_weight     = RR_WEIGHT_NONE,
-		.no_path_retry = NO_PATH_RETRY_UNDEF,
+		.no_path_retry = 30,
 		.minio         = 128,
 		.checker_name  = DIRECTIO,
-		.prio_name     = PRIO_ONTAP,
+		.prio_name     = DEFAULT_PRIO,
 		.prio_args     = NULL,
 	},
 	/*
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH] multipath-tools: RDAC border
  2016-06-17 14:52 [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table Xose Vazquez Perez
                   ` (7 preceding siblings ...)
  2016-06-17 14:52 ` [PATCH 10/10] multipath-tools: group ONTAP family Xose Vazquez Perez
@ 2016-06-17 14:52 ` Xose Vazquez Perez
       [not found] ` <1466175169-16684-7-git-send-email-xose.vazquez@gmail.com>
  9 siblings, 0 replies; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 14:52 UTC (permalink / raw)
  Cc: Xose Vazquez Perez, device-mapper development

Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>

---
There are 21 disorganized RDAC devices.

What do you prefer?

Order by original manufacturer, current manufacturer or
by real controllers families. Or a mixed combination.

???
---
 libmultipath/hwtable.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index b67568f..ae562c6 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1074,6 +1074,7 @@ static struct hwentry default_hw[] = {
 		.prio_name     = PRIO_RDAC,
 		.prio_args     = NULL,
 	},
+	/* RDAC ends here */
 	{
 		.vendor	       = "Intel",
 		.product       = "Multi-Flex",
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH 07/10] multipath-tools: dm-devel list is only for subscribers
       [not found] ` <1466175169-16684-7-git-send-email-xose.vazquez@gmail.com>
@ 2016-06-17 15:15   ` Xose Vazquez Perez
  0 siblings, 0 replies; 14+ messages in thread
From: Xose Vazquez Perez @ 2016-06-17 15:15 UTC (permalink / raw)
  Cc: device-mapper development

This mail was eaten by the SPAM filter again,try #2.

On 06/17/2016 04:52 PM, Xose Vazquez Perez wrote:
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/hwtable.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 25c77e3..598b9b8 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -10,7 +10,7 @@
>  
>  /*
>   * Tuning suggestions on these parameters should go to
> - * dm-devel @ redhat.com
> + * dm-devel @ redhat.com (subscribers-only, see README)
>   * 
>   * You are welcome to claim maintainership over a controller
>   * family. Please mail the currently enlisted maintainer and
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 08/10] multipath-tools: remove USER_FRIENDLY_NAMES_OFF
  2016-06-17 14:52 ` [PATCH 08/10] multipath-tools: remove USER_FRIENDLY_NAMES_OFF Xose Vazquez Perez
@ 2016-06-20  6:58   ` Christophe Varoqui
  2016-06-20  7:07     ` Hannes Reinecke
  0 siblings, 1 reply; 14+ messages in thread
From: Christophe Varoqui @ 2016-06-20  6:58 UTC (permalink / raw)
  To: Xose Vazquez Perez; +Cc: device-mapper development


[-- Attachment #1.1: Type: text/plain, Size: 1460 bytes --]

I tend to agree with Xose this is unfair to set user_friendly_name in the
hwtable entries.
Does anybody have a vote against my merging this patch ?

On Fri, Jun 17, 2016 at 4:52 PM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:

> This is up to sysadmins, and it is already off by default.
>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/hwtable.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 598b9b8..bef8d31 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -794,7 +794,6 @@ static struct hwentry default_hw[] = {
>                 .prio_name     = PRIO_ONTAP,
>                 .prio_args     = NULL,
>                 .retain_hwhandler = RETAIN_HWHANDLER_ON,
> -               .user_friendly_names = USER_FRIENDLY_NAMES_OFF,
>                 .detect_prio   = DETECT_PRIO_ON,
>         },
>         /*
> @@ -1133,7 +1132,6 @@ static struct hwentry default_hw[] = {
>                 .pgfailback    = -FAILBACK_IMMEDIATE,
>                 .checker_name  = TUR,
>                 .fast_io_fail  = 10,
> -               .user_friendly_names = USER_FRIENDLY_NAMES_OFF,
>                 .prio_name     = DEFAULT_PRIO,
>                 .no_path_retry = 0,
>                 .dev_loss      = 60,
> --
> 2.5.5
>
>

[-- Attachment #1.2: Type: text/html, Size: 2200 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 08/10] multipath-tools: remove USER_FRIENDLY_NAMES_OFF
  2016-06-20  6:58   ` Christophe Varoqui
@ 2016-06-20  7:07     ` Hannes Reinecke
  2016-06-20 10:42       ` Bryn M. Reeves
  0 siblings, 1 reply; 14+ messages in thread
From: Hannes Reinecke @ 2016-06-20  7:07 UTC (permalink / raw)
  To: dm-devel

On 06/20/2016 08:58 AM, Christophe Varoqui wrote:
> I tend to agree with Xose this is unfair to set user_friendly_name in
> the hwtable entries.
> Does anybody have a vote against my merging this patch ?
> 
> On Fri, Jun 17, 2016 at 4:52 PM, Xose Vazquez Perez
> <xose.vazquez@gmail.com <mailto:xose.vazquez@gmail.com>> wrote:
> 
>     This is up to sysadmins, and it is already off by default.
> 
>     Cc: Christophe Varoqui <christophe.varoqui@opensvc.com
>     <mailto:christophe.varoqui@opensvc.com>>
>     Cc: device-mapper development <dm-devel@redhat.com
>     <mailto:dm-devel@redhat.com>>
>     Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com
>     <mailto:xose.vazquez@gmail.com>>
>     ---
>      libmultipath/hwtable.c | 2 --
>      1 file changed, 2 deletions(-)
> 
>     diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
>     index 598b9b8..bef8d31 100644
>     --- a/libmultipath/hwtable.c
>     +++ b/libmultipath/hwtable.c
>     @@ -794,7 +794,6 @@ static struct hwentry default_hw[] = {
>                     .prio_name     = PRIO_ONTAP,
>                     .prio_args     = NULL,
>                     .retain_hwhandler = RETAIN_HWHANDLER_ON,
>     -               .user_friendly_names = USER_FRIENDLY_NAMES_OFF,
>                     .detect_prio   = DETECT_PRIO_ON,
>             },
>             /*
>     @@ -1133,7 +1132,6 @@ static struct hwentry default_hw[] = {
>                     .pgfailback    = -FAILBACK_IMMEDIATE,
>                     .checker_name  = TUR,
>                     .fast_io_fail  = 10,
>     -               .user_friendly_names = USER_FRIENDLY_NAMES_OFF,
>                     .prio_name     = DEFAULT_PRIO,
>                     .no_path_retry = 0,

No, indeed, that's fine.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 08/10] multipath-tools: remove USER_FRIENDLY_NAMES_OFF
  2016-06-20  7:07     ` Hannes Reinecke
@ 2016-06-20 10:42       ` Bryn M. Reeves
  0 siblings, 0 replies; 14+ messages in thread
From: Bryn M. Reeves @ 2016-06-20 10:42 UTC (permalink / raw)
  To: Hannes Reinecke; +Cc: dm-devel

On Mon, Jun 20, 2016 at 09:07:26AM +0200, Hannes Reinecke wrote:
> On 06/20/2016 08:58 AM, Christophe Varoqui wrote:
> >     @@ -1133,7 +1132,6 @@ static struct hwentry default_hw[] = {
> >                     .pgfailback    = -FAILBACK_IMMEDIATE,
> >                     .checker_name  = TUR,
> >                     .fast_io_fail  = 10,
> >     -               .user_friendly_names = USER_FRIENDLY_NAMES_OFF,
> >                     .prio_name     = DEFAULT_PRIO,
> >                     .no_path_retry = 0,
> 
> No, indeed, that's fine.

Agreed: multipath names are mysterious enough for many users without
compiled-in defaults changing things behind their backs.

Regards,
Bryn.
 

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2016-06-20 10:42 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-17 14:52 [PATCH v2 01/10] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table Xose Vazquez Perez
2016-06-17 14:52 ` [PATCH v2 02/10] multipath-tools: add INFINIDAT devices " Xose Vazquez Perez
2016-06-17 14:52 ` [PATCH v2 03/10] multipath-tools: add TEGILE " Xose Vazquez Perez
2016-06-17 14:52 ` [PATCH 04/10] multipath-tools: remove current maintainer from orphan array families Xose Vazquez Perez
2016-06-17 14:52 ` [PATCH v2 05/10] multipath-tools: unreachable controllers maintainers Xose Vazquez Perez
2016-06-17 14:52 ` [PATCH 06/10] multipath-tools: new email address for Srinivas Ramani Xose Vazquez Perez
2016-06-17 14:52 ` [PATCH 08/10] multipath-tools: remove USER_FRIENDLY_NAMES_OFF Xose Vazquez Perez
2016-06-20  6:58   ` Christophe Varoqui
2016-06-20  7:07     ` Hannes Reinecke
2016-06-20 10:42       ` Bryn M. Reeves
2016-06-17 14:52 ` [PATCH 09/10] multipath-tools: clean up comments at hwtable.c Xose Vazquez Perez
2016-06-17 14:52 ` [PATCH 10/10] multipath-tools: group ONTAP family Xose Vazquez Perez
2016-06-17 14:52 ` [PATCH] multipath-tools: RDAC border Xose Vazquez Perez
     [not found] ` <1466175169-16684-7-git-send-email-xose.vazquez@gmail.com>
2016-06-17 15:15   ` [PATCH 07/10] multipath-tools: dm-devel list is only for subscribers Xose Vazquez Perez

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.