* [PATCH] [NEXT] gpiolib: make lineevent_irq_thread static
@ 2016-06-17 15:03 Ben Dooks
2016-06-18 9:05 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-17 15:03 UTC (permalink / raw)
To: linux-kernel; +Cc: Ben Dooks, linux-gpio, Linus Walleij, Alexandre Courbot
The lineevent_irq_thread is not exported, so make it static
to fix the following warning:
drivers/gpio/gpiolib.c:654:13: warning: symbol 'lineevent_irq_thread' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: linux-gpio@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 8b3db59..7f32fc8 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -651,7 +651,7 @@ static const struct file_operations lineevent_fileops = {
#endif
};
-irqreturn_t lineevent_irq_thread(int irq, void *p)
+static irqreturn_t lineevent_irq_thread(int irq, void *p)
{
struct lineevent_state *le = p;
struct gpioevent_data ge;
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [NEXT] gpiolib: make lineevent_irq_thread static
2016-06-17 15:03 [PATCH] [NEXT] gpiolib: make lineevent_irq_thread static Ben Dooks
@ 2016-06-18 9:05 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-06-18 9:05 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, linux-gpio, Alexandre Courbot
On Fri, Jun 17, 2016 at 5:03 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The lineevent_irq_thread is not exported, so make it static
> to fix the following warning:
>
> drivers/gpio/gpiolib.c:654:13: warning: symbol 'lineevent_irq_thread' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: linux-gpio@vger.kernel.org
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
Patch applied, thanks a lot Ben, awesome!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-18 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-17 15:03 [PATCH] [NEXT] gpiolib: make lineevent_irq_thread static Ben Dooks
2016-06-18 9:05 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.