* [PATCH] ASoC: cs53l30: Set idle_bias_off true
@ 2016-06-18 1:31 Nicolin Chen
2016-06-20 15:35 ` Handrigan, Paul
2016-06-21 18:52 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Nicolin Chen @ 2016-06-18 1:31 UTC (permalink / raw)
To: broonie; +Cc: lgirdwood, brian.austin, Paul.Handrigan, linux-kernel, alsa-devel
The driver is using the set_bias_level to control the power on and
off so it should get SND_SOC_BIAS_OFF in order to proceed normal
powering sequences. This patch enables the idle_bias_off option so
the DAPM core will set the bias level to SND_SOC_BIAS_OFF instead
of stopping at SND_SOC_BIAS_STANDBY.
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
---
sound/soc/codecs/cs53l30.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index a5976f3..b0a64a1 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -879,6 +879,7 @@ static int cs53l30_codec_probe(struct snd_soc_codec *codec)
static struct snd_soc_codec_driver cs53l30_driver = {
.probe = cs53l30_codec_probe,
.set_bias_level = cs53l30_set_bias_level,
+ .idle_bias_off = true,
.dapm_widgets = cs53l30_dapm_widgets,
.num_dapm_widgets = ARRAY_SIZE(cs53l30_dapm_widgets),
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: cs53l30: Set idle_bias_off true
2016-06-18 1:31 [PATCH] ASoC: cs53l30: Set idle_bias_off true Nicolin Chen
@ 2016-06-20 15:35 ` Handrigan, Paul
2016-06-21 18:52 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Handrigan, Paul @ 2016-06-20 15:35 UTC (permalink / raw)
To: Nicolin Chen, broonie; +Cc: lgirdwood, Austin, Brian, linux-kernel, alsa-devel
On 6/17/16, 8:31 PM, "Nicolin Chen" <nicoleotsuka@gmail.com> wrote:
>The driver is using the set_bias_level to control the power on and
>off so it should get SND_SOC_BIAS_OFF in order to proceed normal
>powering sequences. This patch enables the idle_bias_off option so
>the DAPM core will set the bias level to SND_SOC_BIAS_OFF instead
>of stopping at SND_SOC_BIAS_STANDBY.
>
>Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
>---
> sound/soc/codecs/cs53l30.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
>index a5976f3..b0a64a1 100644
>--- a/sound/soc/codecs/cs53l30.c
>+++ b/sound/soc/codecs/cs53l30.c
>@@ -879,6 +879,7 @@ static int cs53l30_codec_probe(struct snd_soc_codec
>*codec)
> static struct snd_soc_codec_driver cs53l30_driver = {
> .probe = cs53l30_codec_probe,
> .set_bias_level = cs53l30_set_bias_level,
>+ .idle_bias_off = true,
>
> .dapm_widgets = cs53l30_dapm_widgets,
> .num_dapm_widgets = ARRAY_SIZE(cs53l30_dapm_widgets),
>--
>2.1.4
Thanks!
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: cs53l30: Set idle_bias_off true
@ 2016-06-20 15:35 ` Handrigan, Paul
0 siblings, 0 replies; 5+ messages in thread
From: Handrigan, Paul @ 2016-06-20 15:35 UTC (permalink / raw)
To: Nicolin Chen, broonie; +Cc: Austin, Brian, lgirdwood, alsa-devel, linux-kernel
On 6/17/16, 8:31 PM, "Nicolin Chen" <nicoleotsuka@gmail.com> wrote:
>The driver is using the set_bias_level to control the power on and
>off so it should get SND_SOC_BIAS_OFF in order to proceed normal
>powering sequences. This patch enables the idle_bias_off option so
>the DAPM core will set the bias level to SND_SOC_BIAS_OFF instead
>of stopping at SND_SOC_BIAS_STANDBY.
>
>Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
>---
> sound/soc/codecs/cs53l30.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
>index a5976f3..b0a64a1 100644
>--- a/sound/soc/codecs/cs53l30.c
>+++ b/sound/soc/codecs/cs53l30.c
>@@ -879,6 +879,7 @@ static int cs53l30_codec_probe(struct snd_soc_codec
>*codec)
> static struct snd_soc_codec_driver cs53l30_driver = {
> .probe = cs53l30_codec_probe,
> .set_bias_level = cs53l30_set_bias_level,
>+ .idle_bias_off = true,
>
> .dapm_widgets = cs53l30_dapm_widgets,
> .num_dapm_widgets = ARRAY_SIZE(cs53l30_dapm_widgets),
>--
>2.1.4
Thanks!
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Applied "ASoC: cs53l30: Set idle_bias_off true" to the asoc tree
2016-06-18 1:31 [PATCH] ASoC: cs53l30: Set idle_bias_off true Nicolin Chen
@ 2016-06-21 18:52 ` Mark Brown
2016-06-21 18:52 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2016-06-21 18:52 UTC (permalink / raw)
To: Nicolin Chen
Cc: Mark Brown, broonie, brian.austin, alsa-devel, lgirdwood,
Paul.Handrigan, linux-kernel
The patch
ASoC: cs53l30: Set idle_bias_off true
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From b0e71c0ddda4e1540b38658cac705222a648c756 Mon Sep 17 00:00:00 2001
From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: Fri, 17 Jun 2016 18:31:57 -0700
Subject: [PATCH] ASoC: cs53l30: Set idle_bias_off true
The driver is using the set_bias_level to control the power on and
off so it should get SND_SOC_BIAS_OFF in order to proceed normal
powering sequences. This patch enables the idle_bias_off option so
the DAPM core will set the bias level to SND_SOC_BIAS_OFF instead
of stopping at SND_SOC_BIAS_STANDBY.
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/cs53l30.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index a5976f3b589a..b0a64a19a045 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -879,6 +879,7 @@ static int cs53l30_codec_probe(struct snd_soc_codec *codec)
static struct snd_soc_codec_driver cs53l30_driver = {
.probe = cs53l30_codec_probe,
.set_bias_level = cs53l30_set_bias_level,
+ .idle_bias_off = true,
.dapm_widgets = cs53l30_dapm_widgets,
.num_dapm_widgets = ARRAY_SIZE(cs53l30_dapm_widgets),
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Applied "ASoC: cs53l30: Set idle_bias_off true" to the asoc tree
@ 2016-06-21 18:52 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2016-06-21 18:52 UTC (permalink / raw)
To: Nicolin Chen; +Cc: Mark Brown
The patch
ASoC: cs53l30: Set idle_bias_off true
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From b0e71c0ddda4e1540b38658cac705222a648c756 Mon Sep 17 00:00:00 2001
From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: Fri, 17 Jun 2016 18:31:57 -0700
Subject: [PATCH] ASoC: cs53l30: Set idle_bias_off true
The driver is using the set_bias_level to control the power on and
off so it should get SND_SOC_BIAS_OFF in order to proceed normal
powering sequences. This patch enables the idle_bias_off option so
the DAPM core will set the bias level to SND_SOC_BIAS_OFF instead
of stopping at SND_SOC_BIAS_STANDBY.
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/cs53l30.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index a5976f3b589a..b0a64a19a045 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -879,6 +879,7 @@ static int cs53l30_codec_probe(struct snd_soc_codec *codec)
static struct snd_soc_codec_driver cs53l30_driver = {
.probe = cs53l30_codec_probe,
.set_bias_level = cs53l30_set_bias_level,
+ .idle_bias_off = true,
.dapm_widgets = cs53l30_dapm_widgets,
.num_dapm_widgets = ARRAY_SIZE(cs53l30_dapm_widgets),
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-21 18:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-18 1:31 [PATCH] ASoC: cs53l30: Set idle_bias_off true Nicolin Chen
2016-06-20 15:35 ` Handrigan, Paul
2016-06-20 15:35 ` Handrigan, Paul
2016-06-21 18:52 ` Applied "ASoC: cs53l30: Set idle_bias_off true" to the asoc tree Mark Brown
2016-06-21 18:52 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.