From: Deepa Dinamani <deepa.kernel@gmail.com> To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: arnd@arndb.de, tglx@linutronix.de, torvalds@linux-foundation.org, tytso@mit.edu, viro@zeniv.linux.org.uk, y2038@lists.linaro.org, Hiral Patel <hiralpat@cisco.com>, Suma Ramars <sramars@cisco.com>, Brian Uchino <buchino@cisco.com>, "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, John Stultz <john.stultz@linaro.org>, linux-scsi@vger.kernel.org Subject: [PATCH v2 19/24] fnic: Use time64_t to represent trace timestamps Date: Sun, 19 Jun 2016 17:27:18 -0700 [thread overview] Message-ID: <1466382443-11063-20-git-send-email-deepa.kernel@gmail.com> (raw) In-Reply-To: <1466382443-11063-1-git-send-email-deepa.kernel@gmail.com> trace timestamps use struct timespec and CURRENT_TIME which are not y2038 safe. These timestamps are only part of the trace log on the machine and are not shared with the fnic. Replace then with y2038 safe struct timespec64 and ktime_get_real_ts64(), respectively. Note that change to add time64_to_tm() is already part of John's kernel tree: https://lkml.org/lkml/2016/6/17/875 . Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com> Cc: Hiral Patel <hiralpat@cisco.com> Cc: Suma Ramars <sramars@cisco.com> Cc: Brian Uchino <buchino@cisco.com> Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: John Stultz <john.stultz@linaro.org> Cc: linux-scsi@vger.kernel.org --- drivers/scsi/fnic/fnic_trace.c | 4 ++-- drivers/scsi/fnic/fnic_trace.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c index 4e15c4b..5a5fa01 100644 --- a/drivers/scsi/fnic/fnic_trace.c +++ b/drivers/scsi/fnic/fnic_trace.c @@ -613,7 +613,7 @@ int fnic_fc_trace_set_data(u32 host_no, u8 frame_type, fc_trace_entries.rd_idx = 0; } - fc_buf->time_stamp = CURRENT_TIME; + ktime_get_real_ts64(&fc_buf->time_stamp); fc_buf->host_no = host_no; fc_buf->frame_type = frame_type; @@ -740,7 +740,7 @@ void copy_and_format_trace_data(struct fc_trace_hdr *tdata, len = *orig_len; - time_to_tm(tdata->time_stamp.tv_sec, 0, &tm); + time64_to_tm(tdata->time_stamp.tv_sec, 0, &tm); fmt = "%02d:%02d:%04ld %02d:%02d:%02d.%09lu ns%8x %c%8x\t"; len += snprintf(fnic_dbgfs_prt->buffer + len, diff --git a/drivers/scsi/fnic/fnic_trace.h b/drivers/scsi/fnic/fnic_trace.h index a8aa057..e375d0c 100644 --- a/drivers/scsi/fnic/fnic_trace.h +++ b/drivers/scsi/fnic/fnic_trace.h @@ -72,7 +72,7 @@ struct fnic_trace_data { typedef struct fnic_trace_data fnic_trace_data_t; struct fc_trace_hdr { - struct timespec time_stamp; + struct timespec64 time_stamp; u32 host_no; u8 frame_type; u8 frame_len; -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Deepa Dinamani <deepa.kernel@gmail.com> To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Suma Ramars <sramars@cisco.com>, tytso@mit.edu, "Martin K. Petersen" <martin.petersen@oracle.com>, arnd@arndb.de, y2038@lists.linaro.org, Hiral Patel <hiralpat@cisco.com>, John Stultz <john.stultz@linaro.org>, viro@zeniv.linux.org.uk, linux-scsi@vger.kernel.org, "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, tglx@linutronix.de, Brian Uchino <buchino@cisco.com>, torvalds@linux-foundation.org Subject: [PATCH v2 19/24] fnic: Use time64_t to represent trace timestamps Date: Sun, 19 Jun 2016 17:27:18 -0700 [thread overview] Message-ID: <1466382443-11063-20-git-send-email-deepa.kernel@gmail.com> (raw) In-Reply-To: <1466382443-11063-1-git-send-email-deepa.kernel@gmail.com> trace timestamps use struct timespec and CURRENT_TIME which are not y2038 safe. These timestamps are only part of the trace log on the machine and are not shared with the fnic. Replace then with y2038 safe struct timespec64 and ktime_get_real_ts64(), respectively. Note that change to add time64_to_tm() is already part of John's kernel tree: https://lkml.org/lkml/2016/6/17/875 . Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com> Cc: Hiral Patel <hiralpat@cisco.com> Cc: Suma Ramars <sramars@cisco.com> Cc: Brian Uchino <buchino@cisco.com> Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: John Stultz <john.stultz@linaro.org> Cc: linux-scsi@vger.kernel.org --- drivers/scsi/fnic/fnic_trace.c | 4 ++-- drivers/scsi/fnic/fnic_trace.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c index 4e15c4b..5a5fa01 100644 --- a/drivers/scsi/fnic/fnic_trace.c +++ b/drivers/scsi/fnic/fnic_trace.c @@ -613,7 +613,7 @@ int fnic_fc_trace_set_data(u32 host_no, u8 frame_type, fc_trace_entries.rd_idx = 0; } - fc_buf->time_stamp = CURRENT_TIME; + ktime_get_real_ts64(&fc_buf->time_stamp); fc_buf->host_no = host_no; fc_buf->frame_type = frame_type; @@ -740,7 +740,7 @@ void copy_and_format_trace_data(struct fc_trace_hdr *tdata, len = *orig_len; - time_to_tm(tdata->time_stamp.tv_sec, 0, &tm); + time64_to_tm(tdata->time_stamp.tv_sec, 0, &tm); fmt = "%02d:%02d:%04ld %02d:%02d:%02d.%09lu ns%8x %c%8x\t"; len += snprintf(fnic_dbgfs_prt->buffer + len, diff --git a/drivers/scsi/fnic/fnic_trace.h b/drivers/scsi/fnic/fnic_trace.h index a8aa057..e375d0c 100644 --- a/drivers/scsi/fnic/fnic_trace.h +++ b/drivers/scsi/fnic/fnic_trace.h @@ -72,7 +72,7 @@ struct fnic_trace_data { typedef struct fnic_trace_data fnic_trace_data_t; struct fc_trace_hdr { - struct timespec time_stamp; + struct timespec64 time_stamp; u32 host_no; u8 frame_type; u8 frame_len; -- 1.9.1 _______________________________________________ Y2038 mailing list Y2038@lists.linaro.org https://lists.linaro.org/mailman/listinfo/y2038
next prev parent reply other threads:[~2016-06-20 1:28 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-20 0:26 [PATCH v2 00/24] Delete CURRENT_TIME and CURRENT_TIME_SEC macros Deepa Dinamani 2016-06-20 0:26 ` [lustre-devel] " Deepa Dinamani 2016-06-20 0:26 ` [Ocfs2-devel] " Deepa Dinamani 2016-06-20 0:26 ` Deepa Dinamani 2016-06-20 0:26 ` Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 01/24] vfs: Add current_time() api Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 02/24] fs: Replace CURRENT_TIME with current_time() for inode timestamps Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 03/24] fs: Replace CURRENT_TIME_SEC " Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 04/24] fs: Replace current_fs_time() with current_time() Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 05/24] fs: jfs: Replace CURRENT_TIME_SEC by current_time() Deepa Dinamani 2016-06-20 18:04 ` [Jfs-discussion] " Dave Kleikamp 2016-06-20 0:27 ` [PATCH v2 06/24] fs: ext4: Use current_time() for inode timestamps Deepa Dinamani 2016-06-20 0:27 ` Deepa Dinamani 2016-06-22 13:40 ` Arnd Bergmann 2016-06-22 13:40 ` Arnd Bergmann 2016-06-24 23:08 ` Deepa Dinamani 2016-06-24 23:08 ` Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 07/24] fs: ubifs: Replace CURRENT_TIME_SEC with current_time Deepa Dinamani 2016-06-22 13:47 ` Arnd Bergmann 2016-06-24 21:05 ` Deepa Dinamani 2016-06-24 21:14 ` [Y2038] " Arnd Bergmann 2016-06-20 0:27 ` [PATCH v2 08/24] fs: btrfs: Use ktime_get_real_ts for root ctime Deepa Dinamani 2016-06-20 9:46 ` David Sterba 2016-06-20 0:27 ` [PATCH v2 09/24] fs: udf: Replace CURRENT_TIME with current_time() Deepa Dinamani 2016-06-22 13:54 ` [Y2038] " Arnd Bergmann 2016-06-23 1:59 ` Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 10/24] fs: cifs: Replace CURRENT_TIME by current_time() Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 11/24] fs: cifs: Replace CURRENT_TIME with ktime_get_real_ts() Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 12/24] fs: cifs: Replace CURRENT_TIME by get_seconds Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 13/24] fs: f2fs: Use ktime_get_real_seconds for sit_info times Deepa Dinamani 2016-06-20 0:27 ` Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 14/24] drivers: staging: lustre: Replace CURRENT_TIME with current_time() Deepa Dinamani 2016-06-20 0:27 ` [lustre-devel] " Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 15/24] fs: ocfs2: Use time64_t to represent orphan scan times Deepa Dinamani 2016-06-20 0:27 ` [Ocfs2-devel] " Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 16/24] fs: ocfs2: Replace CURRENT_TIME with ktime_get_real_seconds() Deepa Dinamani 2016-06-20 0:27 ` [Ocfs2-devel] " Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 17/24] audit: Use timespec64 to represent audit timestamps Deepa Dinamani 2016-06-20 0:27 ` Deepa Dinamani 2016-06-20 15:16 ` Richard Guy Briggs 2016-06-20 15:16 ` Richard Guy Briggs 2016-06-20 0:27 ` [PATCH v2 18/24] fs: nfs: Make nfs boot time y2038 safe Deepa Dinamani 2016-06-20 0:27 ` Deepa Dinamani [this message] 2016-06-20 0:27 ` [PATCH v2 19/24] fnic: Use time64_t to represent trace timestamps Deepa Dinamani 2016-06-22 14:09 ` Arnd Bergmann 2016-06-23 1:51 ` Deepa Dinamani 2016-06-23 1:51 ` Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 20/24] block: Replace CURRENT_TIME with ktime_get_real_ts Deepa Dinamani 2016-06-20 0:27 ` Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 21/24] libceph: " Deepa Dinamani 2016-06-20 0:27 ` Deepa Dinamani 2016-06-20 8:33 ` Willem Jan Withagen 2016-06-22 0:56 ` Deepa Dinamani 2016-06-22 8:20 ` Willem Jan Withagen 2016-06-23 0:17 ` Deepa Dinamani 2016-06-23 7:01 ` Willem Jan Withagen 2016-06-20 0:27 ` [PATCH v2 22/24] fs: ceph: Replace current_fs_time for request stamp Deepa Dinamani 2016-06-20 0:27 ` Deepa Dinamani 2016-06-20 0:27 ` [PATCH v2 23/24] time: Delete CURRENT_TIME_SEC and CURRENT_TIME macro Deepa Dinamani 2016-06-22 15:44 ` Arnd Bergmann 2016-06-20 0:27 ` [PATCH v2 24/24] time: Delete current_fs_time() function Deepa Dinamani 2016-06-20 18:03 ` [PATCH v2 00/24] Delete CURRENT_TIME and CURRENT_TIME_SEC macros Linus Torvalds 2016-06-20 18:03 ` [lustre-devel] " Linus Torvalds 2016-06-20 18:03 ` [Ocfs2-devel] " Linus Torvalds 2016-06-20 18:03 ` Linus Torvalds 2016-06-20 18:03 ` Linus Torvalds 2016-06-20 18:03 ` Linus Torvalds 2016-06-20 18:58 ` Deepa Dinamani 2016-06-20 18:58 ` [lustre-devel] " Deepa Dinamani 2016-06-20 18:58 ` [Ocfs2-devel] " Deepa Dinamani 2016-06-20 18:58 ` Deepa Dinamani 2016-06-20 18:58 ` Deepa Dinamani 2016-06-20 18:58 ` Deepa Dinamani 2016-06-21 15:00 ` [Y2038] " Arnd Bergmann 2016-06-21 15:00 ` [lustre-devel] " Arnd Bergmann 2016-06-21 15:00 ` [Ocfs2-devel] " Arnd Bergmann 2016-06-21 15:00 ` Arnd Bergmann 2016-06-21 15:00 ` Arnd Bergmann 2016-06-21 15:00 ` Arnd Bergmann 2016-06-22 15:49 ` Arnd Bergmann 2016-06-22 15:49 ` [lustre-devel] " Arnd Bergmann 2016-06-22 15:49 ` [Ocfs2-devel] " Arnd Bergmann 2016-06-22 15:49 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1466382443-11063-20-git-send-email-deepa.kernel@gmail.com \ --to=deepa.kernel@gmail.com \ --cc=arnd@arndb.de \ --cc=buchino@cisco.com \ --cc=hiralpat@cisco.com \ --cc=jejb@linux.vnet.ibm.com \ --cc=john.stultz@linaro.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=sramars@cisco.com \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=tytso@mit.edu \ --cc=viro@zeniv.linux.org.uk \ --cc=y2038@lists.linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.