* [PATCH docs] Add Gerrit server info to contributing doc
@ 2016-06-20 13:50 OpenBMC Patches
2016-06-20 13:50 ` OpenBMC Patches
0 siblings, 1 reply; 6+ messages in thread
From: OpenBMC Patches @ 2016-06-20 13:50 UTC (permalink / raw)
To: openbmc; +Cc: Adriana Kobylak
Add steps to setup and push changes to the openbmc gerrit server.
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/openbmc/docs/30)
<!-- Reviewable:end -->
https://github.com/openbmc/docs/pull/30
Adriana Kobylak (1):
Add Gerrit server info to contributing doc
contributing.md | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
--
2.8.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH docs] Add Gerrit server info to contributing doc
2016-06-20 13:50 [PATCH docs] Add Gerrit server info to contributing doc OpenBMC Patches
@ 2016-06-20 13:50 ` OpenBMC Patches
2016-06-20 22:42 ` Patrick Williams
2016-06-21 1:51 ` Andrew Jeffery
0 siblings, 2 replies; 6+ messages in thread
From: OpenBMC Patches @ 2016-06-20 13:50 UTC (permalink / raw)
To: openbmc; +Cc: Adriana Kobylak
From: Adriana Kobylak <anoo@us.ibm.com>
Add steps to setup and push changes to the openbmc gerrit server.
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
---
contributing.md | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/contributing.md b/contributing.md
index db485a0..fb24acd 100644
--- a/contributing.md
+++ b/contributing.md
@@ -84,6 +84,36 @@ The guidelines in the Linux kernel are very useful:
Your contribution will generally need to be reviewed before being accepted.
+
+Submitting changes via Gerrit server
+------------------------------------
+
+The openbmc gerrit server is https://gerrit.openbmc-project.xyz/#/q/status:open
+
+If you're going to be working with gerrit often, it's useful to create an SSH
+host block in ~/.ssh/config. Ex:
+```
+Host openbmc.gerrit
+ Hostname gerrit.openbmc-project.xyz
+ Port 29418
+ User your_github_id
+```
+
+From your openbmc git repository, add a remote to the gerrit server, where
+<openbmc_repo> is the current git repository you're working on, such as
+phosphor-rest-server:
+`remote add gerrit ssh://your_github_id@openbmc.gerrit/openbmc/openbmc_repo`
+
+Obtain the git hook commit-msg to automatically add a Change-Id to the commit
+message, which is needed by Gerrit:
+`gitdir=$(git rev-parse --git-dir)`
+`scp -p -P 29418 your_github_id@gerrit.openbmc-project.xyz:hooks/commit-msg ${gitdir}/hooks`
+
+To submit a change set, push to the gerrit server, where <gerrit> is the name
+of the remote added with the remote add command:
+`git push gerrit HEAD:refs/for/master`
+
+
Avoid references to non-public resources
----------------------------------------
--
2.8.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH docs] Add Gerrit server info to contributing doc
2016-06-20 13:50 ` OpenBMC Patches
@ 2016-06-20 22:42 ` Patrick Williams
2016-06-21 1:51 ` Andrew Jeffery
1 sibling, 0 replies; 6+ messages in thread
From: Patrick Williams @ 2016-06-20 22:42 UTC (permalink / raw)
To: OpenBMC Patches; +Cc: openbmc, Adriana Kobylak
[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]
Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
On Mon, Jun 20, 2016 at 08:50:13AM -0500, OpenBMC Patches wrote:
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> Add steps to setup and push changes to the openbmc gerrit server.
>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
> ---
> contributing.md | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/contributing.md b/contributing.md
> index db485a0..fb24acd 100644
> --- a/contributing.md
> +++ b/contributing.md
> @@ -84,6 +84,36 @@ The guidelines in the Linux kernel are very useful:
>
> Your contribution will generally need to be reviewed before being accepted.
>
> +
> +Submitting changes via Gerrit server
> +------------------------------------
> +
> +The openbmc gerrit server is https://gerrit.openbmc-project.xyz/#/q/status:open
> +
> +If you're going to be working with gerrit often, it's useful to create an SSH
> +host block in ~/.ssh/config. Ex:
> +```
> +Host openbmc.gerrit
> + Hostname gerrit.openbmc-project.xyz
> + Port 29418
> + User your_github_id
> +```
> +
> +From your openbmc git repository, add a remote to the gerrit server, where
> +<openbmc_repo> is the current git repository you're working on, such as
> +phosphor-rest-server:
> +`remote add gerrit ssh://your_github_id@openbmc.gerrit/openbmc/openbmc_repo`
> +
> +Obtain the git hook commit-msg to automatically add a Change-Id to the commit
> +message, which is needed by Gerrit:
> +`gitdir=$(git rev-parse --git-dir)`
> +`scp -p -P 29418 your_github_id@gerrit.openbmc-project.xyz:hooks/commit-msg ${gitdir}/hooks`
> +
> +To submit a change set, push to the gerrit server, where <gerrit> is the name
> +of the remote added with the remote add command:
> +`git push gerrit HEAD:refs/for/master`
> +
> +
> Avoid references to non-public resources
> ----------------------------------------
>
> --
> 2.8.4
>
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
--
Patrick Williams
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH docs] Add Gerrit server info to contributing doc
2016-06-20 13:50 ` OpenBMC Patches
2016-06-20 22:42 ` Patrick Williams
@ 2016-06-21 1:51 ` Andrew Jeffery
2016-06-21 2:08 ` Patrick Williams
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Jeffery @ 2016-06-21 1:51 UTC (permalink / raw)
To: OpenBMC Patches, openbmc; +Cc: Adriana Kobylak, Patrick Williams
[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]
On Mon, 2016-06-20 at 08:50 -0500, OpenBMC Patches wrote:
> From: Adriana Kobylak <anoo@us.ibm.com>
>
> Add steps to setup and push changes to the openbmc gerrit server.
>
> Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
> ---
> contributing.md | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/contributing.md b/contributing.md
> index db485a0..fb24acd 100644
> --- a/contributing.md
> +++ b/contributing.md
> @@ -84,6 +84,36 @@ The guidelines in the Linux kernel are very useful:
>
> Your contribution will generally need to be reviewed before being accepted.
>
> +
> +Submitting changes via Gerrit server
> +------------------------------------
> +
> +The openbmc gerrit server is https://gerrit.openbmc-project.xyz/#/q/status:open
> +
> +If you're going to be working with gerrit often, it's useful to create an SSH
> +host block in ~/.ssh/config. Ex:
> +```
> +Host openbmc.gerrit
> + Hostname gerrit.openbmc-project.xyz
> + Port 29418
> + User your_github_id
> +```
> +
> +From your openbmc git repository, add a remote to the gerrit server, where
> + is the current git repository you're working on, such as
> +phosphor-rest-server:
> +`remote add gerrit ssh://your_github_id@openbmc.gerrit/openbmc/openbmc_repo`
> +
> +Obtain the git hook commit-msg to automatically add a Change-Id to the commit
> +message, which is needed by Gerrit:
> +`gitdir=$(git rev-parse --git-dir)`
> +`scp -p -P 29418 your_github_id@gerrit.openbmc-project.xyz:hooks/commit-msg ${gitdir}/hooks`
> +
> +To submit a change set, push to the gerrit server, where is the name
> +of the remote added with the remote add command:
> +`git push gerrit HEAD:refs/for/master`
> +
> +
Are we planning to list the projects that are using Gerrit here as
well? I understand there's only a test project at the moment, but just
wanted to clarify.
Cheers,
Andrew
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH docs] Add Gerrit server info to contributing doc
2016-06-21 1:51 ` Andrew Jeffery
@ 2016-06-21 2:08 ` Patrick Williams
2016-06-21 4:10 ` Andrew Jeffery
0 siblings, 1 reply; 6+ messages in thread
From: Patrick Williams @ 2016-06-21 2:08 UTC (permalink / raw)
To: Andrew Jeffery; +Cc: OpenBMC Patches, openbmc, Adriana Kobylak
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
On Tue, Jun 21, 2016 at 11:21:57AM +0930, Andrew Jeffery wrote:
> On Mon, 2016-06-20 at 08:50 -0500, OpenBMC Patches wrote:
> Are we planning to list the projects that are using Gerrit here as
> well? I understand there's only a test project at the moment, but just
> wanted to clarify.
>
I don't believe so. The intention is that the majority are there and I
don't think we should maintain a list of them. It would be more
straight-forward to maintain a list of ones NOT there.
--
Patrick Williams
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH docs] Add Gerrit server info to contributing doc
2016-06-21 2:08 ` Patrick Williams
@ 2016-06-21 4:10 ` Andrew Jeffery
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Jeffery @ 2016-06-21 4:10 UTC (permalink / raw)
To: Patrick Williams; +Cc: OpenBMC Patches, openbmc, Adriana Kobylak
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
On Mon, 2016-06-20 at 21:08 -0500, Patrick Williams wrote:
> On Tue, Jun 21, 2016 at 11:21:57AM +0930, Andrew Jeffery wrote:
> >
> > On Mon, 2016-06-20 at 08:50 -0500, OpenBMC Patches wrote:
> > Are we planning to list the projects that are using Gerrit here as
> > well? I understand there's only a test project at the moment, but just
> > wanted to clarify.
> >
> I don't believe so. The intention is that the majority are there and I
> don't think we should maintain a list of them. It would be more
> straight-forward to maintain a list of ones NOT there.
>
Sure. Either way I think we should do something to document that we
have different workflows for different repos (this change is fine as is
though). This gives us something to point at when people ask. I'm just
trying to keep in mind the points raised in LWN's drive-through-
contributions article[1].
Cheers,
Andrew
[1] https://lwn.net/SubscriberLink/688560/9fa49b203bb0997d/
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-21 4:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-20 13:50 [PATCH docs] Add Gerrit server info to contributing doc OpenBMC Patches
2016-06-20 13:50 ` OpenBMC Patches
2016-06-20 22:42 ` Patrick Williams
2016-06-21 1:51 ` Andrew Jeffery
2016-06-21 2:08 ` Patrick Williams
2016-06-21 4:10 ` Andrew Jeffery
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.