All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc/pci: Reduce log level of PCI I/O space warning
@ 2016-06-22  7:23 Benjamin Herrenschmidt
  2016-06-24  6:31 ` Gavin Shan
  2016-06-28 12:10 ` Michael Ellerman
  0 siblings, 2 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2016-06-22  7:23 UTC (permalink / raw)
  To: linuxppc dev list

If a PHB has no I/O space, there's no need to make it look like
something bad happened, a pr_debug() is plenty enough since this
is the case of all our modern POWER chips.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 arch/powerpc/kernel/pci-common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index 2a67b16..3ab1f7b 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c
@@ -1487,9 +1487,9 @@ static void pcibios_setup_phb_resources(struct pci_controller *hose,
 	res = &hose->io_resource;
 
 	if (!res->flags) {
-		pr_info("PCI: I/O resource not set for host"
-		       " bridge %s (domain %d)\n",
-		       hose->dn->full_name, hose->global_number);
+		pr_debug("PCI: I/O resource not set for host"
+			 " bridge %s (domain %d)\n",
+			 hose->dn->full_name, hose->global_number);
 	} else {
 		offset = pcibios_io_space_offset(hose);
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/pci: Reduce log level of PCI I/O space warning
  2016-06-22  7:23 [PATCH] powerpc/pci: Reduce log level of PCI I/O space warning Benjamin Herrenschmidt
@ 2016-06-24  6:31 ` Gavin Shan
  2016-06-28 12:10 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Gavin Shan @ 2016-06-24  6:31 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc dev list

On Wed, Jun 22, 2016 at 05:23:07PM +1000, Benjamin Herrenschmidt wrote:
>If a PHB has no I/O space, there's no need to make it look like
>something bad happened, a pr_debug() is plenty enough since this
>is the case of all our modern POWER chips.
>
>Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>

>---
> arch/powerpc/kernel/pci-common.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
>index 2a67b16..3ab1f7b 100644
>--- a/arch/powerpc/kernel/pci-common.c
>+++ b/arch/powerpc/kernel/pci-common.c
>@@ -1487,9 +1487,9 @@ static void pcibios_setup_phb_resources(struct pci_controller *hose,
> 	res = &hose->io_resource;
> 
> 	if (!res->flags) {
>-		pr_info("PCI: I/O resource not set for host"
>-		       " bridge %s (domain %d)\n",
>-		       hose->dn->full_name, hose->global_number);
>+		pr_debug("PCI: I/O resource not set for host"
>+			 " bridge %s (domain %d)\n",
>+			 hose->dn->full_name, hose->global_number);
> 	} else {
> 		offset = pcibios_io_space_offset(hose);
> 
>
>
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@lists.ozlabs.org
>https://lists.ozlabs.org/listinfo/linuxppc-dev

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: powerpc/pci: Reduce log level of PCI I/O space warning
  2016-06-22  7:23 [PATCH] powerpc/pci: Reduce log level of PCI I/O space warning Benjamin Herrenschmidt
  2016-06-24  6:31 ` Gavin Shan
@ 2016-06-28 12:10 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2016-06-28 12:10 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, linuxppc dev list

On Wed, 2016-22-06 at 07:23:07 UTC, Benjamin Herrenschmidt wrote:
> If a PHB has no I/O space, there's no need to make it look like
> something bad happened, a pr_debug() is plenty enough since this
> is the case of all our modern POWER chips.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/cdb1b3424dba7d38a2835f6f5f

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-28 12:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-22  7:23 [PATCH] powerpc/pci: Reduce log level of PCI I/O space warning Benjamin Herrenschmidt
2016-06-24  6:31 ` Gavin Shan
2016-06-28 12:10 ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.