[PATCH 1/2] drm/i915: Add more Kabylake PCI IDs.

[PATCH 1/2] drm/i915: Add more Kabylake PCI IDs.

[Rodrigo Vivi]

The spec has been updated adding new PCI IDs.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 include/drm/i915_pciids.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 9094599..87dde1c 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -309,6 +309,7 @@
 	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
 	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
 	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
+	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
 	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
 	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
 
@@ -322,7 +323,9 @@
 	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
 
 #define INTEL_KBL_GT3_IDS(info) \
+	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
 	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
 
-- 
2.5.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/2] drm/i915: Removing PCI IDs that are no longer listed as Kabylake.

[Rodrigo Vivi]

This is unusual. Usually IDs listed on early stages of platform
definition are kept there as reserved for later use.

However these IDs here are not listed anymore in any of steppings
and devices IDs tables for Kabylake on configurations overview
section of BSpec.

So it is better removing them before they become used in any
other future platform.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 include/drm/i915_pciids.h | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 87dde1c..33466bf 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -325,15 +325,10 @@
 #define INTEL_KBL_GT3_IDS(info) \
 	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
-	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
-	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
-	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
+	INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
 
 #define INTEL_KBL_GT4_IDS(info) \
-	INTEL_VGA_DEVICE(0x5932, info), /* DT  GT4 */ \
-	INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \
-	INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \
-	INTEL_VGA_DEVICE(0x593D, info)  /* WKS GT4 */
+	INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
 
 #define INTEL_KBL_IDS(info) \
 	INTEL_KBL_GT1_IDS(info), \
-- 
2.5.5

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

✗ Ro.CI.BAT: failure for series starting with [1/2] drm/i915: Add more Kabylake PCI IDs.

[Patchwork]

== Series Details ==

Series: series starting with [1/2] drm/i915: Add more Kabylake PCI IDs.
URL   : https://patchwork.freedesktop.org/series/9101/
State : failure

== Summary ==

Series 9101v1 Series without cover letter
http://patchwork.freedesktop.org/api/1.0/series/9101/revisions/1/mbox

Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (ro-hsw-i3-4010u)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                skip       -> DMESG-WARN (ro-bdw-i5-5250u)
        Subgroup suspend-read-crc-pipe-c:
                skip       -> DMESG-WARN (ro-bdw-i7-5557U)
Test vgem_basic:
        Subgroup create:
                skip       -> PASS       (ro-bdw-i7-5557U)
                skip       -> PASS       (ro-ilk1-i5-650)
                skip       -> PASS       (ro-hsw-i3-4010u)
                skip       -> PASS       (ro-bdw-i7-5600u)
                skip       -> PASS       (ro-bdw-i5-5250u)
                skip       -> PASS       (ro-hsw-i7-4770r)
                skip       -> PASS       (ro-ivb-i7-3770)
                skip       -> PASS       (ro-ivb2-i7-3770)
                skip       -> PASS       (ro-byt-n2820)
                skip       -> PASS       (ro-skl3-i5-6260u)
        Subgroup debugfs:
                skip       -> PASS       (ro-bdw-i7-5557U)
                skip       -> PASS       (ro-ilk1-i5-650)
                skip       -> PASS       (ro-hsw-i3-4010u)
                skip       -> PASS       (ro-bdw-i7-5600u)
                skip       -> PASS       (ro-bdw-i5-5250u)
                skip       -> PASS       (ro-hsw-i7-4770r)
                skip       -> PASS       (ro-ivb-i7-3770)
                skip       -> PASS       (ro-ivb2-i7-3770)
                skip       -> PASS       (ro-byt-n2820)
                skip       -> PASS       (ro-skl3-i5-6260u)
        Subgroup mmap:
                skip       -> DMESG-FAIL (ro-bdw-i7-5557U)
                skip       -> DMESG-FAIL (ro-ilk1-i5-650)
                skip       -> DMESG-FAIL (ro-hsw-i3-4010u)
                skip       -> DMESG-FAIL (ro-bdw-i7-5600u)
                skip       -> DMESG-FAIL (ro-bdw-i5-5250u)
                skip       -> DMESG-FAIL (ro-hsw-i7-4770r)
                skip       -> DMESG-FAIL (ro-ivb-i7-3770)
                skip       -> DMESG-FAIL (ro-ivb2-i7-3770)
                skip       -> DMESG-FAIL (ro-byt-n2820)
                skip       -> DMESG-FAIL (ro-skl3-i5-6260u)
        Subgroup sysfs:
                skip       -> PASS       (ro-bdw-i7-5557U)
                skip       -> PASS       (ro-ilk1-i5-650)
                skip       -> PASS       (ro-hsw-i3-4010u)
                skip       -> PASS       (ro-bdw-i7-5600u)
                skip       -> PASS       (ro-bdw-i5-5250u)
                skip       -> PASS       (ro-hsw-i7-4770r)
                skip       -> PASS       (ro-ivb-i7-3770)
                skip       -> PASS       (ro-ivb2-i7-3770)
                skip       -> PASS       (ro-byt-n2820)
                skip       -> PASS       (ro-skl3-i5-6260u)
Test vgem_reload_basic:
                skip       -> PASS       (ro-bdw-i7-5557U)
                skip       -> PASS       (ro-ilk1-i5-650)
                skip       -> PASS       (ro-hsw-i3-4010u)
                skip       -> PASS       (ro-bdw-i7-5600u)
                skip       -> PASS       (ro-bdw-i5-5250u)
                skip       -> PASS       (ro-hsw-i7-4770r)
                skip       -> PASS       (ro-ivb-i7-3770)
                skip       -> PASS       (ro-ivb2-i7-3770)
                skip       -> PASS       (ro-byt-n2820)
                skip       -> PASS       (ro-skl3-i5-6260u)

fi-hsw-i7-4770k  total:228  pass:194  dwarn:0   dfail:0   fail:1   skip:33 
fi-kbl-qkkr      total:228  pass:161  dwarn:28  dfail:0   fail:0   skip:39 
fi-skl-i5-6260u  total:228  pass:202  dwarn:0   dfail:0   fail:1   skip:25 
fi-skl-i7-6700k  total:228  pass:188  dwarn:0   dfail:0   fail:1   skip:39 
fi-snb-i7-2600   total:228  pass:174  dwarn:0   dfail:0   fail:1   skip:53 
ro-bdw-i5-5250u  total:227  pass:201  dwarn:3   dfail:1   fail:1   skip:21 
ro-bdw-i7-5557U  total:227  pass:202  dwarn:2   dfail:1   fail:1   skip:21 
ro-bdw-i7-5600u  total:227  pass:189  dwarn:0   dfail:1   fail:0   skip:37 
ro-byt-n2820     total:227  pass:177  dwarn:0   dfail:1   fail:4   skip:45 
ro-hsw-i3-4010u  total:227  pass:193  dwarn:1   dfail:1   fail:1   skip:31 
ro-hsw-i7-4770r  total:227  pass:194  dwarn:0   dfail:1   fail:1   skip:31 
ro-ilk1-i5-650   total:222  pass:154  dwarn:0   dfail:1   fail:2   skip:65 
ro-ivb-i7-3770   total:227  pass:185  dwarn:0   dfail:1   fail:1   skip:40 
ro-ivb2-i7-3770  total:227  pass:189  dwarn:0   dfail:1   fail:1   skip:36 
ro-skl3-i5-6260u total:227  pass:205  dwarn:1   dfail:1   fail:1   skip:19 
ro-bsw-n3050 failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1289/

8e5ac92 drm-intel-nightly: 2016y-06m-22d-18h-10m-30s UTC integration manifest
2432e6f drm/i915: Removing PCI IDs that are no longer listed as Kabylake.
fb08957 drm/i915: Add more Kabylake PCI IDs.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Add more Kabylake PCI IDs.

[Pandiyan, Dhinakaran]

On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote:
> The spec has been updated adding new PCI IDs.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  include/drm/i915_pciids.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 9094599..87dde1c 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -309,6 +309,7 @@
>  	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
>  	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
>  	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
> +	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
>  	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
>  	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
>  
> @@ -322,7 +323,9 @@
>  	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
>  
>  #define INTEL_KBL_GT3_IDS(info) \
> +	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
> +	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
>  	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
>  

I verified the added and removed PCI IDs against Spec, looks good to me.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] drm/i915: Add more Kabylake PCI IDs.

[Pandiyan, Dhinakaran]

On Fri, 2016-06-24 at 22:06 +0000, Pandiyan, Dhinakaran wrote:
> On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote:
> > The spec has been updated adding new PCI IDs.
> > 
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  include/drm/i915_pciids.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> > index 9094599..87dde1c 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -309,6 +309,7 @@
> >  	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
> >  	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
> >  	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
> > +	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
> >  	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
> >  	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
> >  
> > @@ -322,7 +323,9 @@
> >  	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
> >  
> >  #define INTEL_KBL_GT3_IDS(info) \
> > +	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
> >  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
> > +	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
> >  	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
> >  	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
> >  
> 
> I verified the added and removed PCI IDs against Spec, looks good to me.
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Missed the tag.
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] drm/i915: Removing PCI IDs that are no longer listed as Kabylake.

[Pandiyan, Dhinakaran]

On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote:
> -       INTEL_VGA_DEVICE(0x5932, info), /* DT  GT4 */ \
> -       INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \
> -       INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \
> -       INTEL_VGA_DEVICE(0x593D, info)  /* WKS GT4


Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Removing PCI IDs that are no longer listed as Kabylake.

[Jani Nikula]

On Fri, 24 Jun 2016, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> This is unusual. Usually IDs listed on early stages of platform
> definition are kept there as reserved for later use.
>
> However these IDs here are not listed anymore in any of steppings
> and devices IDs tables for Kabylake on configurations overview
> section of BSpec.
>
> So it is better removing them before they become used in any
> other future platform.
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Please reply to the list when you actually push.

Both of these could have used cc: drm-intel-fixes because we support kbl
starting v4.7. I've picked them to fixes now.

BR,
Jani.

> ---
>  include/drm/i915_pciids.h | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 87dde1c..33466bf 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -325,15 +325,10 @@
>  #define INTEL_KBL_GT3_IDS(info) \
>  	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
> -	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
> -	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
> -	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
> +	INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
>  
>  #define INTEL_KBL_GT4_IDS(info) \
> -	INTEL_VGA_DEVICE(0x5932, info), /* DT  GT4 */ \
> -	INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \
> -	INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \
> -	INTEL_VGA_DEVICE(0x593D, info)  /* WKS GT4 */
> +	INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
>  
>  #define INTEL_KBL_IDS(info) \
>  	INTEL_KBL_GT1_IDS(info), \

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Removing PCI IDs that are no longer listed as Kabylake.

[Vivi, Rodrigo]

On Wed, 2016-06-29 at 12:24 +0300, Jani Nikula wrote:
> On Fri, 24 Jun 2016, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > 
> > This is unusual. Usually IDs listed on early stages of platform
> > definition are kept there as reserved for later use.
> > 
> > However these IDs here are not listed anymore in any of steppings
> > and devices IDs tables for Kabylake on configurations overview
> > section of BSpec.
> > 
> > So it is better removing them before they become used in any
> > other future platform.
> > 
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Please reply to the list when you actually push.

ops. I merged yesterday but forgot to reply, sorry.

> 
> Both of these could have used cc: drm-intel-fixes because we support
> kbl
> starting v4.7. I've picked them to fixes now.

Thanks

> 
> BR,
> Jani.
> 
> > 
> > ---
> >  include/drm/i915_pciids.h | 9 ++-------
> >  1 file changed, 2 insertions(+), 7 deletions(-)
> > 
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> > index 87dde1c..33466bf 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -325,15 +325,10 @@
> >  #define INTEL_KBL_GT3_IDS(info) \
> >  	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
> >  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
> > -	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
> > -	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
> > -	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
> > +	INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
> >  
> >  #define INTEL_KBL_GT4_IDS(info) \
> > -	INTEL_VGA_DEVICE(0x5932, info), /* DT  GT4 */ \
> > -	INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \
> > -	INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \
> > -	INTEL_VGA_DEVICE(0x593D, info)  /* WKS GT4 */
> > +	INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
> >  
> >  #define INTEL_KBL_IDS(info) \
> >  	INTEL_KBL_GT1_IDS(info), \
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev