All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] pciids: Add more Kabylake PCI IDs.
@ 2016-06-23 21:50 Rodrigo Vivi
  2016-06-23 21:50 ` [PATCH 2/2] pciids: : Removing PCI IDs that are no longer listed as Kabylake Rodrigo Vivi
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2016-06-23 21:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

The spec has been updated adding new PCI IDs.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 src/i915_pciids.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/i915_pciids.h b/src/i915_pciids.h
index 9094599..87dde1c 100644
--- a/src/i915_pciids.h
+++ b/src/i915_pciids.h
@@ -309,6 +309,7 @@
 	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
 	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
 	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
+	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
 	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
 	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
 
@@ -322,7 +323,9 @@
 	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
 
 #define INTEL_KBL_GT3_IDS(info) \
+	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
+	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
 	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
 
-- 
2.5.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] pciids: : Removing PCI IDs that are no longer listed as Kabylake.
  2016-06-23 21:50 [PATCH 1/2] pciids: Add more Kabylake PCI IDs Rodrigo Vivi
@ 2016-06-23 21:50 ` Rodrigo Vivi
  2016-06-28 22:13   ` Pandiyan, Dhinakaran
  2016-06-24 10:36 ` ✗ Ro.CI.BAT: failure for series starting with [1/2] pciids: Add more Kabylake PCI IDs Patchwork
  2016-06-24 22:07 ` [PATCH 1/2] " Pandiyan, Dhinakaran
  2 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Vivi @ 2016-06-23 21:50 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

This is unusual. Usually IDs listed on early stages of platform
definition are kept there as reserved for later use.

However these IDs here are not listed anymore in any of steppings
and devices IDs tables for Kabylake on configurations overview
section of BSpec.

So it is better removing them before they become used in any
other future platform.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 src/i915_pciids.h | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/i915_pciids.h b/src/i915_pciids.h
index 87dde1c..33466bf 100644
--- a/src/i915_pciids.h
+++ b/src/i915_pciids.h
@@ -325,15 +325,10 @@
 #define INTEL_KBL_GT3_IDS(info) \
 	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
 	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
-	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
-	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
-	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
+	INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
 
 #define INTEL_KBL_GT4_IDS(info) \
-	INTEL_VGA_DEVICE(0x5932, info), /* DT  GT4 */ \
-	INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \
-	INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \
-	INTEL_VGA_DEVICE(0x593D, info)  /* WKS GT4 */
+	INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
 
 #define INTEL_KBL_IDS(info) \
 	INTEL_KBL_GT1_IDS(info), \
-- 
2.5.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* ✗ Ro.CI.BAT: failure for series starting with [1/2] pciids: Add more Kabylake PCI IDs.
  2016-06-23 21:50 [PATCH 1/2] pciids: Add more Kabylake PCI IDs Rodrigo Vivi
  2016-06-23 21:50 ` [PATCH 2/2] pciids: : Removing PCI IDs that are no longer listed as Kabylake Rodrigo Vivi
@ 2016-06-24 10:36 ` Patchwork
  2016-06-24 22:07 ` [PATCH 1/2] " Pandiyan, Dhinakaran
  2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2016-06-24 10:36 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] pciids: Add more Kabylake PCI IDs.
URL   : https://patchwork.freedesktop.org/series/9105/
State : failure

== Summary ==

Series 9105v1 Series without cover letter
http://patchwork.freedesktop.org/api/1.0/series/9105/revisions/1/mbox

Test gem_exec_suspend:
        Subgroup basic-s3:
                pass       -> INCOMPLETE (fi-hsw-i7-4770k)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> INCOMPLETE (fi-snb-i7-2600)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-skl-i7-6700k)

fi-hsw-i7-4770k  total:103  pass:86   dwarn:0   dfail:0   fail:0   skip:16 
fi-skl-i5-6260u  total:228  pass:202  dwarn:0   dfail:0   fail:1   skip:25 
fi-skl-i7-6700k  total:196  pass:170  dwarn:0   dfail:0   fail:1   skip:24 
fi-snb-i7-2600   total:190  pass:156  dwarn:0   dfail:0   fail:1   skip:32 
fi-kbl-qkkr failed to connect after reboot
ro-bsw-n3050 failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1294/

35115e2 drm-intel-nightly: 2016y-06m-24d-06h-55m-13s UTC integration manifest
585867d pciids: : Removing PCI IDs that are no longer listed as Kabylake.
95d1c95 pciids: Add more Kabylake PCI IDs.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pciids: Add more Kabylake PCI IDs.
  2016-06-23 21:50 [PATCH 1/2] pciids: Add more Kabylake PCI IDs Rodrigo Vivi
  2016-06-23 21:50 ` [PATCH 2/2] pciids: : Removing PCI IDs that are no longer listed as Kabylake Rodrigo Vivi
  2016-06-24 10:36 ` ✗ Ro.CI.BAT: failure for series starting with [1/2] pciids: Add more Kabylake PCI IDs Patchwork
@ 2016-06-24 22:07 ` Pandiyan, Dhinakaran
  2016-06-24 22:32   ` Pandiyan, Dhinakaran
  2 siblings, 1 reply; 6+ messages in thread
From: Pandiyan, Dhinakaran @ 2016-06-24 22:07 UTC (permalink / raw)
  To: Vivi, Rodrigo; +Cc: intel-gfx

On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote:
> The spec has been updated adding new PCI IDs.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  src/i915_pciids.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/i915_pciids.h b/src/i915_pciids.h
> index 9094599..87dde1c 100644
> --- a/src/i915_pciids.h
> +++ b/src/i915_pciids.h
> @@ -309,6 +309,7 @@
>  	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
>  	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
>  	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
> +	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
>  	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
>  	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
>  
> @@ -322,7 +323,9 @@
>  	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
>  
>  #define INTEL_KBL_GT3_IDS(info) \
> +	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
> +	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
>  	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
>  

I verified the added and removed PCI IDs against the Spec, looks good to
me.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pciids: Add more Kabylake PCI IDs.
  2016-06-24 22:07 ` [PATCH 1/2] " Pandiyan, Dhinakaran
@ 2016-06-24 22:32   ` Pandiyan, Dhinakaran
  0 siblings, 0 replies; 6+ messages in thread
From: Pandiyan, Dhinakaran @ 2016-06-24 22:32 UTC (permalink / raw)
  To: Vivi, Rodrigo; +Cc: intel-gfx

On Fri, 2016-06-24 at 15:20 -0700, Dhinakaran Pandiyan wrote:
> On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote:
> > The spec has been updated adding new PCI IDs.
> > 
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  src/i915_pciids.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/src/i915_pciids.h b/src/i915_pciids.h
> > index 9094599..87dde1c 100644
> > --- a/src/i915_pciids.h
> > +++ b/src/i915_pciids.h
> > @@ -309,6 +309,7 @@
> >  	INTEL_VGA_DEVICE(0x5906, info), /* ULT GT1 */ \
> >  	INTEL_VGA_DEVICE(0x590E, info), /* ULX GT1 */ \
> >  	INTEL_VGA_DEVICE(0x5902, info), /* DT  GT1 */ \
> > +	INTEL_VGA_DEVICE(0x5908, info), /* Halo GT1 */ \
> >  	INTEL_VGA_DEVICE(0x590B, info), /* Halo GT1 */ \
> >  	INTEL_VGA_DEVICE(0x590A, info) /* SRV GT1 */
> >  
> > @@ -322,7 +323,9 @@
> >  	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
> >  
> >  #define INTEL_KBL_GT3_IDS(info) \
> > +	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
> >  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
> > +	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
> >  	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
> >  	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
> >  
> 
> I verified the added and removed PCI IDs against the Spec, looks good to
> me.

Missed the tag.
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] pciids: : Removing PCI IDs that are no longer listed as Kabylake.
  2016-06-23 21:50 ` [PATCH 2/2] pciids: : Removing PCI IDs that are no longer listed as Kabylake Rodrigo Vivi
@ 2016-06-28 22:13   ` Pandiyan, Dhinakaran
  0 siblings, 0 replies; 6+ messages in thread
From: Pandiyan, Dhinakaran @ 2016-06-28 22:13 UTC (permalink / raw)
  To: Vivi, Rodrigo; +Cc: intel-gfx

On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote:
> This is unusual. Usually IDs listed on early stages of platform
> definition are kept there as reserved for later use.
> 
> However these IDs here are not listed anymore in any of steppings
> and devices IDs tables for Kabylake on configurations overview
> section of BSpec.
> 
> So it is better removing them before they become used in any
> other future platform.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  src/i915_pciids.h | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/src/i915_pciids.h b/src/i915_pciids.h
> index 87dde1c..33466bf 100644
> --- a/src/i915_pciids.h
> +++ b/src/i915_pciids.h
> @@ -325,15 +325,10 @@
>  #define INTEL_KBL_GT3_IDS(info) \
>  	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
>  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
> -	INTEL_VGA_DEVICE(0x5927, info), /* ULT GT3 */ \
> -	INTEL_VGA_DEVICE(0x592B, info), /* Halo GT3 */ \
> -	INTEL_VGA_DEVICE(0x592A, info) /* SRV GT3 */
> +	INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
>  
>  #define INTEL_KBL_GT4_IDS(info) \
> -	INTEL_VGA_DEVICE(0x5932, info), /* DT  GT4 */ \
> -	INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \
> -	INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \
> -	INTEL_VGA_DEVICE(0x593D, info)  /* WKS GT4 */
> +	INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
>  
>  #define INTEL_KBL_IDS(info) \
>  	INTEL_KBL_GT1_IDS(info), \
Verified against the spec, lgtm.
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-28 22:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-23 21:50 [PATCH 1/2] pciids: Add more Kabylake PCI IDs Rodrigo Vivi
2016-06-23 21:50 ` [PATCH 2/2] pciids: : Removing PCI IDs that are no longer listed as Kabylake Rodrigo Vivi
2016-06-28 22:13   ` Pandiyan, Dhinakaran
2016-06-24 10:36 ` ✗ Ro.CI.BAT: failure for series starting with [1/2] pciids: Add more Kabylake PCI IDs Patchwork
2016-06-24 22:07 ` [PATCH 1/2] " Pandiyan, Dhinakaran
2016-06-24 22:32   ` Pandiyan, Dhinakaran

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.