[PATCH] powerpc/pseries: HVC early debug options should depend on HVC_CONSOLE

[PATCH] powerpc/pseries: HVC early debug options should depend on HVC_CONSOLE

[Michael Ellerman]

The pseries HVC early debug options, CONFIG_PPC_EARLY_DEBUG_LPAR and
CONFIG_PPC_EARLY_DEBUG_LPAR_HVSI both require code that is part of the
hvc driver. If we turn them on but not CONFIG_HVC_CONSOLE then we get:

  arch/powerpc/kernel/built-in.o: In function `.udbg_early_init':
  arch/powerpc/kernel/built-in.o:(.debug_addr+0x9a00): undefined reference to `udbg_init_debug_lpar'

Similarly for HVSI. So make them both depend on CONFIG_HVC_CONSOLE.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/Kconfig.debug | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
index d3fcf7e64e3a..cfe08eab90c6 100644
--- a/arch/powerpc/Kconfig.debug
+++ b/arch/powerpc/Kconfig.debug
@@ -149,14 +149,14 @@ config PPC_EARLY_DEBUG_BOOTX
 
 config PPC_EARLY_DEBUG_LPAR
 	bool "LPAR HV Console"
-	depends on PPC_PSERIES
+	depends on PPC_PSERIES && HVC_CONSOLE
 	help
 	  Select this to enable early debugging for a machine with a HVC
 	  console on vterm 0.
 
 config PPC_EARLY_DEBUG_LPAR_HVSI
 	bool "LPAR HVSI Console"
-	depends on PPC_PSERIES
+	depends on PPC_PSERIES && HVC_CONSOLE
 	help
 	  Select this to enable early debugging for a machine with a HVSI
 	  console on a specified vterm.
-- 
2.5.0

Re: powerpc/pseries: HVC early debug options should depend on HVC_CONSOLE

[Michael Ellerman]

On Tue, 2016-28-06 at 05:02:46 UTC, Michael Ellerman wrote:
> The pseries HVC early debug options, CONFIG_PPC_EARLY_DEBUG_LPAR and
> CONFIG_PPC_EARLY_DEBUG_LPAR_HVSI both require code that is part of the
> hvc driver. If we turn them on but not CONFIG_HVC_CONSOLE then we get:
> 
>   arch/powerpc/kernel/built-in.o: In function `.udbg_early_init':
>   arch/powerpc/kernel/built-in.o:(.debug_addr+0x9a00): undefined reference to `udbg_init_debug_lpar'
> 
> Similarly for HVSI. So make them both depend on CONFIG_HVC_CONSOLE.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Applied to powerpc next.

https://git.kernel.org/powerpc/c/236977609a81150c4561c33fa6

cheers