* [PATCH 1/2] drm/fsl-dcu: update the panel dt binding document
@ 2016-06-28 9:39 Meng Yi
[not found] ` <1467106748-19314-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Meng Yi @ 2016-06-28 9:39 UTC (permalink / raw)
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, shawnguo-DgEjT+Ai2ygdnm+yROfE0A,
stefan-XLVq0VzYD2Y
Cc: airlied-cv59FeDIM0c, emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w,
jianwei.wang.chn-Re5JQEeQqe8AvxtiuMwx3w,
alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
devicetree-u79uwXL29TY76Z2rM5mHXA, Meng Yi
dropped the old "fsl,panel" property, using the of_graph dt
binding syntax
Signed-off-by: Meng Yi <meng.yi-3arQi8VN3Tc@public.gmane.org>
---
Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt b/Documentation/devicetree/bindings/display/fsl,dcu.txt
index ae55cde..f44cf5b 100644
--- a/Documentation/devicetree/bindings/display/fsl,dcu.txt
+++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt
@@ -12,7 +12,7 @@ Required properties:
- clock-names: Should be "dcu" and "pix"
See ../clocks/clock-bindings.txt for details.
- big-endian Boolean property, LS1021A DCU registers are big-endian.
-- fsl,panel: The phandle to panel node.
+- port Video port for the panel output
Optional properties:
- fsl,tcon: The phandle to the timing controller node.
@@ -24,6 +24,11 @@ dcu: dcu@2ce0000 {
clocks = <&platform_clk 0>, <&platform_clk 0>;
clock-names = "dcu", "pix";
big-endian;
- fsl,panel = <&panel>;
fsl,tcon = <&tcon>;
+
+ port: port@0 {
+ dcu_out: endpoint {
+ remote-endpoint = <&panel_out>;
+ };
+ };
};
--
2.1.0.27.g96db324
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/fsl-dcu: update panel syntax to of_graph dt binding
[not found] ` <1467106748-19314-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
@ 2016-06-28 9:39 ` Meng Yi
2016-06-28 21:07 ` [PATCH 1/2] drm/fsl-dcu: update the panel dt binding document Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Meng Yi @ 2016-06-28 9:39 UTC (permalink / raw)
To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, shawnguo-DgEjT+Ai2ygdnm+yROfE0A,
stefan-XLVq0VzYD2Y
Cc: airlied-cv59FeDIM0c, emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w,
jianwei.wang.chn-Re5JQEeQqe8AvxtiuMwx3w,
alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
devicetree-u79uwXL29TY76Z2rM5mHXA, Meng Yi
add of_graph dt binding for panel, and "fsl,panel" property
is deprecated
Signed-off-by: Meng Yi <meng.yi-3arQi8VN3Tc@public.gmane.org>
---
arch/arm/boot/dts/ls1021a-twr.dts | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts
index 75ecaed..eec920b 100644
--- a/arch/arm/boot/dts/ls1021a-twr.dts
+++ b/arch/arm/boot/dts/ls1021a-twr.dts
@@ -108,12 +108,22 @@
panel: panel {
compatible = "nec,nl4827hc19-05b";
+ port@0 {
+ panel_out: endpoint {
+ remote-endpoint = <&dcu_out>;
+ };
+ };
};
};
&dcu {
- fsl,panel = <&panel>;
status = "okay";
+
+ port: port@0 {
+ dcu_out: endpoint {
+ remote-endpoint = <&panel_out>;
+ };
+ };
};
&dspi1 {
--
2.1.0.27.g96db324
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/fsl-dcu: update the panel dt binding document
[not found] ` <1467106748-19314-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
2016-06-28 9:39 ` [PATCH 2/2] drm/fsl-dcu: update panel syntax to of_graph dt binding Meng Yi
@ 2016-06-28 21:07 ` Rob Herring
2016-06-28 21:18 ` Stefan Agner
1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2016-06-28 21:07 UTC (permalink / raw)
To: Meng Yi
Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A, stefan-XLVq0VzYD2Y,
airlied-cv59FeDIM0c, emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w,
jianwei.wang.chn-Re5JQEeQqe8AvxtiuMwx3w,
alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
devicetree-u79uwXL29TY76Z2rM5mHXA
On Tue, Jun 28, 2016 at 05:39:07PM +0800, Meng Yi wrote:
> dropped the old "fsl,panel" property, using the of_graph dt
> binding syntax
>
> Signed-off-by: Meng Yi <meng.yi-3arQi8VN3Tc@public.gmane.org>
> ---
> Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt b/Documentation/devicetree/bindings/display/fsl,dcu.txt
> index ae55cde..f44cf5b 100644
> --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt
> +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt
> @@ -12,7 +12,7 @@ Required properties:
> - clock-names: Should be "dcu" and "pix"
> See ../clocks/clock-bindings.txt for details.
> - big-endian Boolean property, LS1021A DCU registers are big-endian.
> -- fsl,panel: The phandle to panel node.
> +- port Video port for the panel output
>
> Optional properties:
> - fsl,tcon: The phandle to the timing controller node.
> @@ -24,6 +24,11 @@ dcu: dcu@2ce0000 {
> clocks = <&platform_clk 0>, <&platform_clk 0>;
> clock-names = "dcu", "pix";
> big-endian;
> - fsl,panel = <&panel>;
> fsl,tcon = <&tcon>;
> +
> + port: port@0 {
Drop the unit address. With that,
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> + dcu_out: endpoint {
> + remote-endpoint = <&panel_out>;
> + };
> + };
> };
> --
> 2.1.0.27.g96db324
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/fsl-dcu: update the panel dt binding document
2016-06-28 21:07 ` [PATCH 1/2] drm/fsl-dcu: update the panel dt binding document Rob Herring
@ 2016-06-28 21:18 ` Stefan Agner
[not found] ` <8e8820c0ccfa8e1348a038959da850f8-XLVq0VzYD2Y@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Agner @ 2016-06-28 21:18 UTC (permalink / raw)
To: Rob Herring
Cc: jianwei.wang.chn, Meng Yi, devicetree, emil.l.velikov, dri-devel,
shawnguo, alexander.stein
On 2016-06-28 14:07, Rob Herring wrote:
> On Tue, Jun 28, 2016 at 05:39:07PM +0800, Meng Yi wrote:
>> dropped the old "fsl,panel" property, using the of_graph dt
>> binding syntax
>>
>> Signed-off-by: Meng Yi <meng.yi@nxp.com>
>> ---
>> Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt b/Documentation/devicetree/bindings/display/fsl,dcu.txt
>> index ae55cde..f44cf5b 100644
>> --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt
>> +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt
>> @@ -12,7 +12,7 @@ Required properties:
>> - clock-names: Should be "dcu" and "pix"
>> See ../clocks/clock-bindings.txt for details.
>> - big-endian Boolean property, LS1021A DCU registers are big-endian.
>> -- fsl,panel: The phandle to panel node.
>> +- port Video port for the panel output
>>
>> Optional properties:
>> - fsl,tcon: The phandle to the timing controller node.
>> @@ -24,6 +24,11 @@ dcu: dcu@2ce0000 {
>> clocks = <&platform_clk 0>, <&platform_clk 0>;
>> clock-names = "dcu", "pix";
>> big-endian;
>> - fsl,panel = <&panel>;
>> fsl,tcon = <&tcon>;
>> +
>> + port: port@0 {
>
> Drop the unit address. With that,
I was going to say add a corresponding reg property and specify
address-cells.
So is it ok to also create a port without address?
If yes, we should probably be consistent and also not use the unit
address in patch 2/2 (since that panel also has only one port).
--
Stefan
>
> Acked-by: Rob Herring <robh@kernel.org>
>
>> + dcu_out: endpoint {
>> + remote-endpoint = <&panel_out>;
>> + };
>> + };
>> };
>> --
>> 2.1.0.27.g96db324
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] drm/fsl-dcu: update the panel dt binding document
[not found] ` <8e8820c0ccfa8e1348a038959da850f8-XLVq0VzYD2Y@public.gmane.org>
@ 2016-06-29 2:58 ` Meng Yi
[not found] ` <HE1PR04MB1051B76708D9E3F0F3DB4C56EC230-6LN7OEpIatUZ5NoXM8MaPs9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Meng Yi @ 2016-06-29 2:58 UTC (permalink / raw)
To: Stefan Agner, Rob Herring
Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A, airlied-cv59FeDIM0c,
emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w,
jianwei.wang.chn-Re5JQEeQqe8AvxtiuMwx3w,
alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
devicetree-u79uwXL29TY76Z2rM5mHXA
> >> Optional properties:
> >> - fsl,tcon: The phandle to the timing controller node.
> >> @@ -24,6 +24,11 @@ dcu: dcu@2ce0000 {
> >> clocks = <&platform_clk 0>, <&platform_clk 0>;
> >> clock-names = "dcu", "pix";
> >> big-endian;
> >> - fsl,panel = <&panel>;
> >> fsl,tcon = <&tcon>;
> >> +
> >> + port: port@0 {
> >
> > Drop the unit address. With that,
>
> I was going to say add a corresponding reg property and specify address-cells.
>
For now, we only have one 'remote-endpoint', you mean maybe we should
use 'ports' that prepare for multiple connections?
> So is it ok to also create a port without address?
>
It works fine, I think it is ok.
Best Regards,
Meng
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] drm/fsl-dcu: update the panel dt binding document
[not found] ` <HE1PR04MB1051B76708D9E3F0F3DB4C56EC230-6LN7OEpIatUZ5NoXM8MaPs9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2016-06-29 5:40 ` Stefan Agner
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Agner @ 2016-06-29 5:40 UTC (permalink / raw)
To: Meng Yi
Cc: Rob Herring, shawnguo-DgEjT+Ai2ygdnm+yROfE0A,
airlied-cv59FeDIM0c, emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w,
jianwei.wang.chn-Re5JQEeQqe8AvxtiuMwx3w,
alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
devicetree-u79uwXL29TY76Z2rM5mHXA
On 2016-06-28 19:58, Meng Yi wrote:
>> >> Optional properties:
>> >> - fsl,tcon: The phandle to the timing controller node.
>> >> @@ -24,6 +24,11 @@ dcu: dcu@2ce0000 {
>> >> clocks = <&platform_clk 0>, <&platform_clk 0>;
>> >> clock-names = "dcu", "pix";
>> >> big-endian;
>> >> - fsl,panel = <&panel>;
>> >> fsl,tcon = <&tcon>;
>> >> +
>> >> + port: port@0 {
>> >
>> > Drop the unit address. With that,
>>
>> I was going to say add a corresponding reg property and specify address-cells.
>>
>
> For now, we only have one 'remote-endpoint', you mean maybe we should
> use 'ports' that prepare for multiple connections?
>
I ment to add the address because most drivers do. But then, most
drivers support multiple ports.
>> So is it ok to also create a port without address?
>>
>
> It works fine, I think it is ok.
I guess it is ok too since Rob suggested it. However, consequently I
also would drop the unit address of the port node inside the panel node.
--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-29 5:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-28 9:39 [PATCH 1/2] drm/fsl-dcu: update the panel dt binding document Meng Yi
[not found] ` <1467106748-19314-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
2016-06-28 9:39 ` [PATCH 2/2] drm/fsl-dcu: update panel syntax to of_graph dt binding Meng Yi
2016-06-28 21:07 ` [PATCH 1/2] drm/fsl-dcu: update the panel dt binding document Rob Herring
2016-06-28 21:18 ` Stefan Agner
[not found] ` <8e8820c0ccfa8e1348a038959da850f8-XLVq0VzYD2Y@public.gmane.org>
2016-06-29 2:58 ` Meng Yi
[not found] ` <HE1PR04MB1051B76708D9E3F0F3DB4C56EC230-6LN7OEpIatUZ5NoXM8MaPs9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-06-29 5:40 ` Stefan Agner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.