* [PATCH 1/3] dt-bindings: phy: Fix description of Tegra210 PHY nodes
2016-06-29 11:07 ` Jon Hunter
@ 2016-06-29 11:07 ` Jon Hunter
-1 siblings, 0 replies; 12+ messages in thread
From: Jon Hunter @ 2016-06-29 11:07 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding, Alexandre Courbot
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jon Hunter
The dt-binding document for the Tegra XUSB pad controller states that
'utmi' is one of the valid choices for the Tegra210 PHY node names and
has child lanes named, 'utmi-0', 'utmi-1', 'utmi-2' and 'utmi-3'.
However, neither the XUSB pad controller PHY driver or the actual
Tegra210 binding for the XUSB pad controller use these names. Instead
both the driver and binding use the node name 'usb2' and for the child
lanes use the names 'usb2-0', 'usb2-1', 'usb2-2' and 'usb2-3'. Given
that the driver and binding are consistent with the naming, up date the
dt-binding documentation to match.
Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
index 0bf1ae243552..3742c152c467 100644
--- a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
+++ b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
@@ -124,7 +124,7 @@ For Tegra124 and Tegra132, the list of valid PHY nodes is given below:
- functions: "usb3-ss", "sata"
For Tegra210, the list of valid PHY nodes is given below:
-- utmi: utmi-0, utmi-1, utmi-2, utmi-3
+- usb2: usb2-0, usb2-1, usb2-2, usb2-3
- functions: "snps", "xusb", "uart"
- hsic: hsic-0, hsic-1
- functions: "snps", "xusb"
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/3] dt-bindings: phy: Fix description of Tegra210 PHY nodes
@ 2016-06-29 11:07 ` Jon Hunter
0 siblings, 0 replies; 12+ messages in thread
From: Jon Hunter @ 2016-06-29 11:07 UTC (permalink / raw)
To: linux-arm-kernel
The dt-binding document for the Tegra XUSB pad controller states that
'utmi' is one of the valid choices for the Tegra210 PHY node names and
has child lanes named, 'utmi-0', 'utmi-1', 'utmi-2' and 'utmi-3'.
However, neither the XUSB pad controller PHY driver or the actual
Tegra210 binding for the XUSB pad controller use these names. Instead
both the driver and binding use the node name 'usb2' and for the child
lanes use the names 'usb2-0', 'usb2-1', 'usb2-2' and 'usb2-3'. Given
that the driver and binding are consistent with the naming, up date the
dt-binding documentation to match.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
index 0bf1ae243552..3742c152c467 100644
--- a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
+++ b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
@@ -124,7 +124,7 @@ For Tegra124 and Tegra132, the list of valid PHY nodes is given below:
- functions: "usb3-ss", "sata"
For Tegra210, the list of valid PHY nodes is given below:
-- utmi: utmi-0, utmi-1, utmi-2, utmi-3
+- usb2: usb2-0, usb2-1, usb2-2, usb2-3
- functions: "snps", "xusb", "uart"
- hsic: hsic-0, hsic-1
- functions: "snps", "xusb"
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
[parent not found: <1467198453-23406-2-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH 1/3] dt-bindings: phy: Fix description of Tegra210 PHY nodes
2016-06-29 11:07 ` Jon Hunter
@ 2016-07-01 1:41 ` Rob Herring
-1 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2016-07-01 1:41 UTC (permalink / raw)
To: Jon Hunter
Cc: Stephen Warren, Thierry Reding, Alexandre Courbot,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Wed, Jun 29, 2016 at 12:07:31PM +0100, Jon Hunter wrote:
> The dt-binding document for the Tegra XUSB pad controller states that
> 'utmi' is one of the valid choices for the Tegra210 PHY node names and
> has child lanes named, 'utmi-0', 'utmi-1', 'utmi-2' and 'utmi-3'.
> However, neither the XUSB pad controller PHY driver or the actual
> Tegra210 binding for the XUSB pad controller use these names. Instead
> both the driver and binding use the node name 'usb2' and for the child
> lanes use the names 'usb2-0', 'usb2-1', 'usb2-2' and 'usb2-3'. Given
> that the driver and binding are consistent with the naming, up date the
> dt-binding documentation to match.
>
> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/3] dt-bindings: phy: Fix description of Tegra210 PHY nodes
@ 2016-07-01 1:41 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2016-07-01 1:41 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 29, 2016 at 12:07:31PM +0100, Jon Hunter wrote:
> The dt-binding document for the Tegra XUSB pad controller states that
> 'utmi' is one of the valid choices for the Tegra210 PHY node names and
> has child lanes named, 'utmi-0', 'utmi-1', 'utmi-2' and 'utmi-3'.
> However, neither the XUSB pad controller PHY driver or the actual
> Tegra210 binding for the XUSB pad controller use these names. Instead
> both the driver and binding use the node name 'usb2' and for the child
> lanes use the names 'usb2-0', 'usb2-1', 'usb2-2' and 'usb2-3'. Given
> that the driver and binding are consistent with the naming, up date the
> dt-binding documentation to match.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/3] dt-bindings: usb: Fix Tegra XUSB example
2016-06-29 11:07 ` Jon Hunter
@ 2016-06-29 11:07 ` Jon Hunter
-1 siblings, 0 replies; 12+ messages in thread
From: Jon Hunter @ 2016-06-29 11:07 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding, Alexandre Courbot
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jon Hunter
The example binding for the Tegra XUSB omits the 'lane' subnode in the
XUSB pad controller path which is required according to the binding
documentation for the Tegra XUSB pad controller [0]. In addition to this
the phy-names with the suffix 'utmi' are also not valid and should have
the suffix 'usb2'. Correct both the XUSB pad controller pad path and
phy-names for the XUSB example.
[0] Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
index d28295a3e55f..3eee9e505400 100644
--- a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
@@ -104,10 +104,10 @@ Example:
nvidia,xusb-padctl = <&padctl>;
- phys = <&{/padctl@0,7009f000/pads/usb2/usb2-1}>, /* mini-PCIe USB */
- <&{/padctl@0,7009f000/pads/usb2/usb2-2}>, /* USB A */
- <&{/padctl@0,7009f000/pads/pcie/pcie-0}>; /* USB A */
- phy-names = "utmi-1", "utmi-2", "usb3-0";
+ phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
+ <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
+ <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
+ phy-names = "usb2-1", "usb2-2", "usb3-0";
avddio-pex-supply = <&vdd_1v05_run>;
dvddio-pex-supply = <&vdd_1v05_run>;
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/3] dt-bindings: usb: Fix Tegra XUSB example
@ 2016-06-29 11:07 ` Jon Hunter
0 siblings, 0 replies; 12+ messages in thread
From: Jon Hunter @ 2016-06-29 11:07 UTC (permalink / raw)
To: linux-arm-kernel
The example binding for the Tegra XUSB omits the 'lane' subnode in the
XUSB pad controller path which is required according to the binding
documentation for the Tegra XUSB pad controller [0]. In addition to this
the phy-names with the suffix 'utmi' are also not valid and should have
the suffix 'usb2'. Correct both the XUSB pad controller pad path and
phy-names for the XUSB example.
[0] Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
index d28295a3e55f..3eee9e505400 100644
--- a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
@@ -104,10 +104,10 @@ Example:
nvidia,xusb-padctl = <&padctl>;
- phys = <&{/padctl@0,7009f000/pads/usb2/usb2-1}>, /* mini-PCIe USB */
- <&{/padctl@0,7009f000/pads/usb2/usb2-2}>, /* USB A */
- <&{/padctl@0,7009f000/pads/pcie/pcie-0}>; /* USB A */
- phy-names = "utmi-1", "utmi-2", "usb3-0";
+ phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
+ <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
+ <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
+ phy-names = "usb2-1", "usb2-2", "usb3-0";
avddio-pex-supply = <&vdd_1v05_run>;
dvddio-pex-supply = <&vdd_1v05_run>;
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] arm64: tegra: Correct Tegra210 XUSB mailbox interrupt
2016-06-29 11:07 ` Jon Hunter
@ 2016-06-29 11:07 ` Jon Hunter
-1 siblings, 0 replies; 12+ messages in thread
From: Jon Hunter @ 2016-06-29 11:07 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding, Alexandre Courbot
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jon Hunter
The XUSB mailbox interrupt for Tegra210 is 40 and not 49 which is for
the XUSB pad controller. For some Tegra210 boards, this is causing USB
connect and disconnect events to go undetected. Fix this by changing the
interrupt number for the XUSB mailbox to 40.
Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
index efb0fd98b789..6bc60ea95d16 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
@@ -740,7 +740,7 @@
reg-names = "hcd", "fpci", "ipfs";
interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
+ <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&tegra_car TEGRA210_CLK_XUSB_HOST>,
<&tegra_car TEGRA210_CLK_XUSB_HOST_SRC>,
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] arm64: tegra: Correct Tegra210 XUSB mailbox interrupt
@ 2016-06-29 11:07 ` Jon Hunter
0 siblings, 0 replies; 12+ messages in thread
From: Jon Hunter @ 2016-06-29 11:07 UTC (permalink / raw)
To: linux-arm-kernel
The XUSB mailbox interrupt for Tegra210 is 40 and not 49 which is for
the XUSB pad controller. For some Tegra210 boards, this is causing USB
connect and disconnect events to go undetected. Fix this by changing the
interrupt number for the XUSB mailbox to 40.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
index efb0fd98b789..6bc60ea95d16 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
@@ -740,7 +740,7 @@
reg-names = "hcd", "fpci", "ipfs";
interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
+ <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&tegra_car TEGRA210_CLK_XUSB_HOST>,
<&tegra_car TEGRA210_CLK_XUSB_HOST_SRC>,
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] Fixes for Tegra XUSB
2016-06-29 11:07 ` Jon Hunter
@ 2016-06-30 9:30 ` Thierry Reding
-1 siblings, 0 replies; 12+ messages in thread
From: Thierry Reding @ 2016-06-30 9:30 UTC (permalink / raw)
To: Jon Hunter
Cc: Stephen Warren, Alexandre Courbot,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]
On Wed, Jun 29, 2016 at 12:07:30PM +0100, Jon Hunter wrote:
> Fixes for Tegra XUSB dt-binding documentation and the XUSB mailbox
> interrupt.
>
> When testing XUSB on the Tegra210 Smaug, I found that USB connect and
> disconnect events were not being seen. I have debug this and found that
> the XUSB mailbox is incorrect and I was never receiving any interrupts
> from the XUSB mailbox. Interestingly, this behaviour is not seen on the
> Tegra210 Jetson TX1 despite the fact that there were no mailbox
> interrupts. The two boards have different USB connectors and so may be
> the connection is slightly different. After fixing the mailbox interrupt
> both boards now receive interrupts from the XUSB mailbox as expected.
>
> Jon Hunter (3):
> dt-bindings: phy: Fix description of Tegra210 PHY nodes
> dt-bindings: usb: Fix Tegra XUSB example
> arm64: tegra: Correct Tegra210 XUSB mailbox interrupt
>
> .../devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt | 2 +-
> Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt | 8 ++++----
> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
All applied to for-4.8/dt-bindings (1 and 2) and for-4.8/arm64 (3).
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/3] Fixes for Tegra XUSB
@ 2016-06-30 9:30 ` Thierry Reding
0 siblings, 0 replies; 12+ messages in thread
From: Thierry Reding @ 2016-06-30 9:30 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 29, 2016 at 12:07:30PM +0100, Jon Hunter wrote:
> Fixes for Tegra XUSB dt-binding documentation and the XUSB mailbox
> interrupt.
>
> When testing XUSB on the Tegra210 Smaug, I found that USB connect and
> disconnect events were not being seen. I have debug this and found that
> the XUSB mailbox is incorrect and I was never receiving any interrupts
> from the XUSB mailbox. Interestingly, this behaviour is not seen on the
> Tegra210 Jetson TX1 despite the fact that there were no mailbox
> interrupts. The two boards have different USB connectors and so may be
> the connection is slightly different. After fixing the mailbox interrupt
> both boards now receive interrupts from the XUSB mailbox as expected.
>
> Jon Hunter (3):
> dt-bindings: phy: Fix description of Tegra210 PHY nodes
> dt-bindings: usb: Fix Tegra XUSB example
> arm64: tegra: Correct Tegra210 XUSB mailbox interrupt
>
> .../devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt | 2 +-
> Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt | 8 ++++----
> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
All applied to for-4.8/dt-bindings (1 and 2) and for-4.8/arm64 (3).
Thanks,
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160630/1317ddaf/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread