All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <stephen.boyd@linaro.org>
To: Roger Quadros <rogerq@ti.com>, Chanwoo Choi <cw00.choi@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware
Date: Wed, 29 Jun 2016 11:51:26 -0700	[thread overview]
Message-ID: <146722628645.16253.7225962760627246499@sboyd-linaro> (raw)
In-Reply-To: <57736671.6090800@ti.com>

Quoting Roger Quadros (2016-06-28 23:10:57)
> On 29/06/16 01:01, Stephen Boyd wrote:
> > Quoting Roger Quadros (2016-06-28 02:13:57)
> >> On 28/06/16 11:47, Stephen Boyd wrote:
> >>>
> >>> Sorry I must have confused you. There are two modules in the PMIC that
> >>> are doing detection here. The charger module is detecting the VBUS event
> >>> and this misc module is detecting the ID pin. I'm not sure why they're
> >>> two different blocks, but it is what it is in the hardware.
> >>>
> >> OK. Can the MISC block do anything else other than USB ID?
> > 
> > Yes.
> > 
> >> Does the USB ID interrupt come on a different line than the charger interrupt?
> > 
> > Yes.
> > 
> 
> OK. Is it better to have this driver somewhere in drivers/mfd or drivers/misc if the
> other function doesn't need/use extcon?
> 

If/when the other functionality is used by the kernel we can consider
moving this driver somewhere else. As there currently isn't any other
usage of this device node I implemented it in the extcon directory to be
explicit about the usage.

WARNING: multiple messages have this Message-ID (diff)
From: stephen.boyd@linaro.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware
Date: Wed, 29 Jun 2016 11:51:26 -0700	[thread overview]
Message-ID: <146722628645.16253.7225962760627246499@sboyd-linaro> (raw)
In-Reply-To: <57736671.6090800@ti.com>

Quoting Roger Quadros (2016-06-28 23:10:57)
> On 29/06/16 01:01, Stephen Boyd wrote:
> > Quoting Roger Quadros (2016-06-28 02:13:57)
> >> On 28/06/16 11:47, Stephen Boyd wrote:
> >>>
> >>> Sorry I must have confused you. There are two modules in the PMIC that
> >>> are doing detection here. The charger module is detecting the VBUS event
> >>> and this misc module is detecting the ID pin. I'm not sure why they're
> >>> two different blocks, but it is what it is in the hardware.
> >>>
> >> OK. Can the MISC block do anything else other than USB ID?
> > 
> > Yes.
> > 
> >> Does the USB ID interrupt come on a different line than the charger interrupt?
> > 
> > Yes.
> > 
> 
> OK. Is it better to have this driver somewhere in drivers/mfd or drivers/misc if the
> other function doesn't need/use extcon?
> 

If/when the other functionality is used by the kernel we can consider
moving this driver somewhere else. As there currently isn't any other
usage of this device node I implemented it in the extcon directory to be
explicit about the usage.

  reply	other threads:[~2016-06-29 18:51 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-26  5:56 [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd
2016-06-26  5:56 ` Stephen Boyd
2016-06-26 11:20 ` Chanwoo Choi
2016-06-26 11:20   ` Chanwoo Choi
2016-06-26 11:22   ` Chanwoo Choi
2016-06-26 11:22     ` Chanwoo Choi
2016-06-26 11:22     ` Chanwoo Choi
2016-06-27 19:11   ` Stephen Boyd
2016-06-27 19:11     ` Stephen Boyd
2016-06-28 12:06     ` Chanwoo Choi
2016-06-28 12:06       ` Chanwoo Choi
2016-06-28 21:59       ` Stephen Boyd
2016-06-28 21:59         ` Stephen Boyd
2016-06-29  6:25         ` Chanwoo Choi
2016-06-29  6:25           ` Chanwoo Choi
2016-06-29 18:48           ` Stephen Boyd
2016-06-29 18:48             ` Stephen Boyd
2016-06-29 18:48             ` Stephen Boyd
2016-06-30  0:35             ` Chanwoo Choi
2016-06-30  0:35               ` Chanwoo Choi
2016-06-30  1:04               ` Stephen Boyd
2016-06-30  1:04                 ` Stephen Boyd
2016-06-27  7:39 ` Roger Quadros
2016-06-27  7:39   ` Roger Quadros
2016-06-27  7:39   ` Roger Quadros
2016-06-27 19:30   ` Stephen Boyd
2016-06-27 19:30     ` Stephen Boyd
2016-06-27 19:30     ` Stephen Boyd
2016-06-28  6:36     ` Roger Quadros
2016-06-28  6:36       ` Roger Quadros
2016-06-28  6:36       ` Roger Quadros
2016-06-28  8:47       ` Stephen Boyd
2016-06-28  8:47         ` Stephen Boyd
2016-06-28  9:13         ` Roger Quadros
2016-06-28  9:13           ` Roger Quadros
2016-06-28  9:13           ` Roger Quadros
2016-06-28 22:01           ` Stephen Boyd
2016-06-28 22:01             ` Stephen Boyd
2016-06-29  6:10             ` Roger Quadros
2016-06-29  6:10               ` Roger Quadros
2016-06-29  6:10               ` Roger Quadros
2016-06-29 18:51               ` Stephen Boyd [this message]
2016-06-29 18:51                 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=146722628645.16253.7225962760627246499@sboyd-linaro \
    --to=stephen.boyd@linaro.org \
    --cc=cw00.choi@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.