* [U-Boot] [PATCH v2] powerpc: MPC8544DS: revert typo in I2C offset value
@ 2016-06-29 23:44 York Sun
2016-07-01 2:01 ` Joe Hershberger
0 siblings, 1 reply; 2+ messages in thread
From: York Sun @ 2016-06-29 23:44 UTC (permalink / raw)
To: u-boot
From: Benjamin Kamath <bkamath@spaceflight.com>
I2C offset was changed by commit 00f792e0 (added multibus support)
from 0x3100 to 0x3000. This typo leads to error when reading SPD
from DDR DIMMs.
Signed-off-by: Benjamin Kamath <bkamath@spaceflight.com>
Signed-off-by: York Sun <york.sun@nxp.com>
---
Changes in v2:
Add short summary of commit 00f792e0.
include/configs/MPC8544DS.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/MPC8544DS.h b/include/configs/MPC8544DS.h
index b9d97c1..321f71e 100644
--- a/include/configs/MPC8544DS.h
+++ b/include/configs/MPC8544DS.h
@@ -209,7 +209,7 @@ extern unsigned long get_board_sys_clk(unsigned long dummy);
#define CONFIG_SYS_I2C_FSL
#define CONFIG_SYS_FSL_I2C_SPEED 400000
#define CONFIG_SYS_FSL_I2C_SLAVE 0x7F
-#define CONFIG_SYS_FSL_I2C_OFFSET 0x3000
+#define CONFIG_SYS_FSL_I2C_OFFSET 0x3100
#define CONFIG_SYS_I2C_NOPROBES { {0, 0x69} }
#define CONFIG_SYS_I2C_EEPROM_ADDR 0x57
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH v2] powerpc: MPC8544DS: revert typo in I2C offset value
2016-06-29 23:44 [U-Boot] [PATCH v2] powerpc: MPC8544DS: revert typo in I2C offset value York Sun
@ 2016-07-01 2:01 ` Joe Hershberger
0 siblings, 0 replies; 2+ messages in thread
From: Joe Hershberger @ 2016-07-01 2:01 UTC (permalink / raw)
To: u-boot
On Wed, Jun 29, 2016 at 6:44 PM, York Sun <york.sun@nxp.com> wrote:
> From: Benjamin Kamath <bkamath@spaceflight.com>
>
> I2C offset was changed by commit 00f792e0 (added multibus support)
> from 0x3100 to 0x3000. This typo leads to error when reading SPD
> from DDR DIMMs.
>
> Signed-off-by: Benjamin Kamath <bkamath@spaceflight.com>
> Signed-off-by: York Sun <york.sun@nxp.com>
Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-01 2:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-29 23:44 [U-Boot] [PATCH v2] powerpc: MPC8544DS: revert typo in I2C offset value York Sun
2016-07-01 2:01 ` Joe Hershberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.