All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Emese Revfy <re.emese@gmail.com>
Cc: kernel-hardening@lists.openwall.com, pageexec@freemail.hu,
	spender@grsecurity.net, mmarek@suse.com, keescook@chromium.org,
	linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com,
	linux-kbuild@vger.kernel.org, minipli@ld-linux.so,
	linux@armlinux.org.uk, catalin.marinas@arm.com,
	linux@rasmusvillemoes.dk, david.brown@linaro.org,
	benh@kernel.crashing.org, tglx@linutronix.de,
	akpm@linux-foundation.org, jlayton@poochiereds.net,
	arnd@arndb.de
Subject: Re: [PATCH v1 2/2] Mark functions with the __nocapture attribute
Date: Wed, 29 Jun 2016 17:12:45 -0700	[thread overview]
Message-ID: <1467245565.24287.115.camel@perches.com> (raw)
In-Reply-To: <20160629204204.859692ea2b7f570260ed18a0@gmail.com>

On Wed, 2016-06-29 at 20:42 +0200, Emese Revfy wrote:
> On Tue, 28 Jun 2016 14:00:57 -0700 Joe Perches <joe@perches.com> wrote:
> > On Tue, 2016-06-28 at 22:40 +0200, Emese Revfy wrote:
> > > On Tue, 28 Jun 2016 09:43:31 -0700 Joe Perches <joe@perches.com> wrote:
> > > > On Tue, 2016-06-28 at 13:36 +0200, Emese Revfy wrote:
> > > > > The nocapture gcc attribute can be on functions only.
> > > > > The attribute takes one or more unsigned integer constants as parameters
> > > > > that specify the function argument(s) of const char* type to initify.
> > > > Perhaps this should be const <void>*
> > > For me function arguments are the values passed to a function call so
> > > the const char* type is good because this is the only one that the plugin handles
> > > (for now at least).
> > OK, but this function prototype specified takes a const void *
> > 
> > +extern void * memcpy(void *, const void *, __kernel_size_t) __nocapture(2);
> What matters for the plugin is the type of the passed arguments (which can be const char*
> in the current implementation), not that of the parameters.

And how does this work when the prototype requires the compiler to
implicit cast to const void * before calling the function?

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Emese Revfy <re.emese@gmail.com>
Cc: kernel-hardening@lists.openwall.com, pageexec@freemail.hu,
	spender@grsecurity.net, mmarek@suse.com, keescook@chromium.org,
	linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com,
	linux-kbuild@vger.kernel.org, minipli@ld-linux.so,
	linux@armlinux.org.uk, catalin.marinas@arm.com,
	linux@rasmusvillemoes.dk, david.brown@linaro.org,
	benh@kernel.crashing.org, tglx@linutronix.de,
	akpm@linux-foundation.org, jlayton@poochiereds.net,
	arnd@arndb.de
Subject: [kernel-hardening] Re: [PATCH v1 2/2] Mark functions with the __nocapture attribute
Date: Wed, 29 Jun 2016 17:12:45 -0700	[thread overview]
Message-ID: <1467245565.24287.115.camel@perches.com> (raw)
In-Reply-To: <20160629204204.859692ea2b7f570260ed18a0@gmail.com>

On Wed, 2016-06-29 at 20:42 +0200, Emese Revfy wrote:
> On Tue, 28 Jun 2016 14:00:57 -0700 Joe Perches <joe@perches.com> wrote:
> > On Tue, 2016-06-28 at 22:40 +0200, Emese Revfy wrote:
> > > On Tue, 28 Jun 2016 09:43:31 -0700 Joe Perches <joe@perches.com> wrote:
> > > > On Tue, 2016-06-28 at 13:36 +0200, Emese Revfy wrote:
> > > > > The nocapture gcc attribute can be on functions only.
> > > > > The attribute takes one or more unsigned integer constants as parameters
> > > > > that specify the function argument(s) of const char* type to initify.
> > > > Perhaps this should be const <void>*
> > > For me function arguments are the values passed to a function call so
> > > the const char* type is good because this is the only one that the plugin handles
> > > (for now at least).
> > OK, but this function prototype specified takes a const void *
> > 
> > +extern void * memcpy(void *, const void *, __kernel_size_t) __nocapture(2);
> What matters for the plugin is the type of the passed arguments (which can be const char*
> in the current implementation), not that of the parameters.

And how does this work when the prototype requires the compiler to
implicit cast to const void * before calling the function?

  reply	other threads:[~2016-06-30  0:12 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 11:34 [PATCH v1 0/2] Introduce the initify gcc plugin Emese Revfy
2016-06-28 11:34 ` [kernel-hardening] " Emese Revfy
2016-06-28 11:35 ` [PATCH v1 1/2] Add " Emese Revfy
2016-06-28 11:35   ` [kernel-hardening] " Emese Revfy
2016-06-28 21:05   ` Rasmus Villemoes
2016-06-28 21:05     ` [kernel-hardening] " Rasmus Villemoes
2016-06-29 14:50     ` Kees Cook
2016-06-29 14:50       ` [kernel-hardening] " Kees Cook
2016-06-29 14:50       ` Kees Cook
2016-06-29 19:03     ` Emese Revfy
2016-06-29 19:03       ` [kernel-hardening] " Emese Revfy
2016-06-28 11:36 ` [PATCH v1 2/2] Mark functions with the __nocapture attribute Emese Revfy
2016-06-28 11:36   ` [kernel-hardening] " Emese Revfy
2016-06-28 16:43   ` Joe Perches
2016-06-28 16:43     ` [kernel-hardening] " Joe Perches
2016-06-28 20:40     ` Emese Revfy
2016-06-28 20:40       ` [kernel-hardening] " Emese Revfy
2016-06-28 21:00       ` Joe Perches
2016-06-28 21:00         ` [kernel-hardening] " Joe Perches
2016-06-29 18:42         ` Emese Revfy
2016-06-29 18:42           ` [kernel-hardening] " Emese Revfy
2016-06-30  0:12           ` Joe Perches [this message]
2016-06-30  0:12             ` Joe Perches
2016-07-01 14:03             ` Emese Revfy
2016-07-01 14:03               ` [kernel-hardening] " Emese Revfy
2016-06-28 20:50   ` Rasmus Villemoes
2016-06-28 20:50     ` [kernel-hardening] " Rasmus Villemoes
2016-06-28 21:38     ` PaX Team
2016-06-28 21:38       ` [kernel-hardening] " PaX Team
2016-06-28 22:41       ` Rasmus Villemoes
2016-06-28 22:41         ` [kernel-hardening] " Rasmus Villemoes
2016-06-29 18:39     ` Emese Revfy
2016-06-29 18:39       ` [kernel-hardening] " Emese Revfy
2016-06-28 11:42 ` [PATCH v1 0/2] Introduce the initify gcc plugin Emese Revfy
2016-06-28 11:42   ` [kernel-hardening] " Emese Revfy
2016-06-28 12:57 ` [kernel-hardening] " Mark Rutland
2016-06-28 16:14   ` Emese Revfy
2016-06-28 20:46     ` Kees Cook
2016-06-28 20:46       ` Kees Cook
2016-06-29  8:21       ` Mark Rutland
2016-06-29  8:21         ` Mark Rutland
2016-06-29 17:52         ` Mark Rutland
2016-06-29 17:52           ` Mark Rutland
2016-06-29 18:28           ` Emese Revfy
2016-06-29 18:28             ` Emese Revfy
2016-06-28 16:35 ` Joe Perches
2016-06-28 16:35   ` [kernel-hardening] " Joe Perches
2016-06-28 18:48   ` Joe Perches
2016-06-28 18:48     ` [kernel-hardening] " Joe Perches
2016-06-28 19:02     ` Rasmus Villemoes
2016-06-28 19:02       ` [kernel-hardening] " Rasmus Villemoes
2016-06-28 20:29       ` Emese Revfy
2016-06-28 20:29         ` [kernel-hardening] " Emese Revfy
2016-06-28 17:00 ` Mathias Krause
2016-06-28 17:00   ` [kernel-hardening] " Mathias Krause
2016-06-28 20:29   ` Emese Revfy
2016-06-28 20:29     ` [kernel-hardening] " Emese Revfy
2016-06-28 21:49 ` Joe Perches
2016-06-28 21:49   ` [kernel-hardening] " Joe Perches
2016-06-28 22:07   ` Valdis.Kletnieks
2016-06-28 23:54     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467245565.24287.115.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=david.brown@linaro.org \
    --cc=jlayton@poochiereds.net \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linux@rasmusvillemoes.dk \
    --cc=minipli@ld-linux.so \
    --cc=mmarek@suse.com \
    --cc=pageexec@freemail.hu \
    --cc=re.emese@gmail.com \
    --cc=spender@grsecurity.net \
    --cc=tglx@linutronix.de \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.