* [PATCH] efi: arm64: add debugfs node to dump UEFI runtime page tables
@ 2016-06-30 10:01 ` Ard Biesheuvel
0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2016-06-30 10:01 UTC (permalink / raw)
To: linux-arm-kernel, linux-efi, catalin.marinas, mark.rutland, matt
Cc: leif.lindholm, Ard Biesheuvel
Register the debugfs node 'efi_page_tables' to allow the UEFI runtime
page tables to be inspected. Note that ARM does not have 'asm/ptdump.h'
[yet] so for now, this is arm64 only.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
This patch could be helpful in assessing the series 'arm64: avoid block
entries that we need to split later' that I sent out yesterday.
drivers/firmware/efi/arm-runtime.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
index 17ccf0a8787a..4197a1da013d 100644
--- a/drivers/firmware/efi/arm-runtime.c
+++ b/drivers/firmware/efi/arm-runtime.c
@@ -39,6 +39,26 @@ static struct mm_struct efi_mm = {
.mmlist = LIST_HEAD_INIT(efi_mm.mmlist),
};
+#ifdef CONFIG_ARM64
+#include <asm/ptdump.h>
+
+static struct ptdump_info efi_ptdump_info = {
+ .mm = &efi_mm,
+ .markers = (struct addr_marker[]){
+ { 0, "UEFI runtime start" },
+ { TASK_SIZE_64, "UEFI runtime end" }
+ },
+ .base_addr = 0,
+};
+
+static int __init ptdump_init(void)
+{
+ return ptdump_register(&efi_ptdump_info, "efi_page_tables");
+}
+device_initcall(ptdump_init);
+
+#endif
+
static bool __init efi_virtmap_init(void)
{
efi_memory_desc_t *md;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] efi: arm64: add debugfs node to dump UEFI runtime page tables
@ 2016-06-30 10:01 ` Ard Biesheuvel
0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2016-06-30 10:01 UTC (permalink / raw)
To: linux-arm-kernel
Register the debugfs node 'efi_page_tables' to allow the UEFI runtime
page tables to be inspected. Note that ARM does not have 'asm/ptdump.h'
[yet] so for now, this is arm64 only.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
This patch could be helpful in assessing the series 'arm64: avoid block
entries that we need to split later' that I sent out yesterday.
drivers/firmware/efi/arm-runtime.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
index 17ccf0a8787a..4197a1da013d 100644
--- a/drivers/firmware/efi/arm-runtime.c
+++ b/drivers/firmware/efi/arm-runtime.c
@@ -39,6 +39,26 @@ static struct mm_struct efi_mm = {
.mmlist = LIST_HEAD_INIT(efi_mm.mmlist),
};
+#ifdef CONFIG_ARM64
+#include <asm/ptdump.h>
+
+static struct ptdump_info efi_ptdump_info = {
+ .mm = &efi_mm,
+ .markers = (struct addr_marker[]){
+ { 0, "UEFI runtime start" },
+ { TASK_SIZE_64, "UEFI runtime end" }
+ },
+ .base_addr = 0,
+};
+
+static int __init ptdump_init(void)
+{
+ return ptdump_register(&efi_ptdump_info, "efi_page_tables");
+}
+device_initcall(ptdump_init);
+
+#endif
+
static bool __init efi_virtmap_init(void)
{
efi_memory_desc_t *md;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] efi: arm64: add debugfs node to dump UEFI runtime page tables
2016-06-30 10:01 ` Ard Biesheuvel
@ 2016-06-30 14:09 ` Mark Rutland
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Rutland @ 2016-06-30 14:09 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-efi-u79uwXL29TY76Z2rM5mHXA, catalin.marinas-5wv7dgnIgG8,
matt-mF/unelCI9GS6iBeEJttW/XRex20P6io,
leif.lindholm-QSEj5FYQhm4dnm+yROfE0A
On Thu, Jun 30, 2016 at 12:01:46PM +0200, Ard Biesheuvel wrote:
> Register the debugfs node 'efi_page_tables' to allow the UEFI runtime
> page tables to be inspected. Note that ARM does not have 'asm/ptdump.h'
> [yet] so for now, this is arm64 only.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>
> This patch could be helpful in assessing the series 'arm64: avoid block
> entries that we need to split later' that I sent out yesterday.
It's probably worth noting that this is based on the arm64 for-next/core
branch. I don't know if/how we can orgnise branches for merging this.
> drivers/firmware/efi/arm-runtime.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
> index 17ccf0a8787a..4197a1da013d 100644
> --- a/drivers/firmware/efi/arm-runtime.c
> +++ b/drivers/firmware/efi/arm-runtime.c
> @@ -39,6 +39,26 @@ static struct mm_struct efi_mm = {
> .mmlist = LIST_HEAD_INIT(efi_mm.mmlist),
> };
>
> +#ifdef CONFIG_ARM64
If you use CONFIG_ARM64_PTDUMP for the moment, then we won't have some
unused structs lying around when the feature is unused.
Otherwise, I agree that this is a useful debuging feature. FWIW, either
way:
Acked-by: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Thanks,
Mark.
> +#include <asm/ptdump.h>
> +
> +static struct ptdump_info efi_ptdump_info = {
> + .mm = &efi_mm,
> + .markers = (struct addr_marker[]){
> + { 0, "UEFI runtime start" },
> + { TASK_SIZE_64, "UEFI runtime end" }
> + },
> + .base_addr = 0,
> +};
> +
> +static int __init ptdump_init(void)
> +{
> + return ptdump_register(&efi_ptdump_info, "efi_page_tables");
> +}
> +device_initcall(ptdump_init);
> +
> +#endif
> +
> static bool __init efi_virtmap_init(void)
> {
> efi_memory_desc_t *md;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] efi: arm64: add debugfs node to dump UEFI runtime page tables
@ 2016-06-30 14:09 ` Mark Rutland
0 siblings, 0 replies; 6+ messages in thread
From: Mark Rutland @ 2016-06-30 14:09 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 30, 2016 at 12:01:46PM +0200, Ard Biesheuvel wrote:
> Register the debugfs node 'efi_page_tables' to allow the UEFI runtime
> page tables to be inspected. Note that ARM does not have 'asm/ptdump.h'
> [yet] so for now, this is arm64 only.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>
> This patch could be helpful in assessing the series 'arm64: avoid block
> entries that we need to split later' that I sent out yesterday.
It's probably worth noting that this is based on the arm64 for-next/core
branch. I don't know if/how we can orgnise branches for merging this.
> drivers/firmware/efi/arm-runtime.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
> index 17ccf0a8787a..4197a1da013d 100644
> --- a/drivers/firmware/efi/arm-runtime.c
> +++ b/drivers/firmware/efi/arm-runtime.c
> @@ -39,6 +39,26 @@ static struct mm_struct efi_mm = {
> .mmlist = LIST_HEAD_INIT(efi_mm.mmlist),
> };
>
> +#ifdef CONFIG_ARM64
If you use CONFIG_ARM64_PTDUMP for the moment, then we won't have some
unused structs lying around when the feature is unused.
Otherwise, I agree that this is a useful debuging feature. FWIW, either
way:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> +#include <asm/ptdump.h>
> +
> +static struct ptdump_info efi_ptdump_info = {
> + .mm = &efi_mm,
> + .markers = (struct addr_marker[]){
> + { 0, "UEFI runtime start" },
> + { TASK_SIZE_64, "UEFI runtime end" }
> + },
> + .base_addr = 0,
> +};
> +
> +static int __init ptdump_init(void)
> +{
> + return ptdump_register(&efi_ptdump_info, "efi_page_tables");
> +}
> +device_initcall(ptdump_init);
> +
> +#endif
> +
> static bool __init efi_virtmap_init(void)
> {
> efi_memory_desc_t *md;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efi: arm64: add debugfs node to dump UEFI runtime page tables
2016-06-30 14:09 ` Mark Rutland
@ 2016-07-01 13:18 ` Ard Biesheuvel
-1 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2016-07-01 13:18 UTC (permalink / raw)
To: Mark Rutland
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-efi-u79uwXL29TY76Z2rM5mHXA, Catalin Marinas, Matt Fleming,
Leif Lindholm
On 30 June 2016 at 16:09, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> On Thu, Jun 30, 2016 at 12:01:46PM +0200, Ard Biesheuvel wrote:
>> Register the debugfs node 'efi_page_tables' to allow the UEFI runtime
>> page tables to be inspected. Note that ARM does not have 'asm/ptdump.h'
>> [yet] so for now, this is arm64 only.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>>
>> This patch could be helpful in assessing the series 'arm64: avoid block
>> entries that we need to split later' that I sent out yesterday.
>
> It's probably worth noting that this is based on the arm64 for-next/core
> branch. I don't know if/how we can orgnise branches for merging this.
>
There's no rush, so Matt can take it for v4.9 I suppose?
>> drivers/firmware/efi/arm-runtime.c | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
>> index 17ccf0a8787a..4197a1da013d 100644
>> --- a/drivers/firmware/efi/arm-runtime.c
>> +++ b/drivers/firmware/efi/arm-runtime.c
>> @@ -39,6 +39,26 @@ static struct mm_struct efi_mm = {
>> .mmlist = LIST_HEAD_INIT(efi_mm.mmlist),
>> };
>>
>> +#ifdef CONFIG_ARM64
>
> If you use CONFIG_ARM64_PTDUMP for the moment, then we won't have some
> unused structs lying around when the feature is unused.
>
I can change that
> Otherwise, I agree that this is a useful debuging feature. FWIW, either
> way:
>
> Acked-by: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
>
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] efi: arm64: add debugfs node to dump UEFI runtime page tables
@ 2016-07-01 13:18 ` Ard Biesheuvel
0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2016-07-01 13:18 UTC (permalink / raw)
To: linux-arm-kernel
On 30 June 2016 at 16:09, Mark Rutland <mark.rutland@arm.com> wrote:
> On Thu, Jun 30, 2016 at 12:01:46PM +0200, Ard Biesheuvel wrote:
>> Register the debugfs node 'efi_page_tables' to allow the UEFI runtime
>> page tables to be inspected. Note that ARM does not have 'asm/ptdump.h'
>> [yet] so for now, this is arm64 only.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>>
>> This patch could be helpful in assessing the series 'arm64: avoid block
>> entries that we need to split later' that I sent out yesterday.
>
> It's probably worth noting that this is based on the arm64 for-next/core
> branch. I don't know if/how we can orgnise branches for merging this.
>
There's no rush, so Matt can take it for v4.9 I suppose?
>> drivers/firmware/efi/arm-runtime.c | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
>> index 17ccf0a8787a..4197a1da013d 100644
>> --- a/drivers/firmware/efi/arm-runtime.c
>> +++ b/drivers/firmware/efi/arm-runtime.c
>> @@ -39,6 +39,26 @@ static struct mm_struct efi_mm = {
>> .mmlist = LIST_HEAD_INIT(efi_mm.mmlist),
>> };
>>
>> +#ifdef CONFIG_ARM64
>
> If you use CONFIG_ARM64_PTDUMP for the moment, then we won't have some
> unused structs lying around when the feature is unused.
>
I can change that
> Otherwise, I agree that this is a useful debuging feature. FWIW, either
> way:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-01 13:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-30 10:01 [PATCH] efi: arm64: add debugfs node to dump UEFI runtime page tables Ard Biesheuvel
2016-06-30 10:01 ` Ard Biesheuvel
[not found] ` <1467280906-31158-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-06-30 14:09 ` Mark Rutland
2016-06-30 14:09 ` Mark Rutland
2016-07-01 13:18 ` Ard Biesheuvel
2016-07-01 13:18 ` Ard Biesheuvel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.