[U-Boot] [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB

[U-Boot] [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB

[Rajesh Bhagat]

Adds code to use driver model for USB EHCI and XHCI FSL driver

Rajesh Bhagat (5):
  drivers: usb: fsl: Make function for initialization to use in
    CONFIG_DM_USB
  usb: ehci: fsl: Add code to use CONFIG_DM_USB
  usb: xhci: fsl: Add code to use CONFIG_DM_USB
  dm: ls1021a: dts: Update USB 3.0 node to support DM USB
  arm: ls1021a: Enable CONFIG_DM_USB in defconfigs

 arch/arm/dts/ls1021a.dtsi                    |    2 +-
 configs/ls1021aqds_ddr4_nor_defconfig        |    1 +
 configs/ls1021aqds_ddr4_nor_lpuart_defconfig |    1 +
 configs/ls1021aqds_nor_defconfig             |    1 +
 configs/ls1021aqds_nor_lpuart_defconfig      |    1 +
 drivers/usb/host/ehci-fsl.c                  |  194 +++++++++++++++++++++----
 drivers/usb/host/xhci-fsl.c                  |   83 +++++++++++-
 7 files changed, 250 insertions(+), 33 deletions(-)

-- 
1.7.7.4

[U-Boot] [PATCH 1/5] drivers: usb: fsl: Make function for initialization to use in CONFIG_DM_USB

[Rajesh Bhagat]

Moves code from ehci_hcd_init to new function ehci_fsl_init
which can be re-used in CONFIG_DM_USB.

Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
---
 drivers/usb/host/ehci-fsl.c |   63 ++++++++++++++++++++++++------------------
 1 files changed, 36 insertions(+), 27 deletions(-)

diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index fa916ed..df3fa04 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -24,6 +24,8 @@
 #endif
 
 static void set_txfifothresh(struct usb_ehci *, u32);
+static int ehci_fsl_init(int index, struct usb_ehci *ehci,
+			 struct ehci_hccr *hccr, struct ehci_hcor *hcor);
 
 /* Check USB PHY clock valid */
 static int usb_phy_clk_valid(struct usb_ehci *ehci)
@@ -47,6 +49,38 @@ int ehci_hcd_init(int index, enum usb_init_type init,
 		struct ehci_hccr **hccr, struct ehci_hcor **hcor)
 {
 	struct usb_ehci *ehci = NULL;
+
+	switch (index) {
+	case 0:
+		ehci = (struct usb_ehci *)CONFIG_SYS_FSL_USB1_ADDR;
+		break;
+	case 1:
+		ehci = (struct usb_ehci *)CONFIG_SYS_FSL_USB2_ADDR;
+		break;
+	default:
+		printf("ERROR: wrong controller index!!\n");
+		return -EINVAL;
+	};
+
+	*hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
+	*hcor = (struct ehci_hcor *)((uint32_t) *hccr +
+			HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
+
+	return ehci_fsl_init(index, ehci, *hccr, *hcor);
+}
+
+/*
+ * Destroy the appropriate control structures corresponding
+ * the the EHCI host controller.
+ */
+int ehci_hcd_stop(int index)
+{
+	return 0;
+}
+
+static int ehci_fsl_init(int index, struct usb_ehci *ehci,
+			 struct ehci_hccr *hccr, struct ehci_hcor *hcor)
+{
 	const char *phy_type = NULL;
 	size_t len;
 	char current_usb_controller[5];
@@ -68,22 +102,6 @@ int ehci_hcd_init(int index, enum usb_init_type init,
 	snprintf(current_usb_controller, sizeof(current_usb_controller),
 		 "usb%d", index+1);
 
-	switch (index) {
-	case 0:
-		ehci = (struct usb_ehci *)CONFIG_SYS_FSL_USB1_ADDR;
-		break;
-	case 1:
-		ehci = (struct usb_ehci *)CONFIG_SYS_FSL_USB2_ADDR;
-		break;
-	default:
-		printf("ERROR: wrong controller index!!\n");
-		return -EINVAL;
-	};
-
-	*hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
-	*hcor = (struct ehci_hcor *)((uint32_t) *hccr +
-			HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
-
 	/* Set to Host mode */
 	setbits_le32(&ehci->usbmode, CM_HOST);
 
@@ -116,7 +134,7 @@ int ehci_hcd_init(int index, enum usb_init_type init,
 				UTMI_PHY_EN);
 		udelay(1000); /* delay required for PHY Clk to appear */
 #endif
-		out_le32(&(*hcor)->or_portsc[0], PORT_PTS_UTMI);
+		out_le32(&(hcor)->or_portsc[0], PORT_PTS_UTMI);
 		clrsetbits_be32(&ehci->control, CONTROL_REGISTER_W1C_MASK,
 				USB_EN);
 	} else {
@@ -127,7 +145,7 @@ int ehci_hcd_init(int index, enum usb_init_type init,
 		udelay(1000); /* delay required for PHY Clk to appear */
 		if (!usb_phy_clk_valid(ehci))
 			return -EINVAL;
-		out_le32(&(*hcor)->or_portsc[0], PORT_PTS_ULPI);
+		out_le32(&(hcor)->or_portsc[0], PORT_PTS_ULPI);
 	}
 
 	out_be32(&ehci->prictrl, 0x0000000c);
@@ -153,15 +171,6 @@ int ehci_hcd_init(int index, enum usb_init_type init,
 }
 
 /*
- * Destroy the appropriate control structures corresponding
- * the the EHCI host controller.
- */
-int ehci_hcd_stop(int index)
-{
-	return 0;
-}
-
-/*
  * Setting the value of TXFIFO_THRESH field in TXFILLTUNING register
  * to counter DDR latencies in writing data into Tx buffer.
  * This prevents Tx buffer from getting underrun
-- 
1.7.7.4

[U-Boot] [PATCH 2/5] usb: ehci: fsl: Add code to use CONFIG_DM_USB

[Rajesh Bhagat]

Adds code to use driver model for USB EHCI FSL driver

Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
---
 drivers/usb/host/ehci-fsl.c |  131 +++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 127 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index df3fa04..f5e3ae7 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -1,5 +1,5 @@
 /*
- * (C) Copyright 2009, 2011 Freescale Semiconductor, Inc.
+ * (C) Copyright 2009, 2011, 2016 Freescale Semiconductor, Inc.
  *
  * (C) Copyright 2008, Excito Elektronik i Sk=E5ne AB
  *
@@ -16,16 +16,32 @@
 #include <hwconfig.h>
 #include <fsl_usb.h>
 #include <fdt_support.h>
+#include <dm.h>
 
 #include "ehci.h"
 
+DECLARE_GLOBAL_DATA_PTR;
+
 #ifndef CONFIG_USB_MAX_CONTROLLER_COUNT
 #define CONFIG_USB_MAX_CONTROLLER_COUNT 1
 #endif
 
+#ifdef CONFIG_DM_USB
+struct ehci_fsl_priv {
+	struct ehci_ctrl ehci;
+	fdt_addr_t hcd_base;
+	char *phy_type;
+};
+#endif
+
 static void set_txfifothresh(struct usb_ehci *, u32);
+#ifdef CONFIG_DM_USB
+static int ehci_fsl_init(struct ehci_fsl_priv *priv, struct usb_ehci *ehci,
+		  struct ehci_hccr *hccr, struct ehci_hcor *hcor);
+#else
 static int ehci_fsl_init(int index, struct usb_ehci *ehci,
 			 struct ehci_hccr *hccr, struct ehci_hcor *hcor);
+#endif
 
 /* Check USB PHY clock valid */
 static int usb_phy_clk_valid(struct usb_ehci *ehci)
@@ -39,6 +55,99 @@ static int usb_phy_clk_valid(struct usb_ehci *ehci)
 	}
 }
 
+#ifdef CONFIG_DM_USB
+static int ehci_fsl_ofdata_to_platdata(struct udevice *dev)
+{
+	struct ehci_fsl_priv *priv = dev_get_priv(dev);
+	const void *prop;
+
+	prop = fdt_getprop(gd->fdt_blob, dev->of_offset, "phy_type",
+			   NULL);
+	if (prop) {
+		priv->phy_type = (char *)prop;
+		debug("phy_type %s\n", priv->phy_type);
+	}
+
+	return 0;
+}
+
+static int ehci_fsl_init_after_reset(struct ehci_ctrl *ctrl)
+{
+	struct usb_ehci *ehci = NULL;
+	struct ehci_fsl_priv *priv = container_of(ctrl, struct ehci_fsl_priv,
+						   ehci);
+
+	ehci = (struct usb_ehci *)priv->hcd_base;
+	if (ehci_fsl_init(priv, ehci, priv->ehci.hccr, priv->ehci.hcor) < 0)
+		return -ENXIO;
+
+	return 0;
+}
+
+static const struct ehci_ops fsl_ehci_ops = {
+	.init_after_reset = ehci_fsl_init_after_reset,
+};
+
+static int ehci_fsl_probe(struct udevice *dev)
+{
+	struct ehci_fsl_priv *priv = dev_get_priv(dev);
+	struct usb_ehci *ehci = NULL;
+	struct ehci_hccr *hccr;
+	struct ehci_hcor *hcor;
+
+	/*
+	 * Get the base address for EHCI controller from the device node
+	 */
+	priv->hcd_base = dev_get_addr(dev);
+	if (priv->hcd_base == FDT_ADDR_T_NONE) {
+		debug("Can't get the EHCI register base address\n");
+		return -ENXIO;
+	}
+	ehci = (struct usb_ehci *)priv->hcd_base;
+	hccr = (struct ehci_hccr *)(&ehci->caplength);
+	hcor = (struct ehci_hcor *)
+		((u32)hccr + HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
+	if (ehci_fsl_init(priv, ehci, hccr, hcor) < 0)
+		return -ENXIO;
+
+	debug("ehci-fsl: init hccr %x and hcor %x hc_length %d\n",
+	      (u32)hccr, (u32)hcor,
+	      (u32)HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
+	return ehci_register(dev, hccr, hcor, &fsl_ehci_ops, 0, USB_INIT_HOST);
+}
+
+static int ehci_fsl_remove(struct udevice *dev)
+{
+	int ret;
+
+	ret = ehci_deregister(dev);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
+static const struct udevice_id ehci_usb_ids[] = {
+	{ .compatible = "fsl-usb2-mph", },
+	{ .compatible = "fsl-usb2-dr", },
+	{ }
+};
+
+U_BOOT_DRIVER(ehci_fsl) = {
+	.name	= "ehci_fsl",
+	.id	= UCLASS_USB,
+	.of_match = ehci_usb_ids,
+	.ofdata_to_platdata = ehci_fsl_ofdata_to_platdata,
+	.probe = ehci_fsl_probe,
+	.remove = ehci_fsl_remove,
+	.ops	= &ehci_usb_ops,
+	.platdata_auto_alloc_size = sizeof(struct usb_platdata),
+	.priv_auto_alloc_size = sizeof(struct ehci_fsl_priv),
+	.flags	= DM_FLAG_ALLOC_PRIV_DMA,
+};
+#else
 /*
  * Create the appropriate control structures to manage
  * a new EHCI host controller.
@@ -77,13 +186,21 @@ int ehci_hcd_stop(int index)
 {
 	return 0;
 }
+#endif
 
+#ifdef CONFIG_DM_USB
+static int ehci_fsl_init(struct ehci_fsl_priv *priv, struct usb_ehci *ehci,
+		  struct ehci_hccr *hccr, struct ehci_hcor *hcor)
+#else
 static int ehci_fsl_init(int index, struct usb_ehci *ehci,
 			 struct ehci_hccr *hccr, struct ehci_hcor *hcor)
+#endif
 {
 	const char *phy_type = NULL;
+#ifndef CONFIG_DM_USB
 	size_t len;
 	char current_usb_controller[5];
+#endif
 #ifdef CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY
 	char usb_phy[5];
 
@@ -98,9 +215,6 @@ static int ehci_fsl_init(int index, struct usb_ehci *ehci,
 		 */
 		mdelay(5);
 	}
-	memset(current_usb_controller, '\0', 5);
-	snprintf(current_usb_controller, sizeof(current_usb_controller),
-		 "usb%d", index+1);
 
 	/* Set to Host mode */
 	setbits_le32(&ehci->usbmode, CM_HOST);
@@ -109,9 +223,18 @@ static int ehci_fsl_init(int index, struct usb_ehci *ehci,
 	out_be32(&ehci->snoop2, 0x80000000 | SNOOP_SIZE_2GB);
 
 	/* Init phy */
+#ifdef CONFIG_DM_USB
+	if (priv->phy_type)
+		phy_type = priv->phy_type;
+#else
+	memset(current_usb_controller, '\0', 5);
+	snprintf(current_usb_controller, sizeof(current_usb_controller),
+		 "usb%d", index+1);
+
 	if (hwconfig_sub(current_usb_controller, "phy_type"))
 		phy_type = hwconfig_subarg(current_usb_controller,
 				"phy_type", &len);
+#endif
 	else
 		phy_type = getenv("usb_phy_type");
 
-- 
1.7.7.4

[U-Boot] [PATCH 3/5] usb: xhci: fsl: Add code to use CONFIG_DM_USB

[Rajesh Bhagat]

Adds code to use driver model for USB XHCI FSL driver

Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
---
 drivers/usb/host/xhci-fsl.c |   83 ++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 82 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/xhci-fsl.c b/drivers/usb/host/xhci-fsl.c
index c12a189..bdcd4f1 100644
--- a/drivers/usb/host/xhci-fsl.c
+++ b/drivers/usb/host/xhci-fsl.c
@@ -1,5 +1,5 @@
 /*
- * Copyright 2015 Freescale Semiconductor, Inc.
+ * Copyright 2015,2016 Freescale Semiconductor, Inc.
  *
  * FSL USB HOST xHCI Controller
  *
@@ -17,12 +17,21 @@
 #include "xhci.h"
 #include <fsl_errata.h>
 #include <fsl_usb.h>
+#include <dm.h>
 
 /* Declare global data pointer */
 DECLARE_GLOBAL_DATA_PTR;
 
+#ifndef CONFIG_DM_USB
 static struct fsl_xhci fsl_xhci;
 unsigned long ctr_addr[] = FSL_USB_XHCI_ADDR;
+#else
+struct xhci_fsl_priv {
+	struct xhci_ctrl xhci;
+	fdt_addr_t hcd_base;
+	struct fsl_xhci ctx;
+};
+#endif
 
 __weak int __board_usb_init(int index, enum usb_init_type init)
 {
@@ -77,6 +86,77 @@ static int fsl_xhci_core_exit(struct fsl_xhci *fsl_xhci)
 	return 0;
 }
 
+#ifdef CONFIG_DM_USB
+static int xhci_fsl_probe(struct udevice *dev)
+{
+	struct xhci_fsl_priv *priv = dev_get_priv(dev);
+	struct xhci_hccr *hccr;
+	struct xhci_hcor *hcor;
+
+	int ret = 0;
+
+	/*
+	 * Get the base address for XHCI controller from the device node
+	 */
+	priv->hcd_base = dev_get_addr(dev);
+	if (priv->hcd_base == FDT_ADDR_T_NONE) {
+		debug("Can't get the XHCI register base address\n");
+		return -ENXIO;
+	}
+	priv->ctx.hcd = (struct xhci_hccr *)priv->hcd_base;
+	priv->ctx.dwc3_reg = (struct dwc3 *)((char *)(priv->hcd_base) +
+			  DWC3_REG_OFFSET);
+
+	fsl_apply_xhci_errata();
+
+	ret = fsl_xhci_core_init(&priv->ctx);
+	if (ret < 0) {
+		puts("Failed to initialize xhci\n");
+		return ret;
+	}
+
+	hccr = (struct xhci_hccr *)(priv->ctx.hcd);
+	hcor = (struct xhci_hcor *)((uintptr_t) hccr
+				+ HC_LENGTH(xhci_readl(&hccr->cr_capbase)));
+
+	debug("xhci-fsl: init hccr %lx and hcor %lx hc_length %lx\n",
+	      (uintptr_t)hccr, (uintptr_t)hcor,
+	      (uintptr_t)HC_LENGTH(xhci_readl(&hccr->cr_capbase)));
+
+	return xhci_register(dev, hccr, hcor);
+}
+
+static int xhci_fsl_remove(struct udevice *dev)
+{
+	struct xhci_fsl_priv *priv = dev_get_priv(dev);
+	int ret;
+
+	fsl_xhci_core_exit(&priv->ctx);
+
+	ret = xhci_deregister(dev);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
+static const struct udevice_id xhci_usb_ids[] = {
+	{ .compatible = "fsl,layerscape-dwc3", },
+	{ }
+};
+
+U_BOOT_DRIVER(xhci_fsl) = {
+	.name	= "xhci_fsl",
+	.id	= UCLASS_USB,
+	.of_match = xhci_usb_ids,
+	.probe = xhci_fsl_probe,
+	.remove = xhci_fsl_remove,
+	.ops	= &xhci_usb_ops,
+	.platdata_auto_alloc_size = sizeof(struct usb_platdata),
+	.priv_auto_alloc_size = sizeof(struct xhci_fsl_priv),
+	.flags	= DM_FLAG_ALLOC_PRIV_DMA,
+};
+#else
 int xhci_hcd_init(int index, struct xhci_hccr **hccr, struct xhci_hcor **hcor)
 {
 	struct fsl_xhci *ctx = &fsl_xhci;
@@ -116,3 +196,4 @@ void xhci_hcd_stop(int index)
 
 	fsl_xhci_core_exit(ctx);
 }
+#endif
-- 
1.7.7.4

[U-Boot] [PATCH 4/5] dm: ls1021a: dts: Update USB 3.0 node to support DM USB

[Rajesh Bhagat]

Update USB 3.0 controller dts node in ls1021a.dtsi.

Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
---
 arch/arm/dts/ls1021a.dtsi |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/dts/ls1021a.dtsi b/arch/arm/dts/ls1021a.dtsi
index ee0e554..119b1af 100644
--- a/arch/arm/dts/ls1021a.dtsi
+++ b/arch/arm/dts/ls1021a.dtsi
@@ -368,7 +368,7 @@
 		};
 
 		usb3 at 3100000 {
-			compatible = "snps,dwc3";
+			compatible = "fsl,layerscape-dwc3";
 			reg = <0x3100000 0x10000>;
 			interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
 			dr_mode = "host";
-- 
1.7.7.4

[U-Boot] [PATCH 5/5] arm: ls1021a: Enable CONFIG_DM_USB in defconfigs

[Rajesh Bhagat]

Enables driver model flag CONFIG_DM_USB for LS1021A
platform defconfigs.

Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
---
 configs/ls1021aqds_ddr4_nor_defconfig        |    1 +
 configs/ls1021aqds_ddr4_nor_lpuart_defconfig |    1 +
 configs/ls1021aqds_nor_defconfig             |    1 +
 configs/ls1021aqds_nor_lpuart_defconfig      |    1 +
 4 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/configs/ls1021aqds_ddr4_nor_defconfig b/configs/ls1021aqds_ddr4_nor_defconfig
index 6012d49..ffaf6fd 100644
--- a/configs/ls1021aqds_ddr4_nor_defconfig
+++ b/configs/ls1021aqds_ddr4_nor_defconfig
@@ -30,3 +30,4 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+CONFIG_DM_USB=y
diff --git a/configs/ls1021aqds_ddr4_nor_lpuart_defconfig b/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
index 685f1da..a7c3253 100644
--- a/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
+++ b/configs/ls1021aqds_ddr4_nor_lpuart_defconfig
@@ -30,3 +30,4 @@ CONFIG_FSL_LPUART=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+CONFIG_DM_USB=y
diff --git a/configs/ls1021aqds_nor_defconfig b/configs/ls1021aqds_nor_defconfig
index 6748546..7a82c67 100644
--- a/configs/ls1021aqds_nor_defconfig
+++ b/configs/ls1021aqds_nor_defconfig
@@ -29,3 +29,4 @@ CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+CONFIG_DM_USB=y
diff --git a/configs/ls1021aqds_nor_lpuart_defconfig b/configs/ls1021aqds_nor_lpuart_defconfig
index 81035c9..30c65ca 100644
--- a/configs/ls1021aqds_nor_lpuart_defconfig
+++ b/configs/ls1021aqds_nor_lpuart_defconfig
@@ -30,3 +30,4 @@ CONFIG_FSL_LPUART=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
+CONFIG_DM_USB=y
-- 
1.7.7.4

[U-Boot] [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB

[Rajesh Bhagat]

Hi All, 

Any Comments? 

> -----Original Message-----
> From: Rajesh Bhagat [mailto:rajesh.bhagat at nxp.com]
> Sent: Friday, July 01, 2016 6:52 PM
> To: u-boot at lists.denx.de
> Cc: marex at denx.de; york sun <york.sun@nxp.com>; Sriram Dash
> <sriram.dash@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
> Subject: [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB
> 
> Adds code to use driver model for USB EHCI and XHCI FSL driver
> 
> Rajesh Bhagat (5):
>   drivers: usb: fsl: Make function for initialization to use in
>     CONFIG_DM_USB
>   usb: ehci: fsl: Add code to use CONFIG_DM_USB
>   usb: xhci: fsl: Add code to use CONFIG_DM_USB
>   dm: ls1021a: dts: Update USB 3.0 node to support DM USB
>   arm: ls1021a: Enable CONFIG_DM_USB in defconfigs
> 
>  arch/arm/dts/ls1021a.dtsi                    |    2 +-
>  configs/ls1021aqds_ddr4_nor_defconfig        |    1 +
>  configs/ls1021aqds_ddr4_nor_lpuart_defconfig |    1 +
>  configs/ls1021aqds_nor_defconfig             |    1 +
>  configs/ls1021aqds_nor_lpuart_defconfig      |    1 +
>  drivers/usb/host/ehci-fsl.c                  |  194 +++++++++++++++++++++----
>  drivers/usb/host/xhci-fsl.c                  |   83 +++++++++++-
>  7 files changed, 250 insertions(+), 33 deletions(-)
> 
> --
> 1.7.7.4

Best Regards,
Rajesh Bhagat 

[U-Boot] [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB

[Marek Vasut]

On 07/21/2016 10:02 AM, Rajesh Bhagat wrote:
> Hi All, 
> 
> Any Comments? 

York, please check this.

>> -----Original Message-----
>> From: Rajesh Bhagat [mailto:rajesh.bhagat at nxp.com]
>> Sent: Friday, July 01, 2016 6:52 PM
>> To: u-boot at lists.denx.de
>> Cc: marex at denx.de; york sun <york.sun@nxp.com>; Sriram Dash
>> <sriram.dash@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
>> Subject: [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB
>>
>> Adds code to use driver model for USB EHCI and XHCI FSL driver
>>
>> Rajesh Bhagat (5):
>>   drivers: usb: fsl: Make function for initialization to use in
>>     CONFIG_DM_USB
>>   usb: ehci: fsl: Add code to use CONFIG_DM_USB
>>   usb: xhci: fsl: Add code to use CONFIG_DM_USB
>>   dm: ls1021a: dts: Update USB 3.0 node to support DM USB
>>   arm: ls1021a: Enable CONFIG_DM_USB in defconfigs
>>
>>  arch/arm/dts/ls1021a.dtsi                    |    2 +-
>>  configs/ls1021aqds_ddr4_nor_defconfig        |    1 +
>>  configs/ls1021aqds_ddr4_nor_lpuart_defconfig |    1 +
>>  configs/ls1021aqds_nor_defconfig             |    1 +
>>  configs/ls1021aqds_nor_lpuart_defconfig      |    1 +
>>  drivers/usb/host/ehci-fsl.c                  |  194 +++++++++++++++++++++----
>>  drivers/usb/host/xhci-fsl.c                  |   83 +++++++++++-
>>  7 files changed, 250 insertions(+), 33 deletions(-)
>>
>> --
>> 1.7.7.4
> 
> Best Regards,
> Rajesh Bhagat 
> 


-- 
Best regards,
Marek Vasut

[U-Boot] [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB

[york sun]

On 07/21/2016 04:45 AM, Marek Vasut wrote:
> On 07/21/2016 10:02 AM, Rajesh Bhagat wrote:
>> Hi All,
>>
>> Any Comments?
>
> York, please check this.

Passed compiling tests on powerpc and arm platforms.

York

>
>>> -----Original Message-----
>>> From: Rajesh Bhagat [mailto:rajesh.bhagat at nxp.com]
>>> Sent: Friday, July 01, 2016 6:52 PM
>>> To: u-boot at lists.denx.de
>>> Cc: marex at denx.de; york sun <york.sun@nxp.com>; Sriram Dash
>>> <sriram.dash@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
>>> Subject: [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB
>>>
>>> Adds code to use driver model for USB EHCI and XHCI FSL driver
>>>
>>> Rajesh Bhagat (5):
>>>   drivers: usb: fsl: Make function for initialization to use in
>>>     CONFIG_DM_USB
>>>   usb: ehci: fsl: Add code to use CONFIG_DM_USB
>>>   usb: xhci: fsl: Add code to use CONFIG_DM_USB
>>>   dm: ls1021a: dts: Update USB 3.0 node to support DM USB
>>>   arm: ls1021a: Enable CONFIG_DM_USB in defconfigs
>>>
>>>  arch/arm/dts/ls1021a.dtsi                    |    2 +-
>>>  configs/ls1021aqds_ddr4_nor_defconfig        |    1 +
>>>  configs/ls1021aqds_ddr4_nor_lpuart_defconfig |    1 +
>>>  configs/ls1021aqds_nor_defconfig             |    1 +
>>>  configs/ls1021aqds_nor_lpuart_defconfig      |    1 +
>>>  drivers/usb/host/ehci-fsl.c                  |  194 +++++++++++++++++++++----
>>>  drivers/usb/host/xhci-fsl.c                  |   83 +++++++++++-
>>>  7 files changed, 250 insertions(+), 33 deletions(-)
>>>
>>> --
>>> 1.7.7.4
>>
>> Best Regards,
>> Rajesh Bhagat
>>
>
>

[U-Boot] [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB

[Marek Vasut]

On 07/27/2016 08:00 PM, york sun wrote:
> On 07/21/2016 04:45 AM, Marek Vasut wrote:
>> On 07/21/2016 10:02 AM, Rajesh Bhagat wrote:
>>> Hi All,
>>>
>>> Any Comments?
>>
>> York, please check this.
> 
> Passed compiling tests on powerpc and arm platforms.

And the patches are OK ?

> York
> 
>>
>>>> -----Original Message-----
>>>> From: Rajesh Bhagat [mailto:rajesh.bhagat at nxp.com]
>>>> Sent: Friday, July 01, 2016 6:52 PM
>>>> To: u-boot at lists.denx.de
>>>> Cc: marex at denx.de; york sun <york.sun@nxp.com>; Sriram Dash
>>>> <sriram.dash@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
>>>> Subject: [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB
>>>>
>>>> Adds code to use driver model for USB EHCI and XHCI FSL driver
>>>>
>>>> Rajesh Bhagat (5):
>>>>   drivers: usb: fsl: Make function for initialization to use in
>>>>     CONFIG_DM_USB
>>>>   usb: ehci: fsl: Add code to use CONFIG_DM_USB
>>>>   usb: xhci: fsl: Add code to use CONFIG_DM_USB
>>>>   dm: ls1021a: dts: Update USB 3.0 node to support DM USB
>>>>   arm: ls1021a: Enable CONFIG_DM_USB in defconfigs
>>>>
>>>>  arch/arm/dts/ls1021a.dtsi                    |    2 +-
>>>>  configs/ls1021aqds_ddr4_nor_defconfig        |    1 +
>>>>  configs/ls1021aqds_ddr4_nor_lpuart_defconfig |    1 +
>>>>  configs/ls1021aqds_nor_defconfig             |    1 +
>>>>  configs/ls1021aqds_nor_lpuart_defconfig      |    1 +
>>>>  drivers/usb/host/ehci-fsl.c                  |  194 +++++++++++++++++++++----
>>>>  drivers/usb/host/xhci-fsl.c                  |   83 +++++++++++-
>>>>  7 files changed, 250 insertions(+), 33 deletions(-)
>>>>
>>>> --
>>>> 1.7.7.4
>>>
>>> Best Regards,
>>> Rajesh Bhagat
>>>
>>
>>
> 


-- 
Best regards,
Marek Vasut

[U-Boot] [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB

[york sun]

On 07/28/2016 04:34 AM, Marek Vasut wrote:
> On 07/27/2016 08:00 PM, york sun wrote:
>> On 07/21/2016 04:45 AM, Marek Vasut wrote:
>>> On 07/21/2016 10:02 AM, Rajesh Bhagat wrote:
>>>> Hi All,
>>>>
>>>> Any Comments?
>>>
>>> York, please check this.
>>
>> Passed compiling tests on powerpc and arm platforms.
>
> And the patches are OK ?
>

They look OK to me. But I have to admit I am not an expert on USB.

York

[U-Boot] [PATCH 0/5] usb: fsl: Add code to use CONFIG_DM_USB

[Marek Vasut]

On 07/28/2016 06:01 PM, york sun wrote:
> On 07/28/2016 04:34 AM, Marek Vasut wrote:
>> On 07/27/2016 08:00 PM, york sun wrote:
>>> On 07/21/2016 04:45 AM, Marek Vasut wrote:
>>>> On 07/21/2016 10:02 AM, Rajesh Bhagat wrote:
>>>>> Hi All,
>>>>>
>>>>> Any Comments?
>>>>
>>>> York, please check this.
>>>
>>> Passed compiling tests on powerpc and arm platforms.
>>
>> And the patches are OK ?
>>
> 
> They look OK to me. But I have to admit I am not an expert on USB.

OK


-- 
Best regards,
Marek Vasut