* [PATCH] Btrfs: use the correct struct for BTRFS_IOC_LOGICAL_INO
@ 2016-07-03 21:23 Hans van Kranenburg
2016-07-04 17:57 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Hans van Kranenburg @ 2016-07-03 21:23 UTC (permalink / raw)
To: linux-btrfs; +Cc: Hans van Kranenburg
BTRFS_IOC_LOGICAL_INO takes a btrfs_ioctl_logical_ino_args as argument,
not a btrfs_ioctl_ino_path_args. The lines were probably copy/pasted
when the code was written.
Since btrfs_ioctl_logical_ino_args and btrfs_ioctl_ino_path_args have
the same size, the actual IOCTL definition here does not change.
But, it makes the code less confusing for the reader.
Signed-off-by: Hans van Kranenburg <hans.van.kranenburg@mendix.com>
---
include/uapi/linux/btrfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/btrfs.h b/include/uapi/linux/btrfs.h
index 2bdd1e3..ac5eacd 100644
--- a/include/uapi/linux/btrfs.h
+++ b/include/uapi/linux/btrfs.h
@@ -798,7 +798,7 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
#define BTRFS_IOC_INO_PATHS _IOWR(BTRFS_IOCTL_MAGIC, 35, \
struct btrfs_ioctl_ino_path_args)
#define BTRFS_IOC_LOGICAL_INO _IOWR(BTRFS_IOCTL_MAGIC, 36, \
- struct btrfs_ioctl_ino_path_args)
+ struct btrfs_ioctl_logical_ino_args)
#define BTRFS_IOC_SET_RECEIVED_SUBVOL _IOWR(BTRFS_IOCTL_MAGIC, 37, \
struct btrfs_ioctl_received_subvol_args)
#define BTRFS_IOC_SEND _IOW(BTRFS_IOCTL_MAGIC, 38, struct btrfs_ioctl_send_args)
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Btrfs: use the correct struct for BTRFS_IOC_LOGICAL_INO
2016-07-03 21:23 [PATCH] Btrfs: use the correct struct for BTRFS_IOC_LOGICAL_INO Hans van Kranenburg
@ 2016-07-04 17:57 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2016-07-04 17:57 UTC (permalink / raw)
To: Hans van Kranenburg; +Cc: linux-btrfs
On Sun, Jul 03, 2016 at 11:23:06PM +0200, Hans van Kranenburg wrote:
> BTRFS_IOC_LOGICAL_INO takes a btrfs_ioctl_logical_ino_args as argument,
> not a btrfs_ioctl_ino_path_args. The lines were probably copy/pasted
> when the code was written.
>
> Since btrfs_ioctl_logical_ino_args and btrfs_ioctl_ino_path_args have
> the same size, the actual IOCTL definition here does not change.
>
> But, it makes the code less confusing for the reader.
>
> Signed-off-by: Hans van Kranenburg <hans.van.kranenburg@mendix.com>
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-04 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-03 21:23 [PATCH] Btrfs: use the correct struct for BTRFS_IOC_LOGICAL_INO Hans van Kranenburg
2016-07-04 17:57 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.