All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/6] gnutls: update legal info
@ 2016-07-04 12:46 Rahul Bedarkar
  2016-07-04 12:46 ` [Buildroot] [PATCH 2/6] libuci: " Rahul Bedarkar
                   ` (6 more replies)
  0 siblings, 7 replies; 14+ messages in thread
From: Rahul Bedarkar @ 2016-07-04 12:46 UTC (permalink / raw)
  To: buildroot

GnuTLS core library is licensed under LGPLv2.1+ while gnutls-openssl
library is licensed under GPLv3+. Annotate the license with components.

Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
---
 package/gnutls/gnutls.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gnutls/gnutls.mk b/package/gnutls/gnutls.mk
index 76d2ca2..c063f8f 100644
--- a/package/gnutls/gnutls.mk
+++ b/package/gnutls/gnutls.mk
@@ -8,7 +8,7 @@ GNUTLS_VERSION_MAJOR = 3.4
 GNUTLS_VERSION = $(GNUTLS_VERSION_MAJOR).13
 GNUTLS_SOURCE = gnutls-$(GNUTLS_VERSION).tar.xz
 GNUTLS_SITE = ftp://ftp.gnutls.org/gcrypt/gnutls/v$(GNUTLS_VERSION_MAJOR)
-GNUTLS_LICENSE = GPLv3+, LGPLv2.1+
+GNUTLS_LICENSE = GPLv3+ (gnutls-openssl library), LGPLv2.1+ (core library)
 GNUTLS_LICENSE_FILES = COPYING COPYING.LESSER
 GNUTLS_DEPENDENCIES = host-pkgconf libtasn1 nettle pcre
 GNUTLS_CONF_OPTS = \
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 2/6] libuci: update legal info
  2016-07-04 12:46 [Buildroot] [PATCH 1/6] gnutls: update legal info Rahul Bedarkar
@ 2016-07-04 12:46 ` Rahul Bedarkar
  2016-07-04 15:46   ` Yann E. MORIN
  2016-07-04 12:46 ` [Buildroot] [PATCH 3/6] dbus: " Rahul Bedarkar
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 14+ messages in thread
From: Rahul Bedarkar @ 2016-07-04 12:46 UTC (permalink / raw)
  To: buildroot

CLI tool and lua bindings are released under GPLv2.

Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
---
 package/libuci/libuci.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libuci/libuci.mk b/package/libuci/libuci.mk
index 8c060d5..b9bd0c7 100644
--- a/package/libuci/libuci.mk
+++ b/package/libuci/libuci.mk
@@ -6,7 +6,7 @@
 
 LIBUCI_VERSION = e339407372ffc70b1451e4eda218c01aa95a6a7f
 LIBUCI_SITE = git://nbd.name/uci.git
-LIBUCI_LICENSE = LGPLv2.1
+LIBUCI_LICENSE = LGPLv2.1, GPLv2 (tools)
 LIBUCI_INSTALL_STAGING = YES
 LIBUCI_DEPENDENCIES = libubox
 
@@ -15,6 +15,7 @@ LIBUCI_DEPENDENCIES += lua
 LIBUCI_CONF_OPTS += -DBUILD_LUA=ON \
 	-DLUAPATH=/usr/lib/lua/5.1 \
 	-DLUA_CFLAGS=-I$(STAGING_DIR)/usr/include
+LIBUCI_LICENSE += , GPLv2 (lua bindings)
 else
 LIBUCI_CONF_OPTS += -DBUILD_LUA=OFF
 endif
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 3/6] dbus: update legal info
  2016-07-04 12:46 [Buildroot] [PATCH 1/6] gnutls: update legal info Rahul Bedarkar
  2016-07-04 12:46 ` [Buildroot] [PATCH 2/6] libuci: " Rahul Bedarkar
@ 2016-07-04 12:46 ` Rahul Bedarkar
  2016-07-04 12:46 ` [Buildroot] [PATCH 4/6] iw: correct license name Rahul Bedarkar
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Rahul Bedarkar @ 2016-07-04 12:46 UTC (permalink / raw)
  To: buildroot

Library and some tools (dbus-lanuch, dbus-run-session) are dual
licensed under GPLv2 or AFLv2.1 and others (dbus-monitor, dbus-send,
dbus-cleanup-sockets, dbus-uuidgen) are licensed under GPLv2+
only.

Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
---
 package/dbus/dbus.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/dbus/dbus.mk b/package/dbus/dbus.mk
index fbdceb3..11c3d4e 100644
--- a/package/dbus/dbus.mk
+++ b/package/dbus/dbus.mk
@@ -6,7 +6,7 @@
 
 DBUS_VERSION = 1.10.8
 DBUS_SITE = http://dbus.freedesktop.org/releases/dbus
-DBUS_LICENSE = AFLv2.1, GPLv2+
+DBUS_LICENSE = AFLv2.1 or GPLv2+ (library, tools), GPLv2+ (tools)
 DBUS_LICENSE_FILES = COPYING
 DBUS_INSTALL_STAGING = YES
 
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 4/6] iw: correct license name
  2016-07-04 12:46 [Buildroot] [PATCH 1/6] gnutls: update legal info Rahul Bedarkar
  2016-07-04 12:46 ` [Buildroot] [PATCH 2/6] libuci: " Rahul Bedarkar
  2016-07-04 12:46 ` [Buildroot] [PATCH 3/6] dbus: " Rahul Bedarkar
@ 2016-07-04 12:46 ` Rahul Bedarkar
  2016-07-04 15:56   ` Yann E. MORIN
  2016-07-04 12:46 ` [Buildroot] [PATCH 5/6] gmp: correct legal info Rahul Bedarkar
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 14+ messages in thread
From: Rahul Bedarkar @ 2016-07-04 12:46 UTC (permalink / raw)
  To: buildroot

iw license is ISC.

Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
---
 package/iw/iw.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/iw/iw.mk b/package/iw/iw.mk
index 200e703..6f3f309 100644
--- a/package/iw/iw.mk
+++ b/package/iw/iw.mk
@@ -7,7 +7,7 @@
 IW_VERSION = 4.7
 IW_SOURCE = iw-$(IW_VERSION).tar.xz
 IW_SITE = $(BR2_KERNEL_MIRROR)/software/network/iw
-IW_LICENSE = iw license
+IW_LICENSE = ISC
 IW_LICENSE_FILES = COPYING
 IW_DEPENDENCIES = host-pkgconf libnl
 IW_MAKE_OPTS = CC="$(TARGET_CC)" LD="$(TARGET_LD)" LDFLAGS="$(TARGET_LDFLAGS)"
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/6] gmp: correct legal info
  2016-07-04 12:46 [Buildroot] [PATCH 1/6] gnutls: update legal info Rahul Bedarkar
                   ` (2 preceding siblings ...)
  2016-07-04 12:46 ` [Buildroot] [PATCH 4/6] iw: correct license name Rahul Bedarkar
@ 2016-07-04 12:46 ` Rahul Bedarkar
  2016-07-04 16:07   ` Yann E. MORIN
  2016-07-04 12:46 ` [Buildroot] [PATCH 6/6] alsa-lib: update " Rahul Bedarkar
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 14+ messages in thread
From: Rahul Bedarkar @ 2016-07-04 12:46 UTC (permalink / raw)
  To: buildroot

Since version 6, GMP is distributed under the dual licenses LGPLv3+ or
GPLv2+

Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
---
 package/gmp/gmp.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/gmp/gmp.mk b/package/gmp/gmp.mk
index cdde794..485bf7c 100644
--- a/package/gmp/gmp.mk
+++ b/package/gmp/gmp.mk
@@ -8,8 +8,8 @@ GMP_VERSION = 6.1.1
 GMP_SITE = $(BR2_GNU_MIRROR)/gmp
 GMP_SOURCE = gmp-$(GMP_VERSION).tar.xz
 GMP_INSTALL_STAGING = YES
-GMP_LICENSE = LGPLv3+
-GMP_LICENSE_FILES = COPYING.LESSERv3
+GMP_LICENSE = LGPLv3+ or GPLv2+
+GMP_LICENSE_FILES = COPYING.LESSERv3 COPYINGv2
 GMP_DEPENDENCIES = host-m4
 HOST_GMP_DEPENDENCIES = host-m4
 
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 6/6] alsa-lib: update legal info
  2016-07-04 12:46 [Buildroot] [PATCH 1/6] gnutls: update legal info Rahul Bedarkar
                   ` (3 preceding siblings ...)
  2016-07-04 12:46 ` [Buildroot] [PATCH 5/6] gmp: correct legal info Rahul Bedarkar
@ 2016-07-04 12:46 ` Rahul Bedarkar
  2016-07-04 16:14   ` Yann E. MORIN
  2016-07-05  7:15   ` Thomas Petazzoni
  2016-07-04 15:39 ` [Buildroot] [PATCH 1/6] gnutls: " Yann E. MORIN
  2016-07-04 22:14 ` Thomas Petazzoni
  6 siblings, 2 replies; 14+ messages in thread
From: Rahul Bedarkar @ 2016-07-04 12:46 UTC (permalink / raw)
  To: buildroot

aserver tool is licensed under GPLv2+. It is built if 'shm' pcm plugin
is enabled. So, specify its license conditionally when it is enabled.

Reviewed-by: Abhimanyu Vishwakarma <abhimanyu.vishwakarma@imgtec.com>
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
---
 package/alsa-lib/alsa-lib.mk | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
index ae0377d..163c840 100644
--- a/package/alsa-lib/alsa-lib.mk
+++ b/package/alsa-lib/alsa-lib.mk
@@ -12,6 +12,19 @@ ALSA_LIB_LICENSE_FILES = COPYING
 ALSA_LIB_INSTALL_STAGING = YES
 ALSA_LIB_CFLAGS = $(TARGET_CFLAGS)
 ALSA_LIB_AUTORECONF = YES
+
+ifneq (,$(findstring shm,$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_PCM_PLUGINS))))
+ALSA_LIB_HAS_SHM_PLUGIN = y
+else ifneq (,$(findstring all,$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_PCM_PLUGINS))))
+ALSA_LIB_HAS_SHM_PLUGIN = y
+endif
+
+# aserver tool is built when shm pcm plugin is enabled and licensed under GPLv2+
+ifeq ($(ALSA_LIB_HAS_SHM_PLUGIN),y)
+ALSA_LIB_LICENSE += , GPLv2+ (aserver tool)
+ALSA_LIB_LICENSE_FILES += aserver/COPYING
+endif
+
 ALSA_LIB_CONF_OPTS = \
 	--with-alsa-devdir=$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_DEVDIR)) \
 	--with-pcm-plugins="$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_PCM_PLUGINS))" \
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/6] gnutls: update legal info
  2016-07-04 12:46 [Buildroot] [PATCH 1/6] gnutls: update legal info Rahul Bedarkar
                   ` (4 preceding siblings ...)
  2016-07-04 12:46 ` [Buildroot] [PATCH 6/6] alsa-lib: update " Rahul Bedarkar
@ 2016-07-04 15:39 ` Yann E. MORIN
  2016-07-04 22:13   ` Thomas Petazzoni
  2016-07-04 22:14 ` Thomas Petazzoni
  6 siblings, 1 reply; 14+ messages in thread
From: Yann E. MORIN @ 2016-07-04 15:39 UTC (permalink / raw)
  To: buildroot

Rahul, All,

On 2016-07-04 18:16 +0530, Rahul Bedarkar spake thusly:
> GnuTLS core library is licensed under LGPLv2.1+ while gnutls-openssl
> library is licensed under GPLv3+. Annotate the license with components.

What do you call "core library" and "gnutls-openssl library"?

Do you consider libdane to be that "gnutls-openssl library" you talk
about?

I've looked at the source, and libdane is (at least partially) LGPLv3:

    libdane/errors.c:
    [--SNIP--]
     * libdane is free software; you can redistribute it and/or
     * modify it under the terms of the GNU Lesser General Public License
     * as published by the Free Software Foundation; either version 3 of
     * the License, or (at your option) any later version.
    [--SNIP--]

Could you please review the situation and provide a bit more
explanations as to what is what, please?

Regards,
Yann E. MORIN.

> Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> ---
>  package/gnutls/gnutls.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/gnutls/gnutls.mk b/package/gnutls/gnutls.mk
> index 76d2ca2..c063f8f 100644
> --- a/package/gnutls/gnutls.mk
> +++ b/package/gnutls/gnutls.mk
> @@ -8,7 +8,7 @@ GNUTLS_VERSION_MAJOR = 3.4
>  GNUTLS_VERSION = $(GNUTLS_VERSION_MAJOR).13
>  GNUTLS_SOURCE = gnutls-$(GNUTLS_VERSION).tar.xz
>  GNUTLS_SITE = ftp://ftp.gnutls.org/gcrypt/gnutls/v$(GNUTLS_VERSION_MAJOR)
> -GNUTLS_LICENSE = GPLv3+, LGPLv2.1+
> +GNUTLS_LICENSE = GPLv3+ (gnutls-openssl library), LGPLv2.1+ (core library)
>  GNUTLS_LICENSE_FILES = COPYING COPYING.LESSER
>  GNUTLS_DEPENDENCIES = host-pkgconf libtasn1 nettle pcre
>  GNUTLS_CONF_OPTS = \
> -- 
> 2.6.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 2/6] libuci: update legal info
  2016-07-04 12:46 ` [Buildroot] [PATCH 2/6] libuci: " Rahul Bedarkar
@ 2016-07-04 15:46   ` Yann E. MORIN
  0 siblings, 0 replies; 14+ messages in thread
From: Yann E. MORIN @ 2016-07-04 15:46 UTC (permalink / raw)
  To: buildroot

Rahul, All,

On 2016-07-04 18:16 +0530, Rahul Bedarkar spake thusly:
> CLI tool and lua bindings are released under GPLv2.
> 
> Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> ---
>  package/libuci/libuci.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libuci/libuci.mk b/package/libuci/libuci.mk
> index 8c060d5..b9bd0c7 100644
> --- a/package/libuci/libuci.mk
> +++ b/package/libuci/libuci.mk
> @@ -6,7 +6,7 @@
>  
>  LIBUCI_VERSION = e339407372ffc70b1451e4eda218c01aa95a6a7f
>  LIBUCI_SITE = git://nbd.name/uci.git
> -LIBUCI_LICENSE = LGPLv2.1
> +LIBUCI_LICENSE = LGPLv2.1, GPLv2 (tools)
>  LIBUCI_INSTALL_STAGING = YES
>  LIBUCI_DEPENDENCIES = libubox
>  
> @@ -15,6 +15,7 @@ LIBUCI_DEPENDENCIES += lua
>  LIBUCI_CONF_OPTS += -DBUILD_LUA=ON \
>  	-DLUAPATH=/usr/lib/lua/5.1 \
>  	-DLUA_CFLAGS=-I$(STAGING_DIR)/usr/include
> +LIBUCI_LICENSE += , GPLv2 (lua bindings)

Although this is correct, this causes the resulting string to be
ill-formatted:

    LGPLv2.1, GPLv2 (tools) , GPLv2 (lua bindings)

In this case, what we did in other such conditions, was:

    LIBUCI_LICENSE = LGPLv2.1, GPLv2 (tools)

    ifeq ($(BR2_PACKAGE_LUA_5_1),y)
    LIBUCI_LICENSE := $(LIBUCI_LICENSE), GPLv2 (lua bindings)
    endif

See for example qt or freeswitch.

Regards,
Yann E. MORIN.

>  else
>  LIBUCI_CONF_OPTS += -DBUILD_LUA=OFF
>  endif
> -- 
> 2.6.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 4/6] iw: correct license name
  2016-07-04 12:46 ` [Buildroot] [PATCH 4/6] iw: correct license name Rahul Bedarkar
@ 2016-07-04 15:56   ` Yann E. MORIN
  0 siblings, 0 replies; 14+ messages in thread
From: Yann E. MORIN @ 2016-07-04 15:56 UTC (permalink / raw)
  To: buildroot

Rahul, All,

On 2016-07-04 18:16 +0530, Rahul Bedarkar spake thusly:
> iw license is ISC.
> 
> Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/iw/iw.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/iw/iw.mk b/package/iw/iw.mk
> index 200e703..6f3f309 100644
> --- a/package/iw/iw.mk
> +++ b/package/iw/iw.mk
> @@ -7,7 +7,7 @@
>  IW_VERSION = 4.7
>  IW_SOURCE = iw-$(IW_VERSION).tar.xz
>  IW_SITE = $(BR2_KERNEL_MIRROR)/software/network/iw
> -IW_LICENSE = iw license
> +IW_LICENSE = ISC
>  IW_LICENSE_FILES = COPYING
>  IW_DEPENDENCIES = host-pkgconf libnl
>  IW_MAKE_OPTS = CC="$(TARGET_CC)" LD="$(TARGET_LD)" LDFLAGS="$(TARGET_LDFLAGS)"
> -- 
> 2.6.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/6] gmp: correct legal info
  2016-07-04 12:46 ` [Buildroot] [PATCH 5/6] gmp: correct legal info Rahul Bedarkar
@ 2016-07-04 16:07   ` Yann E. MORIN
  0 siblings, 0 replies; 14+ messages in thread
From: Yann E. MORIN @ 2016-07-04 16:07 UTC (permalink / raw)
  To: buildroot

Rahul, All,

On 2016-07-04 18:16 +0530, Rahul Bedarkar spake thusly:
> Since version 6, GMP is distributed under the dual licenses LGPLv3+ or
> GPLv2+
> 
> Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> ---
>  package/gmp/gmp.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/gmp/gmp.mk b/package/gmp/gmp.mk
> index cdde794..485bf7c 100644
> --- a/package/gmp/gmp.mk
> +++ b/package/gmp/gmp.mk
> @@ -8,8 +8,8 @@ GMP_VERSION = 6.1.1
>  GMP_SITE = $(BR2_GNU_MIRROR)/gmp
>  GMP_SOURCE = gmp-$(GMP_VERSION).tar.xz
>  GMP_INSTALL_STAGING = YES
> -GMP_LICENSE = LGPLv3+
> -GMP_LICENSE_FILES = COPYING.LESSERv3
> +GMP_LICENSE = LGPLv3+ or GPLv2+
> +GMP_LICENSE_FILES = COPYING.LESSERv3 COPYINGv2

There are also COPYING and COPYINGv3; both contain the text of the
GPLv3. I'm not sure whether we should carry them or not...

I've looked at a few files, used a few grep-fuu, and they seem to really
consistently refer to either LGPLv3 or GPLv2, which is what you wrote.

So I'd be tempted to agree with you.

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

>  GMP_DEPENDENCIES = host-m4
>  HOST_GMP_DEPENDENCIES = host-m4
>  
> -- 
> 2.6.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 6/6] alsa-lib: update legal info
  2016-07-04 12:46 ` [Buildroot] [PATCH 6/6] alsa-lib: update " Rahul Bedarkar
@ 2016-07-04 16:14   ` Yann E. MORIN
  2016-07-05  7:15   ` Thomas Petazzoni
  1 sibling, 0 replies; 14+ messages in thread
From: Yann E. MORIN @ 2016-07-04 16:14 UTC (permalink / raw)
  To: buildroot

Rahul, All,

On 2016-07-04 18:16 +0530, Rahul Bedarkar spake thusly:
> aserver tool is licensed under GPLv2+. It is built if 'shm' pcm plugin
> is enabled. So, specify its license conditionally when it is enabled.
> 
> Reviewed-by: Abhimanyu Vishwakarma <abhimanyu.vishwakarma@imgtec.com>
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> ---
>  package/alsa-lib/alsa-lib.mk | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
> index ae0377d..163c840 100644
> --- a/package/alsa-lib/alsa-lib.mk
> +++ b/package/alsa-lib/alsa-lib.mk
> @@ -12,6 +12,19 @@ ALSA_LIB_LICENSE_FILES = COPYING
>  ALSA_LIB_INSTALL_STAGING = YES
>  ALSA_LIB_CFLAGS = $(TARGET_CFLAGS)
>  ALSA_LIB_AUTORECONF = YES
> +
> +ifneq (,$(findstring shm,$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_PCM_PLUGINS))))

We prefer positive logic, which you can achieve with something like:

    ifeq ($(filter shm,$($(call qstrip,$(BR2_PACKAGE_ALSA_LIB_PCM_PLUGINS)))),shm)

> +ALSA_LIB_HAS_SHM_PLUGIN = y
> +else ifneq (,$(findstring all,$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_PCM_PLUGINS))))

Ditto.

> +ALSA_LIB_HAS_SHM_PLUGIN = y
> +endif
> +
> +# aserver tool is built when shm pcm plugin is enabled and licensed under GPLv2+
> +ifeq ($(ALSA_LIB_HAS_SHM_PLUGIN),y)
> +ALSA_LIB_LICENSE += , GPLv2+ (aserver tool)

As for libuci, this creates an ill-formatted string. Use the same trick
to fix it. ;-)

Regards,
Yann E. MORIN.

> +ALSA_LIB_LICENSE_FILES += aserver/COPYING
> +endif
> +
>  ALSA_LIB_CONF_OPTS = \
>  	--with-alsa-devdir=$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_DEVDIR)) \
>  	--with-pcm-plugins="$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_PCM_PLUGINS))" \
> -- 
> 2.6.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/6] gnutls: update legal info
  2016-07-04 15:39 ` [Buildroot] [PATCH 1/6] gnutls: " Yann E. MORIN
@ 2016-07-04 22:13   ` Thomas Petazzoni
  0 siblings, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2016-07-04 22:13 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 4 Jul 2016 17:39:50 +0200, Yann E. MORIN wrote:

> On 2016-07-04 18:16 +0530, Rahul Bedarkar spake thusly:
> > GnuTLS core library is licensed under LGPLv2.1+ while gnutls-openssl
> > library is licensed under GPLv3+. Annotate the license with components.  
> 
> What do you call "core library" and "gnutls-openssl library"?

This is explained in the README file:

"""
Since GnuTLS version 3.1.10, the core library has been released under
the GNU Lesser General Public License (LGPL) version 2.1 or later.

Note, however, that version 6.0.0 and later of the gmplib library used
by GnuTLS are distributed under a LGPLv3+ or GPLv2+ dual license, and
as such binaries of this library need to adhere to either LGPLv3+ or
GPLv2+ license.

The GNU LGPL applies to the main GnuTLS library, while the
included applications as well as gnutls-openssl 
library are under the GNU GPL version 3.  The gnutls library is 
located in the lib/ and libdane/ directories, while the applications
in src/ and, the gnutls-openssl library is at extra/.
"""

> 
> Do you consider libdane to be that "gnutls-openssl library" you talk
> about?

No, see above. libdane is part of the "core library".

> I've looked at the source, and libdane is (at least partially) LGPLv3:
> 
>     libdane/errors.c:
>     [--SNIP--]
>      * libdane is free software; you can redistribute it and/or
>      * modify it under the terms of the GNU Lesser General Public License
>      * as published by the Free Software Foundation; either version 3 of
>      * the License, or (at your option) any later version.
>     [--SNIP--]

This seems to be a bug, which I've reported upstream at
https://gitlab.com/gnutls/gnutls/issues/109.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/6] gnutls: update legal info
  2016-07-04 12:46 [Buildroot] [PATCH 1/6] gnutls: update legal info Rahul Bedarkar
                   ` (5 preceding siblings ...)
  2016-07-04 15:39 ` [Buildroot] [PATCH 1/6] gnutls: " Yann E. MORIN
@ 2016-07-04 22:14 ` Thomas Petazzoni
  6 siblings, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2016-07-04 22:14 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 4 Jul 2016 18:16:21 +0530, Rahul Bedarkar wrote:
> GnuTLS core library is licensed under LGPLv2.1+ while gnutls-openssl
> library is licensed under GPLv3+. Annotate the license with components.
> 
> Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
> Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
> ---
>  package/gnutls/gnutls.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied with some changes:

    [Thomas:
     - add comment about the license of the "core library" since some files
       seems to be mistakenly under LGPLv3+ even though the library is
       licensed under LGPLv2.1+.
     - add the README file in the license information, since it contains a
       lot of useful details.]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 6/6] alsa-lib: update legal info
  2016-07-04 12:46 ` [Buildroot] [PATCH 6/6] alsa-lib: update " Rahul Bedarkar
  2016-07-04 16:14   ` Yann E. MORIN
@ 2016-07-05  7:15   ` Thomas Petazzoni
  1 sibling, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2016-07-05  7:15 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 4 Jul 2016 18:16:26 +0530, Rahul Bedarkar wrote:

> +ifneq (,$(findstring shm,$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_PCM_PLUGINS))))
> +ALSA_LIB_HAS_SHM_PLUGIN = y
> +else ifneq (,$(findstring all,$(call qstrip,$(BR2_PACKAGE_ALSA_LIB_PCM_PLUGINS))))
> +ALSA_LIB_HAS_SHM_PLUGIN = y
> +endif
> +
> +# aserver tool is built when shm pcm plugin is enabled and licensed under GPLv2+
> +ifeq ($(ALSA_LIB_HAS_SHM_PLUGIN),y)
> +ALSA_LIB_LICENSE += , GPLv2+ (aserver tool)
> +ALSA_LIB_LICENSE_FILES += aserver/COPYING
> +endif

I think this is somewhat too complicated, what about just doing:

ALSA_LIB_LICENSE = LGPLv2.1+ (library), GPLv2+ (aserver)

However, the code in src/topology/, which can get linked into the
library, seems to be licensed under GPLv2+. This would make the whole
library GPLv2+, no? If that's the case, then the license information
should be updated accordingly.

I've pushed a commit that adds the aserver licensing information (since
it's already better than it is), but it would be good to clarify the
src/topology/ situation.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2016-07-05  7:15 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-04 12:46 [Buildroot] [PATCH 1/6] gnutls: update legal info Rahul Bedarkar
2016-07-04 12:46 ` [Buildroot] [PATCH 2/6] libuci: " Rahul Bedarkar
2016-07-04 15:46   ` Yann E. MORIN
2016-07-04 12:46 ` [Buildroot] [PATCH 3/6] dbus: " Rahul Bedarkar
2016-07-04 12:46 ` [Buildroot] [PATCH 4/6] iw: correct license name Rahul Bedarkar
2016-07-04 15:56   ` Yann E. MORIN
2016-07-04 12:46 ` [Buildroot] [PATCH 5/6] gmp: correct legal info Rahul Bedarkar
2016-07-04 16:07   ` Yann E. MORIN
2016-07-04 12:46 ` [Buildroot] [PATCH 6/6] alsa-lib: update " Rahul Bedarkar
2016-07-04 16:14   ` Yann E. MORIN
2016-07-05  7:15   ` Thomas Petazzoni
2016-07-04 15:39 ` [Buildroot] [PATCH 1/6] gnutls: " Yann E. MORIN
2016-07-04 22:13   ` Thomas Petazzoni
2016-07-04 22:14 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.