* [PATCH] net-next: mediatek: remove superfluous free_irq() call
@ 2016-07-04 13:37 John Crispin
2016-07-04 13:47 ` Arnd Bergmann
2016-07-05 6:56 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: John Crispin @ 2016-07-04 13:37 UTC (permalink / raw)
To: David S. Miller
Cc: Arnd Bergmann, netdev, linux-mediatek, linux-kernel, John Crispin
Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping")
adds handling for irq 1 and 2 to the uninit function but did not remove
irq 0 which is not used since irq grouping was introduced. Fix this by
removing the superfluous call to free_irq().
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: John Crispin <john@phrozen.org>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index fbab9b2..682797e 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1492,7 +1492,6 @@ static void mtk_uninit(struct net_device *dev)
phy_disconnect(mac->phy_dev);
mtk_mdio_cleanup(eth);
mtk_irq_disable(eth, ~0);
- free_irq(eth->irq[0], dev);
free_irq(eth->irq[1], dev);
free_irq(eth->irq[2], dev);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net-next: mediatek: remove superfluous free_irq() call
2016-07-04 13:37 [PATCH] net-next: mediatek: remove superfluous free_irq() call John Crispin
@ 2016-07-04 13:47 ` Arnd Bergmann
2016-07-05 6:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-07-04 13:47 UTC (permalink / raw)
To: John Crispin; +Cc: David S. Miller, netdev, linux-mediatek, linux-kernel
On Monday, July 4, 2016 3:37:10 PM CEST John Crispin wrote:
> Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping")
> adds handling for irq 1 and 2 to the uninit function but did not remove
> irq 0 which is not used since irq grouping was introduced. Fix this by
> removing the superfluous call to free_irq().
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: John Crispin <john@phrozen.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Thanks for the quick update!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net-next: mediatek: remove superfluous free_irq() call
2016-07-04 13:37 [PATCH] net-next: mediatek: remove superfluous free_irq() call John Crispin
2016-07-04 13:47 ` Arnd Bergmann
@ 2016-07-05 6:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-07-05 6:56 UTC (permalink / raw)
To: john; +Cc: arnd, netdev, linux-mediatek, linux-kernel
From: John Crispin <john@phrozen.org>
Date: Mon, 4 Jul 2016 15:37:10 +0200
> Commit 8067302973a1 ("net-next: mediatek: add support for IRQ grouping")
> adds handling for irq 1 and 2 to the uninit function but did not remove
> irq 0 which is not used since irq grouping was introduced. Fix this by
> removing the superfluous call to free_irq().
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: John Crispin <john@phrozen.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-05 6:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-04 13:37 [PATCH] net-next: mediatek: remove superfluous free_irq() call John Crispin
2016-07-04 13:47 ` Arnd Bergmann
2016-07-05 6:56 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.