From: Philipp Zabel <p.zabel@pengutronix.de>
To: gabriel.fernandez@st.com
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Russell King <linux@armlinux.org.uk>,
patrice.chotard@st.com, alexandre.torgue@st.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] drivers: reset: Add STM32 reset driver
Date: Mon, 04 Jul 2016 19:36:50 +0200 [thread overview]
Message-ID: <1467653810.2224.77.camel@pengutronix.de> (raw)
In-Reply-To: <1467640052-6770-3-git-send-email-gabriel.fernandez@st.com>
Hi Gabriel,
Am Montag, den 04.07.2016, 15:47 +0200 schrieb gabriel.fernandez@st.com:
> From: Gabriel Fernandez <gabriel.fernandez@st.com>
Isn't Maxime the author of this driver?
> The STM32 MCUs family IPs can be reset by accessing some registers
> from the RCC block.
>
> The list of available reset lines is documented in the DT bindings.
>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com>
> ---
> drivers/reset/Makefile | 1 +
> drivers/reset/reset-stm32.c | 113 ++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 114 insertions(+)
> create mode 100644 drivers/reset/reset-stm32.c
>
> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> index 03dc1bb..3776b7b 100644
> --- a/drivers/reset/Makefile
> +++ b/drivers/reset/Makefile
[...]
> +static const struct reset_control_ops stm32_reset_ops = {
> + .assert = stm32_reset_assert,
> + .deassert = stm32_reset_deassert,
Are the registers not readable, or did you choose not to
implement .status on purpose?
regards
Philipp
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: gabriel.fernandez-qxv4g6HH51o@public.gmane.org
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Maxime Coquelin
<mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
patrice.chotard-qxv4g6HH51o@public.gmane.org,
alexandre.torgue-qxv4g6HH51o@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/4] drivers: reset: Add STM32 reset driver
Date: Mon, 04 Jul 2016 19:36:50 +0200 [thread overview]
Message-ID: <1467653810.2224.77.camel@pengutronix.de> (raw)
In-Reply-To: <1467640052-6770-3-git-send-email-gabriel.fernandez-qxv4g6HH51o@public.gmane.org>
Hi Gabriel,
Am Montag, den 04.07.2016, 15:47 +0200 schrieb gabriel.fernandez-qxv4g6HH51o@public.gmane.org:
> From: Gabriel Fernandez <gabriel.fernandez-qxv4g6HH51o@public.gmane.org>
Isn't Maxime the author of this driver?
> The STM32 MCUs family IPs can be reset by accessing some registers
> from the RCC block.
>
> The list of available reset lines is documented in the DT bindings.
>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez-qxv4g6HH51o@public.gmane.org>
> ---
> drivers/reset/Makefile | 1 +
> drivers/reset/reset-stm32.c | 113 ++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 114 insertions(+)
> create mode 100644 drivers/reset/reset-stm32.c
>
> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> index 03dc1bb..3776b7b 100644
> --- a/drivers/reset/Makefile
> +++ b/drivers/reset/Makefile
[...]
> +static const struct reset_control_ops stm32_reset_ops = {
> + .assert = stm32_reset_assert,
> + .deassert = stm32_reset_deassert,
Are the registers not readable, or did you choose not to
implement .status on purpose?
regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] drivers: reset: Add STM32 reset driver
Date: Mon, 04 Jul 2016 19:36:50 +0200 [thread overview]
Message-ID: <1467653810.2224.77.camel@pengutronix.de> (raw)
In-Reply-To: <1467640052-6770-3-git-send-email-gabriel.fernandez@st.com>
Hi Gabriel,
Am Montag, den 04.07.2016, 15:47 +0200 schrieb gabriel.fernandez at st.com:
> From: Gabriel Fernandez <gabriel.fernandez@st.com>
Isn't Maxime the author of this driver?
> The STM32 MCUs family IPs can be reset by accessing some registers
> from the RCC block.
>
> The list of available reset lines is documented in the DT bindings.
>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com>
> ---
> drivers/reset/Makefile | 1 +
> drivers/reset/reset-stm32.c | 113 ++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 114 insertions(+)
> create mode 100644 drivers/reset/reset-stm32.c
>
> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> index 03dc1bb..3776b7b 100644
> --- a/drivers/reset/Makefile
> +++ b/drivers/reset/Makefile
[...]
> +static const struct reset_control_ops stm32_reset_ops = {
> + .assert = stm32_reset_assert,
> + .deassert = stm32_reset_deassert,
Are the registers not readable, or did you choose not to
implement .status on purpose?
regards
Philipp
next prev parent reply other threads:[~2016-07-04 17:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 13:47 [PATCH 1/4] dt-bindings: mfd: Add STM32F4 RCC numeric constants into DT include file gabriel.fernandez
2016-07-04 13:47 ` gabriel.fernandez at st.com
2016-07-04 13:47 ` gabriel.fernandez-qxv4g6HH51o
2016-07-04 13:47 ` [PATCH 2/4] dt-bindings: Document the STM32 reset bindings gabriel.fernandez
2016-07-04 13:47 ` gabriel.fernandez at st.com
2016-07-04 13:47 ` gabriel.fernandez-qxv4g6HH51o
2016-07-04 17:36 ` Philipp Zabel
2016-07-04 17:36 ` Philipp Zabel
2016-07-04 17:36 ` Philipp Zabel
2016-07-05 7:30 ` Gabriel Fernandez
2016-07-05 7:30 ` Gabriel Fernandez
2016-07-05 7:30 ` Gabriel Fernandez
2016-07-05 16:18 ` Rob Herring
2016-07-05 16:18 ` Rob Herring
2016-07-06 7:39 ` Gabriel Fernandez
2016-07-06 7:39 ` Gabriel Fernandez
2016-07-06 7:39 ` Gabriel Fernandez
2016-07-04 13:47 ` [PATCH 3/4] drivers: reset: Add STM32 reset driver gabriel.fernandez
2016-07-04 13:47 ` gabriel.fernandez at st.com
2016-07-04 13:47 ` gabriel.fernandez
2016-07-04 17:36 ` Philipp Zabel [this message]
2016-07-04 17:36 ` Philipp Zabel
2016-07-04 17:36 ` Philipp Zabel
2016-07-05 7:29 ` Gabriel Fernandez
2016-07-05 7:29 ` Gabriel Fernandez
2016-07-05 7:29 ` Gabriel Fernandez
2016-07-05 13:29 ` Philipp Zabel
2016-07-05 13:29 ` Philipp Zabel
2016-07-05 13:29 ` Philipp Zabel
2016-07-06 15:39 ` Gabriel Fernandez
2016-07-06 15:39 ` Gabriel Fernandez
2016-07-06 15:39 ` Gabriel Fernandez
2016-07-06 15:43 ` Philipp Zabel
2016-07-06 15:43 ` Philipp Zabel
2016-07-06 15:43 ` Philipp Zabel
2016-07-05 13:28 ` Philipp Zabel
2016-07-05 13:28 ` Philipp Zabel
2016-07-05 13:28 ` Philipp Zabel
2016-07-06 7:44 ` Gabriel Fernandez
2016-07-06 7:44 ` Gabriel Fernandez
2016-07-06 7:44 ` Gabriel Fernandez
2016-07-04 13:47 ` [PATCH 4/4] ARM: dts: stm32f429: add missing #reset-cells of rcc gabriel.fernandez
2016-07-04 13:47 ` gabriel.fernandez at st.com
2016-07-04 13:47 ` gabriel.fernandez-qxv4g6HH51o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467653810.2224.77.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=gabriel.fernandez@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=patrice.chotard@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.