All of lore.kernel.org
 help / color / mirror / Atom feed
* [B.A.T.M.A.N.] [PATCH] batman-adv-devel: Exchange include order for uapi header files
@ 2016-07-08  9:38 Sven Eckelmann
  2016-07-08  9:50 ` Marek Lindner
  0 siblings, 1 reply; 2+ messages in thread
From: Sven Eckelmann @ 2016-07-08  9:38 UTC (permalink / raw)
  To: b.a.t.m.a.n; +Cc: Sven Eckelmann

The build of netlink.c currently fails because the definition of
GENL_NAMESIZE and similar things are missing. This is is caused by an
incorrect order of backports and non-backports header files mixed up with
uapi and non-uapi header files. Parts of the header files would not get
included by include_next because it not anymore in the remaining search
paths.

Reported: Marek Lindner <marek.lindner@open-mesh.com>
Signed-off-by: Sven Eckelmann <sven.eckelmann@open-mesh.com>
---
Please check again - I might have forgotten something.
---
 batman-adv-devel/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/batman-adv-devel/Makefile b/batman-adv-devel/Makefile
index 60ac5fd..4fa20ab 100644
--- a/batman-adv-devel/Makefile
+++ b/batman-adv-devel/Makefile
@@ -64,10 +64,10 @@ PKG_EXTRA_CFLAGS:= \
 NOSTDINC_FLAGS = \
 	-I$(PKG_BUILD_DIR)/net/batman-adv \
 	-I$(PKG_BUILD_DIR)/include/ \
-	-I$(STAGING_DIR)/usr/include/mac80211-backport/uapi \
 	-I$(STAGING_DIR)/usr/include/mac80211-backport \
-	-I$(STAGING_DIR)/usr/include/mac80211/uapi \
+	-I$(STAGING_DIR)/usr/include/mac80211-backport/uapi \
 	-I$(STAGING_DIR)/usr/include/mac80211 \
+	-I$(STAGING_DIR)/usr/include/mac80211/uapi \
 	-include backport/backport.h \
 	-include $(PKG_BUILD_DIR)/compat-hacks.h \
 	-DBATADV_SOURCE_VERSION=\\\"$(PKG_BATMAN_SHORTREV)\\\" \
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [B.A.T.M.A.N.] [PATCH] batman-adv-devel: Exchange include order for uapi header files
  2016-07-08  9:38 [B.A.T.M.A.N.] [PATCH] batman-adv-devel: Exchange include order for uapi header files Sven Eckelmann
@ 2016-07-08  9:50 ` Marek Lindner
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2016-07-08  9:50 UTC (permalink / raw)
  To: b.a.t.m.a.n; +Cc: Sven Eckelmann

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]

On Friday, July 08, 2016 11:38:35 Sven Eckelmann wrote:
> The build of netlink.c currently fails because the definition of
> GENL_NAMESIZE and similar things are missing. This is is caused by an
> incorrect order of backports and non-backports header files mixed up with
> uapi and non-uapi header files. Parts of the header files would not get
> included by include_next because it not anymore in the remaining search
> paths.
> 
> Reported: Marek Lindner <marek.lindner@open-mesh.com>
> Signed-off-by: Sven Eckelmann <sven.eckelmann@open-mesh.com>
> ---
> Please check again - I might have forgotten something.
> ---
>  batman-adv-devel/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied in revision 5306b0e.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-08  9:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-08  9:38 [B.A.T.M.A.N.] [PATCH] batman-adv-devel: Exchange include order for uapi header files Sven Eckelmann
2016-07-08  9:50 ` Marek Lindner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.