[[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step.

[[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step.

[Aníbal Limón]

DirectoryDownload step is based on UploadDirectory and i miss
to upgrade the error log when the buildslave don't support
downloadDirectory previously said uploadDirectory.

Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
---
 .../site-packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/python2.7/site-packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py b/lib/python2.7/site-packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py
index fb49597..a2f7007 100644
--- a/lib/python2.7/site-packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py
+++ b/lib/python2.7/site-packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py
@@ -487,7 +487,7 @@ class DirectoryDownload(_TransferBuildStep):
         version = self.slaveVersion("downloadDirectory")
 
         if not version:
-            m = "slave is too old, does not know about uploadDirectory"
+            m = "slave is too old, does not know about downloadDirectory"
             raise BuildSlaveTooOldError(m)
 
         # we rely upon the fact that the buildmaster runs chdir'ed into its
-- 
2.1.4

[[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal

[Aníbal Limón]

The error report is generated into AB master and currently we
don't have a method to get AB worker distro, so set to universal.

Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
---
 lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py b/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
index 5b9e408..809bcc3 100644
--- a/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
+++ b/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
@@ -52,7 +52,9 @@ class RunOeSelftest(ShellCommand):
         report['machine'] = 'universal'
         report['build_sys'] = "%s-%s" % (platform.machine(),
                 platform.system().lower())
-        report['nativelsb'] = get_lsb_distro() or 'universal'
+        # XXX: Set to universal because isn't easy to get Autobuilder
+        # worker distro.
+        report['nativelsb'] = 'universal' 
         report['distro'] = 'universal'
         report['target_sys'] = 'universal'
 
-- 
2.1.4

Re: [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal

[Joshua G Lock]

On Mon, 2016-07-11 at 16:37 -0500, Aníbal Limón wrote:
> The error report is generated into AB master and currently we
> don't have a method to get AB worker distro, so set to universal.

Can you elaborate a bit here? Why don't we have a method available to
get the worker distro? Is it because we don't ensure all of the
builders in the cluster include lsb_release?

Are our worker distro versions new enough that we can rely on os-
release?

http://manpages.ubuntu.com/manpages/xenial/en/man5/os-release.5.html

Regards,

Joshua

> 
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>  lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
> | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/python2.7/site-
> packages/autobuilder/buildsteps/RunOeSelftest.py
> b/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
> index 5b9e408..809bcc3 100644
> --- a/lib/python2.7/site-
> packages/autobuilder/buildsteps/RunOeSelftest.py
> +++ b/lib/python2.7/site-
> packages/autobuilder/buildsteps/RunOeSelftest.py
> @@ -52,7 +52,9 @@ class RunOeSelftest(ShellCommand):
>          report['machine'] = 'universal'
>          report['build_sys'] = "%s-%s" % (platform.machine(),
>                  platform.system().lower())
> -        report['nativelsb'] = get_lsb_distro() or 'universal'
> +        # XXX: Set to universal because isn't easy to get
> Autobuilder
> +        # worker distro.
> +        report['nativelsb'] = 'universal' 
>          report['distro'] = 'universal'
>          report['target_sys'] = 'universal'
>  
> -- 
> 2.1.4
> 

Re: [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal

[Aníbal Limón]

[-- Attachment #1: Type: text/plain, Size: 2224 bytes --]



On 07/12/2016 11:09 AM, Joshua G Lock wrote:
> On Mon, 2016-07-11 at 16:37 -0500, Aníbal Limón wrote:
>> The error report is generated into AB master and currently we
>> don't have a method to get AB worker distro, so set to universal.
> 
> Can you elaborate a bit here? Why don't we have a method available to
> get the worker distro? Is it because we don't ensure all of the
> builders in the cluster include lsb_release?

Currently, we don't have an easy way to get the worker distro an
buildstep is needed in order TODO that but isn't trivial.

I propose to have at step at buildinit for get the worker information.
At this time only will be distro. I removed the get_lsb_distro() because
it gets the distro of the master instead of the worker.

I added a bug for this task,

https://bugzilla.yoctoproject.org/show_bug.cgi?id=9917

Cheers,
	alimon


> 
> Are our worker distro versions new enough that we can rely on os-
> release?
> 
> http://manpages.ubuntu.com/manpages/xenial/en/man5/os-release.5.html
> 
> Regards,
> 
> Joshua
> 
>>
>> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
>> ---
>>  lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
>> | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/python2.7/site-
>> packages/autobuilder/buildsteps/RunOeSelftest.py
>> b/lib/python2.7/site-packages/autobuilder/buildsteps/RunOeSelftest.py
>> index 5b9e408..809bcc3 100644
>> --- a/lib/python2.7/site-
>> packages/autobuilder/buildsteps/RunOeSelftest.py
>> +++ b/lib/python2.7/site-
>> packages/autobuilder/buildsteps/RunOeSelftest.py
>> @@ -52,7 +52,9 @@ class RunOeSelftest(ShellCommand):
>>          report['machine'] = 'universal'
>>          report['build_sys'] = "%s-%s" % (platform.machine(),
>>                  platform.system().lower())
>> -        report['nativelsb'] = get_lsb_distro() or 'universal'
>> +        # XXX: Set to universal because isn't easy to get
>> Autobuilder
>> +        # worker distro.
>> +        report['nativelsb'] = 'universal' 
>>          report['distro'] = 'universal'
>>          report['target_sys'] = 'universal'
>>  
>> -- 
>> 2.1.4
>>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal

[Joshua G Lock]

On Tue, 2016-07-12 at 11:21 -0500, Aníbal Limón wrote:
> 
> On 07/12/2016 11:09 AM, Joshua G Lock wrote:
> > On Mon, 2016-07-11 at 16:37 -0500, Aníbal Limón wrote:
> > > The error report is generated into AB master and currently we
> > > don't have a method to get AB worker distro, so set to universal.
> > 
> > Can you elaborate a bit here? Why don't we have a method available
> > to
> > get the worker distro? Is it because we don't ensure all of the
> > builders in the cluster include lsb_release?
> 
> Currently, we don't have an easy way to get the worker distro an
> buildstep is needed in order TODO that but isn't trivial.
> 
> I propose to have at step at buildinit for get the worker
> information.
> At this time only will be distro. I removed the get_lsb_distro()
> because
> it gets the distro of the master instead of the worker.

Could we just extract the value of NATIVELSBSTRING[1] from the build
header in the logs?

Regards,

Joshua

1. http://www.yoctoproject.org/docs/2.1/ref-manual/ref-manual.html#var-
NATIVELSBSTRING

> 
> I added a bug for this task,
> 
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=9917
> 
> Cheers,
> 	alimon
> 
> 
> > 
> > Are our worker distro versions new enough that we can rely on os-
> > release?
> > 
> > http://manpages.ubuntu.com/manpages/xenial/en/man5/os-release.5.htm
> > l
> > 
> > Regards,
> > 
> > Joshua
> > 
> > > 
> > > Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> > > ---
> > >  lib/python2.7/site-
> > > packages/autobuilder/buildsteps/RunOeSelftest.py
> > > > 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/lib/python2.7/site-
> > > packages/autobuilder/buildsteps/RunOeSelftest.py
> > > b/lib/python2.7/site-
> > > packages/autobuilder/buildsteps/RunOeSelftest.py
> > > index 5b9e408..809bcc3 100644
> > > --- a/lib/python2.7/site-
> > > packages/autobuilder/buildsteps/RunOeSelftest.py
> > > +++ b/lib/python2.7/site-
> > > packages/autobuilder/buildsteps/RunOeSelftest.py
> > > @@ -52,7 +52,9 @@ class RunOeSelftest(ShellCommand):
> > >          report['machine'] = 'universal'
> > >          report['build_sys'] = "%s-%s" % (platform.machine(),
> > >                  platform.system().lower())
> > > -        report['nativelsb'] = get_lsb_distro() or 'universal'
> > > +        # XXX: Set to universal because isn't easy to get
> > > Autobuilder
> > > +        # worker distro.
> > > +        report['nativelsb'] = 'universal' 
> > >          report['distro'] = 'universal'
> > >          report['target_sys'] = 'universal'
> > >  
> > > -- 
> > > 2.1.4
> > > 
> 

Re: [[PATCH][yocto-autobuilder] 2/2] buildsteps/RunOeSelftest.py: Set native_lsb to universal

[Aníbal Limón]

[-- Attachment #1: Type: text/plain, Size: 2964 bytes --]



On 07/13/2016 08:32 AM, Joshua G Lock wrote:
> On Tue, 2016-07-12 at 11:21 -0500, Aníbal Limón wrote:
>>
>> On 07/12/2016 11:09 AM, Joshua G Lock wrote:
>>> On Mon, 2016-07-11 at 16:37 -0500, Aníbal Limón wrote:
>>>> The error report is generated into AB master and currently we
>>>> don't have a method to get AB worker distro, so set to universal.
>>>
>>> Can you elaborate a bit here? Why don't we have a method available
>>> to
>>> get the worker distro? Is it because we don't ensure all of the
>>> builders in the cluster include lsb_release?
>>
>> Currently, we don't have an easy way to get the worker distro an
>> buildstep is needed in order TODO that but isn't trivial.
>>
>> I propose to have at step at buildinit for get the worker
>> information.
>> At this time only will be distro. I removed the get_lsb_distro()
>> because
>> it gets the distro of the master instead of the worker.
> 
> Could we just extract the value of NATIVELSBSTRING[1] from the build
> header in the logs?

I use this value in the BuildImages steps because bitbake builds an
image an print that information but for the oe-selftest isn't available
because it executes a different tests suites maybe or not using bitbake.

	alimon

> 
> Regards,
> 
> Joshua
> 
> 1. http://www.yoctoproject.org/docs/2.1/ref-manual/ref-manual.html#var-
> NATIVELSBSTRING
> 
>>
>> I added a bug for this task,
>>
>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=9917
>>
>> Cheers,
>> 	alimon
>>
>>
>>>
>>> Are our worker distro versions new enough that we can rely on os-
>>> release?
>>>
>>> http://manpages.ubuntu.com/manpages/xenial/en/man5/os-release.5.htm
>>> l
>>>
>>> Regards,
>>>
>>> Joshua
>>>
>>>>
>>>> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
>>>> ---
>>>>  lib/python2.7/site-
>>>> packages/autobuilder/buildsteps/RunOeSelftest.py
>>>>> 4 +++-
>>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/lib/python2.7/site-
>>>> packages/autobuilder/buildsteps/RunOeSelftest.py
>>>> b/lib/python2.7/site-
>>>> packages/autobuilder/buildsteps/RunOeSelftest.py
>>>> index 5b9e408..809bcc3 100644
>>>> --- a/lib/python2.7/site-
>>>> packages/autobuilder/buildsteps/RunOeSelftest.py
>>>> +++ b/lib/python2.7/site-
>>>> packages/autobuilder/buildsteps/RunOeSelftest.py
>>>> @@ -52,7 +52,9 @@ class RunOeSelftest(ShellCommand):
>>>>          report['machine'] = 'universal'
>>>>          report['build_sys'] = "%s-%s" % (platform.machine(),
>>>>                  platform.system().lower())
>>>> -        report['nativelsb'] = get_lsb_distro() or 'universal'
>>>> +        # XXX: Set to universal because isn't easy to get
>>>> Autobuilder
>>>> +        # worker distro.
>>>> +        report['nativelsb'] = 'universal' 
>>>>          report['distro'] = 'universal'
>>>>          report['target_sys'] = 'universal'
>>>>  
>>>> -- 
>>>> 2.1.4
>>>>
>>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [[PATCH][yocto-autobuilder] 1/2] buildbot/steps/transfer.py: Fix typo in DirectoryDownload step.

[Joshua G Lock]

This and the 2/2 have been pushed to master, thanks.

Joshua

On Mon, 2016-07-11 at 16:37 -0500, Aníbal Limón wrote:
> DirectoryDownload step is based on UploadDirectory and i miss
> to upgrade the error log when the buildslave don't support
> downloadDirectory previously said uploadDirectory.
> 
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>  .../site-packages/buildbot-0.8.8-
> py2.7.egg/buildbot/steps/transfer.py   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/python2.7/site-packages/buildbot-0.8.8-
> py2.7.egg/buildbot/steps/transfer.py b/lib/python2.7/site-
> packages/buildbot-0.8.8-py2.7.egg/buildbot/steps/transfer.py
> index fb49597..a2f7007 100644
> --- a/lib/python2.7/site-packages/buildbot-0.8.8-
> py2.7.egg/buildbot/steps/transfer.py
> +++ b/lib/python2.7/site-packages/buildbot-0.8.8-
> py2.7.egg/buildbot/steps/transfer.py
> @@ -487,7 +487,7 @@ class DirectoryDownload(_TransferBuildStep):
>          version = self.slaveVersion("downloadDirectory")
>  
>          if not version:
> -            m = "slave is too old, does not know about
> uploadDirectory"
> +            m = "slave is too old, does not know about
> downloadDirectory"
>              raise BuildSlaveTooOldError(m)
>  
>          # we rely upon the fact that the buildmaster runs chdir'ed
> into its
> -- 
> 2.1.4
>