All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel@redhat.com, qemu-ppc@nongnu.org, qemu-arm@nongnu.org,
	rth@twiddle.net, aurelien@aurel32.net, leon.alrae@imgtec.com,
	agraf@suse.de, peter.maydell@linaro.org,
	mark.cave-ayland@ilande.co.uk, mst@redhat.com, thuth@redhat.com
Subject: [Qemu-devel]  [PATCH 3/7] hw/mips: fix PCI bus initialization
Date: Thu, 14 Jul 2016 16:43:42 +0300	[thread overview]
Message-ID: <1468503826-10617-4-git-send-email-marcel@redhat.com> (raw)
In-Reply-To: <1468503826-10617-1-git-send-email-marcel@redhat.com>

Delay the host-bridge 'realization' until the
PCI root bus is attached.

Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
 hw/mips/gt64xxx_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c
index 3f4523d..4811843 100644
--- a/hw/mips/gt64xxx_pci.c
+++ b/hw/mips/gt64xxx_pci.c
@@ -1167,7 +1167,6 @@ PCIBus *gt64120_register(qemu_irq *pic)
     DeviceState *dev;
 
     dev = qdev_create(NULL, TYPE_GT64120_PCI_HOST_BRIDGE);
-    qdev_init_nofail(dev);
     d = GT64120_PCI_HOST_BRIDGE(dev);
     phb = PCI_HOST_BRIDGE(dev);
     memory_region_init(&d->pci0_mem, OBJECT(dev), "pci0-mem", UINT32_MAX);
@@ -1178,6 +1177,7 @@ PCIBus *gt64120_register(qemu_irq *pic)
                                 &d->pci0_mem,
                                 get_system_io(),
                                 PCI_DEVFN(18, 0), 4, TYPE_PCI_BUS);
+    qdev_init_nofail(dev);
     memory_region_init_io(&d->ISD_mem, OBJECT(dev), &isd_mem_ops, d, "isd-mem", 0x1000);
 
     pci_create_simple(phb->bus, PCI_DEVFN(0, 0), "gt64120_pci");
-- 
2.4.3

  parent reply	other threads:[~2016-07-14 13:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 13:43 [Qemu-devel] [PATCH 0/7] hw/pci-bus: Fix PCI bus regression on several archs Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-devel] [PATCH 1/7] tests/prom-env-test: increase the test timeout Marcel Apfelbaum
2016-07-14 13:51   ` Thomas Huth
2016-07-14 15:19     ` Marcel Apfelbaum
2016-07-18 19:34     ` Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-devel] [PATCH 2/7] hw/alpha: fix PCI bus initialization Marcel Apfelbaum
2016-07-14 13:43 ` Marcel Apfelbaum [this message]
2016-07-15 12:31   ` [Qemu-devel] [PATCH 3/7] hw/mips: " Leon Alrae
2016-07-14 13:43 ` [Qemu-devel] [PATCH 4/7] hw/apb: " Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-devel] [PATCH 5/7] hw/grackle: " Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-devel] [PATCH 6/7] hw/prep: realize the PCI root bus as part of the prep init Marcel Apfelbaum
2016-07-14 13:43 ` [Qemu-devel] [PATCH 7/7] hw/versatile: realize the PCI root bus as part of the versatile init Marcel Apfelbaum
2016-07-15 15:05 ` [Qemu-devel] [PATCH 0/7] hw/pci-bus: Fix PCI bus regression on several archs Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468503826-10617-4-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=leon.alrae@imgtec.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.