Re: [Qemu-devel] [PATCH 1/7] tests/prom-env-test: increase the test timeout

From: Thomas Huth <thuth@redhat.com>
To: Marcel Apfelbaum <marcel@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, rth@twiddle.net,
	aurelien@aurel32.net, leon.alrae@imgtec.com, agraf@suse.de,
	peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk,
	mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/7] tests/prom-env-test: increase the test timeout
Date: Thu, 14 Jul 2016 15:51:53 +0200	[thread overview]
Message-ID: <c4294e73-88a1-ba9b-9e52-3527b142ae57@redhat.com> (raw)
In-Reply-To: <1468503826-10617-2-git-send-email-marcel@redhat.com>

On 14.07.2016 15:43, Marcel Apfelbaum wrote:
> On a slower machine the test can take more than 30 seconds.
> Increase the timeout to 100 seconds.
> 
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
>  tests/prom-env-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/prom-env-test.c b/tests/prom-env-test.c
> index 6df57d2..7a62857 100644
> --- a/tests/prom-env-test.c
> +++ b/tests/prom-env-test.c
> @@ -30,7 +30,7 @@ static void check_guest_memory(void)
>      int i;
>  
>      /* Poll until code has run and modified memory. Wait at most 30 seconds */
> -    for (i = 0; i < 3000; ++i) {
> +    for (i = 0; i < 10000; ++i) {
>          signature = readl(ADDRESS);
>          if (signature == MAGIC) {
>              break;

Ack, but could you please also update the comment before the for-loop?

 Thanks,
  Thomas