All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915:gen9: restrict WaC6DisallowByGfxPause
@ 2016-07-15 13:49 tim.gore
  2016-07-15 14:12 ` ✗ Ro.CI.BAT: failure for " Patchwork
  2016-07-19  6:56 ` [PATCH] " Kamble, Sagar A
  0 siblings, 2 replies; 4+ messages in thread
From: tim.gore @ 2016-07-15 13:49 UTC (permalink / raw)
  To: intel-gfx

From: Tim Gore <tim.gore@intel.com>

WaC6DisallowByGfxPause is currently applied unconditionally
but is not required in all revisions.

References: HSD#2133391
Signed-off-by: Tim Gore <tim.gore@intel.com>
---
 drivers/gpu/drm/i915/intel_guc_loader.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c
index 605c696..173dcef 100644
--- a/drivers/gpu/drm/i915/intel_guc_loader.c
+++ b/drivers/gpu/drm/i915/intel_guc_loader.c
@@ -349,7 +349,9 @@ static int guc_ucode_xfer(struct drm_i915_private *dev_priv)
 	}
 
 	/* WaC6DisallowByGfxPause*/
-	I915_WRITE(GEN6_GFXPAUSE, 0x30FFF);
+	if (IS_SKL_REVID(dev, 0, SKL_REVID_B0) ||
+	    IS_BXT_REVID(dev, 0, BXT_REVID_A1))
+		I915_WRITE(GEN6_GFXPAUSE, 0x30FFF);
 
 	if (IS_BROXTON(dev))
 		I915_WRITE(GEN9LP_GT_PM_CONFIG, GT_DOORBELL_ENABLE);
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* ✗ Ro.CI.BAT: failure for drm/i915:gen9: restrict WaC6DisallowByGfxPause
  2016-07-15 13:49 [PATCH] drm/i915:gen9: restrict WaC6DisallowByGfxPause tim.gore
@ 2016-07-15 14:12 ` Patchwork
  2016-07-19  6:56 ` [PATCH] " Kamble, Sagar A
  1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-07-15 14:12 UTC (permalink / raw)
  To: tim.gore; +Cc: intel-gfx

== Series Details ==

Series: drm/i915:gen9: restrict WaC6DisallowByGfxPause
URL   : https://patchwork.freedesktop.org/series/9930/
State : failure

== Summary ==

Series 9930v1 drm/i915:gen9: restrict WaC6DisallowByGfxPause
http://patchwork.freedesktop.org/api/1.0/series/9930/revisions/1/mbox

Test gem_exec_suspend:
        Subgroup basic-s3:
                incomplete -> PASS       (fi-hsw-i7-4770k)
                dmesg-warn -> PASS       (ro-bdw-i7-5557U)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a-frame-sequence:
                fail       -> PASS       (ro-byt-n2820)
        Subgroup read-crc-pipe-c:
                skip       -> PASS       (fi-skl-i5-6260u)
        Subgroup suspend-read-crc-pipe-a:
                pass       -> INCOMPLETE (fi-skl-i7-6700k)

fi-hsw-i7-4770k  total:241  pass:210  dwarn:0   dfail:0   fail:7   skip:24 
fi-kbl-qkkr      total:241  pass:174  dwarn:26  dfail:1   fail:9   skip:31 
fi-skl-i5-6260u  total:241  pass:218  dwarn:0   dfail:0   fail:7   skip:16 
fi-skl-i7-6700k  total:195  pass:170  dwarn:0   dfail:0   fail:0   skip:24 
fi-snb-i7-2600   total:195  pass:162  dwarn:0   dfail:0   fail:0   skip:32 
ro-bdw-i5-5250u  total:242  pass:214  dwarn:4   dfail:0   fail:7   skip:17 
ro-bdw-i7-5557U  total:242  pass:215  dwarn:0   dfail:0   fail:7   skip:20 
ro-bdw-i7-5600u  total:242  pass:200  dwarn:0   dfail:0   fail:7   skip:35 
ro-bsw-n3050     total:218  pass:173  dwarn:0   dfail:0   fail:2   skip:42 
ro-byt-n2820     total:242  pass:191  dwarn:0   dfail:0   fail:9   skip:42 
ro-hsw-i3-4010u  total:242  pass:206  dwarn:0   dfail:0   fail:8   skip:28 
ro-hsw-i7-4770r  total:242  pass:206  dwarn:0   dfail:0   fail:8   skip:28 
ro-ilk-i7-620lm  total:242  pass:166  dwarn:0   dfail:0   fail:9   skip:67 
ro-ilk1-i5-650   total:237  pass:166  dwarn:0   dfail:0   fail:9   skip:62 
ro-ivb-i7-3770   total:242  pass:197  dwarn:0   dfail:0   fail:8   skip:37 
ro-skl3-i5-6260u total:242  pass:218  dwarn:1   dfail:0   fail:7   skip:16 
ro-snb-i7-2620M  total:242  pass:188  dwarn:0   dfail:0   fail:9   skip:45 
fi-bsw-n3050 failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1504/

26b8bdb drm-intel-nightly: 2016y-07m-15d-12h-47m-23s UTC integration manifest
cc07d00 drm/i915:gen9: restrict WaC6DisallowByGfxPause

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915:gen9: restrict WaC6DisallowByGfxPause
  2016-07-15 13:49 [PATCH] drm/i915:gen9: restrict WaC6DisallowByGfxPause tim.gore
  2016-07-15 14:12 ` ✗ Ro.CI.BAT: failure for " Patchwork
@ 2016-07-19  6:56 ` Kamble, Sagar A
  2016-07-19  9:56   ` Gore, Tim
  1 sibling, 1 reply; 4+ messages in thread
From: Kamble, Sagar A @ 2016-07-19  6:56 UTC (permalink / raw)
  To: tim.gore; +Cc: intel-gfx



On 7/15/2016 7:19 PM, tim.gore@intel.com wrote:
> From: Tim Gore <tim.gore@intel.com>
>
> WaC6DisallowByGfxPause is currently applied unconditionally
> but is not required in all revisions.
>
> References: HSD#2133391
> Signed-off-by: Tim Gore <tim.gore@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_guc_loader.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c
> index 605c696..173dcef 100644
> --- a/drivers/gpu/drm/i915/intel_guc_loader.c
> +++ b/drivers/gpu/drm/i915/intel_guc_loader.c
> @@ -349,7 +349,9 @@ static int guc_ucode_xfer(struct drm_i915_private *dev_priv)
>   	}
>   
>   	/* WaC6DisallowByGfxPause*/
> -	I915_WRITE(GEN6_GFXPAUSE, 0x30FFF);
> +	if (IS_SKL_REVID(dev, 0, SKL_REVID_B0) ||
> +	    IS_BXT_REVID(dev, 0, BXT_REVID_A1))
I see this is applicable till BXT B0 and SKL C0 in wa_database. Am I 
missing something?
> +		I915_WRITE(GEN6_GFXPAUSE, 0x30FFF);
>   
>   	if (IS_BROXTON(dev))
>   		I915_WRITE(GEN9LP_GT_PM_CONFIG, GT_DOORBELL_ENABLE);

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915:gen9: restrict WaC6DisallowByGfxPause
  2016-07-19  6:56 ` [PATCH] " Kamble, Sagar A
@ 2016-07-19  9:56   ` Gore, Tim
  0 siblings, 0 replies; 4+ messages in thread
From: Gore, Tim @ 2016-07-19  9:56 UTC (permalink / raw)
  To: Kamble, Sagar A; +Cc: intel-gfx



Tim Gore 
Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ

> -----Original Message-----
> From: Kamble, Sagar A
> Sent: Tuesday, July 19, 2016 7:56 AM
> To: Gore, Tim
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915:gen9: restrict
> WaC6DisallowByGfxPause
> 
> 
> 
> On 7/15/2016 7:19 PM, tim.gore@intel.com wrote:
> > From: Tim Gore <tim.gore@intel.com>
> >
> > WaC6DisallowByGfxPause is currently applied unconditionally but is not
> > required in all revisions.
> >
> > References: HSD#2133391
> > Signed-off-by: Tim Gore <tim.gore@intel.com>
> > ---
> >   drivers/gpu/drm/i915/intel_guc_loader.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c
> > b/drivers/gpu/drm/i915/intel_guc_loader.c
> > index 605c696..173dcef 100644
> > --- a/drivers/gpu/drm/i915/intel_guc_loader.c
> > +++ b/drivers/gpu/drm/i915/intel_guc_loader.c
> > @@ -349,7 +349,9 @@ static int guc_ucode_xfer(struct drm_i915_private
> *dev_priv)
> >   	}
> >
> >   	/* WaC6DisallowByGfxPause*/
> > -	I915_WRITE(GEN6_GFXPAUSE, 0x30FFF);
> > +	if (IS_SKL_REVID(dev, 0, SKL_REVID_B0) ||
> > +	    IS_BXT_REVID(dev, 0, BXT_REVID_A1))
> I see this is applicable till BXT B0 and SKL C0 in wa_database. Am I missing
> something?

  The HSD (ref'd above) indicates that this problem is fixed in Bxt B0 and Skl C0.
I wasn't sure whether to follow the HSD or prior art.?

> > +		I915_WRITE(GEN6_GFXPAUSE, 0x30FFF);
> >
> >   	if (IS_BROXTON(dev))
> >   		I915_WRITE(GEN9LP_GT_PM_CONFIG,
> GT_DOORBELL_ENABLE);

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-19  9:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-15 13:49 [PATCH] drm/i915:gen9: restrict WaC6DisallowByGfxPause tim.gore
2016-07-15 14:12 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-07-19  6:56 ` [PATCH] " Kamble, Sagar A
2016-07-19  9:56   ` Gore, Tim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.