All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Turquette <mturquette@baylibre.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-clk@vger.kernel.org
Cc: "Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Jay Sternberg" <jay.e.sternberg@intel.com>,
	"Jens Axboe" <axboe@fb.com>,
	linux-kernel@vger.kernel.org,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Matias Bjørling" <m@bjorling.me>,
	"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Valentin Rothberg" <valentinrothberg@gmail.com>
Subject: Re: [PATCH] clk: probe common clock drivers earlier
Date: Fri, 15 Jul 2016 19:11:16 -0700	[thread overview]
Message-ID: <146863507652.73491.7469412916688579441@resonance> (raw)
In-Reply-To: <1462435037-27979-1-git-send-email-yamada.masahiro@socionext.com>

Quoting Masahiro Yamada (2016-05-05 00:57:17)
> Several SoCs implement platform drivers for clocks rather than
> CLK_OF_DECLARE().  Clocks should come earlier because they are
> prerequisites for many of other drivers.  It will help to mitigate
> EPROBE_DEFER issues.
> 
> Also, drop the comment since it does not look valuable.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Michael Turquette <mturquette@baylibre.com>

Regards,
Mike

> ---
> 
>  drivers/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 8f5d076..a2a4922 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -44,6 +44,7 @@ obj-$(CONFIG_REGULATOR)               += regulator/
>  
>  # reset controllers early, since gpu drivers might rely on them to initialize
>  obj-$(CONFIG_RESET_CONTROLLER) += reset/
> +obj-y                          += clk/
>  
>  # tty/ comes before char/ so that the VT console is the boot-time
>  # default.
> @@ -141,8 +142,6 @@ obj-$(CONFIG_VHOST_RING)    += vhost/
>  obj-$(CONFIG_VLYNQ)            += vlynq/
>  obj-$(CONFIG_STAGING)          += staging/
>  obj-y                          += platform/
> -#common clk code
> -obj-y                          += clk/
>  
>  obj-$(CONFIG_MAILBOX)          += mailbox/
>  obj-$(CONFIG_HWSPINLOCK)       += hwspinlock/
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Michael Turquette <mturquette@baylibre.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	 linux-clk@vger.kernel.org
Cc: "Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Jay Sternberg" <jay.e.sternberg@intel.com>,
	"Jens Axboe" <axboe@fb.com>,
	linux-kernel@vger.kernel.org,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Matias Bjørling" <m@bjorling.me>,
	"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Valentin Rothberg" <valentinrothberg@gmail.com>
Subject: Re: [PATCH] clk: probe common clock drivers earlier
Date: Fri, 15 Jul 2016 19:11:16 -0700	[thread overview]
Message-ID: <146863507652.73491.7469412916688579441@resonance> (raw)
In-Reply-To: <1462435037-27979-1-git-send-email-yamada.masahiro@socionext.com>

Quoting Masahiro Yamada (2016-05-05 00:57:17)
> Several SoCs implement platform drivers for clocks rather than
> CLK_OF_DECLARE().  Clocks should come earlier because they are
> prerequisites for many of other drivers.  It will help to mitigate
> EPROBE_DEFER issues.
> =

> Also, drop the comment since it does not look valuable.
> =

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Michael Turquette <mturquette@baylibre.com>

Regards,
Mike

> ---
> =

>  drivers/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> =

> diff --git a/drivers/Makefile b/drivers/Makefile
> index 8f5d076..a2a4922 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -44,6 +44,7 @@ obj-$(CONFIG_REGULATOR)               +=3D regulator/
>  =

>  # reset controllers early, since gpu drivers might rely on them to initi=
alize
>  obj-$(CONFIG_RESET_CONTROLLER) +=3D reset/
> +obj-y                          +=3D clk/
>  =

>  # tty/ comes before char/ so that the VT console is the boot-time
>  # default.
> @@ -141,8 +142,6 @@ obj-$(CONFIG_VHOST_RING)    +=3D vhost/
>  obj-$(CONFIG_VLYNQ)            +=3D vlynq/
>  obj-$(CONFIG_STAGING)          +=3D staging/
>  obj-y                          +=3D platform/
> -#common clk code
> -obj-y                          +=3D clk/
>  =

>  obj-$(CONFIG_MAILBOX)          +=3D mailbox/
>  obj-$(CONFIG_HWSPINLOCK)       +=3D hwspinlock/
> -- =

> 1.9.1
> =

> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-07-16  2:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-05  7:57 [PATCH] clk: probe common clock drivers earlier Masahiro Yamada
2016-07-15 21:53 ` Linus Torvalds
2016-07-16  2:11 ` Michael Turquette [this message]
2016-07-16  2:11   ` Michael Turquette
2016-07-16  4:57   ` Masahiro Yamada
2016-07-20 10:58     ` Geert Uytterhoeven
2016-07-21  0:59       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=146863507652.73491.7469412916688579441@resonance \
    --to=mturquette@baylibre.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=axboe@fb.com \
    --cc=dan.j.williams@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jay.e.sternberg@intel.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m@bjorling.me \
    --cc=valentinrothberg@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.