* [Qemu-devel] [PATCH qemu] xhci: Fix possible side effect from assert()
@ 2016-07-18 3:29 Alexey Kardashevskiy
0 siblings, 0 replies; only message in thread
From: Alexey Kardashevskiy @ 2016-07-18 3:29 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy, Gerd Hoffmann
A static analysis tool called BEAM detected possible side effect from
assert() calling a helper which may change an XHCI ring after every call.
This moves xhci_ring_fetch() out of assert() so it will be called
with and without enabled debug.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
hw/usb/hcd-xhci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 976bfb0..188f954 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2201,7 +2201,9 @@ static void xhci_kick_ep(XHCIState *xhci, unsigned int slotid,
xfer->trb_count = length;
for (i = 0; i < length; i++) {
- assert(xhci_ring_fetch(xhci, ring, &xfer->trbs[i], NULL));
+ TRBType type;
+ type = xhci_ring_fetch(xhci, ring, &xfer->trbs[i], NULL);
+ assert(type);
}
xfer->streamid = streamid;
--
2.5.0.rc3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-07-18 3:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-18 3:29 [Qemu-devel] [PATCH qemu] xhci: Fix possible side effect from assert() Alexey Kardashevskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.