From: "Michael S. Tsirkin" <mst@redhat.com> To: qemu-devel@nongnu.org Cc: Peter Maydell <peter.maydell@linaro.org>, Peter Xu <peterx@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org Subject: [PULL v4 24/57] intel_iommu: add support for split irqchip Date: Thu, 21 Jul 2016 19:27:58 +0300 [thread overview] Message-ID: <1469118288-4776-25-git-send-email-mst@redhat.com> (raw) In-Reply-To: <1469118288-4776-1-git-send-email-mst@redhat.com> From: Peter Xu <peterx@redhat.com> In split irqchip mode, IOAPIC is working in user space, only update kernel irq routes when entry changed. When IR is enabled, we directly update the kernel with translated messages. It works just like a kernel cache for the remapping entries. Since KVM irqfd is using kernel gsi routes to deliver interrupts, as long as we can support split irqchip, we will support irqfd as well. Also, since kernel gsi routes will cache translated interrupts, irqfd delivery will not suffer from any performance impact due to IR. And, since we supported irqfd, vhost devices will be able to work seamlessly with IR now. Logically this should contain both vhost-net and vhost-user case. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> [move trace-events lines into target-i386/trace-events] Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- Makefile.objs | 1 + include/hw/i386/intel_iommu.h | 1 + include/hw/i386/x86-iommu.h | 5 +++++ hw/i386/intel_iommu.c | 7 +++++++ target-i386/kvm.c | 27 +++++++++++++++++++++++++++ target-i386/trace-events | 4 ++++ 6 files changed, 45 insertions(+) create mode 100644 target-i386/trace-events diff --git a/Makefile.objs b/Makefile.objs index 7f1f0a3..6d5ddcf 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -153,6 +153,7 @@ trace-events-y += hw/alpha/trace-events trace-events-y += ui/trace-events trace-events-y += audio/trace-events trace-events-y += net/trace-events +trace-events-y += target-i386/trace-events trace-events-y += target-sparc/trace-events trace-events-y += target-s390x/trace-events trace-events-y += target-ppc/trace-events diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h index cdbbddd..e048ced 100644 --- a/include/hw/i386/intel_iommu.h +++ b/include/hw/i386/intel_iommu.h @@ -26,6 +26,7 @@ #include "hw/i386/x86-iommu.h" #include "hw/i386/ioapic.h" #include "hw/pci/msi.h" +#include "hw/sysbus.h" #define TYPE_INTEL_IOMMU_DEVICE "intel-iommu" #define INTEL_IOMMU_DEVICE(obj) \ diff --git a/include/hw/i386/x86-iommu.h b/include/hw/i386/x86-iommu.h index 699dd06..fa6ce31 100644 --- a/include/hw/i386/x86-iommu.h +++ b/include/hw/i386/x86-iommu.h @@ -21,6 +21,7 @@ #define IOMMU_COMMON_H #include "hw/sysbus.h" +#include "hw/pci/pci.h" #define TYPE_X86_IOMMU_DEVICE ("x86-iommu") #define X86_IOMMU_DEVICE(obj) \ @@ -31,6 +32,7 @@ OBJECT_GET_CLASS(X86IOMMUClass, obj, TYPE_X86_IOMMU_DEVICE) #define X86_IOMMU_PCI_DEVFN_MAX 256 +#define X86_IOMMU_SID_INVALID (0xffff) typedef struct X86IOMMUState X86IOMMUState; typedef struct X86IOMMUClass X86IOMMUClass; @@ -39,6 +41,9 @@ struct X86IOMMUClass { SysBusDeviceClass parent; /* Intel/AMD specific realize() hook */ DeviceRealize realize; + /* MSI-based interrupt remapping */ + int (*int_remap)(X86IOMMUState *iommu, MSIMessage *src, + MSIMessage *dst, uint16_t sid); }; struct X86IOMMUState { diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 9066cda..ebc7531 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2165,6 +2165,12 @@ do_not_translate: return 0; } +static int vtd_int_remap(X86IOMMUState *iommu, MSIMessage *src, + MSIMessage *dst, uint16_t sid) +{ + return vtd_interrupt_remap_msi(INTEL_IOMMU_DEVICE(iommu), src, dst); +} + static MemTxResult vtd_mem_ir_read(void *opaque, hwaddr addr, uint64_t *data, unsigned size, MemTxAttrs attrs) @@ -2399,6 +2405,7 @@ static void vtd_class_init(ObjectClass *klass, void *data) dc->props = vtd_properties; dc->hotpluggable = false; x86_class->realize = vtd_realize; + x86_class->int_remap = vtd_int_remap; } static const TypeInfo vtd_info = { diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 9327523..9c00e48 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -35,6 +35,7 @@ #include "hw/i386/apic.h" #include "hw/i386/apic_internal.h" #include "hw/i386/apic-msidef.h" +#include "hw/i386/intel_iommu.h" #include "exec/ioport.h" #include "standard-headers/asm-x86/hyperv.h" @@ -42,6 +43,7 @@ #include "hw/pci/msi.h" #include "migration/migration.h" #include "exec/memattrs.h" +#include "trace.h" //#define DEBUG_KVM @@ -3371,6 +3373,31 @@ int kvm_device_msix_deassign(KVMState *s, uint32_t dev_id) int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route, uint64_t address, uint32_t data, PCIDevice *dev) { + X86IOMMUState *iommu = x86_iommu_get_default(); + + if (iommu) { + int ret; + MSIMessage src, dst; + X86IOMMUClass *class = X86_IOMMU_GET_CLASS(iommu); + + src.address = route->u.msi.address_hi; + src.address <<= VTD_MSI_ADDR_HI_SHIFT; + src.address |= route->u.msi.address_lo; + src.data = route->u.msi.data; + + ret = class->int_remap(iommu, &src, &dst, dev ? \ + pci_requester_id(dev) : \ + X86_IOMMU_SID_INVALID); + if (ret) { + trace_kvm_x86_fixup_msi_error(route->gsi); + return 1; + } + + route->u.msi.address_hi = dst.address >> VTD_MSI_ADDR_HI_SHIFT; + route->u.msi.address_lo = dst.address & VTD_MSI_ADDR_LO_MASK; + route->u.msi.data = dst.data; + } + return 0; } diff --git a/target-i386/trace-events b/target-i386/trace-events new file mode 100644 index 0000000..2113075 --- /dev/null +++ b/target-i386/trace-events @@ -0,0 +1,4 @@ +# See docs/trace-events.txt for syntax documentation. + +# target-i386/kvm.c +kvm_x86_fixup_msi_error(uint32_t gsi) "VT-d failed to remap interrupt for GSI %" PRIu32 -- MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: qemu-devel@nongnu.org Cc: Peter Maydell <peter.maydell@linaro.org>, Peter Xu <peterx@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org Subject: [Qemu-devel] [PULL v4 24/57] intel_iommu: add support for split irqchip Date: Thu, 21 Jul 2016 19:27:58 +0300 [thread overview] Message-ID: <1469118288-4776-25-git-send-email-mst@redhat.com> (raw) In-Reply-To: <1469118288-4776-1-git-send-email-mst@redhat.com> From: Peter Xu <peterx@redhat.com> In split irqchip mode, IOAPIC is working in user space, only update kernel irq routes when entry changed. When IR is enabled, we directly update the kernel with translated messages. It works just like a kernel cache for the remapping entries. Since KVM irqfd is using kernel gsi routes to deliver interrupts, as long as we can support split irqchip, we will support irqfd as well. Also, since kernel gsi routes will cache translated interrupts, irqfd delivery will not suffer from any performance impact due to IR. And, since we supported irqfd, vhost devices will be able to work seamlessly with IR now. Logically this should contain both vhost-net and vhost-user case. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> [move trace-events lines into target-i386/trace-events] Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- Makefile.objs | 1 + include/hw/i386/intel_iommu.h | 1 + include/hw/i386/x86-iommu.h | 5 +++++ hw/i386/intel_iommu.c | 7 +++++++ target-i386/kvm.c | 27 +++++++++++++++++++++++++++ target-i386/trace-events | 4 ++++ 6 files changed, 45 insertions(+) create mode 100644 target-i386/trace-events diff --git a/Makefile.objs b/Makefile.objs index 7f1f0a3..6d5ddcf 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -153,6 +153,7 @@ trace-events-y += hw/alpha/trace-events trace-events-y += ui/trace-events trace-events-y += audio/trace-events trace-events-y += net/trace-events +trace-events-y += target-i386/trace-events trace-events-y += target-sparc/trace-events trace-events-y += target-s390x/trace-events trace-events-y += target-ppc/trace-events diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h index cdbbddd..e048ced 100644 --- a/include/hw/i386/intel_iommu.h +++ b/include/hw/i386/intel_iommu.h @@ -26,6 +26,7 @@ #include "hw/i386/x86-iommu.h" #include "hw/i386/ioapic.h" #include "hw/pci/msi.h" +#include "hw/sysbus.h" #define TYPE_INTEL_IOMMU_DEVICE "intel-iommu" #define INTEL_IOMMU_DEVICE(obj) \ diff --git a/include/hw/i386/x86-iommu.h b/include/hw/i386/x86-iommu.h index 699dd06..fa6ce31 100644 --- a/include/hw/i386/x86-iommu.h +++ b/include/hw/i386/x86-iommu.h @@ -21,6 +21,7 @@ #define IOMMU_COMMON_H #include "hw/sysbus.h" +#include "hw/pci/pci.h" #define TYPE_X86_IOMMU_DEVICE ("x86-iommu") #define X86_IOMMU_DEVICE(obj) \ @@ -31,6 +32,7 @@ OBJECT_GET_CLASS(X86IOMMUClass, obj, TYPE_X86_IOMMU_DEVICE) #define X86_IOMMU_PCI_DEVFN_MAX 256 +#define X86_IOMMU_SID_INVALID (0xffff) typedef struct X86IOMMUState X86IOMMUState; typedef struct X86IOMMUClass X86IOMMUClass; @@ -39,6 +41,9 @@ struct X86IOMMUClass { SysBusDeviceClass parent; /* Intel/AMD specific realize() hook */ DeviceRealize realize; + /* MSI-based interrupt remapping */ + int (*int_remap)(X86IOMMUState *iommu, MSIMessage *src, + MSIMessage *dst, uint16_t sid); }; struct X86IOMMUState { diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 9066cda..ebc7531 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2165,6 +2165,12 @@ do_not_translate: return 0; } +static int vtd_int_remap(X86IOMMUState *iommu, MSIMessage *src, + MSIMessage *dst, uint16_t sid) +{ + return vtd_interrupt_remap_msi(INTEL_IOMMU_DEVICE(iommu), src, dst); +} + static MemTxResult vtd_mem_ir_read(void *opaque, hwaddr addr, uint64_t *data, unsigned size, MemTxAttrs attrs) @@ -2399,6 +2405,7 @@ static void vtd_class_init(ObjectClass *klass, void *data) dc->props = vtd_properties; dc->hotpluggable = false; x86_class->realize = vtd_realize; + x86_class->int_remap = vtd_int_remap; } static const TypeInfo vtd_info = { diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 9327523..9c00e48 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -35,6 +35,7 @@ #include "hw/i386/apic.h" #include "hw/i386/apic_internal.h" #include "hw/i386/apic-msidef.h" +#include "hw/i386/intel_iommu.h" #include "exec/ioport.h" #include "standard-headers/asm-x86/hyperv.h" @@ -42,6 +43,7 @@ #include "hw/pci/msi.h" #include "migration/migration.h" #include "exec/memattrs.h" +#include "trace.h" //#define DEBUG_KVM @@ -3371,6 +3373,31 @@ int kvm_device_msix_deassign(KVMState *s, uint32_t dev_id) int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route, uint64_t address, uint32_t data, PCIDevice *dev) { + X86IOMMUState *iommu = x86_iommu_get_default(); + + if (iommu) { + int ret; + MSIMessage src, dst; + X86IOMMUClass *class = X86_IOMMU_GET_CLASS(iommu); + + src.address = route->u.msi.address_hi; + src.address <<= VTD_MSI_ADDR_HI_SHIFT; + src.address |= route->u.msi.address_lo; + src.data = route->u.msi.data; + + ret = class->int_remap(iommu, &src, &dst, dev ? \ + pci_requester_id(dev) : \ + X86_IOMMU_SID_INVALID); + if (ret) { + trace_kvm_x86_fixup_msi_error(route->gsi); + return 1; + } + + route->u.msi.address_hi = dst.address >> VTD_MSI_ADDR_HI_SHIFT; + route->u.msi.address_lo = dst.address & VTD_MSI_ADDR_LO_MASK; + route->u.msi.data = dst.data; + } + return 0; } diff --git a/target-i386/trace-events b/target-i386/trace-events new file mode 100644 index 0000000..2113075 --- /dev/null +++ b/target-i386/trace-events @@ -0,0 +1,4 @@ +# See docs/trace-events.txt for syntax documentation. + +# target-i386/kvm.c +kvm_x86_fixup_msi_error(uint32_t gsi) "VT-d failed to remap interrupt for GSI %" PRIu32 -- MST
next prev parent reply other threads:[~2016-07-21 16:28 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-21 16:26 [Qemu-devel] [PULL v4 00/57] pc, pci, virtio: new features, cleanups, fixes Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 01/57] nvdimm: fix memory leak in error code path Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 02/57] tests/prom-env-test: increase the test timeout Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 03/57] hw/alpha: fix PCI bus initialization Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 04/57] hw/mips: " Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 05/57] hw/apb: " Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 06/57] hw/grackle: " Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 07/57] hw/prep: realize the PCI root bus as part of the prep init Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 08/57] hw/versatile: realize the PCI root bus as part of the versatile init Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 09/57] x86-iommu: introduce parent class Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 10/57] intel_iommu: rename VTD_PCI_DEVFN_MAX to x86-iommu Michael S. Tsirkin 2016-07-21 16:26 ` [Qemu-devel] [PULL v4 11/57] x86-iommu: provide x86_iommu_get_default Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 12/57] x86-iommu: introduce "intremap" property Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 13/57] acpi: enable INTR for DMAR report structure Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 14/57] intel_iommu: allow queued invalidation for IR Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 15/57] intel_iommu: set IR bit for ECAP register Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 16/57] acpi: add DMAR scope definition for root IOAPIC Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 17/57] intel_iommu: define interrupt remap table addr register Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 18/57] intel_iommu: handle interrupt remap enable Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 19/57] intel_iommu: define several structs for IOMMU IR Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 20/57] intel_iommu: add IR translation faults defines Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 21/57] intel_iommu: Add support for PCI MSI remap Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 22/57] q35: ioapic: add support for emulated IOAPIC IR Michael S. Tsirkin 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 23/57] ioapic: introduce ioapic_entry_parse() helper Michael S. Tsirkin 2016-07-21 16:27 ` Michael S. Tsirkin [this message] 2016-07-21 16:27 ` [Qemu-devel] [PULL v4 24/57] intel_iommu: add support for split irqchip Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] [PULL v4 25/57] x86-iommu: introduce IEC notifiers Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] [PULL v4 26/57] ioapic: register IOMMU IEC notifier for ioapic Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] [PULL v4 27/57] intel_iommu: Add support for Extended Interrupt Mode Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] [PULL v4 28/57] intel_iommu: add SID validation for IR Michael S. Tsirkin 2016-07-21 16:28 ` [PULL v4 29/57] kvm-irqchip: simplify kvm_irqchip_add_msi_route Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] " Michael S. Tsirkin 2016-07-21 16:28 ` [PULL v4 30/57] kvm-irqchip: i386: add hook for add/remove virq Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] " Michael S. Tsirkin 2016-07-21 16:28 ` [PULL v4 31/57] kvm-irqchip: x86: add msi route notify fn Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] " Michael S. Tsirkin 2016-07-21 16:28 ` [PULL v4 32/57] kvm-irqchip: do explicit commit when update irq Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] " Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] [PULL v4 33/57] intel_iommu: support all masks in interrupt entry cache invalidation Michael S. Tsirkin 2016-07-21 16:28 ` [PULL v4 34/57] kvm-all: add trace events for kvm irqchip ops Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] " Michael S. Tsirkin 2016-07-21 16:28 ` [Qemu-devel] [PULL v4 35/57] intel_iommu: disallow kernel-irqchip=on with IR Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 36/57] virtio: Add typedef for handle_output Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 37/57] virtio: Introduce virtio_add_queue_aio Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 38/57] virtio-blk: Call virtio_add_queue_aio Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 39/57] virtio-scsi: " Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 40/57] Revert "mirror: Workaround for unexpected iohandler events during completion" Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 41/57] virtio-scsi: Replace HandleOutput typedef Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 42/57] virtio-net: Remove old migration version support Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 43/57] virtio-serial: " Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 44/57] virtio: Migration helper function and macro Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 45/57] virtio-scsi: Wrap in vmstate Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 46/57] virtio-blk: " Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 47/57] virtio-rng: " Michael S. Tsirkin 2016-07-21 16:29 ` [Qemu-devel] [PULL v4 48/57] virtio-balloon: " Michael S. Tsirkin 2016-07-21 16:30 ` [Qemu-devel] [PULL v4 49/57] virtio-net: " Michael S. Tsirkin 2016-07-21 16:30 ` [Qemu-devel] [PULL v4 50/57] virtio-serial: " Michael S. Tsirkin 2016-07-21 16:30 ` [Qemu-devel] [PULL v4 51/57] 9pfs: " Michael S. Tsirkin 2016-07-21 16:30 ` [Qemu-devel] [PULL v4 52/57] virtio-input: " Michael S. Tsirkin 2016-07-21 16:30 ` [Qemu-devel] [PULL v4 53/57] virtio-gpu: Use migrate_add_blocker for virgl migration blocking Michael S. Tsirkin 2016-07-21 16:30 ` [Qemu-devel] [PULL v4 54/57] virtio-gpu: Wrap in vmstate Michael S. Tsirkin 2016-07-21 16:30 ` [Qemu-devel] [PULL v4 55/57] virtio: Update migration docs Michael S. Tsirkin 2016-07-21 16:30 ` [Qemu-devel] [PULL v4 56/57] intel_iommu: get rid of {0} initializers Michael S. Tsirkin 2016-07-21 16:30 ` [Qemu-devel] [PULL v4 57/57] intel_iommu: avoid unnamed fields Michael S. Tsirkin 2016-07-21 17:23 ` [Qemu-devel] [PULL v4 00/57] pc, pci, virtio: new features, cleanups, fixes Peter Maydell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1469118288-4776-25-git-send-email-mst@redhat.com \ --to=mst@redhat.com \ --cc=ehabkost@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=peterx@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.