* [PATCH 0/2] cxlflash: Regression patch and updating Maintainers list
@ 2016-07-21 20:42 Uma Krishnan
2016-07-21 20:44 ` [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown Uma Krishnan
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Uma Krishnan @ 2016-07-21 20:42 UTC (permalink / raw)
To: linux-scsi, James Bottomley, Martin K. Petersen, Matthew R. Ochs,
Manoj N. Kumar
Cc: Brian King, linuxppc-dev, Ian Munsie, Andrew Donnellan,
Frederic Barrat, Christophe Lombard
First patch in this set fixes a regression that was casued by the
Commit 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL
Flash cards"), which is currently staged for 4.8 in next/master.
Second patch updates the Maintainers list for cxlflash driver.
This series is intended for 4.8 and is bisectable. These patches
are cut against next/master that contains the original commit.
Uma Krishnan (2):
cxlflash: Verify problem state area is mapped before notifying
shutdown
MAINTAINERS: Update cxlflash maintainers
MAINTAINERS | 1 +
drivers/scsi/cxlflash/main.c | 10 +++++++++-
2 files changed, 10 insertions(+), 1 deletion(-)
--
2.1.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown
2016-07-21 20:42 [PATCH 0/2] cxlflash: Regression patch and updating Maintainers list Uma Krishnan
@ 2016-07-21 20:44 ` Uma Krishnan
2016-07-22 3:26 ` Andrew Donnellan
2016-07-22 15:36 ` Matthew R. Ochs
2016-07-21 20:44 ` [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers Uma Krishnan
2016-07-22 20:21 ` [PATCH 0/2] cxlflash: Regression patch and updating Maintainers list Martin K. Petersen
2 siblings, 2 replies; 9+ messages in thread
From: Uma Krishnan @ 2016-07-21 20:44 UTC (permalink / raw)
To: linux-scsi, James Bottomley, Martin K. Petersen, Matthew R. Ochs,
Manoj N. Kumar
Cc: Brian King, linuxppc-dev, Ian Munsie, Andrew Donnellan,
Frederic Barrat, Christophe Lombard
If an EEH or some other hard error occurs while the
adapter instance was being initialized, on the subsequent
shutdown of the device, the system could crash with:
[c000000f1da03b60] c0000000005eccfc pci_device_shutdown+0x6c/0x100
[c000000f1da03ba0] c0000000006d67d4 device_shutdown+0x1b4/0x2c0
[c000000f1da03c40] c0000000000ea30c kernel_restart_prepare+0x5c/0x80
[c000000f1da03c70] c0000000000ea48c kernel_restart+0x2c/0xc0
[c000000f1da03ce0] c0000000000ea970 SyS_reboot+0x1c0/0x2d0
[c000000f1da03e30] c000000000009204 system_call+0x38/0xb4
This crash is due to the AFU not being mapped when the shutdown
notification routine is called and is a regression that was inserted
recently with Commit 704c4b0ddc03 ("cxlflash: Shutdown notify support
for CXL Flash cards").
As a fix, shutdown notification should only occur when the AFU is mapped.
Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards")
Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
---
drivers/scsi/cxlflash/main.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
index 860008d..661bb94 100644
--- a/drivers/scsi/cxlflash/main.c
+++ b/drivers/scsi/cxlflash/main.c
@@ -778,7 +778,7 @@ static void notify_shutdown(struct cxlflash_cfg *cfg, bool wait)
{
struct afu *afu = cfg->afu;
struct device *dev = &cfg->dev->dev;
- struct sisl_global_map __iomem *global = &afu->afu_map->global;
+ struct sisl_global_map __iomem *global;
struct dev_dependent_vals *ddv;
u64 reg, status;
int i, retry_cnt = 0;
@@ -787,6 +787,14 @@ static void notify_shutdown(struct cxlflash_cfg *cfg, bool wait)
if (!(ddv->flags & CXLFLASH_NOTIFY_SHUTDOWN))
return;
+ if (!afu || !afu->afu_map) {
+ dev_dbg(dev, "%s: The problem state area is not mapped\n",
+ __func__);
+ return;
+ }
+
+ global = &afu->afu_map->global;
+
/* Notify AFU */
for (i = 0; i < NUM_FC_PORTS; i++) {
reg = readq_be(&global->fc_regs[i][FC_CONFIG2 / 8]);
--
2.1.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers
2016-07-21 20:42 [PATCH 0/2] cxlflash: Regression patch and updating Maintainers list Uma Krishnan
2016-07-21 20:44 ` [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown Uma Krishnan
@ 2016-07-21 20:44 ` Uma Krishnan
2016-07-22 15:37 ` Matthew R. Ochs
2016-07-22 20:21 ` [PATCH 0/2] cxlflash: Regression patch and updating Maintainers list Martin K. Petersen
2 siblings, 1 reply; 9+ messages in thread
From: Uma Krishnan @ 2016-07-21 20:44 UTC (permalink / raw)
To: linux-scsi, James Bottomley, Martin K. Petersen, Matthew R. Ochs,
Manoj N. Kumar
Cc: Brian King, linuxppc-dev, Ian Munsie, Andrew Donnellan,
Frederic Barrat, Christophe Lombard
Adding myself as a cxlflash maintainer.
Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2dbc028..e5f5882 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3487,6 +3487,7 @@ F: Documentation/ABI/testing/sysfs-class-cxl
CXLFLASH (IBM Coherent Accelerator Processor Interface CAPI Flash) SCSI DRIVER
M: Manoj N. Kumar <manoj@linux.vnet.ibm.com>
M: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
+M: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
L: linux-scsi@vger.kernel.org
S: Supported
F: drivers/scsi/cxlflash/
--
2.1.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown
2016-07-21 20:44 ` [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown Uma Krishnan
@ 2016-07-22 3:26 ` Andrew Donnellan
2016-07-22 15:36 ` Matthew R. Ochs
1 sibling, 0 replies; 9+ messages in thread
From: Andrew Donnellan @ 2016-07-22 3:26 UTC (permalink / raw)
To: Uma Krishnan, linux-scsi, James Bottomley, Martin K. Petersen,
Matthew R. Ochs, Manoj N. Kumar
Cc: Brian King, linuxppc-dev, Ian Munsie, Frederic Barrat,
Christophe Lombard
On 22/07/16 06:44, Uma Krishnan wrote:
> If an EEH or some other hard error occurs while the
> adapter instance was being initialized, on the subsequent
> shutdown of the device, the system could crash with:
>
> [c000000f1da03b60] c0000000005eccfc pci_device_shutdown+0x6c/0x100
> [c000000f1da03ba0] c0000000006d67d4 device_shutdown+0x1b4/0x2c0
> [c000000f1da03c40] c0000000000ea30c kernel_restart_prepare+0x5c/0x80
> [c000000f1da03c70] c0000000000ea48c kernel_restart+0x2c/0xc0
> [c000000f1da03ce0] c0000000000ea970 SyS_reboot+0x1c0/0x2d0
> [c000000f1da03e30] c000000000009204 system_call+0x38/0xb4
>
> This crash is due to the AFU not being mapped when the shutdown
> notification routine is called and is a regression that was inserted
> recently with Commit 704c4b0ddc03 ("cxlflash: Shutdown notify support
> for CXL Flash cards").
>
> As a fix, shutdown notification should only occur when the AFU is mapped.
>
> Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards")
> Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown
2016-07-21 20:44 ` [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown Uma Krishnan
@ 2016-07-22 15:36 ` Matthew R. Ochs
2016-07-22 15:36 ` Matthew R. Ochs
1 sibling, 0 replies; 9+ messages in thread
From: Matthew R. Ochs @ 2016-07-22 15:36 UTC (permalink / raw)
To: Uma Krishnan
Cc: linux-scsi, James Bottomley, Martin K. Petersen, Manoj N. Kumar,
Brian King, linuxppc-dev, Ian Munsie, Andrew Donnellan,
Frederic Barrat, Christophe Lombard
> On Jul 21, 2016, at 3:44 PM, Uma Krishnan <ukrishn@linux.vnet.ibm.com> wrote:
>
> If an EEH or some other hard error occurs while the
> adapter instance was being initialized, on the subsequent
> shutdown of the device, the system could crash with:
>
> [c000000f1da03b60] c0000000005eccfc pci_device_shutdown+0x6c/0x100
> [c000000f1da03ba0] c0000000006d67d4 device_shutdown+0x1b4/0x2c0
> [c000000f1da03c40] c0000000000ea30c kernel_restart_prepare+0x5c/0x80
> [c000000f1da03c70] c0000000000ea48c kernel_restart+0x2c/0xc0
> [c000000f1da03ce0] c0000000000ea970 SyS_reboot+0x1c0/0x2d0
> [c000000f1da03e30] c000000000009204 system_call+0x38/0xb4
>
> This crash is due to the AFU not being mapped when the shutdown
> notification routine is called and is a regression that was inserted
> recently with Commit 704c4b0ddc03 ("cxlflash: Shutdown notify support
> for CXL Flash cards").
>
> As a fix, shutdown notification should only occur when the AFU is mapped.
>
> Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards")
> Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown
@ 2016-07-22 15:36 ` Matthew R. Ochs
0 siblings, 0 replies; 9+ messages in thread
From: Matthew R. Ochs @ 2016-07-22 15:36 UTC (permalink / raw)
To: Uma Krishnan
Cc: linux-scsi, James Bottomley, Martin K. Petersen, Manoj N. Kumar,
Brian King, linuxppc-dev, Ian Munsie, Andrew Donnellan,
Frederic Barrat, Christophe Lombard
> On Jul 21, 2016, at 3:44 PM, Uma Krishnan <ukrishn@linux.vnet.ibm.com> =
wrote:
>=20
> If an EEH or some other hard error occurs while the
> adapter instance was being initialized, on the subsequent
> shutdown of the device, the system could crash with:
>=20
> [c000000f1da03b60] c0000000005eccfc pci_device_shutdown+0x6c/0x100
> [c000000f1da03ba0] c0000000006d67d4 device_shutdown+0x1b4/0x2c0
> [c000000f1da03c40] c0000000000ea30c kernel_restart_prepare+0x5c/0x80
> [c000000f1da03c70] c0000000000ea48c kernel_restart+0x2c/0xc0
> [c000000f1da03ce0] c0000000000ea970 SyS_reboot+0x1c0/0x2d0
> [c000000f1da03e30] c000000000009204 system_call+0x38/0xb4
>=20
> This crash is due to the AFU not being mapped when the shutdown
> notification routine is called and is a regression that was inserted
> recently with Commit 704c4b0ddc03 ("cxlflash: Shutdown notify support
> for CXL Flash cards").
>=20
> As a fix, shutdown notification should only occur when the AFU is =
mapped.
>=20
> Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash =
cards")
> Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers
2016-07-21 20:44 ` [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers Uma Krishnan
@ 2016-07-22 15:37 ` Matthew R. Ochs
0 siblings, 0 replies; 9+ messages in thread
From: Matthew R. Ochs @ 2016-07-22 15:37 UTC (permalink / raw)
To: Uma Krishnan
Cc: linux-scsi, James Bottomley, Martin K. Petersen, Manoj N. Kumar,
Brian King, linuxppc-dev, Ian Munsie, Andrew Donnellan,
Frederic Barrat, Christophe Lombard
> On Jul 21, 2016, at 3:44 PM, Uma Krishnan <ukrishn@linux.vnet.ibm.com> wrote:
>
> Adding myself as a cxlflash maintainer.
>
> Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers
@ 2016-07-22 15:37 ` Matthew R. Ochs
0 siblings, 0 replies; 9+ messages in thread
From: Matthew R. Ochs @ 2016-07-22 15:37 UTC (permalink / raw)
To: Uma Krishnan
Cc: linux-scsi, James Bottomley, Martin K. Petersen, Manoj N. Kumar,
Brian King, linuxppc-dev, Ian Munsie, Andrew Donnellan,
Frederic Barrat, Christophe Lombard
> On Jul 21, 2016, at 3:44 PM, Uma Krishnan <ukrishn@linux.vnet.ibm.com> =
wrote:
>=20
> Adding myself as a cxlflash maintainer.
>=20
> Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] cxlflash: Regression patch and updating Maintainers list
2016-07-21 20:42 [PATCH 0/2] cxlflash: Regression patch and updating Maintainers list Uma Krishnan
2016-07-21 20:44 ` [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown Uma Krishnan
2016-07-21 20:44 ` [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers Uma Krishnan
@ 2016-07-22 20:21 ` Martin K. Petersen
2 siblings, 0 replies; 9+ messages in thread
From: Martin K. Petersen @ 2016-07-22 20:21 UTC (permalink / raw)
To: Uma Krishnan
Cc: linux-scsi, James Bottomley, Martin K. Petersen, Matthew R. Ochs,
Manoj N. Kumar, Brian King, linuxppc-dev, Ian Munsie,
Andrew Donnellan, Frederic Barrat, Christophe Lombard
>>>>> "Uma" == Uma Krishnan <ukrishn@linux.vnet.ibm.com> writes:
Uma> First patch in this set fixes a regression that was casued by the
Uma> Commit 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL
Uma> Flash cards"), which is currently staged for 4.8 in next/master.
Uma> Second patch updates the Maintainers list for cxlflash driver.
Uma> This series is intended for 4.8 and is bisectable. These patches
Uma> are cut against next/master that contains the original commit.
Applied to 4.8/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-07-22 20:21 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-21 20:42 [PATCH 0/2] cxlflash: Regression patch and updating Maintainers list Uma Krishnan
2016-07-21 20:44 ` [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown Uma Krishnan
2016-07-22 3:26 ` Andrew Donnellan
2016-07-22 15:36 ` Matthew R. Ochs
2016-07-22 15:36 ` Matthew R. Ochs
2016-07-21 20:44 ` [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers Uma Krishnan
2016-07-22 15:37 ` Matthew R. Ochs
2016-07-22 15:37 ` Matthew R. Ochs
2016-07-22 20:21 ` [PATCH 0/2] cxlflash: Regression patch and updating Maintainers list Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.