* [PATCH -next v2] drm/rcar-du: remove redundant dev_err call in rcar_du_lvdsenc_get_resources()
@ 2013-08-23 13:15 Wei Yongjun
2013-08-23 13:17 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-08-23 13:15 UTC (permalink / raw)
To: airlied, laurent.pinchart+renesas; +Cc: yongjun_wei, dri-devel, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR(). Also remove the dev_err call to avoid redundant
error message and check for return value of platform_get_resource_byname().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
v1 -> v2; remove return value check of platform_get_resource_byname()
---
drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c b/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c
index a0f6a17..fe1f6f5 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c
@@ -144,18 +144,9 @@ static int rcar_du_lvdsenc_get_resources(struct rcar_du_lvdsenc *lvds,
sprintf(name, "lvds.%u", lvds->index);
mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
- if (mem == NULL) {
- dev_err(&pdev->dev, "failed to get memory resource for %s\n",
- name);
- return -EINVAL;
- }
-
lvds->mmio = devm_ioremap_resource(&pdev->dev, mem);
- if (lvds->mmio == NULL) {
- dev_err(&pdev->dev, "failed to remap memory resource for %s\n",
- name);
- return -ENOMEM;
- }
+ if (IS_ERR(lvds->mmio))
+ return PTR_ERR(lvds->mmio);
lvds->clock = devm_clk_get(&pdev->dev, name);
if (IS_ERR(lvds->clock)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next v2] drm/rcar-du: remove redundant dev_err call in rcar_du_lvdsenc_get_resources()
2013-08-23 13:15 [PATCH -next v2] drm/rcar-du: remove redundant dev_err call in rcar_du_lvdsenc_get_resources() Wei Yongjun
@ 2013-08-23 13:17 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2013-08-23 13:17 UTC (permalink / raw)
To: Wei Yongjun, yongjun_wei; +Cc: airlied, dri-devel, linux-kernel
On Friday 23 August 2013 21:15:16 Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should be
> replaced with IS_ERR(). Also remove the dev_err call to avoid redundant
> error message and check for return value of platform_get_resource_byname().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Dave, could you please pick the patch up ?
> ---
> v1 -> v2; remove return value check of platform_get_resource_byname()
> ---
> drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c
> b/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c index a0f6a17..fe1f6f5 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c
> @@ -144,18 +144,9 @@ static int rcar_du_lvdsenc_get_resources(struct
> rcar_du_lvdsenc *lvds, sprintf(name, "lvds.%u", lvds->index);
>
> mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
> - if (mem == NULL) {
> - dev_err(&pdev->dev, "failed to get memory resource for %s\n",
> - name);
> - return -EINVAL;
> - }
> -
> lvds->mmio = devm_ioremap_resource(&pdev->dev, mem);
> - if (lvds->mmio == NULL) {
> - dev_err(&pdev->dev, "failed to remap memory resource for %s\n",
> - name);
> - return -ENOMEM;
> - }
> + if (IS_ERR(lvds->mmio))
> + return PTR_ERR(lvds->mmio);
>
> lvds->clock = devm_clk_get(&pdev->dev, name);
> if (IS_ERR(lvds->clock)) {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-23 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-23 13:15 [PATCH -next v2] drm/rcar-du: remove redundant dev_err call in rcar_du_lvdsenc_get_resources() Wei Yongjun
2013-08-23 13:17 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.