All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/efl: enable systemd support
@ 2016-07-22 22:23 Romain Naour
  2016-07-22 22:23 ` [Buildroot] [PATCH 2/2] package/enlightenment: " Romain Naour
  2016-07-23 13:09 ` [Buildroot] [PATCH 1/2] package/efl: " Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Romain Naour @ 2016-07-22 22:23 UTC (permalink / raw)
  To: buildroot

systemd it one of the "highly recommended" dependecies according to the
README [1] but disabling it doesn't need the
--enable-i-really-know-what-i-am-doing... option.

That's why BR2_PACKAGE_EFL_HAS_RECOMMENDED_CONFIG is not disabled when
systemd is not selected.

[1] https://git.enlightenment.org/core/efl.git/tree/README?h=efl-1.17#n489

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
Tested with Qemu for x86_64 target with systemd + X11 server
---
 package/efl/efl.mk | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/package/efl/efl.mk b/package/efl/efl.mk
index 18d409b..d404e71 100644
--- a/package/efl/efl.mk
+++ b/package/efl/efl.mk
@@ -25,7 +25,6 @@ EFL_DEPENDENCIES = host-pkgconf host-efl host-luajit dbus freetype \
 # Configure options:
 # --disable-lua-old: build elua for the target.
 # --disable-sdl: disable sdl2 support.
-# --disable-systemd: disable systemd support.
 # --disable-xinput22: disable X11 XInput v2.2+ support.
 # --with-opengl=none: disable opengl support.
 EFL_CONF_OPTS = \
@@ -34,7 +33,6 @@ EFL_CONF_OPTS = \
 	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
 	--disable-lua-old \
 	--disable-sdl \
-	--disable-systemd \
 	--disable-xinput22 \
 	--with-opengl=none
 
@@ -57,6 +55,13 @@ else
 EFL_CONF_OPTS += --disable-libmount
 endif
 
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+EFL_CONF_OPTS += --enable-systemd
+EFL_DEPENDENCIES += systemd
+else
+EFL_CONF_OPTS += --disable-systemd
+endif
+
 ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
 EFL_CONF_OPTS += --enable-fontconfig
 EFL_DEPENDENCIES += fontconfig
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 2/2] package/enlightenment: enable systemd support
  2016-07-22 22:23 [Buildroot] [PATCH 1/2] package/efl: enable systemd support Romain Naour
@ 2016-07-22 22:23 ` Romain Naour
  2016-07-23 13:09 ` [Buildroot] [PATCH 1/2] package/efl: " Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Romain Naour @ 2016-07-22 22:23 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
Tested with Qemu for x86_64 target with systemd + X11 server
---
 package/enlightenment/enlightenment.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/package/enlightenment/enlightenment.mk b/package/enlightenment/enlightenment.mk
index e8fee3f..2440cec 100644
--- a/package/enlightenment/enlightenment.mk
+++ b/package/enlightenment/enlightenment.mk
@@ -22,8 +22,14 @@ ENLIGHTENMENT_CONF_OPTS = \
 	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
 	--with-eet-eet=$(HOST_DIR)/usr/bin/eet \
 	--disable-pam \
-	--disable-rpath \
-	--disable-systemd
+	--disable-rpath
+
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+ENLIGHTENMENT_CONF_OPTS += --enable-systemd
+ENLIGHTENMENT_DEPENDENCIES += systemd
+else
+ENLIGHTENMENT_CONF_OPTS += --disable-systemd
+endif
 
 # uClibc has an old incomplete sys/ptrace.h for powerpc & sparc
 ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_powerpc)$(BR2_sparc),yy)
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/2] package/efl: enable systemd support
  2016-07-22 22:23 [Buildroot] [PATCH 1/2] package/efl: enable systemd support Romain Naour
  2016-07-22 22:23 ` [Buildroot] [PATCH 2/2] package/enlightenment: " Romain Naour
@ 2016-07-23 13:09 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-07-23 13:09 UTC (permalink / raw)
  To: buildroot

Hello,

On Sat, 23 Jul 2016 00:23:17 +0200, Romain Naour wrote:
> systemd it one of the "highly recommended" dependecies according to the
> README [1] but disabling it doesn't need the
> --enable-i-really-know-what-i-am-doing... option.
> 
> That's why BR2_PACKAGE_EFL_HAS_RECOMMENDED_CONFIG is not disabled when
> systemd is not selected.
> 
> [1] https://git.enlightenment.org/core/efl.git/tree/README?h=efl-1.17#n489
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> Tested with Qemu for x86_64 target with systemd + X11 server
> ---
>  package/efl/efl.mk | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Both applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-23 13:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-22 22:23 [Buildroot] [PATCH 1/2] package/efl: enable systemd support Romain Naour
2016-07-22 22:23 ` [Buildroot] [PATCH 2/2] package/enlightenment: " Romain Naour
2016-07-23 13:09 ` [Buildroot] [PATCH 1/2] package/efl: " Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.