* [PATCH] cxl: fix sparse warnings
@ 2016-07-22 9:01 Andrew Donnellan
2016-07-22 15:39 ` Matthew R. Ochs
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andrew Donnellan @ 2016-07-22 9:01 UTC (permalink / raw)
To: linuxppc-dev; +Cc: imunsie, fbarrat, clombard, felix, vaibhav
Make native_irq_wait() static and use NULL rather than 0 to initialise
phb->cfg_data in cxl_pci_vphb_add() to remove sparse warnings.
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
---
drivers/misc/cxl/native.c | 2 +-
drivers/misc/cxl/vphb.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c
index 3bcdaee..e606fdc 100644
--- a/drivers/misc/cxl/native.c
+++ b/drivers/misc/cxl/native.c
@@ -924,7 +924,7 @@ static irqreturn_t native_irq_multiplexed(int irq, void *data)
return fail_psl_irq(afu, &irq_info);
}
-void native_irq_wait(struct cxl_context *ctx)
+static void native_irq_wait(struct cxl_context *ctx)
{
u64 dsisr;
int timeout = 1000;
diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c
index dee8def..7ada5f1 100644
--- a/drivers/misc/cxl/vphb.c
+++ b/drivers/misc/cxl/vphb.c
@@ -221,7 +221,7 @@ int cxl_pci_vphb_add(struct cxl_afu *afu)
/* Setup the PHB using arch provided callback */
phb->ops = &cxl_pcie_pci_ops;
phb->cfg_addr = NULL;
- phb->cfg_data = 0;
+ phb->cfg_data = NULL;
phb->private_data = afu;
phb->controller_ops = cxl_pci_controller_ops;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl: fix sparse warnings
2016-07-22 9:01 [PATCH] cxl: fix sparse warnings Andrew Donnellan
@ 2016-07-22 15:39 ` Matthew R. Ochs
2016-07-25 2:42 ` Ian Munsie
2016-08-09 11:26 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Matthew R. Ochs @ 2016-07-22 15:39 UTC (permalink / raw)
To: Andrew Donnellan; +Cc: linuxppc-dev, felix, vaibhav, imunsie, fbarrat, clombard
> On Jul 22, 2016, at 4:01 AM, Andrew Donnellan =
<andrew.donnellan@au1.ibm.com> wrote:
>=20
> Make native_irq_wait() static and use NULL rather than 0 to initialise
> phb->cfg_data in cxl_pci_vphb_add() to remove sparse warnings.
>=20
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl: fix sparse warnings
2016-07-22 9:01 [PATCH] cxl: fix sparse warnings Andrew Donnellan
2016-07-22 15:39 ` Matthew R. Ochs
@ 2016-07-25 2:42 ` Ian Munsie
2016-08-09 11:26 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Ian Munsie @ 2016-07-25 2:42 UTC (permalink / raw)
To: andrew.donnellan
Cc: linuxppc-dev, Philippe Bergheaud, Vaibhav Jain, fbarrat, clombard
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: cxl: fix sparse warnings
2016-07-22 9:01 [PATCH] cxl: fix sparse warnings Andrew Donnellan
2016-07-22 15:39 ` Matthew R. Ochs
2016-07-25 2:42 ` Ian Munsie
@ 2016-08-09 11:26 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2016-08-09 11:26 UTC (permalink / raw)
To: Andrew Donnellan, linuxppc-dev; +Cc: felix, vaibhav, imunsie, fbarrat, clombard
On Fri, 2016-22-07 at 09:01:36 UTC, Andrew Donnellan wrote:
> Make native_irq_wait() static and use NULL rather than 0 to initialise
> phb->cfg_data in cxl_pci_vphb_add() to remove sparse warnings.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/6fd40f192a9dba391b2d84882f
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-09 11:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-22 9:01 [PATCH] cxl: fix sparse warnings Andrew Donnellan
2016-07-22 15:39 ` Matthew R. Ochs
2016-07-25 2:42 ` Ian Munsie
2016-08-09 11:26 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.