* [meta-java][PATCH v3] openjdk-8: ignore wrong GCCVERSION-flag
@ 2016-07-25 6:16 Sven Ebenfeld
2016-08-01 6:19 ` Ebenfeld, Sven
0 siblings, 1 reply; 3+ messages in thread
From: Sven Ebenfeld @ 2016-07-25 6:16 UTC (permalink / raw)
To: openembedded-devel; +Cc: Sven Ebenfeld
During my recipe parsing, GCCVERSION in the cross case seems to
be 'l' this leads to a ValueError during recipe parsing. Therefore
check type before trying to parse the version flag.
Signed-off-by: Sven Ebenfeld <sven.ebenfeld@vaillant-group.com>
---
recipes-core/openjdk/openjdk-8-common.inc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/recipes-core/openjdk/openjdk-8-common.inc b/recipes-core/openjdk/openjdk-8-common.inc
index 7ad802a..c2f9eb4 100644
--- a/recipes-core/openjdk/openjdk-8-common.inc
+++ b/recipes-core/openjdk/openjdk-8-common.inc
@@ -271,8 +271,10 @@ def version_specific_cflags(d):
# doesn't work anyway.
version = d.getVar('GCCVERSION', expand=True)[0]
- extraflags = d.getVar('FLAGS_GCC%d' % int(version), True) or ''
- return extraflags
+ if version.isdigit():
+ extraflags = d.getVar('FLAGS_GCC%d' % int(version), True) or ''
+ return extraflags
+ return ''
CFLAGS_append = " ${@version_specific_cflags(d)}"
CXXFLAGS_append = " ${@version_specific_cflags(d)}"
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [meta-java][PATCH v3] openjdk-8: ignore wrong GCCVERSION-flag
2016-07-25 6:16 [meta-java][PATCH v3] openjdk-8: ignore wrong GCCVERSION-flag Sven Ebenfeld
@ 2016-08-01 6:19 ` Ebenfeld, Sven
2016-08-01 10:56 ` Maxin B. John
0 siblings, 1 reply; 3+ messages in thread
From: Ebenfeld, Sven @ 2016-08-01 6:19 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]
What is about this patch?
I see it's archived but not merged. My builds of the fido branch are failing
without this patch.
Best Regards,
Sven Ebenfeld
IRE-S CoC Connectivity & Controls - Technology Advisor Network Technologies
& Security
Vaillant
-----Original Message-----
From: Sven Ebenfeld [mailto:sven.ebenfeld@vaillant-group.com]
Sent: Monday, July 25, 2016 8:17 AM
To: openembedded-devel@lists.openembedded.org
Cc: Ebenfeld, Sven <sven.ebenfeld@vaillant-group.com>
Subject: [meta-java][PATCH v3] openjdk-8: ignore wrong GCCVERSION-flag
During my recipe parsing, GCCVERSION in the cross case seems to be 'l' this
leads to a ValueError during recipe parsing. Therefore check type before
trying to parse the version flag.
Signed-off-by: Sven Ebenfeld <sven.ebenfeld@vaillant-group.com>
---
recipes-core/openjdk/openjdk-8-common.inc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/recipes-core/openjdk/openjdk-8-common.inc
b/recipes-core/openjdk/openjdk-8-common.inc
index 7ad802a..c2f9eb4 100644
--- a/recipes-core/openjdk/openjdk-8-common.inc
+++ b/recipes-core/openjdk/openjdk-8-common.inc
@@ -271,8 +271,10 @@ def version_specific_cflags(d):
# doesn't work anyway.
version = d.getVar('GCCVERSION', expand=True)[0]
- extraflags = d.getVar('FLAGS_GCC%d' % int(version), True) or ''
- return extraflags
+ if version.isdigit():
+ extraflags = d.getVar('FLAGS_GCC%d' % int(version), True) or ''
+ return extraflags
+ return ''
CFLAGS_append = " ${@version_specific_cflags(d)}"
CXXFLAGS_append = " ${@version_specific_cflags(d)}"
--
1.9.1
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5473 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [meta-java][PATCH v3] openjdk-8: ignore wrong GCCVERSION-flag
2016-08-01 6:19 ` Ebenfeld, Sven
@ 2016-08-01 10:56 ` Maxin B. John
0 siblings, 0 replies; 3+ messages in thread
From: Maxin B. John @ 2016-08-01 10:56 UTC (permalink / raw)
To: openembedded-devel
Hi Sven,
On Mon, Aug 01, 2016 at 06:19:05AM +0000, Ebenfeld, Sven wrote:
> What is about this patch?
> I see it's archived but not merged. My builds of the fido branch are failing
> without this patch.
Pushed to master-next. Sorry for the delay.
> Best Regards,
>
> Sven Ebenfeld
> IRE-S CoC Connectivity & Controls - Technology Advisor Network Technologies
> & Security
> Vaillant
Best Regards,
Maxin
>
> -----Original Message-----
> From: Sven Ebenfeld [mailto:sven.ebenfeld@vaillant-group.com]
> Sent: Monday, July 25, 2016 8:17 AM
> To: openembedded-devel@lists.openembedded.org
> Cc: Ebenfeld, Sven <sven.ebenfeld@vaillant-group.com>
> Subject: [meta-java][PATCH v3] openjdk-8: ignore wrong GCCVERSION-flag
>
> During my recipe parsing, GCCVERSION in the cross case seems to be 'l' this
> leads to a ValueError during recipe parsing. Therefore check type before
> trying to parse the version flag.
>
> Signed-off-by: Sven Ebenfeld <sven.ebenfeld@vaillant-group.com>
> ---
> recipes-core/openjdk/openjdk-8-common.inc | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-core/openjdk/openjdk-8-common.inc
> b/recipes-core/openjdk/openjdk-8-common.inc
> index 7ad802a..c2f9eb4 100644
> --- a/recipes-core/openjdk/openjdk-8-common.inc
> +++ b/recipes-core/openjdk/openjdk-8-common.inc
> @@ -271,8 +271,10 @@ def version_specific_cflags(d):
> # doesn't work anyway.
> version = d.getVar('GCCVERSION', expand=True)[0]
>
> - extraflags = d.getVar('FLAGS_GCC%d' % int(version), True) or ''
> - return extraflags
> + if version.isdigit():
> + extraflags = d.getVar('FLAGS_GCC%d' % int(version), True) or ''
> + return extraflags
> + return ''
>
> CFLAGS_append = " ${@version_specific_cflags(d)}"
> CXXFLAGS_append = " ${@version_specific_cflags(d)}"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-01 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-25 6:16 [meta-java][PATCH v3] openjdk-8: ignore wrong GCCVERSION-flag Sven Ebenfeld
2016-08-01 6:19 ` Ebenfeld, Sven
2016-08-01 10:56 ` Maxin B. John
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.