All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe()
@ 2016-07-28  2:12 Wei Yongjun
  2016-07-28 20:42 ` Iyappan Subramanian
  2016-07-31  3:39 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-07-28  2:12 UTC (permalink / raw)
  To: Iyappan Subramanian, Keyur Chudgar, Florian Fainelli; +Cc: Wei Yongjun, netdev

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
 drivers/net/phy/mdio-xgene.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/phy/mdio-xgene.c b/drivers/net/phy/mdio-xgene.c
index d94a978..7756748 100644
--- a/drivers/net/phy/mdio-xgene.c
+++ b/drivers/net/phy/mdio-xgene.c
@@ -345,10 +345,8 @@ static int xgene_mdio_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	csr_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(csr_base)) {
-		dev_err(dev, "Unable to retrieve mac CSR region\n");
+	if (IS_ERR(csr_base))
 		return PTR_ERR(csr_base);
-	}
 	pdata->mac_csr_addr = csr_base;
 	pdata->mdio_csr_addr = csr_base + BLOCK_XG_MDIO_CSR_OFFSET;
 	pdata->diag_csr_addr = csr_base + BLOCK_DIAG_CSR_OFFSET;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe()
  2016-07-28  2:12 [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe() Wei Yongjun
@ 2016-07-28 20:42 ` Iyappan Subramanian
  2016-07-31  3:39 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Iyappan Subramanian @ 2016-07-28 20:42 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: Keyur Chudgar, Florian Fainelli, netdev

On Wed, Jul 27, 2016 at 7:12 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> ---
>  drivers/net/phy/mdio-xgene.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/phy/mdio-xgene.c b/drivers/net/phy/mdio-xgene.c
> index d94a978..7756748 100644
> --- a/drivers/net/phy/mdio-xgene.c
> +++ b/drivers/net/phy/mdio-xgene.c
> @@ -345,10 +345,8 @@ static int xgene_mdio_probe(struct platform_device *pdev)
>
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         csr_base = devm_ioremap_resource(dev, res);
> -       if (IS_ERR(csr_base)) {
> -               dev_err(dev, "Unable to retrieve mac CSR region\n");
> +       if (IS_ERR(csr_base))
>                 return PTR_ERR(csr_base);
> -       }
>         pdata->mac_csr_addr = csr_base;
>         pdata->mdio_csr_addr = csr_base + BLOCK_XG_MDIO_CSR_OFFSET;
>         pdata->diag_csr_addr = csr_base + BLOCK_DIAG_CSR_OFFSET;
>
>
>

Thanks.

Acked-By: Iyappan Subramanian <isubramanian@apm.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe()
  2016-07-28  2:12 [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe() Wei Yongjun
  2016-07-28 20:42 ` Iyappan Subramanian
@ 2016-07-31  3:39 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-07-31  3:39 UTC (permalink / raw)
  To: weiyj.lk; +Cc: isubramanian, kchudgar, f.fainelli, netdev

From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Thu, 28 Jul 2016 02:12:17 +0000

> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-31  3:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-28  2:12 [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe() Wei Yongjun
2016-07-28 20:42 ` Iyappan Subramanian
2016-07-31  3:39 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.