* [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind()
@ 2016-07-28 2:14 Wei Yongjun
2016-07-28 8:22 ` Brian Starkey
0 siblings, 1 reply; 4+ messages in thread
From: Wei Yongjun @ 2016-07-28 2:14 UTC (permalink / raw)
To: Liviu Dudau, Brian Starkey, Mali DP Maintainers, David Airlie
Cc: Wei Yongjun, dri-devel, linux-kernel
Fix to return error code -EINVAL from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
instead of the endpoint')
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/gpu/drm/arm/malidp_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 4e61ea5..44b24cb 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev)
/* Set the CRTC's port so that the encoder component can find it */
ep = of_graph_get_next_endpoint(dev->of_node, NULL);
- if (!ep)
+ if (!ep) {
+ ret = -EINVAL;
goto port_fail;
+ }
malidp->crtc.port = of_get_next_parent(ep);
ret = component_bind_all(dev, drm);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind()
2016-07-28 2:14 [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() Wei Yongjun
@ 2016-07-28 8:22 ` Brian Starkey
0 siblings, 0 replies; 4+ messages in thread
From: Brian Starkey @ 2016-07-28 8:22 UTC (permalink / raw)
To: Wei Yongjun, seanpaul; +Cc: Liviu Dudau, David Airlie, dri-devel, linux-kernel
Hi Wei,
On Thu, Jul 28, 2016 at 02:14:26AM +0000, Wei Yongjun wrote:
>Fix to return error code -EINVAL from the error handling
>case instead of 0, as done elsewhere in this function.
>
>Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
>instead of the endpoint')
>Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>---
Thanks for cleaning up after me! :-)
Acked-by: Brian Starkey <brian.starkey@arm.com>
@Sean, can you pick this up on top of 3c31760e760c?
Cheers,
Brian
> drivers/gpu/drm/arm/malidp_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
>index 4e61ea5..44b24cb 100644
>--- a/drivers/gpu/drm/arm/malidp_drv.c
>+++ b/drivers/gpu/drm/arm/malidp_drv.c
>@@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev)
>
> /* Set the CRTC's port so that the encoder component can find it */
> ep = of_graph_get_next_endpoint(dev->of_node, NULL);
>- if (!ep)
>+ if (!ep) {
>+ ret = -EINVAL;
> goto port_fail;
>+ }
> malidp->crtc.port = of_get_next_parent(ep);
>
> ret = component_bind_all(dev, drm);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind()
@ 2016-07-28 8:22 ` Brian Starkey
0 siblings, 0 replies; 4+ messages in thread
From: Brian Starkey @ 2016-07-28 8:22 UTC (permalink / raw)
To: Wei Yongjun, seanpaul; +Cc: Liviu Dudau, linux-kernel, dri-devel
Hi Wei,
On Thu, Jul 28, 2016 at 02:14:26AM +0000, Wei Yongjun wrote:
>Fix to return error code -EINVAL from the error handling
>case instead of 0, as done elsewhere in this function.
>
>Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
>instead of the endpoint')
>Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>---
Thanks for cleaning up after me! :-)
Acked-by: Brian Starkey <brian.starkey@arm.com>
@Sean, can you pick this up on top of 3c31760e760c?
Cheers,
Brian
> drivers/gpu/drm/arm/malidp_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
>index 4e61ea5..44b24cb 100644
>--- a/drivers/gpu/drm/arm/malidp_drv.c
>+++ b/drivers/gpu/drm/arm/malidp_drv.c
>@@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev)
>
> /* Set the CRTC's port so that the encoder component can find it */
> ep = of_graph_get_next_endpoint(dev->of_node, NULL);
>- if (!ep)
>+ if (!ep) {
>+ ret = -EINVAL;
> goto port_fail;
>+ }
> malidp->crtc.port = of_get_next_parent(ep);
>
> ret = component_bind_all(dev, drm);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind()
2016-07-28 8:22 ` Brian Starkey
(?)
@ 2016-07-28 11:00 ` Daniel Vetter
-1 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2016-07-28 11:00 UTC (permalink / raw)
To: Brian Starkey; +Cc: Wei Yongjun, seanpaul, Liviu Dudau, linux-kernel, dri-devel
On Thu, Jul 28, 2016 at 09:22:21AM +0100, Brian Starkey wrote:
> Hi Wei,
>
> On Thu, Jul 28, 2016 at 02:14:26AM +0000, Wei Yongjun wrote:
> > Fix to return error code -EINVAL from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
> > instead of the endpoint')
> > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> > ---
>
> Thanks for cleaning up after me! :-)
>
> Acked-by: Brian Starkey <brian.starkey@arm.com>
Applied to drm-misc, thanks.
-Daniel
>
> @Sean, can you pick this up on top of 3c31760e760c?
>
> Cheers,
> Brian
>
> > drivers/gpu/drm/arm/malidp_drv.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> > index 4e61ea5..44b24cb 100644
> > --- a/drivers/gpu/drm/arm/malidp_drv.c
> > +++ b/drivers/gpu/drm/arm/malidp_drv.c
> > @@ -362,8 +362,10 @@ static int malidp_bind(struct device *dev)
> >
> > /* Set the CRTC's port so that the encoder component can find it */
> > ep = of_graph_get_next_endpoint(dev->of_node, NULL);
> > - if (!ep)
> > + if (!ep) {
> > + ret = -EINVAL;
> > goto port_fail;
> > + }
> > malidp->crtc.port = of_get_next_parent(ep);
> >
> > ret = component_bind_all(dev, drm);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-28 11:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-28 2:14 [PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind() Wei Yongjun
2016-07-28 8:22 ` Brian Starkey
2016-07-28 8:22 ` Brian Starkey
2016-07-28 11:00 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.