* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:12 ` Linus Torvalds
0 siblings, 0 replies; 33+ messages in thread
From: Linus Torvalds @ 2016-07-28 3:12 UTC (permalink / raw)
To: Joe Perches
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, Jul 27, 2016 at 7:57 PM, Joe Perches <joe@perches.com> wrote:
>
> It'll continue to list only Al Viro unless a --git cmdline option
> is specified and almost no one uses that.
Did you actually try it.
The get_maintainer.pl script should use "--git-fallback" by default,
so in the absence of a an exact match (which it won't have) it _will_
in fact pick out recent git authorship.
(Where "recent" means "in the last year" by default).
I depend that recent authorship matching quite a lot. In fact, I think
the reason nobody uses "--git" is that the default "--git-fallback" is
sufficient most of the time.
Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
2016-07-28 3:12 ` Linus Torvalds
@ 2016-07-28 3:21 ` Joe Perches
-1 siblings, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:21 UTC (permalink / raw)
To: Linus Torvalds
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 7:57 PM, Joe Perches <joe@perches.com> wrote:
> >
> >
> > It'll continue to list only Al Viro unless a --git cmdline option
> > is specified and almost no one uses that.
> Did you actually try it.
yes.
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS
and infrastructure))
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and
infrastructure))
linux-kernel@vger.kernel.org (open list)
joe@XPS-9350:~/linux/next$ ./scripts/get_maintainer.pl -f
fs/binfmt_misc.c --git
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS
and
infrastructure),commit_signer:2/3=67%,authored:2/3=67%,added_lines:10/49
=20%,removed_lines:14/16=88%)
James Bottomley <James.Bottomley@HansenPartnership.com>
(commit_signer:1/3=33%,authored:1/3=33%,added_lines:39/49=80%,removed_li
nes:2/16=12%)
Serge Hallyn <serge.hallyn@canonical.com> (commit_signer:1/3=33%)
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and
infrastructure))
linux-kernel@vger.kernel.org (open list)
> The get_maintainer.pl script should use "--git-fallback" by default,
> so in the absence of a an exact match (which it won't have) it _will_
> in fact pick out recent git authorship.
>
> (Where "recent" means "in the last year" by default).
>
> I depend that recent authorship matching quite a lot. In fact, I think
> the reason nobody uses "--git" is that the default "--git-fallback" is
> sufficient most of the time.
>
> Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:21 ` Joe Perches
0 siblings, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:21 UTC (permalink / raw)
To: Linus Torvalds
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 7:57 PM, Joe Perches <joe@perches.com> wrote:
> >
> >
> > It'll continue to list only Al Viro unless a --git cmdline option
> > is specified and almost no one uses that.
> Did you actually try it.
yes.
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c�
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS
and infrastructure))
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and
infrastructure))
linux-kernel@vger.kernel.org (open list)
joe@XPS-9350:~/linux/next$ ./scripts/get_maintainer.pl -f
fs/binfmt_misc.c --git
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS
and
infrastructure),commit_signer:2/3=67%,authored:2/3=67%,added_lines:10/49
=20%,removed_lines:14/16=88%)
James Bottomley <James.Bottomley@HansenPartnership.com>
(commit_signer:1/3=33%,authored:1/3=33%,added_lines:39/49=80%,removed_li
nes:2/16=12%)
Serge Hallyn <serge.hallyn@canonical.com> (commit_signer:1/3=33%)
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and
infrastructure))
linux-kernel@vger.kernel.org (open list)
> The get_maintainer.pl script should use "--git-fallback" by default,
> so in the absence of a an exact match (which it won't have) it _will_
> in fact pick out recent git authorship.
>
> (Where "recent" means "in the last year" by default).
>
> I depend that recent authorship matching quite a lot. In fact, I think
> the reason nobody uses "--git" is that the default "--git-fallback" is
> sufficient most of the time.
>
> ����������������Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <1469676065.3998.19.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>]
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
2016-07-28 3:21 ` Joe Perches
(?)
@ 2016-07-28 3:26 ` Linus Torvalds
-1 siblings, 0 replies; 33+ messages in thread
From: Linus Torvalds @ 2016-07-28 3:26 UTC (permalink / raw)
To: Joe Perches
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel, James Bottomley, Al Viro, linux-fsdevel,
Andrew Morton
On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> wrote:
> On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
>> Did you actually try it.
>
> yes.
Well, in that case the script is buggy. It self-documents as having
"--git-fallback" on by default, and I'm not seeing anybody claiming
explicit maintenance of fs/binfmt_misc.c.
Al's match comes from a wildcard, not an exact one.
Hmm. Fishy.
Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:26 ` Linus Torvalds
0 siblings, 0 replies; 33+ messages in thread
From: Linus Torvalds @ 2016-07-28 3:26 UTC (permalink / raw)
To: Joe Perches
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
>> Did you actually try it.
>
> yes.
Well, in that case the script is buggy. It self-documents as having
"--git-fallback" on by default, and I'm not seeing anybody claiming
explicit maintenance of fs/binfmt_misc.c.
Al's match comes from a wildcard, not an exact one.
Hmm. Fishy.
Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:26 ` Linus Torvalds
0 siblings, 0 replies; 33+ messages in thread
From: Linus Torvalds @ 2016-07-28 3:26 UTC (permalink / raw)
To: Joe Perches
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
>> Did you actually try it.
>
> yes.
Well, in that case the script is buggy. It self-documents as having
"--git-fallback" on by default, and I'm not seeing anybody claiming
explicit maintenance of fs/binfmt_misc.c.
Al's match comes from a wildcard, not an exact one.
Hmm. Fishy.
Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
2016-07-28 3:26 ` Linus Torvalds
@ 2016-07-28 3:30 ` Joe Perches
-1 siblings, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:30 UTC (permalink / raw)
To: Linus Torvalds
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, 2016-07-27 at 20:26 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe@perches.com> wrote:
> >
> > On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> > >
> > > Did you actually try it.
> > yes.
> Well, in that case the script is buggy. It self-documents as having
> "--git-fallback" on by default, and I'm not seeing anybody claiming
> explicit maintenance of fs/binfmt_misc.c.
>
> Al's match comes from a wildcard, not an exact one.
Nope, the script doesn't have a defect here.
It's documented what the script does with wildcards.
You _could_ argue that the file pattern specified
for VFS is inappropriate though,
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:30 ` Joe Perches
0 siblings, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:30 UTC (permalink / raw)
To: Linus Torvalds
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, 2016-07-27 at 20:26 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe@perches.com> wrote:
> >
> > On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> > >
> > > Did you actually try it.
> > yes.
> Well, in that case the script is buggy. It self-documents as having
> "--git-fallback" on by default, and I'm not seeing anybody claiming
> explicit maintenance of fs/binfmt_misc.c.
>
> Al's match comes from a wildcard, not an exact one.
Nope, the script doesn't have a defect here.
It's documented what the script does with wildcards.
You _could_ argue that the file pattern specified
for VFS is inappropriate though,
^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <1469676632.3998.27.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>]
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
[not found] ` <1469676632.3998.27.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
@ 2016-07-28 11:07 ` James Bottomley
0 siblings, 0 replies; 33+ messages in thread
From: James Bottomley @ 2016-07-28 11:07 UTC (permalink / raw)
To: Joe Perches, Linus Torvalds
Cc: linux-fsdevel,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel, Andrew Morton, Al Viro
On Wed, 2016-07-27 at 20:30 -0700, Joe Perches wrote:
> On Wed, 2016-07-27 at 20:26 -0700, Linus Torvalds wrote:
> > On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
> > wrote:
> > >
> > > On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> > > >
> > > > Did you actually try it.
> > > yes.
> > Well, in that case the script is buggy. It self-documents as having
> > "--git-fallback" on by default, and I'm not seeing anybody claiming
> > explicit maintenance of fs/binfmt_misc.c.
> >
> > Al's match comes from a wildcard, not an exact one.
>
> Nope, the script doesn't have a defect here.
> It's documented what the script does with wildcards.
>
> You _could_ argue that the file pattern specified
> for VFS is inappropriate though,
If people prefer, I can add a MAINTAINERS entry ... it's just that none
of the binfmts currently has one, plus linux-fsdevel is still fingered
as the list and that's the place to send patches and bug reports
anyway.
James
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
2016-07-28 3:30 ` Joe Perches
@ 2016-07-28 11:07 ` James Bottomley
-1 siblings, 0 replies; 33+ messages in thread
From: James Bottomley @ 2016-07-28 11:07 UTC (permalink / raw)
To: Joe Perches, Linus Torvalds
Cc: containers, linux-kernel, Al Viro, linux-fsdevel, Andrew Morton
On Wed, 2016-07-27 at 20:30 -0700, Joe Perches wrote:
> On Wed, 2016-07-27 at 20:26 -0700, Linus Torvalds wrote:
> > On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe@perches.com>
> > wrote:
> > >
> > > On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> > > >
> > > > Did you actually try it.
> > > yes.
> > Well, in that case the script is buggy. It self-documents as having
> > "--git-fallback" on by default, and I'm not seeing anybody claiming
> > explicit maintenance of fs/binfmt_misc.c.
> >
> > Al's match comes from a wildcard, not an exact one.
>
> Nope, the script doesn't have a defect here.
> It's documented what the script does with wildcards.
>
> You _could_ argue that the file pattern specified
> for VFS is inappropriate though,
If people prefer, I can add a MAINTAINERS entry ... it's just that none
of the binfmts currently has one, plus linux-fsdevel is still fingered
as the list and that's the place to send patches and bug reports
anyway.
James
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 11:07 ` James Bottomley
0 siblings, 0 replies; 33+ messages in thread
From: James Bottomley @ 2016-07-28 11:07 UTC (permalink / raw)
To: Joe Perches, Linus Torvalds
Cc: containers, linux-kernel, Al Viro, linux-fsdevel, Andrew Morton
On Wed, 2016-07-27 at 20:30 -0700, Joe Perches wrote:
> On Wed, 2016-07-27 at 20:26 -0700, Linus Torvalds wrote:
> > On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe@perches.com>
> > wrote:
> > >
> > > On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> > > >
> > > > Did you actually try it.
> > > yes.
> > Well, in that case the script is buggy. It self-documents as having
> > "--git-fallback" on by default, and I'm not seeing anybody claiming
> > explicit maintenance of fs/binfmt_misc.c.
> >
> > Al's match comes from a wildcard, not an exact one.
>
> Nope, the script doesn't have a defect here.
> It's documented what the script does with wildcards.
>
> You _could_ argue that the file pattern specified
> for VFS is inappropriate though,
If people prefer, I can add a MAINTAINERS entry ... it's just that none
of the binfmts currently has one, plus linux-fsdevel is still fingered
as the list and that's the place to send patches and bug reports
anyway.
James
^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <CA+55aFz3+37s7eQ55kGbEEoGhMtvkAwYQ3szOSVrg3MKA+iWrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
[not found] ` <CA+55aFz3+37s7eQ55kGbEEoGhMtvkAwYQ3szOSVrg3MKA+iWrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-07-28 3:30 ` Joe Perches
2016-07-28 3:31 ` Linus Torvalds
1 sibling, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:30 UTC (permalink / raw)
To: Linus Torvalds
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel, James Bottomley, Al Viro, linux-fsdevel,
Andrew Morton
On Wed, 2016-07-27 at 20:26 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 8:21 PM, Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> wrote:
> >
> > On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> > >
> > > Did you actually try it.
> > yes.
> Well, in that case the script is buggy. It self-documents as having
> "--git-fallback" on by default, and I'm not seeing anybody claiming
> explicit maintenance of fs/binfmt_misc.c.
>
> Al's match comes from a wildcard, not an exact one.
Nope, the script doesn't have a defect here.
It's documented what the script does with wildcards.
You _could_ argue that the file pattern specified
for VFS is inappropriate though,
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
2016-07-28 3:26 ` Linus Torvalds
(?)
@ 2016-07-28 3:31 ` Linus Torvalds
-1 siblings, 0 replies; 33+ messages in thread
From: Linus Torvalds @ 2016-07-28 3:31 UTC (permalink / raw)
To: Joe Perches
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel, James Bottomley, Al Viro, linux-fsdevel,
Andrew Morton
On Wed, Jul 27, 2016 at 8:26 PM, Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
>
> Hmm. Fishy.
Hmm. The exact match logic is a bit odd, and clearly doesn't mean what
I thought it meant. Reading that perl code just makes me more
confused.
I'd actually prefer to make "--git" the default, if you are inside a
git repository. Because obviously the *actual* default is too hard to
understand ;)
Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:31 ` Linus Torvalds
0 siblings, 0 replies; 33+ messages in thread
From: Linus Torvalds @ 2016-07-28 3:31 UTC (permalink / raw)
To: Joe Perches
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, Jul 27, 2016 at 8:26 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Hmm. Fishy.
Hmm. The exact match logic is a bit odd, and clearly doesn't mean what
I thought it meant. Reading that perl code just makes me more
confused.
I'd actually prefer to make "--git" the default, if you are inside a
git repository. Because obviously the *actual* default is too hard to
understand ;)
Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:31 ` Linus Torvalds
0 siblings, 0 replies; 33+ messages in thread
From: Linus Torvalds @ 2016-07-28 3:31 UTC (permalink / raw)
To: Joe Perches
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, Jul 27, 2016 at 8:26 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Hmm. Fishy.
Hmm. The exact match logic is a bit odd, and clearly doesn't mean what
I thought it meant. Reading that perl code just makes me more
confused.
I'd actually prefer to make "--git" the default, if you are inside a
git repository. Because obviously the *actual* default is too hard to
understand ;)
Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
2016-07-28 3:31 ` Linus Torvalds
@ 2016-07-28 3:33 ` Linus Torvalds
-1 siblings, 0 replies; 33+ messages in thread
From: Linus Torvalds @ 2016-07-28 3:33 UTC (permalink / raw)
To: Joe Perches
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, Jul 27, 2016 at 8:31 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> I'd actually prefer to make "--git" the default, if you are inside a
> git repository. Because obviously the *actual* default is too hard to
> understand ;)
I'd also like to make the "-f" optional.
I constantly forget it, and curse it. It should be trivial to see "the
argument is a file that is tracked in git, so it clearly isn't the
name of a patch".
Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:33 ` Linus Torvalds
0 siblings, 0 replies; 33+ messages in thread
From: Linus Torvalds @ 2016-07-28 3:33 UTC (permalink / raw)
To: Joe Perches
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, Jul 27, 2016 at 8:31 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> I'd actually prefer to make "--git" the default, if you are inside a
> git repository. Because obviously the *actual* default is too hard to
> understand ;)
I'd also like to make the "-f" optional.
I constantly forget it, and curse it. It should be trivial to see "the
argument is a file that is tracked in git, so it clearly isn't the
name of a patch".
Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <CA+55aFwUDnS9POpBJysZurSBsWeyYbMF4qPKjD1sFygeFi7tTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
2016-07-28 3:33 ` Linus Torvalds
(?)
@ 2016-07-28 3:58 ` Joe Perches
-1 siblings, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:58 UTC (permalink / raw)
To: Linus Torvalds
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel, James Bottomley, Al Viro, linux-fsdevel,
Andrew Morton
On Wed, 2016-07-27 at 20:33 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 8:31 PM, Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
> > I'd actually prefer to make "--git" the default, if you are inside a
> > git repository. Because obviously the *actual* default is too hard to
> > understand ;)
Well, you are in the minority there.
Most people seem not to want to be cc'd on stuff they may have
sent an odd patch on but don't actually maintain.
You could create a .get_maintainer.conf file and add --git
to it if you want that.
> I'd also like to make the "-f" optional.
>
> I constantly forget it, and curse it. It should be trivial to see "the
> argument is a file that is tracked in git, so it clearly isn't the
> name of a patch".
You could send a patch ;)
I'll look at it in any case.
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:58 ` Joe Perches
0 siblings, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:58 UTC (permalink / raw)
To: Linus Torvalds
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, 2016-07-27 at 20:33 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 8:31 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > I'd actually prefer to make "--git" the default, if you are inside a
> > git repository. Because obviously the *actual* default is too hard to
> > understand ;)
Well, you are in the minority there.
Most people seem not to want to be cc'd on stuff they may have
sent an odd patch on but don't actually maintain.
You could create a .get_maintainer.conf file and add --git
to it if you want that.
> I'd also like to make the "-f" optional.
>
> I constantly forget it, and curse it. It should be trivial to see "the
> argument is a file that is tracked in git, so it clearly isn't the
> name of a patch".
You could send a patch ;)
I'll look at it in any case.
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:58 ` Joe Perches
0 siblings, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:58 UTC (permalink / raw)
To: Linus Torvalds
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, 2016-07-27 at 20:33 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 8:31 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > I'd actually prefer to make "--git" the default, if you are inside a
> > git repository. Because obviously the *actual* default is too hard to
> > understand ;)
Well, you are in the minority there.
Most people seem not to want to be cc'd on stuff they may have
sent an odd patch on but don't actually maintain.
You could create a .get_maintainer.conf file and add --git
to it if you want that.
> I'd also like to make the "-f" optional.
>
> I constantly forget it, and curse it. It should be trivial to see "the
> argument is a file that is tracked in git, so it clearly isn't the
> name of a patch".
You could send a patch ;)
I'll look at it in any case.
^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <CA+55aFxK7Xw2XsSJX6ErzTt+J-jywk26v4pP42rAs2=OkSfhFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
[not found] ` <CA+55aFxK7Xw2XsSJX6ErzTt+J-jywk26v4pP42rAs2=OkSfhFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-07-28 3:33 ` Linus Torvalds
0 siblings, 0 replies; 33+ messages in thread
From: Linus Torvalds @ 2016-07-28 3:33 UTC (permalink / raw)
To: Joe Perches
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel, James Bottomley, Al Viro, linux-fsdevel,
Andrew Morton
On Wed, Jul 27, 2016 at 8:31 PM, Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
>
> I'd actually prefer to make "--git" the default, if you are inside a
> git repository. Because obviously the *actual* default is too hard to
> understand ;)
I'd also like to make the "-f" optional.
I constantly forget it, and curse it. It should be trivial to see "the
argument is a file that is tracked in git, so it clearly isn't the
name of a patch".
Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
2016-07-28 3:12 ` Linus Torvalds
@ 2016-07-28 3:26 ` Joe Perches
-1 siblings, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:26 UTC (permalink / raw)
To: Linus Torvalds
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 7:57 PM, Joe Perches <joe@perches.com> wrote:
> > It'll continue to list only Al Viro unless a --git cmdline option
> > is specified and almost no one uses that.
> Did you actually try it.
Sorry about the last reply, typing with a broken arm is a bit difficult.
Yes. I gather you did not.
The VFS MAINTAINERS entry is:
FILESYSTEMS (VFS and infrastructure)
M: Alexander Viro <viro@zeniv.linux.org.uk>
L: linux-fsdevel@vger.kernel.org
S: Maintained
F: fs/*
so that matches this file location.
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS and infrastructure))
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure))
linux-kernel@vger.kernel.org (open list)
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c --git
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS and infrastructure),commit_signer:2/3=67%,authored:2/3=67%,added_lines:10/49=20%,removed_lines:14/16=88%)
James Bottomley <James.Bottomley@HansenPartnership.com> (commit_signer:1/3=33%,authored:1/3=33%,added_lines:39/49=80%,removed_lines:2/16=12%)
Serge Hallyn <serge.hallyn@canonical.com> (commit_signer:1/3=33%)
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure))
linux-kernel@vger.kernel.org (open list)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
@ 2016-07-28 3:26 ` Joe Perches
0 siblings, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:26 UTC (permalink / raw)
To: Linus Torvalds
Cc: James Bottomley, Andrew Morton, linux-kernel, linux-fsdevel,
Al Viro, containers
On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 7:57 PM, Joe Perches <joe@perches.com> wrote:
> > It'll continue to list only Al Viro unless a --git cmdline option
> > is specified and almost no one uses that.
> Did you actually try it.
Sorry about the last reply, typing with a broken arm is a bit difficult.
Yes. I gather you did not.
The VFS MAINTAINERS entry is:
FILESYSTEMS (VFS and infrastructure)
M: Alexander Viro <viro@zeniv.linux.org.uk>
L: linux-fsdevel@vger.kernel.org
S: Maintained
F: fs/*
so that matches this file location.
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c�
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS and infrastructure))
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure))
linux-kernel@vger.kernel.org (open list)
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c --git
Alexander Viro <viro@zeniv.linux.org.uk> (maintainer:FILESYSTEMS (VFS and infrastructure),commit_signer:2/3=67%,authored:2/3=67%,added_lines:10/49=20%,removed_lines:14/16=88%)
James Bottomley <James.Bottomley@HansenPartnership.com> (commit_signer:1/3=33%,authored:1/3=33%,added_lines:39/49=80%,removed_lines:2/16=12%)
Serge Hallyn <serge.hallyn@canonical.com> (commit_signer:1/3=33%)
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure))
linux-kernel@vger.kernel.org (open list)
^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <CA+55aFzK_kNZBNU+Eq+VuuGttOTMP3xK1F9Lsxcff-wkzaNkyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
[not found] ` <CA+55aFzK_kNZBNU+Eq+VuuGttOTMP3xK1F9Lsxcff-wkzaNkyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-07-28 3:21 ` Joe Perches
2016-07-28 3:26 ` Joe Perches
1 sibling, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:21 UTC (permalink / raw)
To: Linus Torvalds
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel, James Bottomley, Al Viro, linux-fsdevel,
Andrew Morton
On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 7:57 PM, Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> wrote:
> >
> >
> > It'll continue to list only Al Viro unless a --git cmdline option
> > is specified and almost no one uses that.
> Did you actually try it.
yes.
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c
Alexander Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org> (maintainer:FILESYSTEMS (VFS
and infrastructure))
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:FILESYSTEMS (VFS and
infrastructure))
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)
joe@XPS-9350:~/linux/next$ ./scripts/get_maintainer.pl -f
fs/binfmt_misc.c --git
Alexander Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org> (maintainer:FILESYSTEMS (VFS
and
infrastructure),commit_signer:2/3=67%,authored:2/3=67%,added_lines:10/49
=20%,removed_lines:14/16=88%)
James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
(commit_signer:1/3=33%,authored:1/3=33%,added_lines:39/49=80%,removed_li
nes:2/16=12%)
Serge Hallyn <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> (commit_signer:1/3=33%)
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:FILESYSTEMS (VFS and
infrastructure))
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)
> The get_maintainer.pl script should use "--git-fallback" by default,
> so in the absence of a an exact match (which it won't have) it _will_
> in fact pick out recent git authorship.
>
> (Where "recent" means "in the last year" by default).
>
> I depend that recent authorship matching quite a lot. In fact, I think
> the reason nobody uses "--git" is that the default "--git-fallback" is
> sufficient most of the time.
>
> Linus
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL] binfmt_misc updates for 4.7+ merge window
[not found] ` <CA+55aFzK_kNZBNU+Eq+VuuGttOTMP3xK1F9Lsxcff-wkzaNkyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-28 3:21 ` Joe Perches
@ 2016-07-28 3:26 ` Joe Perches
1 sibling, 0 replies; 33+ messages in thread
From: Joe Perches @ 2016-07-28 3:26 UTC (permalink / raw)
To: Linus Torvalds
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel, James Bottomley, Al Viro, linux-fsdevel,
Andrew Morton
On Wed, 2016-07-27 at 20:12 -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 7:57 PM, Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> wrote:
> > It'll continue to list only Al Viro unless a --git cmdline option
> > is specified and almost no one uses that.
> Did you actually try it.
Sorry about the last reply, typing with a broken arm is a bit difficult.
Yes. I gather you did not.
The VFS MAINTAINERS entry is:
FILESYSTEMS (VFS and infrastructure)
M: Alexander Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
L: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
S: Maintained
F: fs/*
so that matches this file location.
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c
Alexander Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org> (maintainer:FILESYSTEMS (VFS and infrastructure))
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:FILESYSTEMS (VFS and infrastructure))
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)
$ ./scripts/get_maintainer.pl -f fs/binfmt_misc.c --git
Alexander Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org> (maintainer:FILESYSTEMS (VFS and infrastructure),commit_signer:2/3=67%,authored:2/3=67%,added_lines:10/49=20%,removed_lines:14/16=88%)
James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org> (commit_signer:1/3=33%,authored:1/3=33%,added_lines:39/49=80%,removed_lines:2/16=12%)
Serge Hallyn <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> (commit_signer:1/3=33%)
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:FILESYSTEMS (VFS and infrastructure))
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)
^ permalink raw reply [flat|nested] 33+ messages in thread