All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Pronin <apronin@chromium.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
	Marcel Selhorst <tpmdd@selhorst.net>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	Christophe Ricard <christophe.ricard@gmail.com>,
	dtor@chromium.org, smbarber@chromium.org, dianders@chromium.org,
	Andrey Pronin <apronin@chromium.org>
Subject: [PATCH v3 2/2] tpm_tis_spi: add max xfer size
Date: Wed, 27 Jul 2016 20:49:57 -0700	[thread overview]
Message-ID: <1469677797-74304-3-git-send-email-apronin@chromium.org> (raw)
In-Reply-To: <1469677797-74304-1-git-send-email-apronin@chromium.org>
In-Reply-To: <1468546745-14646-1-git-send-email-apronin@chromium.org>

Reject burstcounts larger than 64 bytes reported by tpm.
SPI Hardware Protocol defined in section 6.4 of TCG PTP
Spec supports up to 64 bytes of data in a transaction.

Signed-off-by: Andrey Pronin <apronin@chromium.org>
---
 drivers/char/tpm/tpm_tis_spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
index dbaad9c..b103373 100644
--- a/drivers/char/tpm/tpm_tis_spi.c
+++ b/drivers/char/tpm/tpm_tis_spi.c
@@ -206,6 +206,7 @@ static const struct tpm_tis_phy_ops tpm_spi_phy_ops = {
 	.read16 = tpm_tis_spi_read16,
 	.read32 = tpm_tis_spi_read32,
 	.write32 = tpm_tis_spi_write32,
+	.max_xfer_size = MAX_SPI_FRAMESIZE,
 };
 
 static int tpm_tis_spi_probe(struct spi_device *dev)
-- 
2.6.6

WARNING: multiple messages have this Message-ID
From: Andrey Pronin <apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Jarkko Sakkinen
	<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Christophe Ricard
	<christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org
Subject: [PATCH v3 2/2] tpm_tis_spi: add max xfer size
Date: Wed, 27 Jul 2016 20:49:57 -0700	[thread overview]
Message-ID: <1469677797-74304-3-git-send-email-apronin@chromium.org> (raw)
In-Reply-To: <1469677797-74304-1-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
In-Reply-To: <1468546745-14646-1-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

Reject burstcounts larger than 64 bytes reported by tpm.
SPI Hardware Protocol defined in section 6.4 of TCG PTP
Spec supports up to 64 bytes of data in a transaction.

Signed-off-by: Andrey Pronin <apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
---
 drivers/char/tpm/tpm_tis_spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
index dbaad9c..b103373 100644
--- a/drivers/char/tpm/tpm_tis_spi.c
+++ b/drivers/char/tpm/tpm_tis_spi.c
@@ -206,6 +206,7 @@ static const struct tpm_tis_phy_ops tpm_spi_phy_ops = {
 	.read16 = tpm_tis_spi_read16,
 	.read32 = tpm_tis_spi_read32,
 	.write32 = tpm_tis_spi_write32,
+	.max_xfer_size = MAX_SPI_FRAMESIZE,
 };
 
 static int tpm_tis_spi_probe(struct spi_device *dev)
-- 
2.6.6


------------------------------------------------------------------------------

  parent reply	other threads:[~2016-07-28  3:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  1:39 [PATCH 0/2] tpm: add optional max xfer size check Andrey Pronin
2016-07-15  1:39 ` [PATCH 1/2] tpm_tis_core: " Andrey Pronin
     [not found]   ` <1468546745-14646-2-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-15  3:13     ` Jason Gunthorpe
2016-07-15  3:25       ` Andrey Pronin
2016-07-15  3:48         ` Guenter Roeck
     [not found]       ` <20160715031351.GD9347-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-18 18:53         ` Jarkko Sakkinen
2016-07-18 18:53       ` Jarkko Sakkinen
2016-07-15  3:13   ` Jason Gunthorpe
2016-07-15  1:39 ` [PATCH 2/2] tpm_tis_spi: add max xfer size Andrey Pronin
2016-07-20  2:34 ` [PATCH v2 0/2] tpm: add optional max xfer size check Andrey Pronin
2016-07-28  3:49 ` [PATCH v3 " Andrey Pronin
     [not found] ` <1468546745-14646-1-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-15  1:39   ` [PATCH 2/2] tpm_tis_spi: add max xfer size Andrey Pronin
2016-07-20  2:34   ` [PATCH v2 0/2] tpm: add optional max xfer size check Andrey Pronin
2016-07-20  2:34     ` [PATCH v2 1/2] tpm_tis_core: " Andrey Pronin
2016-07-20  2:34     ` [PATCH v2 2/2] tpm_tis_spi: add max xfer size Andrey Pronin
2016-07-20 15:10     ` [PATCH v2 0/2] tpm: add optional max xfer size check Jarkko Sakkinen
     [not found]   ` <cover.1468981325.git.apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-20  2:34     ` [PATCH v2 1/2] tpm_tis_core: " Andrey Pronin
2016-07-20 15:10     ` [PATCH v2 0/2] tpm: " Jarkko Sakkinen
2016-07-28  3:49   ` [PATCH v3 " Andrey Pronin
2016-07-28  3:49     ` [PATCH v3 1/2] tpm_tis_core: " Andrey Pronin
2016-07-28  3:49     ` Andrey Pronin [this message]
     [not found]   ` <1469677797-74304-1-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-07-28  3:49     ` Andrey Pronin
2016-07-28 22:52       ` Dmitry Torokhov
     [not found]       ` <1469677797-74304-2-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-08-09  8:14         ` Jarkko Sakkinen
2020-11-19 10:00           ` Dafna Hirschfeld
2020-11-20 15:15             ` Jarkko Sakkinen
2016-08-09  8:14       ` Jarkko Sakkinen
2016-07-28  3:49     ` [PATCH v3 2/2] tpm_tis_spi: add max xfer size Andrey Pronin
2016-07-28 22:53       ` Dmitry Torokhov
2016-08-09  8:14         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469677797-74304-3-git-send-email-apronin@chromium.org \
    --to=apronin@chromium.org \
    --cc=christophe.ricard@gmail.com \
    --cc=dianders@chromium.org \
    --cc=dtor@chromium.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=smbarber@chromium.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    --subject='Re: [PATCH v3 2/2] tpm_tis_spi: add max xfer size' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.