* [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore
@ 2016-07-29 15:10 Aníbal Limón
2016-07-29 15:19 ` Aníbal Limón
2016-07-29 15:31 ` Beth 'pidge' Flanagan
0 siblings, 2 replies; 6+ messages in thread
From: Aníbal Limón @ 2016-07-29 15:10 UTC (permalink / raw)
To: yocto; +Cc: joshua.g.lock, pidge
nightly-oecore buildset doesn't prove got_revision property
so when got_revision is None use got_revision_oecore instead.
[YOCTO #10051]
Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
---
lib/python2.7/site-packages/autobuilder/lib/buildsteps.py | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py b/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py
index eee0c1b..37ac8b0 100644
--- a/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py
+++ b/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py
@@ -118,8 +118,11 @@ class BitbakeShellCommand(ShellCommand):
report['target_sys'] = vrs['TARGET_SYS']
report['component'] = 'bitbake'
- report['branch_commit'] = self.getProperty('branch') + ': ' + \
- self.getProperty('got_revision')
+ branch = self.getProperty('branch')
+ revision = self.getProperty('got_revision')
+ if not revision:
+ revision = self.getProperty('got_revision_oecore')
+ report['branch_commit'] = branch + ': ' + revision
failure = {}
failure['package'] = "bitbake-%s" % vrs['BB_VERSION']
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore
2016-07-29 15:10 [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore Aníbal Limón
@ 2016-07-29 15:19 ` Aníbal Limón
2016-07-29 15:31 ` Beth 'pidge' Flanagan
1 sibling, 0 replies; 6+ messages in thread
From: Aníbal Limón @ 2016-07-29 15:19 UTC (permalink / raw)
To: yocto; +Cc: joshua.g.lock
[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]
+ beth
On 07/29/2016 10:10 AM, Aníbal Limón wrote:
> nightly-oecore buildset doesn't prove got_revision property
> so when got_revision is None use got_revision_oecore instead.
>
> [YOCTO #10051]
>
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> lib/python2.7/site-packages/autobuilder/lib/buildsteps.py | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py b/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py
> index eee0c1b..37ac8b0 100644
> --- a/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py
> +++ b/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py
> @@ -118,8 +118,11 @@ class BitbakeShellCommand(ShellCommand):
> report['target_sys'] = vrs['TARGET_SYS']
>
> report['component'] = 'bitbake'
> - report['branch_commit'] = self.getProperty('branch') + ': ' + \
> - self.getProperty('got_revision')
> + branch = self.getProperty('branch')
> + revision = self.getProperty('got_revision')
> + if not revision:
> + revision = self.getProperty('got_revision_oecore')
> + report['branch_commit'] = branch + ': ' + revision
>
> failure = {}
> failure['package'] = "bitbake-%s" % vrs['BB_VERSION']
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore
2016-07-29 15:10 [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore Aníbal Limón
2016-07-29 15:19 ` Aníbal Limón
@ 2016-07-29 15:31 ` Beth 'pidge' Flanagan
2016-07-29 15:47 ` Aníbal Limón
1 sibling, 1 reply; 6+ messages in thread
From: Beth 'pidge' Flanagan @ 2016-07-29 15:31 UTC (permalink / raw)
To: Aníbal Limón, yocto; +Cc: joshua.g.lock, pidge
On Fri, 2016-07-29 at 10:10 -0500, Aníbal Limón wrote:
> nightly-oecore buildset doesn't prove got_revision property
> so when got_revision is None use got_revision_oecore instead.
>
> [YOCTO #10051]
>
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> lib/python2.7/site-packages/autobuilder/lib/buildsteps.py | 7 +++++-
> -
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/python2.7/site-
> packages/autobuilder/lib/buildsteps.py b/lib/python2.7/site-
> packages/autobuilder/lib/buildsteps.py
> index eee0c1b..37ac8b0 100644
> --- a/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py
> +++ b/lib/python2.7/site-packages/autobuilder/lib/buildsteps.py
> @@ -118,8 +118,11 @@ class BitbakeShellCommand(ShellCommand):
> report['target_sys'] = vrs['TARGET_SYS']
>
> report['component'] = 'bitbake'
> - report['branch_commit'] = self.getProperty('branch') + ': '
> + \
> - self.getProperty('got_revision')
> + branch = self.getProperty('branch')
> + revision = self.getProperty('got_revision')
> + if not revision:
> + revision = self.getProperty('got_revision_oecore')
> + report['branch_commit'] = branch + ': ' + revision
>
I'd put this in a try except. What happens with eclipse?
-b
>
> failure = {}
> failure['package'] = "bitbake-%s" % vrs['BB_VERSION']
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore
2016-07-29 15:31 ` Beth 'pidge' Flanagan
@ 2016-07-29 15:47 ` Aníbal Limón
2016-07-29 15:50 ` Beth 'pidge' Flanagan
0 siblings, 1 reply; 6+ messages in thread
From: Aníbal Limón @ 2016-07-29 15:47 UTC (permalink / raw)
To: pidge, yocto; +Cc: joshua.g.lock, pidge
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
On 07/29/2016 10:31 AM, Beth 'pidge' Flanagan wrote:
> I'd put this in a try except. What happens with eclipse?
At this time we don't support eclipse, i'll add the try except and if
fails use "unknown_branch: unknown_revision".
alimon
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore
2016-07-29 15:47 ` Aníbal Limón
@ 2016-07-29 15:50 ` Beth 'pidge' Flanagan
2016-07-29 15:58 ` Aníbal Limón
0 siblings, 1 reply; 6+ messages in thread
From: Beth 'pidge' Flanagan @ 2016-07-29 15:50 UTC (permalink / raw)
To: Aníbal Limón, yocto; +Cc: joshua.g.lock, pidge
On Fri, 2016-07-29 at 10:47 -0500, Aníbal Limón wrote:
>
> On 07/29/2016 10:31 AM, Beth 'pidge' Flanagan wrote:
> >
> > I'd put this in a try except. What happens with eclipse?
> At this time we don't support eclipse, i'll add the try except and if
> fails use "unknown_branch: unknown_revision".
>
> alimon
>
Ah, some of us still build for it! :D Remember, we try to not break
stuff we still support.
-b
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore
2016-07-29 15:50 ` Beth 'pidge' Flanagan
@ 2016-07-29 15:58 ` Aníbal Limón
0 siblings, 0 replies; 6+ messages in thread
From: Aníbal Limón @ 2016-07-29 15:58 UTC (permalink / raw)
To: pidge, yocto; +Cc: joshua.g.lock
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On 07/29/2016 10:50 AM, Beth 'pidge' Flanagan wrote:
> On Fri, 2016-07-29 at 10:47 -0500, Aníbal Limón wrote:
>>
>> On 07/29/2016 10:31 AM, Beth 'pidge' Flanagan wrote:
>>>
>>> I'd put this in a try except. What happens with eclipse?
>> At this time we don't support eclipse, i'll add the try except and if
>> fails use "unknown_branch: unknown_revision".
>>
>> alimon
>>
>
> Ah, some of us still build for it! :D Remember, we try to not break
> stuff we still support.
Yes right, may be i don't exaplain correctly this functionality is for
generate error reports the eclipse buildsets are supported but atm don't
have error report functionality, i could add later. :D
alimon
>
> -b
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-29 15:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-29 15:10 [PATCH][yocto-autobuilder] lib/buildsteps.py: fix report creation in nigthly-oecore Aníbal Limón
2016-07-29 15:19 ` Aníbal Limón
2016-07-29 15:31 ` Beth 'pidge' Flanagan
2016-07-29 15:47 ` Aníbal Limón
2016-07-29 15:50 ` Beth 'pidge' Flanagan
2016-07-29 15:58 ` Aníbal Limón
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.